use crate::utils;
use crate::utils::higher;
use crate::utils::higher::Range;
-use rustc::hir::*;
-use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
use rustc::ty;
-use rustc::{declare_tool_lint, lint_array};
+use rustc_hir::*;
+use rustc_lint::{LateContext, LateLintPass};
+use rustc_session::{declare_lint_pass, declare_tool_lint};
use syntax::ast::RangeLimits;
declare_clippy_lint! {
}
declare_clippy_lint! {
- /// **What it does:** Checks for usage of indexing or slicing. Arrays are special cased, this lint
+ /// **What it does:** Checks for usage of indexing or slicing. Arrays are special cases, this lint
/// does report on arrays if we can tell that slicing operations are in bounds and does not
/// lint on constant `usize` indexing on arrays because that is handled by rustc's `const_err` lint.
///
/// **Known problems:** Hopefully none.
///
/// **Example:**
- /// ```rust
+ /// ```rust,no_run
/// // Vector
/// let x = vec![0; 5];
///
"indexing/slicing usage"
}
-#[derive(Copy, Clone)]
-pub struct IndexingSlicing;
-
-impl LintPass for IndexingSlicing {
- fn get_lints(&self) -> LintArray {
- lint_array!(INDEXING_SLICING, OUT_OF_BOUNDS_INDEXING)
- }
-
- fn name(&self) -> &'static str {
- "IndexSlicing"
- }
-}
+declare_lint_pass!(IndexingSlicing => [INDEXING_SLICING, OUT_OF_BOUNDS_INDEXING]);
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for IndexingSlicing {
- fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
- if let ExprKind::Index(ref array, ref index) = &expr.node {
+ fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr<'_>) {
+ if let ExprKind::Index(ref array, ref index) = &expr.kind {
let ty = cx.tables.expr_ty(array);
if let Some(range) = higher::range(cx, index) {
// Ranged indexes, i.e., &x[n..m], &x[n..], &x[..n] and &x[..]
- if let ty::Array(_, s) = ty.sty {
- let size: u128 = s.assert_usize(cx.tcx).unwrap().into();
+ if let ty::Array(_, s) = ty.kind {
+ let size: u128 = s.eval_usize(cx.tcx, cx.param_env).into();
let const_range = to_const_range(cx, range, size);
(None, None) => return, // [..] is ok.
};
- utils::span_help_and_lint(cx, INDEXING_SLICING, expr.span, "slicing may panic.", help_msg);
+ utils::span_lint_and_help(cx, INDEXING_SLICING, expr.span, "slicing may panic.", help_msg);
} else {
// Catchall non-range index, i.e., [n] or [n << m]
- if let ty::Array(..) = ty.sty {
+ if let ty::Array(..) = ty.kind {
// Index is a constant uint.
if let Some(..) = constant(cx, cx.tables, index) {
// Let rustc's `const_err` lint handle constant `usize` indexing on arrays.
}
}
- utils::span_help_and_lint(
+ utils::span_lint_and_help(
cx,
INDEXING_SLICING,
expr.span,