impl EarlyLintPass for Formatting {
fn check_block(&mut self, cx: &EarlyContext<'_>, block: &Block) {
for w in block.stmts.windows(2) {
- match (&w[0].kind, &w[1].kind) {
- (&StmtKind::Expr(ref first), &StmtKind::Expr(ref second))
- | (&StmtKind::Expr(ref first), &StmtKind::Semi(ref second)) => {
- check_missing_else(cx, first, second);
- },
- _ => (),
+ if let (StmtKind::Expr(first), StmtKind::Expr(second) | StmtKind::Semi(second)) = (&w[0].kind, &w[1].kind) {
+ check_missing_else(cx, first, second);
}
}
}
really are doing `.. = ({op} ..)`",
op = op
),
- eqop_span,
+ None,
&format!("to remove this lint, use either `{op}=` or `= {op}`", op = op),
);
}
binop = binop_str,
unop = unop_str
),
+ None,
&format!(
"put a space between `{binop}` and `{unop}` and remove the space after `{unop}`",
binop = binop_str,
SUSPICIOUS_ELSE_FORMATTING,
else_span,
&format!("this is an `else {}` but the formatting might hide it", else_desc),
- else_span,
+ None,
&format!(
"to remove this lint, remove the `else` or remove the new line between \
`else` and `{}`",
POSSIBLE_MISSING_COMMA,
lint_span,
"possibly missing a comma here",
- lint_span,
+ None,
"to remove this lint, add a comma or write the expr in a single line",
);
}
SUSPICIOUS_ELSE_FORMATTING,
else_span,
&format!("this looks like {} but the `else` is missing", looks_like),
- else_span,
+ None,
&format!(
"to remove this lint, add the missing `else` or add a new line before {}",
next_thing,
}
fn is_block(expr: &Expr) -> bool {
- if let ExprKind::Block(..) = expr.kind {
- true
- } else {
- false
- }
+ matches!(expr.kind, ExprKind::Block(..))
}
/// Check if the expression is an `if` or `if let`
fn is_if(expr: &Expr) -> bool {
- if let ExprKind::If(..) = expr.kind {
- true
- } else {
- false
- }
+ matches!(expr.kind, ExprKind::If(..))
}