use crate::utils::paths;
use crate::utils::{
- is_expn_of, is_type_diagnostic_item, last_path_segment, match_def_path, match_function_call, snippet, span_lint_and_then,
- walk_ptrs_ty,
+ is_expn_of, is_type_diagnostic_item, last_path_segment, match_def_path, match_function_call, snippet,
+ span_lint_and_then, walk_ptrs_ty,
};
use if_chain::if_chain;
use rustc_ast::ast::LitKind;
///
/// **Examples:**
/// ```rust
+ ///
+ /// // Bad
/// # let foo = "foo";
- /// format!("foo");
/// format!("{}", foo);
+ ///
+ /// // Good
+ /// format!("foo");
/// ```
pub USELESS_FORMAT,
complexity,
// matches `core::fmt::Display::fmt`
if args.len() == 2;
if let ExprKind::Path(ref qpath) = args[1].kind;
- if let Some(did) = cx.tables.qpath_res(qpath, args[1].hir_id).opt_def_id();
+ if let Some(did) = cx.tables().qpath_res(qpath, args[1].hir_id).opt_def_id();
if match_def_path(cx, did, &paths::DISPLAY_FMT_METHOD);
// check `(arg0,)` in match block
if let PatKind::Tuple(ref pats, None) = arms[0].pat.kind;
if pats.len() == 1;
then {
- let ty = walk_ptrs_ty(cx.tables.pat_ty(&pats[0]));
+ let ty = walk_ptrs_ty(cx.tables().pat_ty(&pats[0]));
if ty.kind != rustc_middle::ty::Str && !is_type_diagnostic_item(cx, ty, sym!(string_type)) {
return None;
}
}
} else {
let snip = snippet(cx, format_args.span, "<arg>");
- if let ExprKind::MethodCall(ref path, _, _) = format_args.kind {
+ if let ExprKind::MethodCall(ref path, _, _, _) = format_args.kind {
if path.ident.name == sym!(to_string) {
return Some(format!("{}", snip));
}