-use crate::consts::{constant_simple, Constant};
use rustc::hir::*;
-use rustc::lint::*;
-use syntax::codemap::Span;
+use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
+use rustc::{declare_tool_lint, lint_array};
+use syntax::source_map::Span;
+
+use crate::consts::{constant_simple, Constant};
use crate::utils::{in_macro, span_lint};
-/// **What it does:** Checks for erasing operations, e.g. `x * 0`.
-///
-/// **Why is this bad?** The whole expression can be replaced by zero.
-/// This is most likely not the intended outcome and should probably be
-/// corrected
-///
-/// **Known problems:** None.
-///
-/// **Example:**
-/// ```rust
-/// 0 / x; 0 * x; x & 0
-/// ```
declare_clippy_lint! {
+ /// **What it does:** Checks for erasing operations, e.g., `x * 0`.
+ ///
+ /// **Why is this bad?** The whole expression can be replaced by zero.
+ /// This is most likely not the intended outcome and should probably be
+ /// corrected
+ ///
+ /// **Known problems:** None.
+ ///
+ /// **Example:**
+ /// ```rust
+ /// let x = 1;
+ /// 0 / x;
+ /// 0 * x;
+ /// x & 0;
+ /// ```
pub ERASING_OP,
correctness,
- "using erasing operations, e.g. `x * 0` or `y & 0`"
+ "using erasing operations, e.g., `x * 0` or `y & 0`"
}
#[derive(Copy, Clone)]
fn get_lints(&self) -> LintArray {
lint_array!(ERASING_OP)
}
+
+ fn name(&self) -> &'static str {
+ "ErasingOp"
+ }
}
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for ErasingOp {
if in_macro(e.span) {
return;
}
- if let ExprBinary(ref cmp, ref left, ref right) = e.node {
+ if let ExprKind::Binary(ref cmp, ref left, ref right) = e.node {
match cmp.node {
- BiMul | BiBitAnd => {
+ BinOpKind::Mul | BinOpKind::BitAnd => {
check(cx, left, e.span);
check(cx, right, e.span);
},
- BiDiv => check(cx, left, e.span),
+ BinOpKind::Div => check(cx, left, e.span),
_ => (),
}
}
}
}
-fn check(cx: &LateContext, e: &Expr, span: Span) {
+fn check(cx: &LateContext<'_, '_>, e: &Expr, span: Span) {
if let Some(Constant::Int(v)) = constant_simple(cx, cx.tables, e) {
if v == 0 {
span_lint(