//! lint on `use`ing all variants of an enum
-use rustc::hir::*;
+use crate::utils::span_lint;
use rustc::hir::def::Def;
+use rustc::hir::*;
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
-use syntax::ast::NodeId;
-use syntax::codemap::Span;
-use utils::span_lint;
+use rustc::{declare_tool_lint, lint_array};
+use syntax::source_map::Span;
-/// **What it does:** Checks for `use Enum::*`.
-///
-/// **Why is this bad?** It is usually better style to use the prefixed name of
-/// an enumeration variant, rather than importing variants.
-///
-/// **Known problems:** Old-style enumerations that prefix the variants are
-/// still around.
-///
-/// **Example:**
-/// ```rust
-/// use std::cmp::Ordering::*;
-/// ```
-declare_lint! {
+declare_clippy_lint! {
+ /// **What it does:** Checks for `use Enum::*`.
+ ///
+ /// **Why is this bad?** It is usually better style to use the prefixed name of
+ /// an enumeration variant, rather than importing variants.
+ ///
+ /// **Known problems:** Old-style enumerations that prefix the variants are
+ /// still around.
+ ///
+ /// **Example:**
+ /// ```rust
+ /// use std::cmp::Ordering::*;
+ /// ```
pub ENUM_GLOB_USE,
- Allow,
+ pedantic,
"use items that import all variants of an enum"
}
fn get_lints(&self) -> LintArray {
lint_array!(ENUM_GLOB_USE)
}
+
+ fn name(&self) -> &'static str {
+ "EnumGlobUse"
+ }
}
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for EnumGlobUse {
- fn check_mod(&mut self, cx: &LateContext<'a, 'tcx>, m: &'tcx Mod, _: Span, _: NodeId) {
+ fn check_mod(&mut self, cx: &LateContext<'a, 'tcx>, m: &'tcx Mod, _: Span, _: HirId) {
+ let map = cx.tcx.hir();
// only check top level `use` statements
for item in &m.item_ids {
- self.lint_item(cx, cx.tcx.hir.expect_item(item.id));
+ self.lint_item(cx, map.expect_item(map.hir_to_node_id(item.id)));
}
}
}
impl EnumGlobUse {
- fn lint_item(&self, cx: &LateContext, item: &Item) {
- if item.vis == Visibility::Public {
+ fn lint_item(&self, cx: &LateContext<'_, '_>, item: &Item) {
+ if item.vis.node.is_pub() {
return; // re-exports are fine
}
- if let ItemUse(ref path, UseKind::Glob) = item.node {
+ if let ItemKind::Use(ref path, UseKind::Glob) = item.node {
if let Def::Enum(_) = path.def {
- span_lint(
- cx,
- ENUM_GLOB_USE,
- item.span,
- "don't use glob imports for enum variants",
- );
+ span_lint(cx, ENUM_GLOB_USE, item.span, "don't use glob imports for enum variants");
}
}
}