Merge branch 'macro-use' into HEAD

[rust.git] / clippy_lints / src / enum_glob_use.rs

diff --git a/clippy_lints/src/enum_glob_use.rs b/clippy_lints/src/enum_glob_use.rs
index c00cdc07f84327e0c9ff07d7027f6445621c973a..10cf497725c5306efbe1d152198e84cfe60aeb37 100644 (file)
--- a/clippy_lints/src/enum_glob_use.rs
+++ b/clippy_lints/src/enum_glob_use.rs
@@ -1,10 +1,12 @@
 //! lint on `use`ing all variants of an enum
 
 use rustc::hir::*;
+use rustc::hir::def::Def;
 use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
+use rustc::{declare_lint, lint_array};
 use syntax::ast::NodeId;
 use syntax::codemap::Span;
-use utils::span_lint;
+use crate::utils::span_lint;
 
 /// **What it does:** Checks for `use Enum::*`.
 ///
@@ -12,16 +14,15 @@
 /// an enumeration variant, rather than importing variants.
 ///
 /// **Known problems:** Old-style enumerations that prefix the variants are
-/// still around. May cause problems with modules that are not snake_case (see
-/// [#2397](https://github.com/rust-lang-nursery/rust-clippy/issues/2397))
+/// still around.
 ///
 /// **Example:**
 /// ```rust
 /// use std::cmp::Ordering::*;
 /// ```
-declare_lint! {
+declare_clippy_lint! {
     pub ENUM_GLOB_USE,
-    Allow,
+    pedantic,
     "use items that import all variants of an enum"
 }
 
@@ -44,20 +45,17 @@ fn check_mod(&mut self, cx: &LateContext<'a, 'tcx>, m: &'tcx Mod, _: Span, _: No
 
 impl EnumGlobUse {
     fn lint_item(&self, cx: &LateContext, item: &Item) {
-        if item.vis == Visibility::Public {
+        if item.vis.node.is_pub() {
             return; // re-exports are fine
         }
-        if let ItemUse(ref path, UseKind::Glob) = item.node {
-            // FIXME: ask jseyfried why the qpath.def for `use std::cmp::Ordering::*;`
-            // extracted through `ItemUse(ref qpath, UseKind::Glob)` is a `Mod` and not an
-            // `Enum`
-            // if let Def::Enum(_) = path.def {
-            if path.segments
-                .last()
-                .and_then(|seg| seg.name.as_str().chars().next())
-                .map_or(false, char::is_uppercase)
-            {
-                span_lint(cx, ENUM_GLOB_USE, item.span, "don't use glob imports for enum variants");
+        if let ItemKind::Use(ref path, UseKind::Glob) = item.node {
+            if let Def::Enum(_) = path.def {
+                span_lint(
+                    cx,
+                    ENUM_GLOB_USE,
+                    item.span,
+                    "don't use glob imports for enum variants",
+                );
             }
         }
     }