//! Lint on if expressions with an else if, but without a final else branch.
-use rustc::lint::{in_external_macro, EarlyContext, EarlyLintPass, LintContext};
+use clippy_utils::diagnostics::span_lint_and_help;
+use rustc_ast::ast::{Expr, ExprKind};
+use rustc_lint::{EarlyContext, EarlyLintPass};
+use rustc_middle::lint::in_external_macro;
use rustc_session::{declare_lint_pass, declare_tool_lint};
-use syntax::ast::*;
-
-use crate::utils::span_help_and_lint;
declare_clippy_lint! {
- /// **What it does:** Checks for usage of if expressions with an `else if` branch,
+ /// ### What it does
+ /// Checks for usage of if expressions with an `else if` branch,
/// but without a final `else` branch.
///
- /// **Why is this bad?** Some coding guidelines require this (e.g., MISRA-C:2004 Rule 14.10).
- ///
- /// **Known problems:** None.
+ /// ### Why is this bad?
+ /// Some coding guidelines require this (e.g., MISRA-C:2004 Rule 14.10).
///
- /// **Example:**
+ /// ### Example
/// ```rust
/// # fn a() {}
/// # fn b() {}
impl EarlyLintPass for ElseIfWithoutElse {
fn check_expr(&mut self, cx: &EarlyContext<'_>, mut item: &Expr) {
- if in_external_macro(cx.sess(), item.span) {
+ if in_external_macro(cx.sess, item.span) {
return;
}
while let ExprKind::If(_, _, Some(ref els)) = item.kind {
if let ExprKind::If(_, _, None) = els.kind {
- span_help_and_lint(
+ span_lint_and_help(
cx,
ELSE_IF_WITHOUT_ELSE,
els.span,
"`if` expression with an `else if`, but without a final `else`",
+ None,
"add an `else` block here",
);
}