use rustc::lint::*;
use rustc::ty;
use rustc::hir::*;
-use utils::{match_def_path, paths, span_note_and_lint, is_copy};
+use utils::{is_copy, match_def_path, paths, span_note_and_lint};
/// **What it does:** Checks for calls to `std::mem::drop` with a reference
/// instead of an owned value.
/// **Example:**
/// ```rust
/// let mut lock_guard = mutex.lock();
-/// std::mem::drop(&lock_guard) // Should have been drop(lock_guard), mutex still locked
+/// std::mem::drop(&lock_guard) // Should have been drop(lock_guard), mutex
+/// still locked
/// operation_that_requires_mutex_to_be_unlocked();
/// ```
declare_lint! {
/// instead of an owned value.
///
/// **Why is this bad?** Calling `forget` on a reference will only forget the
-/// reference itself, which is a no-op. It will not forget the underlying referenced
+/// reference itself, which is a no-op. It will not forget the underlying
+/// referenced
/// value, which is likely what was intended.
///
/// **Known problems:** None.
/// **Example:**
/// ```rust
/// let x:i32 = 42; // i32 implements Copy
-/// std::mem::drop(x) // A copy of x is passed to the function, leaving the original unaffected
+/// std::mem::drop(x) // A copy of x is passed to the function, leaving the
+/// original unaffected
/// ```
declare_lint! {
pub DROP_COPY,
/// implement Copy](https://doc.rust-lang.org/std/mem/fn.drop.html) since the
/// value will be copied and moved into the function on invocation.
///
-/// An alternative, but also valid, explanation is that Copy types do not implement
-/// the Drop trait, which means they have no destructors. Without a destructor, there
+/// An alternative, but also valid, explanation is that Copy types do not
+/// implement
+/// the Drop trait, which means they have no destructors. Without a destructor,
+/// there
/// is nothing for `std::mem::forget` to ignore.
///
/// **Known problems:** None.
/// **Example:**
/// ```rust
/// let x:i32 = 42; // i32 implements Copy
-/// std::mem::forget(x) // A copy of x is passed to the function, leaving the original unaffected
+/// std::mem::forget(x) // A copy of x is passed to the function, leaving the
+/// original unaffected
/// ```
declare_lint! {
pub FORGET_COPY,
}
const DROP_REF_SUMMARY: &str = "calls to `std::mem::drop` with a reference instead of an owned value. \
- Dropping a reference does nothing.";
+ Dropping a reference does nothing.";
const FORGET_REF_SUMMARY: &str = "calls to `std::mem::forget` with a reference instead of an owned value. \
- Forgetting a reference does nothing.";
+ Forgetting a reference does nothing.";
const DROP_COPY_SUMMARY: &str = "calls to `std::mem::drop` with a value that implements Copy. \
- Dropping a copy leaves the original intact.";
+ Dropping a copy leaves the original intact.";
const FORGET_COPY_SUMMARY: &str = "calls to `std::mem::forget` with a value that implements Copy. \
- Forgetting a copy leaves the original intact.";
+ Forgetting a copy leaves the original intact.";
#[allow(missing_copy_implementations)]
pub struct Pass;
let ExprPath(ref qpath) = path.node,
args.len() == 1,
], {
- let def_id = cx.tables.qpath_def(qpath, path.id).def_id();
+ let def_id = cx.tables.qpath_def(qpath, path.hir_id).def_id();
let lint;
let msg;
let arg = &args[0];