+use crate::utils::span_lint;
+use rustc::lint::{EarlyContext, EarlyLintPass, LintArray, LintPass};
+use rustc::{declare_lint_pass, declare_tool_lint};
use syntax::ast::*;
-use rustc::lint::{EarlyContext, EarlyLintPass, LintArray, LintContext, LintPass};
-/// **What it does:** Checks for unnecessary double parentheses.
-///
-/// **Why is this bad?** This makes code harder to read and might indicate a
-/// mistake.
-///
-/// **Known problems:** None.
-///
-/// **Example:**
-/// ```rust
-/// ((0))
-/// foo((0))
-/// ((1, 2))
-/// ```
-declare_lint! {
- pub DOUBLE_PARENS, Warn,
+declare_clippy_lint! {
+ /// **What it does:** Checks for unnecessary double parentheses.
+ ///
+ /// **Why is this bad?** This makes code harder to read and might indicate a
+ /// mistake.
+ ///
+ /// **Known problems:** None.
+ ///
+ /// **Example:**
+ /// ```rust
+ /// # fn foo(bar: usize) {}
+ /// ((0));
+ /// foo((0));
+ /// ((1, 2));
+ /// ```
+ pub DOUBLE_PARENS,
+ complexity,
"Warn on unnecessary double parentheses"
}
-#[derive(Copy, Clone)]
-pub struct DoubleParens;
-
-impl LintPass for DoubleParens {
- fn get_lints(&self) -> LintArray {
- lint_array!(DOUBLE_PARENS)
- }
-}
+declare_lint_pass!(DoubleParens => [DOUBLE_PARENS]);
impl EarlyLintPass for DoubleParens {
- fn check_expr(&mut self, cx: &EarlyContext, expr: &Expr) {
+ fn check_expr(&mut self, cx: &EarlyContext<'_>, expr: &Expr) {
+ if expr.span.from_expansion() {
+ return;
+ }
+
match expr.node {
ExprKind::Paren(ref in_paren) => match in_paren.node {
ExprKind::Paren(_) | ExprKind::Tup(_) => {
- cx.span_lint(DOUBLE_PARENS, expr.span, "Consider removing unnecessary double parentheses");
+ span_lint(
+ cx,
+ DOUBLE_PARENS,
+ expr.span,
+ "Consider removing unnecessary double parentheses",
+ );
},
_ => {},
},
- ExprKind::Call(_, ref params) => if params.len() == 1 {
- let param = ¶ms[0];
- if let ExprKind::Paren(_) = param.node {
- cx.span_lint(DOUBLE_PARENS, param.span, "Consider removing unnecessary double parentheses");
+ ExprKind::Call(_, ref params) => {
+ if params.len() == 1 {
+ let param = ¶ms[0];
+ if let ExprKind::Paren(_) = param.node {
+ span_lint(
+ cx,
+ DOUBLE_PARENS,
+ param.span,
+ "Consider removing unnecessary double parentheses",
+ );
+ }
}
},
- ExprKind::MethodCall(_, ref params) => if params.len() == 2 {
- let param = ¶ms[1];
- if let ExprKind::Paren(_) = param.node {
- cx.span_lint(DOUBLE_PARENS, param.span, "Consider removing unnecessary double parentheses");
+ ExprKind::MethodCall(_, ref params) => {
+ if params.len() == 2 {
+ let param = ¶ms[1];
+ if let ExprKind::Paren(_) = param.node {
+ span_lint(
+ cx,
+ DOUBLE_PARENS,
+ param.span,
+ "Consider removing unnecessary double parentheses",
+ );
+ }
}
},
_ => {},