//!
//! This lint is **warn** by default
+use clippy_utils::diagnostics::{span_lint_and_sugg, span_lint_and_then};
+use clippy_utils::source::{snippet_block, snippet_block_with_applicability};
+use clippy_utils::sugg::Sugg;
use if_chain::if_chain;
use rustc_ast::ast;
+use rustc_errors::Applicability;
use rustc_lint::{EarlyContext, EarlyLintPass};
use rustc_session::{declare_lint_pass, declare_tool_lint};
-use crate::utils::sugg::Sugg;
-use crate::utils::{snippet_block, snippet_block_with_applicability, span_lint_and_sugg, span_lint_and_then};
-use rustc_errors::Applicability;
-
declare_clippy_lint! {
- /// **What it does:** Checks for nested `if` statements which can be collapsed
+ /// ### What it does
+ /// Checks for nested `if` statements which can be collapsed
/// by `&&`-combining their conditions.
///
- /// **Why is this bad?** Each `if`-statement adds one level of nesting, which
+ /// ### Why is this bad?
+ /// Each `if`-statement adds one level of nesting, which
/// makes code look more complex than it really is.
///
- /// **Known problems:** None.
- ///
- /// **Example:**
+ /// ### Example
/// ```rust,ignore
/// if x {
/// if y {
/// …
/// }
/// ```
+ #[clippy::version = "pre 1.29.0"]
pub COLLAPSIBLE_IF,
style,
"nested `if`s that can be collapsed (e.g., `if x { if y { ... } }`"
}
declare_clippy_lint! {
- /// **What it does:** Checks for collapsible `else { if ... }` expressions
+ /// ### What it does
+ /// Checks for collapsible `else { if ... }` expressions
/// that can be collapsed to `else if ...`.
///
- /// **Why is this bad?** Each `if`-statement adds one level of nesting, which
+ /// ### Why is this bad?
+ /// Each `if`-statement adds one level of nesting, which
/// makes code look more complex than it really is.
///
- /// **Known problems:** None.
- ///
- /// **Example:**
+ /// ### Example
/// ```rust,ignore
///
/// if x {
/// …
/// }
/// ```
+ #[clippy::version = "1.51.0"]
pub COLLAPSIBLE_ELSE_IF,
style,
"nested `else`-`if` expressions that can be collapsed (e.g., `else { if x { ... } }`)"
impl EarlyLintPass for CollapsibleIf {
fn check_expr(&mut self, cx: &EarlyContext<'_>, expr: &ast::Expr) {
if !expr.span.from_expansion() {
- check_if(cx, expr)
+ check_if(cx, expr);
}
}
}
if let ast::ExprKind::Block(ref block, _) = else_.kind;
if !block_starts_with_comment(cx, block);
if let Some(else_) = expr_block(block);
+ if else_.attrs.is_empty();
if !else_.span.from_expansion();
if let ast::ExprKind::If(..) = else_.kind;
then {
if_chain! {
if !block_starts_with_comment(cx, then);
if let Some(inner) = expr_block(then);
+ if inner.attrs.is_empty();
if let ast::ExprKind::If(ref check_inner, ref content, None) = inner.kind;
+ // Prevent triggering on `if c { if let a = b { .. } }`.
+ if !matches!(check_inner.kind, ast::ExprKind::Let(..));
+ if expr.span.ctxt() == inner.span.ctxt();
then {
- if let ast::ExprKind::Let(..) = check_inner.kind {
- // Prevent triggering on `if c { if let a = b { .. } }`.
- return;
- }
-
- if expr.span.ctxt() != inner.span.ctxt() {
- return;
- }
span_lint_and_then(cx, COLLAPSIBLE_IF, expr.span, "this `if` statement can be collapsed", |diag| {
let lhs = Sugg::ast(cx, check, "..");
let rhs = Sugg::ast(cx, check_inner, "..");