use rustc::lint::*;
use rustc::hir::*;
-use utils::span_lint;
+use crate::utils::span_lint;
/// **What it does:** Checks for usage of blacklisted names for variables, such
/// as `foo`.
/// ```rust
/// let foo = 3.14;
/// ```
-declare_lint! {
+declare_clippy_lint! {
pub BLACKLISTED_NAME,
- Warn,
+ style,
"usage of a blacklisted/placeholder name"
}
}
impl BlackListedName {
- pub fn new(blacklist: Vec<String>) -> BlackListedName {
- BlackListedName { blacklist: blacklist }
+ pub fn new(blacklist: Vec<String>) -> Self {
+ Self {
+ blacklist,
+ }
}
}
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for BlackListedName {
fn check_pat(&mut self, cx: &LateContext<'a, 'tcx>, pat: &'tcx Pat) {
- if let PatKind::Binding(_, _, ref ident, _) = pat.node {
- if self.blacklist.iter().any(|s| ident.node == *s) {
- span_lint(cx,
- BLACKLISTED_NAME,
- ident.span,
- &format!("use of a blacklisted/placeholder name `{}`", ident.node));
+ if let PatKind::Binding(_, _, ident, _) = pat.node {
+ if self.blacklist.iter().any(|s| ident.name == *s) {
+ span_lint(
+ cx,
+ BLACKLISTED_NAME,
+ ident.span,
+ &format!("use of a blacklisted/placeholder name `{}`", ident.name),
+ );
}
}
}