use crate::utils::{
- get_trait_def_id, implements_trait, snippet_opt, span_lint_and_then, trait_ref_of_method, SpanlessEq,
+ eq_expr_value, get_trait_def_id, implements_trait, snippet_opt, span_lint_and_then, trait_ref_of_method,
};
use crate::utils::{higher, sugg};
use if_chain::if_chain;
return;
}
// lhs op= l op r
- if SpanlessEq::new(cx).ignore_fn().eq_expr(lhs, l) {
+ if eq_expr_value(cx, lhs, l) {
lint_misrefactored_assign_op(cx, expr, *op, rhs, lhs, r);
}
// lhs op= l commutative_op r
- if is_commutative(op.node) && SpanlessEq::new(cx).ignore_fn().eq_expr(lhs, r) {
+ if is_commutative(op.node) && eq_expr_value(cx, lhs, r) {
lint_misrefactored_assign_op(cx, expr, *op, rhs, lhs, l);
}
}
if visitor.counter == 1 {
// a = a op b
- if SpanlessEq::new(cx).ignore_fn().eq_expr(assignee, l) {
+ if eq_expr_value(cx, assignee, l) {
lint(assignee, r);
}
// a = b commutative_op a
// Limited to primitive type as these ops are know to be commutative
- if SpanlessEq::new(cx).ignore_fn().eq_expr(assignee, r)
- && cx.typeck_results().expr_ty(assignee).is_primitive_ty()
- {
+ if eq_expr_value(cx, assignee, r) && cx.typeck_results().expr_ty(assignee).is_primitive_ty() {
match op.node {
hir::BinOpKind::Add
| hir::BinOpKind::Mul
type Map = Map<'tcx>;
fn visit_expr(&mut self, expr: &'tcx hir::Expr<'_>) {
- if SpanlessEq::new(self.cx).ignore_fn().eq_expr(self.assignee, expr) {
+ if eq_expr_value(self.cx, self.assignee, expr) {
self.counter += 1;
}