if let hir::ExprBinary(binop, ref l, ref r) = rhs.node {
if op.node == binop.node {
let lint = |assignee: &hir::Expr, rhs: &hir::Expr| {
- let ty = cx.tables.expr_ty(assignee);
- if ty.walk_shallow().next().is_some() {
- return; // implements_trait does not work with generics
- }
- let rty = cx.tables.expr_ty(rhs);
- if rty.walk_shallow().next().is_some() {
- return; // implements_trait does not work with generics
- }
span_lint_and_then(cx,
MISREFACTORED_ASSIGN_OP,
expr.span,
|db| if let (Some(snip_a), Some(snip_r)) =
(snippet_opt(cx, assignee.span), snippet_opt(cx, rhs.span)) {
db.span_suggestion(expr.span,
- "replace it with",
- format!("{} {}= {}", snip_a, op.node.as_str(), snip_r));
+ "replace it with",
+ format!("{} {}= {}",
+ snip_a,
+ op.node.as_str(),
+ snip_r));
});
};
// lhs op= l op r
#[allow(cyclomatic_complexity)]
let lint = |assignee: &hir::Expr, rhs: &hir::Expr| {
let ty = cx.tables.expr_ty(assignee);
- if ty.walk_shallow().next().is_some() {
- return; // implements_trait does not work with generics
- }
let rty = cx.tables.expr_ty(rhs);
- if rty.walk_shallow().next().is_some() {
- return; // implements_trait does not work with generics
- }
macro_rules! ops {
($op:expr,
$cx:expr,
return; // useless if the trait doesn't exist
};
// check that we are not inside an `impl AssignOp` of this exact operation
- let parent_fn = cx.tcx.map.get_parent(e.id);
- let parent_impl = cx.tcx.map.get_parent(parent_fn);
+ let parent_fn = cx.tcx.hir.get_parent(e.id);
+ let parent_impl = cx.tcx.hir.get_parent(parent_fn);
// the crate node is the only one that is not in the map
if_let_chain!{[
parent_impl != ast::CRATE_NODE_ID,
- let hir::map::Node::NodeItem(item) = cx.tcx.map.get(parent_impl),
- let hir::Item_::ItemImpl(_, _, _, Some(ref trait_ref), _, _) = item.node,
+ let hir::map::Node::NodeItem(item) = cx.tcx.hir.get(parent_impl),
+ let hir::Item_::ItemImpl(_, _, _, _, Some(ref trait_ref), _, _) = item.node,
trait_ref.path.def.def_id() == trait_id
], { return; }}
- implements_trait($cx, $ty, trait_id, vec![$rty])
+ implements_trait($cx, $ty, trait_id, &[$rty])
},)*
_ => false,
}
|db| if let (Some(snip_a), Some(snip_r)) =
(snippet_opt(cx, assignee.span), snippet_opt(cx, rhs.span)) {
db.span_suggestion(expr.span,
- "replace it with",
- format!("{} {}= {}", snip_a, op.node.as_str(), snip_r));
+ "replace it with",
+ format!("{} {}= {}",
+ snip_a,
+ op.node.as_str(),
+ snip_r));
});
}
};