use crate::consts::constant_simple;
use crate::utils::span_lint;
use rustc::hir;
+use rustc::impl_lint_pass;
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
-use rustc::{declare_tool_lint, impl_lint_pass};
+use rustc_session::declare_tool_lint;
use syntax::source_map::Span;
declare_clippy_lint! {
///
/// **Example:**
/// ```rust
- /// a + 1
+ /// # let a = 0;
+ /// a + 1;
/// ```
pub INTEGER_ARITHMETIC,
restriction,
///
/// **Example:**
/// ```rust
- /// a + 1.0
+ /// # let a = 0.0;
+ /// a + 1.0;
/// ```
pub FLOAT_ARITHMETIC,
restriction,
return;
}
}
- match &expr.node {
- hir::ExprKind::Binary(op, l, r) => {
+ match &expr.kind {
+ hir::ExprKind::Binary(op, l, r) | hir::ExprKind::AssignOp(op, l, r) => {
match op.node {
hir::BinOpKind::And
| hir::BinOpKind::Or
},
hir::ExprKind::Unary(hir::UnOp::UnNeg, arg) => {
let ty = cx.tables.expr_ty(arg);
- if ty.is_integral() {
- if constant_simple(cx, cx.tables, expr).is_none() {
+ if constant_simple(cx, cx.tables, expr).is_none() {
+ if ty.is_integral() {
span_lint(cx, INTEGER_ARITHMETIC, expr.span, "integer arithmetic detected");
self.expr_span = Some(expr.span);
+ } else if ty.is_floating_point() {
+ span_lint(cx, FLOAT_ARITHMETIC, expr.span, "floating-point arithmetic detected");
+ self.expr_span = Some(expr.span);
}
- } else if ty.is_floating_point() {
- span_lint(cx, FLOAT_ARITHMETIC, expr.span, "floating-point arithmetic detected");
- self.expr_span = Some(expr.span);
}
},
_ => (),
}
}
- fn check_body(&mut self, cx: &LateContext<'_, '_>, body: &hir::Body) {
+ fn check_body(&mut self, cx: &LateContext<'_, '_>, body: &hir::Body<'_>) {
let body_owner = cx.tcx.hir().body_owner(body.id());
match cx.tcx.hir().body_owner_kind(body_owner) {
}
}
- fn check_body_post(&mut self, cx: &LateContext<'_, '_>, body: &hir::Body) {
+ fn check_body_post(&mut self, cx: &LateContext<'_, '_>, body: &hir::Body<'_>) {
let body_owner = cx.tcx.hir().body_owner(body.id());
let body_span = cx.tcx.hir().span(body_owner);