Hide VCS release option when not available

[cheatdb.git] / app / templates / packages / view.html

diff --git a/app/templates/packages/view.html b/app/templates/packages/view.html
index 150abee08bd7bfd2e9ce7d621c236904e4ecace5..59a1501fa06bc2b586199c680198310043237fc3 100644 (file)
--- a/app/templates/packages/view.html
+++ b/app/templates/packages/view.html
@@ -9,7 +9,17 @@
                <div class="box box_grey alert alert-warning">
                        <span class="icon_message"></span>
                        {% if package.releases.count() == 0 %}
-                               You need to create a release before this package can be approved.
+                               {% if package.checkPerm(current_user, "MAKE_RELEASE") %}
+                                       You need to create a release before this package can be approved.
+                                       <p>
+                                               A release is a single downloadable version of your {{ package.type.value | lower }}.
+                                               You need to create releases even if you use a rolling release development cycle,
+                                               as Minetest needs them to check for updates.
+                                       </p>
+                                       <a class="button" href="{{ package.getCreateReleaseURL() }}">Create Release</a>
+                               {% else %}
+                                       A release is required before this package can be approved.
+                               {% endif %}
                        {% elif not package.getDownloadRelease() %}
                                Please wait for the release to be approved.
                        {% else %}
@@ -40,45 +50,49 @@
        </ul>
 
        <aside class="asideright box box_grey">
-               <table>
-                       <tr>
-                               <td>Name</td>
-                               <td>{{ package.name }}</td>
-                       </tr>
-                       <tr>
-                               <td>Author</td>
-                               <td class="{{ package.author.rank }}">
-                                       <a href="{{ url_for('user_profile_page', username=package.author.username) }}">
-                                               {{ package.author.display_name }}
-                                       </a>
-                               </td>
-                       </tr>
-                       <tr>
-                               <td>Type</td>
-                               <td>{{ package.type.value }}</td>
-                       </tr>
-                       <tr>
-                               <td>License</td>
-                               <td>{{ package.license.name }}</td>
-                       </tr>
-               </table>
-
-               <ul class="buttonset linedbuttonset">
-                       {% if package.getDownloadRelease() %}<li><a href="{{ package.getDownloadURL() }}">Download</a></li>{% endif %}
-                       {% if package.repo %}<li><a href="{{ package.repo }}">View Source</a></li>{% endif %}
-                       {% if package.forums %}<li><a href="https://forum.minetest.net/viewtopic.php?t={{ package.forums }}">Forums</a></li>{% endif %}
-                       {% if package.issueTracker %}<li><a href="{{ package.issueTracker }}">Issue Tracker</a></li>{% endif %}
-                       {% if package.website %}<li><a href="{{ package.website }}">Website</a></li>{% endif %}
-                       {% if package.checkPerm(current_user, "EDIT_PACKAGE") %}
-                               <li><a href="{{ package.getEditURL() }}">Edit</a></li>
-                               <li><a href="{{ package.getNewScreenshotURL() }}">Add screenshot</a></li>
-                       {% elif current_user.is_authenticated %}
-                               <li><a href="{{ package.getCreateEditRequestURL() }}">Suggest Change</a></li>
-                       {% endif %}
-                       {% if package.checkPerm(current_user, "MAKE_RELEASE") %}
-                               <li><a href="{{ package.getCreateReleaseURL() }}">Create Release</a></li>
-                       {% endif %}
-               </ul>
+               <h3>Details</h3>
+               <div class="box-body">
+                       <table>
+                               <tr>
+                                       <td>Name</td>
+                                       <td>{{ package.name }}</td>
+                               </tr>
+                               <tr>
+                                       <td>Author</td>
+                                       <td class="{{ package.author.rank }}">
+                                               <a href="{{ url_for('user_profile_page', username=package.author.username) }}">
+                                                       {{ package.author.display_name }}
+                                               </a>
+                                       </td>
+                               </tr>
+                               <tr>
+                                       <td>Type</td>
+                                       <td>{{ package.type.value }}</td>
+                               </tr>
+                               <tr>
+                                       <td>License</td>
+                                       <td>{{ package.license.name }}</td>
+                               </tr>
+                       </table>
+
+                       <ul class="buttonset linedbuttonset">
+                               {% if package.getDownloadRelease() %}<li><a href="{{ package.getDownloadURL() }}">Download</a></li>{% endif %}
+                               {% if package.repo %}<li><a href="{{ package.repo }}">View Source</a></li>{% endif %}
+                               {% if package.forums %}<li><a href="https://forum.minetest.net/viewtopic.php?t={{ package.forums }}">Forums</a></li>{% endif %}
+                               {% if package.issueTracker %}<li><a href="{{ package.issueTracker }}">Issue Tracker</a></li>{% endif %}
+                               {% if package.website %}<li><a href="{{ package.website }}">Website</a></li>{% endif %}
+                               {% if package.checkPerm(current_user, "EDIT_PACKAGE") %}
+                                       <li><a href="{{ package.getEditURL() }}">Edit</a></li>
+                                       <li><a href="{{ package.getNewScreenshotURL() }}">Add screenshot</a></li>
+                               {% endif %}
+                               {% if current_user.is_authenticated %}
+                                       <!-- <li><a href="{{ package.getCreateEditRequestURL() }}">Suggest Change</a></li> -->
+                               {% endif %}
+                               {% if package.checkPerm(current_user, "MAKE_RELEASE") %}
+                                       <li><a href="{{ package.getCreateReleaseURL() }}">Create Release</a></li>
+                               {% endif %}
+                       </ul>
+               </div>
        </aside>
 
        <p class="package-short-large">{{ package.shortDesc }}</p>
@@ -96,14 +110,14 @@
                                        <a href="{{ rel.url }}">{{ rel.title }}</a>,
                                        created {{ rel.releaseDate }}.
                                        {% if rel.task_id %}
-                                               <a href="{{ url_for('check_task', id=rel.task_id, r=package.getDetailsURL()) }}">Importing</a>
+                                               <a href="{{ url_for('check_task', id=rel.task_id, r=package.getDetailsURL()) }}">Importing...</a>
                                        {% elif not rel.approved %}
                                                Waiting for approval.
                                        {% endif %}
 
-                                       {% if not rel.task_id and (package.checkPerm(current_user, "MAKE_RELEASE") or package.checkPerm(current_user, "APPROVE_RELEASE"))  %}
+                                       {% if package.checkPerm(current_user, "MAKE_RELEASE") or package.checkPerm(current_user, "APPROVE_RELEASE")  %}
                                                <a href="{{ rel.getEditURL() }}">Edit
-                                               {% if not rel.approved and package.checkPerm(current_user, "APPROVE_RELEASE") %}
+                                               {% if not rel.task_id and not rel.approved and package.checkPerm(current_user, "APPROVE_RELEASE") %}
                                                        / Approve
                                                {% endif %}
                                                </a>