on:
push:
- branches: [auto, try]
- # Don't run Clippy tests, when only textfiles were modified
- paths-ignore:
- - 'COPYRIGHT'
- - 'LICENSE-*'
- - '**.md'
- - '**.txt'
+ branches:
+ - auto
+ - try
env:
RUST_BACKTRACE: 1
CARGO_TARGET_DIR: '${{ github.workspace }}/target'
- GHA_CI: 1
+ NO_FMT_TEST: 1
+
+defaults:
+ run:
+ shell: bash
jobs:
changelog:
runs-on: ubuntu-latest
steps:
+ - uses: rust-lang/simpleinfra/github-actions/cancel-outdated-builds@master
+ with:
+ github_token: "${{ secrets.github_token }}"
+
- name: Checkout
- uses: actions/checkout@v2.0.0
+ uses: actions/checkout@v2.3.3
with:
ref: ${{ github.ref }}
+
+ # Run
- name: Check Changelog
run: |
MESSAGE=$(git log --format=%B -n 1)
PR=$(echo "$MESSAGE" | grep -o "#[0-9]*" | head -1 | sed -e 's/^#//')
- output=$(curl -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" -s "https://api.github.com/repos/rust-lang/rust-clippy/pulls/$PR" | \
- python -c "import sys, json; print(json.load(sys.stdin)['body'])" | \
- grep "^changelog: " | \
- sed "s/changelog: //g")
- if [[ -z "$output" ]]; then
+ body=$(curl -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" -s "https://api.github.com/repos/rust-lang/rust-clippy/pulls/$PR" | \
+ python -c "import sys, json; print(json.load(sys.stdin)['body'])")
+ output=$(grep "^changelog:\s*\S" <<< "$body" | sed "s/changelog:\s*//g") || {
echo "ERROR: PR body must contain 'changelog: ...'"
exit 1
- elif [[ "$output" = "none" ]]; then
+ }
+ if [[ "$output" = "none" ]]; then
echo "WARNING: changelog is 'none'"
+ else
+ echo "changelog: $output"
fi
+ env:
+ PYTHONIOENCODING: 'utf-8'
base:
needs: changelog
strategy:
runs-on: ${{ matrix.os }}
+ # NOTE: If you modify this job, make sure you copy the changes to clippy.yml
steps:
+ # Setup
+ - uses: rust-lang/simpleinfra/github-actions/cancel-outdated-builds@master
+ with:
+ github_token: "${{ secrets.github_token }}"
+
- name: Install dependencies (Linux-i686)
run: |
sudo dpkg --add-architecture i386
sudo apt-get update
sudo apt-get install gcc-multilib libssl-dev:i386 libgit2-dev:i386
if: matrix.host == 'i686-unknown-linux-gnu'
- - name: rust-toolchain
- uses: actions-rs/toolchain@v1.0.3
- with:
- toolchain: nightly
- target: ${{ matrix.host }}
- profile: minimal
- - name: Cache cargo dir
- uses: actions/cache@v1
- with:
- path: ~/.cargo
- key: ${{ runner.os }}-${{ matrix.host }}
+
- name: Checkout
- uses: actions/checkout@v2.0.0
- - name: Master Toolchain Setup
- run: bash setup-toolchain.sh
- env:
- HOST_TOOLCHAIN: ${{ matrix.host }}
- shell: bash
+ uses: actions/checkout@v2.3.3
+
+ - name: Install toolchain
+ run: rustup show active-toolchain
+ # Run
- name: Set LD_LIBRARY_PATH (Linux)
if: runner.os == 'Linux'
run: |
SYSROOT=$(rustc --print sysroot)
- echo "::set-env name=LD_LIBRARY_PATH::${SYSROOT}/lib${LD_LIBRARY_PATH+:${LD_LIBRARY_PATH}}"
+ echo "LD_LIBRARY_PATH=${SYSROOT}/lib${LD_LIBRARY_PATH+:${LD_LIBRARY_PATH}}" >> $GITHUB_ENV
- name: Link rustc dylib (MacOS)
if: runner.os == 'macOS'
run: |
- name: Set PATH (Windows)
if: runner.os == 'Windows'
run: |
- $sysroot = rustc --print sysroot
- $env:PATH += ';' + $sysroot + '\bin'
- echo "::set-env name=PATH::$env:PATH"
+ SYSROOT=$(rustc --print sysroot)
+ echo "$SYSROOT/bin" >> $GITHUB_PATH
+
- name: Build
- run: cargo build --features deny-warnings
- shell: bash
+ run: cargo build --features deny-warnings,internal
+
- name: Test
- run: cargo test --features deny-warnings
- shell: bash
+ if: runner.os == 'Linux'
+ run: cargo test --features deny-warnings,internal
+
+ - name: Test
+ if: runner.os != 'Linux'
+ run: cargo test --features deny-warnings,internal -- --skip dogfood
+
- name: Test clippy_lints
- run: cargo test --features deny-warnings
- shell: bash
+ run: cargo test --features deny-warnings,internal
working-directory: clippy_lints
+
+ - name: Test clippy_utils
+ run: cargo test --features deny-warnings,internal
+ working-directory: clippy_utils
+
- name: Test rustc_tools_util
run: cargo test --features deny-warnings
- shell: bash
working-directory: rustc_tools_util
+
- name: Test clippy_dev
run: cargo test --features deny-warnings
- shell: bash
working-directory: clippy_dev
- - name: Test cargo-clippy
- run: ../target/debug/cargo-clippy
- shell: bash
- working-directory: clippy_workspace_tests
+
- name: Test clippy-driver
+ run: bash .github/driver.sh
+ env:
+ OS: ${{ runner.os }}
+
+ integration_build:
+ needs: changelog
+ runs-on: ubuntu-latest
+
+ steps:
+ # Setup
+ - uses: rust-lang/simpleinfra/github-actions/cancel-outdated-builds@master
+ with:
+ github_token: "${{ secrets.github_token }}"
+
+ - name: Checkout
+ uses: actions/checkout@v2.3.3
+
+ - name: Install toolchain
+ run: rustup show active-toolchain
+
+ # Run
+ - name: Build Integration Test
+ run: cargo test --test integration --features integration --no-run
+
+ # Upload
+ - name: Extract Binaries
run: |
- (
- set -ex
- # Check sysroot handling
- sysroot=$(./target/debug/clippy-driver --print sysroot)
- test "$sysroot" = "$(rustc --print sysroot)"
-
- if [[ ${{ runner.os }} == "Windows" ]]; then
- desired_sysroot=C:/tmp
- else
- desired_sysroot=/tmp
- fi
- sysroot=$(./target/debug/clippy-driver --sysroot $desired_sysroot --print sysroot)
- test "$sysroot" = $desired_sysroot
-
- sysroot=$(SYSROOT=$desired_sysroot ./target/debug/clippy-driver --print sysroot)
- test "$sysroot" = $desired_sysroot
-
- # Make sure this isn't set - clippy-driver should cope without it
- unset CARGO_MANIFEST_DIR
-
- # Run a lint and make sure it produces the expected output. It's also expected to exit with code 1
- # FIXME: How to match the clippy invocation in compile-test.rs?
- ./target/debug/clippy-driver -Dwarnings -Aunused -Zui-testing --emit metadata --crate-type bin tests/ui/cstring.rs 2> cstring.stderr && exit 1
- sed -e 's,tests/ui,$DIR,' -e '/= help/d' cstring.stderr > normalized.stderr
- diff normalized.stderr tests/ui/cstring.stderr
-
- # TODO: CLIPPY_CONF_DIR / CARGO_MANIFEST_DIR
- )
- shell: bash
-
- - name: Run cargo-cache --autoclean
+ DIR=$CARGO_TARGET_DIR/debug
+ rm $DIR/deps/integration-*.d
+ mv $DIR/deps/integration-* $DIR/integration
+ find $DIR ! -executable -o -type d ! -path $DIR | xargs rm -rf
+ rm -rf $CARGO_TARGET_DIR/release
+
+ - name: Upload Binaries
+ uses: actions/upload-artifact@v1
+ with:
+ name: target
+ path: target
+
+ integration:
+ needs: integration_build
+ strategy:
+ fail-fast: false
+ max-parallel: 6
+ matrix:
+ integration:
+ - 'rust-lang/cargo'
+ # FIXME: re-enable once fmt_macros is renamed in RLS
+ # - 'rust-lang/rls'
+ - 'rust-lang/chalk'
+ - 'rust-lang/rustfmt'
+ - 'Marwes/combine'
+ - 'Geal/nom'
+ - 'rust-lang/stdarch'
+ - 'serde-rs/serde'
+ # FIXME: chrono currently cannot be compiled with `--all-targets`
+ # - 'chronotope/chrono'
+ - 'hyperium/hyper'
+ - 'rust-random/rand'
+ - 'rust-lang/futures-rs'
+ - 'rust-itertools/itertools'
+ - 'rust-lang-nursery/failure'
+ - 'rust-lang/log'
+
+ runs-on: ubuntu-latest
+
+ steps:
+ # Setup
+ - uses: rust-lang/simpleinfra/github-actions/cancel-outdated-builds@master
+ with:
+ github_token: "${{ secrets.github_token }}"
+
+ - name: Checkout
+ uses: actions/checkout@v2.3.3
+
+ - name: Install toolchain
+ run: rustup show active-toolchain
+
+ # Download
+ - name: Download target dir
+ uses: actions/download-artifact@v1
+ with:
+ name: target
+ path: target
+
+ - name: Make Binaries Executable
+ run: chmod +x $CARGO_TARGET_DIR/debug/*
+
+ # Run
+ - name: Test ${{ matrix.integration }}
run: |
- cargo install cargo-cache --debug
- /usr/bin/find ~/.cargo/bin ! -type d -exec strip {} \;
- cargo cache --autoclean
- shell: bash
+ RUSTUP_TOOLCHAIN="$(rustup show active-toolchain | grep -o -E "nightly-[0-9]{4}-[0-9]{2}-[0-9]{2}")" \
+ $CARGO_TARGET_DIR/debug/integration
+ env:
+ INTEGRATION: ${{ matrix.integration }}
+
+ # These jobs doesn't actually test anything, but they're only used to tell
+ # bors the build completed, as there is no practical way to detect when a
+ # workflow is successful listening to webhooks only.
+ #
+ # ALL THE PREVIOUS JOBS NEED TO BE ADDED TO THE `needs` SECTION OF THIS JOB!
+
+ end-success:
+ name: bors test finished
+ if: github.event.pusher.name == 'bors' && success()
+ runs-on: ubuntu-latest
+ needs: [changelog, base, integration_build, integration]
+
+ steps:
+ - name: Mark the job as successful
+ run: exit 0
+
+ end-failure:
+ name: bors test finished
+ if: github.event.pusher.name == 'bors' && (failure() || cancelled())
+ runs-on: ubuntu-latest
+ needs: [changelog, base, integration_build, integration]
+
+ steps:
+ - name: Mark the job as a failure
+ run: exit 1