Check for valid base64 before decoding (#9904)

[dragonfireclient.git] / .github / workflows / build.yml

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 2c4d3abd1e0e78acbbb49825bb048c09b430a3bf..4def50925b7f8933ab776d35335ce2bdb2ed4813 100644 (file)
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -31,7 +31,7 @@ jobs:
     runs-on: ubuntu-18.04
     steps:
       - uses: actions/checkout@v2
-      - name: Install compiler
+      - name: Install deps
         run: |
           sudo apt-get install g++-6 gcc-6 -qyy
           source ./util/ci/common.sh
@@ -41,7 +41,8 @@ jobs:
         run: |
           ./util/ci/build.sh
         env:
-          CMAKE_FLAGS: "-DCMAKE_C_COMPILER=gcc-6 -DCMAKE_CXX_COMPILER=g++-6"
+          CC: gcc-6
+          CXX: g++-6
 
       - name: Test
         run: |
@@ -52,7 +53,7 @@ jobs:
     runs-on: ubuntu-18.04
     steps:
       - uses: actions/checkout@v2
-      - name: Install compiler
+      - name: Install deps
         run: |
           sudo apt-get install g++-8 gcc-8 -qyy
           source ./util/ci/common.sh
@@ -62,7 +63,8 @@ jobs:
         run: |
           ./util/ci/build.sh
         env:
-          CMAKE_FLAGS: "-DCMAKE_C_COMPILER=gcc-8 -DCMAKE_CXX_COMPILER=g++-8"
+          CC: gcc-8
+          CXX: g++-8
 
       - name: Test
         run: |
@@ -73,7 +75,7 @@ jobs:
     runs-on: ubuntu-18.04
     steps:
       - uses: actions/checkout@v2
-      - name: Install compiler
+      - name: Install deps
         run: |
           sudo apt-get install clang-3.9 -qyy
           source ./util/ci/common.sh
@@ -83,7 +85,8 @@ jobs:
         run: |
           ./util/ci/build.sh
         env:
-          CMAKE_FLAGS: "-DCMAKE_C_COMPILER=clang-3.9 -DCMAKE_CXX_COMPILER=clang++-3.9"
+          CC: clang-3.9
+          CXX: clang++-3.9
 
       - name: Test
         run: |
@@ -94,7 +97,7 @@ jobs:
     runs-on: ubuntu-18.04
     steps:
       - uses: actions/checkout@v2
-      - name: Install compiler
+      - name: Install deps
         run: |
           sudo apt-get install clang-9 valgrind -qyy
           source ./util/ci/common.sh
@@ -106,7 +109,8 @@ jobs:
         run: |
           ./util/ci/build.sh
         env:
-          CMAKE_FLAGS: "-DCMAKE_C_COMPILER=clang-9 -DCMAKE_CXX_COMPILER=clang++-9"
+          CC: clang-9
+          CXX: clang++-9
 
       - name: Test
         run: |
@@ -116,12 +120,13 @@ jobs:
         run: |
           valgrind --leak-check=full --leak-check-heuristics=all --undef-value-errors=no --error-exitcode=9 ./bin/minetest --run-unittests
 
-
+  # Build with prometheus-cpp (server-only)
   clang_9_prometheus:
+    name: "clang_9 (PROMETHEUS=1)"
     runs-on: ubuntu-18.04
     steps:
       - uses: actions/checkout@v2
-      - name: Install compiler
+      - name: Install deps
         run: |
           sudo apt-get install clang-9 -qyy
           source ./util/ci/common.sh
@@ -135,18 +140,21 @@ jobs:
         run: |
           ./util/ci/build.sh
         env:
-          CMAKE_FLAGS: "-DCMAKE_C_COMPILER=clang-9 -DCMAKE_CXX_COMPILER=clang++-9 -DENABLE_PROMETHEUS=1"
+          CC: clang-9
+          CXX: clang++-9
+          CMAKE_FLAGS: "-DENABLE_PROMETHEUS=1 -DBUILD_CLIENT=0"
 
       - name: Test
         run: |
-          ./bin/minetest --run-unittests
+          ./bin/minetestserver --run-unittests
 
-  # Some builds doesn't require freetype, ensure it compiled properly
+  # Build without freetype (client-only)
   clang_9_no_freetype:
+    name: "clang_9 (FREETYPE=0)"
     runs-on: ubuntu-18.04
     steps:
       - uses: actions/checkout@v2
-      - name: Install compiler
+      - name: Install deps
         run: |
           sudo apt-get install clang-9 -qyy
           source ./util/ci/common.sh
@@ -156,13 +164,16 @@ jobs:
         run: |
           ./util/ci/build.sh
         env:
-          CMAKE_FLAGS: "-DCMAKE_C_COMPILER=clang-9 -DCMAKE_CXX_COMPILER=clang++-9 -DENABLE_FREETYPE=0"
+          CC: clang-9
+          CXX: clang++-9
+          CMAKE_FLAGS: "-DENABLE_FREETYPE=0 -DBUILD_SERVER=0"
 
       - name: Test
         run: |
           ./bin/minetest --run-unittests
 
   docker:
+    name: "Docker image"
     runs-on: ubuntu-18.04
     steps:
       - uses: actions/checkout@v2
@@ -171,11 +182,13 @@ jobs:
           docker build .
 
   win32:
+    name: "MinGW cross-compiler (32-bit)"
     runs-on: ubuntu-18.04
     steps:
       - uses: actions/checkout@v2
       - name: Install compiler
         run: |
+          sudo apt-get install gettext -qyy
           wget http://minetest.kitsunemimi.pw/mingw-w64-i686_9.2.0_ubuntu18.04.tar.xz -O mingw.tar.xz
           sudo tar -xaf mingw.tar.xz -C /usr
 
@@ -187,11 +200,13 @@ jobs:
           NO_PACKAGE: 1
 
   win64:
+    name: "MinGW cross-compiler (64-bit)"
     runs-on: ubuntu-18.04
     steps:
       - uses: actions/checkout@v2
       - name: Install compiler
         run: |
+          sudo apt-get install gettext -qyy
           wget http://minetest.kitsunemimi.pw/mingw-w64-x86_64_9.2.0_ubuntu18.04.tar.xz -O mingw.tar.xz
           sudo tar -xaf mingw.tar.xz -C /usr
 
@@ -201,3 +216,73 @@ jobs:
         env:
           NO_MINETEST_GAME: 1
           NO_PACKAGE: 1
+
+  msvc:
+    name: VS 2019 ${{ matrix.config.arch }}-${{ matrix.type }}
+    runs-on: windows-2019 
+    env:
+      VCPKG_VERSION: c7ab9d3110813979a873b2dbac630a9ab79850dc
+#                    2020.04
+      vcpkg_packages: irrlicht zlib curl[winssl] openal-soft libvorbis libogg sqlite3 freetype luajit
+    strategy:
+      fail-fast: false
+      matrix:
+        config:
+          - {
+              arch: x86,
+              generator: "-G'Visual Studio 16 2019' -A Win32",
+              vcpkg_triplet: x86-windows
+            }
+          - {
+              arch: x64,
+              generator: "-G'Visual Studio 16 2019' -A x64",
+              vcpkg_triplet: x64-windows
+            }
+        type: [portable]
+#        type: [portable, installer]
+# The installer type is working, but disabled, to save runner jobs.
+# Enable it, when working on the installer.
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Restore from cache and run vcpkg
+        uses: lukka/run-vcpkg@v2
+        with:
+          vcpkgArguments: ${{env.vcpkg_packages}}
+          vcpkgDirectory: '${{ github.workspace }}\vcpkg'
+          appendedCacheKey: ${{ matrix.config.vcpkg_triplet }}
+          vcpkgGitCommitId: ${{ env.VCPKG_VERSION }}
+          vcpkgTriplet: ${{ matrix.config.vcpkg_triplet }}
+
+      - name: CMake
+        run: |
+          cmake ${{matrix.config.generator}}  `
+          -DCMAKE_TOOLCHAIN_FILE="${{ github.workspace }}\vcpkg\scripts\buildsystems\vcpkg.cmake"  `
+          -DCMAKE_BUILD_TYPE=Release  `
+          -DRUN_IN_PLACE=${{ contains(matrix.type, 'portable') }} .
+
+      - name: Build
+        run: cmake --build . --config Release
+
+      - name: CPack
+        run: |
+          If ($env:TYPE -eq "installer")
+          {
+            cpack -G WIX -B "$env:GITHUB_WORKSPACE\Package"
+          }
+          ElseIf($env:TYPE -eq "portable")
+          {
+            cpack -G ZIP -B "$env:GITHUB_WORKSPACE\Package"
+          }
+        env:
+          TYPE: ${{matrix.type}}
+
+      - name: Package Clean
+        run: rm -r $env:GITHUB_WORKSPACE\Package\_CPack_Packages
+
+      - uses: actions/upload-artifact@v1
+        with:
+          name: msvc-${{ matrix.config.arch }}-${{ matrix.type }}
+          path: .\Package\