// run-rustfix #![warn(clippy::let_unit_value)] #![allow(clippy::no_effect)] #![allow(unused_variables)] macro_rules! let_and_return { ($n:expr) => {{ let ret = $n; }}; } fn main() { println!("x"); let _y = 1; // this is fine let _z = ((), 1); // this as well if true { (); } consume_units_with_for_loop(); // should be fine as well multiline_sugg(); let_and_return!(()) // should be fine } // Related to issue #1964 fn consume_units_with_for_loop() { // `for_let_unit` lint should not be triggered by consuming them using for loop. let v = vec![(), (), ()]; let mut count = 0; for _ in v { count += 1; } assert_eq!(count, 3); // Same for consuming from some other Iterator. let (tx, rx) = ::std::sync::mpsc::channel(); tx.send(()).unwrap(); drop(tx); count = 0; for _ in rx.iter() { count += 1; } assert_eq!(count, 1); } fn multiline_sugg() { let v: Vec = vec![2]; v .into_iter() .map(|i| i * 2) .filter(|i| i % 2 == 0) .map(|_| ()) .next() .unwrap(); } #[derive(Copy, Clone)] pub struct ContainsUnit(()); // should be fine fn _returns_generic() { fn f() -> T { unimplemented!() } fn f2(_: T) -> U { unimplemented!() } fn f3(x: T) -> T { x } fn f4(mut x: Vec) -> T { x.pop().unwrap() } let _: () = f(); // Ok let _: () = f(); // Lint. let _: () = f2(0i32); // Ok let _: () = f2(0i32); // Lint. f3(()); // Lint f3(()); // Lint f4(vec![()]); // Lint f4(vec![()]); // Lint // Ok let _: () = { let x = 5; f2(x) }; let _: () = if true { f() } else { f2(0) }; // Ok let _: () = if true { f() } else { f2(0) }; // Lint // Ok let _: () = match Some(0) { None => f2(1), Some(0) => f(), Some(1) => f2(3), Some(_) => f2('x'), }; // Lint match Some(0) { None => f2(1), Some(0) => f(), Some(1) => f2(3), Some(_) => (), }; }