1 #![warn(clippy::suspicious_operation_groupings)]
2 #![allow(clippy::eq_op)]
12 impl PartialEq for Vec3 {
13 fn eq(&self, other: &Self) -> bool {
14 // This should trigger the lint because `self.x` is compared to `other.y`
15 self.x == other.y && self.y == other.y && self.z == other.z
26 fn buggy_ab_cmp(s1: &S, s2: &S) -> bool {
28 s1.a < s2.a && s1.a < s2.b
41 fn do_not_give_bad_suggestions_for_this_unusual_expr(s1: &S, s2: &SaOnly) -> bool {
42 // This is superficially similar to `buggy_ab_cmp`, but we should not suggest
43 // `s2.b` since that is invalid.
44 s1.a < s2.a && s1.a() < s1.b
47 fn do_not_give_bad_suggestions_for_this_macro_expr(s1: &S, s2: &SaOnly) -> bool {
59 // This is superficially similar to `buggy_ab_cmp`, but we should not suggest
60 // `s2.b` since that is invalid.
61 s1.a < s2.a && s1!().a < s1.b
64 fn do_not_give_bad_suggestions_for_this_incorrect_expr(s1: &S, s2: &SaOnly) -> bool {
65 // There's two `s1.b`, but we should not suggest `s2.b` since that is invalid
66 s1.a < s2.a && s1.b < s1.b
69 fn permissable(s1: &S, s2: &S) -> bool {
70 // Something like this seems like it might actually be what is desired.
74 fn non_boolean_operators(s1: &S, s2: &S) -> i32 {
76 s1.a * s2.a + s1.b * s2.b + s1.c * s2.b + s1.d * s2.d
79 fn odd_number_of_pairs(s1: &S, s2: &S) -> i32 {
81 s1.a * s2.a + s1.b * s2.c + s1.c * s2.c
84 fn not_caught_by_eq_op_middle_change_left(s1: &S, s2: &S) -> i32 {
86 s1.a * s2.a + s2.b * s2.b + s1.c * s2.c
89 fn not_caught_by_eq_op_middle_change_right(s1: &S, s2: &S) -> i32 {
91 s1.a * s2.a + s1.b * s1.b + s1.c * s2.c
94 fn not_caught_by_eq_op_start(s1: &S, s2: &S) -> i32 {
96 s1.a * s1.a + s1.b * s2.b + s1.c * s2.c
99 fn not_caught_by_eq_op_end(s1: &S, s2: &S) -> i32 {
101 s1.a * s2.a + s1.b * s2.b + s1.c * s1.c
104 fn the_cross_product_should_not_lint(s1: &S, s2: &S) -> (i32, i32, i32) {
106 s1.b * s2.c - s1.c * s2.b,
107 s1.c * s2.a - s1.a * s2.c,
108 s1.a * s2.b - s1.b * s2.a,
112 fn outer_parens_simple(s1: &S, s2: &S) -> i32 {
114 (s1.a * s2.a + s1.b * s1.b)
117 fn outer_parens(s1: &S, s2: &S) -> i32 {
119 (s1.a * s2.a + s1.b * s2.b + s1.c * s2.b + s1.d * s2.d)
122 fn inner_parens(s1: &S, s2: &S) -> i32 {
124 (s1.a * s2.a) + (s1.b * s2.b) + (s1.c * s2.b) + (s1.d * s2.d)
127 fn outer_and_some_inner_parens(s1: &S, s2: &S) -> i32 {
129 ((s1.a * s2.a) + (s1.b * s2.b) + (s1.c * s2.b) + (s1.d * s2.d))
132 fn all_parens_balanced_tree(s1: &S, s2: &S) -> i32 {
134 (((s1.a * s2.a) + (s1.b * s2.b)) + ((s1.c * s2.b) + (s1.d * s2.d)))
137 fn all_parens_left_tree(s1: &S, s2: &S) -> i32 {
139 (((s1.a * s2.a) + (s1.b * s2.b) + (s1.c * s2.b)) + (s1.d * s2.d))
142 fn all_parens_right_tree(s1: &S, s2: &S) -> i32 {
144 ((s1.a * s2.a) + ((s1.b * s2.b) + (s1.c * s2.b) + (s1.d * s2.d)))
147 fn inside_other_binop_expression(s1: &S, s2: &S) -> i32 {
149 (s1.a * s2.a + s2.b * s2.b) / 2
152 fn inside_function_call(s1: &S, s2: &S) -> i32 {
154 i32::swap_bytes(s1.a * s2.a + s2.b * s2.b)
157 fn inside_larger_boolean_expression(s1: &S, s2: &S) -> bool {
159 s1.a > 0 && s1.b > 0 && s1.d == s2.c && s1.d == s2.d
162 fn inside_larger_boolean_expression_with_unsorted_ops(s1: &S, s2: &S) -> bool {
164 s1.a > 0 && s1.d == s2.c && s1.b > 0 && s1.d == s2.d
168 inner: ((i32,), (i32,), (i32,)),
171 fn changed_middle_ident(n1: &Nested, n2: &Nested) -> bool {
172 // There's no `n2.inner.2.0`
173 (n1.inner.0).0 == (n2.inner.0).0 && (n1.inner.1).0 == (n2.inner.1).0 && (n1.inner.2).0 == (n2.inner.1).0
176 // `eq_op` should catch this one.
177 fn changed_initial_ident(n1: &Nested, n2: &Nested) -> bool {
178 // There's no `n2.inner.0.0`
179 (n1.inner.0).0 == (n1.inner.0).0 && (n1.inner.1).0 == (n2.inner.1).0 && (n1.inner.2).0 == (n2.inner.2).0
182 fn inside_fn_with_similar_expression(s1: &S, s2: &S, strict: bool) -> bool {
184 s1.a < s2.a && s1.b < s2.b
186 // There's no `s1.b` in this subexpression
187 s1.a <= s2.a && s1.a <= s2.b
191 fn inside_an_if_statement(s1: &mut S, s2: &S) {
193 if s1.a < s2.a && s1.a < s2.b {
198 fn maximum_unary_minus_right_tree(s1: &S, s2: &S) -> i32 {
200 -(-(-s1.a * -s2.a) + (-(-s1.b * -s2.b) + -(-s1.c * -s2.b) + -(-s1.d * -s2.d)))
203 fn unary_minus_and_an_if_expression(s1: &S, s2: &S) -> i32 {
205 -(if -s1.a < -s2.a && -s1.a < -s2.b { s1.c } else { s2.a })