1 #![warn(clippy::suspicious_operation_groupings)]
11 impl PartialEq for Vec3 {
12 fn eq(&self, other: &Self) -> bool {
13 // This should trigger the lint because `self.x` is compared to `other.y`
14 self.x == other.y && self.y == other.y && self.z == other.z
25 fn buggy_ab_cmp(s1: &S, s2: &S) -> bool {
27 s1.a < s2.a && s1.a < s2.b
40 fn do_not_give_bad_suggestions_for_this_unusual_expr(s1: &S, s2: &SaOnly) -> bool {
41 // This is superficially similar to `buggy_ab_cmp`, but we should not suggest
42 // `s2.b` since that is invalid.
43 s1.a < s2.a && s1.a() < s1.b
46 fn do_not_give_bad_suggestions_for_this_macro_expr(s1: &S, s2: &SaOnly) -> bool {
58 // This is superficially similar to `buggy_ab_cmp`, but we should not suggest
59 // `s2.b` since that is invalid.
60 s1.a < s2.a && s1!().a < s1.b
63 fn do_not_give_bad_suggestions_for_this_incorrect_expr(s1: &S, s2: &SaOnly) -> bool {
64 // There's two `s1.b`, but we should not suggest `s2.b` since that is invalid
65 s1.a < s2.a && s1.b < s1.b
68 fn permissable(s1: &S, s2: &S) -> bool {
69 // Something like this seems like it might actually be what is desired.
73 fn non_boolean_operators(s1: &S, s2: &S) -> i32 {
75 s1.a * s2.a + s1.b * s2.b + s1.c * s2.b + s1.d * s2.d
78 fn odd_number_of_pairs(s1: &S, s2: &S) -> i32 {
80 s1.a * s2.a + s1.b * s2.c + s1.c * s2.c
83 fn not_caught_by_eq_op_middle_change_left(s1: &S, s2: &S) -> i32 {
85 s1.a * s2.a + s2.b * s2.b + s1.c * s2.c
88 fn not_caught_by_eq_op_middle_change_right(s1: &S, s2: &S) -> i32 {
90 s1.a * s2.a + s1.b * s1.b + s1.c * s2.c
93 fn not_caught_by_eq_op_start(s1: &S, s2: &S) -> i32 {
95 s1.a * s1.a + s1.b * s2.b + s1.c * s2.c
98 fn not_caught_by_eq_op_end(s1: &S, s2: &S) -> i32 {
100 s1.a * s2.a + s1.b * s2.b + s1.c * s1.c
103 fn the_cross_product_should_not_lint(s1: &S, s2: &S) -> (i32, i32, i32) {
105 s1.b * s2.c - s1.c * s2.b,
106 s1.c * s2.a - s1.a * s2.c,
107 s1.a * s2.b - s1.b * s2.a,
111 fn outer_parens_simple(s1: &S, s2: &S) -> i32 {
113 (s1.a * s2.a + s1.b * s1.b)
116 fn outer_parens(s1: &S, s2: &S) -> i32 {
118 (s1.a * s2.a + s1.b * s2.b + s1.c * s2.b + s1.d * s2.d)
121 fn inner_parens(s1: &S, s2: &S) -> i32 {
123 (s1.a * s2.a) + (s1.b * s2.b) + (s1.c * s2.b) + (s1.d * s2.d)
126 fn outer_and_some_inner_parens(s1: &S, s2: &S) -> i32 {
128 ((s1.a * s2.a) + (s1.b * s2.b) + (s1.c * s2.b) + (s1.d * s2.d))
131 fn all_parens_balanced_tree(s1: &S, s2: &S) -> i32 {
133 (((s1.a * s2.a) + (s1.b * s2.b)) + ((s1.c * s2.b) + (s1.d * s2.d)))
136 fn all_parens_left_tree(s1: &S, s2: &S) -> i32 {
138 (((s1.a * s2.a) + (s1.b * s2.b) + (s1.c * s2.b)) + (s1.d * s2.d))
141 fn all_parens_right_tree(s1: &S, s2: &S) -> i32 {
143 ((s1.a * s2.a) + ((s1.b * s2.b) + (s1.c * s2.b) + (s1.d * s2.d)))
146 fn inside_other_binop_expression(s1: &S, s2: &S) -> i32 {
148 (s1.a * s2.a + s2.b * s2.b) / 2
151 fn inside_function_call(s1: &S, s2: &S) -> i32 {
153 i32::swap_bytes(s1.a * s2.a + s2.b * s2.b)
156 fn inside_larger_boolean_expression(s1: &S, s2: &S) -> bool {
158 s1.a > 0 && s1.b > 0 && s1.d == s2.c && s1.d == s2.d
161 fn inside_larger_boolean_expression_with_unsorted_ops(s1: &S, s2: &S) -> bool {
163 s1.a > 0 && s1.d == s2.c && s1.b > 0 && s1.d == s2.d
167 inner: ((i32,), (i32,), (i32,)),
170 fn changed_middle_ident(n1: &Nested, n2: &Nested) -> bool {
171 // There's no `n2.inner.2.0`
172 (n1.inner.0).0 == (n2.inner.0).0 && (n1.inner.1).0 == (n2.inner.1).0 && (n1.inner.2).0 == (n2.inner.1).0
175 // `eq_op` should catch this one.
176 fn changed_initial_ident(n1: &Nested, n2: &Nested) -> bool {
177 // There's no `n2.inner.0.0`
178 (n1.inner.0).0 == (n1.inner.0).0 && (n1.inner.1).0 == (n2.inner.1).0 && (n1.inner.2).0 == (n2.inner.2).0
181 fn inside_fn_with_similar_expression(s1: &S, s2: &S, strict: bool) -> bool {
183 s1.a < s2.a && s1.b < s2.b
185 // There's no `s1.b` in this subexpression
186 s1.a <= s2.a && s1.a <= s2.b
190 fn inside_an_if_statement(s1: &S, s2: &S) {
192 if s1.a < s2.a && s1.a < s2.b {
197 fn maximum_unary_minus_right_tree(s1: &S, s2: &S) -> i32 {
199 -(-(-s1.a * -s2.a) + (-(-s1.b * -s2.b) + -(-s1.c * -s2.b) + -(-s1.d * -s2.d)))
202 fn unary_minus_and_an_if_expression(s1: &S, s2: &S) -> i32 {
204 -(if -s1.a < -s2.a && -s1.a < -s2.b { s1.c } else { s2.a })