1 #![feature(tool_lints)]
3 #![feature(never_type)]
4 #![warn(clippy::result_map_unit_fn)]
7 fn do_nothing<T>(_: T) {}
9 fn diverge<T>(_: T) -> ! {
13 fn plus_one(value: usize) -> usize {
18 field: Result<usize, usize>,
22 fn do_result_nothing(self: &Self, value: usize) {}
24 fn do_result_plus_one(self: &Self, value: usize) -> usize {
29 fn result_map_unit_fn() {
30 let x = HasResult { field: Ok(10) };
32 x.field.map(plus_one);
33 let _ : Result<(), usize> = x.field.map(do_nothing);
35 x.field.map(do_nothing);
37 x.field.map(do_nothing);
42 if let Ok(value) = x.field { do_nothing(value + captured) };
43 let _ : Result<(), usize> = x.field.map(|value| do_nothing(value + captured));
45 x.field.map(|value| x.do_result_nothing(value + captured));
47 x.field.map(|value| { x.do_result_plus_one(value + captured); });
50 x.field.map(|value| do_nothing(value + captured));
52 x.field.map(|value| { do_nothing(value + captured) });
54 x.field.map(|value| { do_nothing(value + captured); });
56 x.field.map(|value| { { do_nothing(value + captured); } });
59 x.field.map(|value| diverge(value + captured));
61 x.field.map(|value| { diverge(value + captured) });
63 x.field.map(|value| { diverge(value + captured); });
65 x.field.map(|value| { { diverge(value + captured); } });
68 x.field.map(|value| plus_one(value + captured));
69 x.field.map(|value| { plus_one(value + captured) });
70 x.field.map(|value| { let y = plus_one(value + captured); });
72 x.field.map(|value| { plus_one(value + captured); });
74 x.field.map(|value| { { plus_one(value + captured); } });
77 x.field.map(|ref value| { do_nothing(value + captured) });
80 x.field.map(|value| { do_nothing(value); do_nothing(value) });
82 x.field.map(|value| if value > 0 { do_nothing(value); do_nothing(value) });
84 // Suggestion for the let block should be `{ ... }` as it's too difficult to build a
85 // proper suggestion for these cases
90 x.field.map(|value| { do_nothing(value); do_nothing(value); });
92 // The following should suggest `if let Ok(_X) ...` as it's difficult to generate a proper let variable name for them
93 let res: Result<!, usize> = Ok(42).map(diverge);
94 "12".parse::<i32>().map(diverge);
96 let res: Result<(), usize> = Ok(plus_one(1)).map(do_nothing);
98 // Should suggest `if let Ok(_y) ...` to not override the existing foo variable
99 let y: Result<usize, usize> = Ok(42);