1 error: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name
2 --> $DIR/methods.rs:31:5
4 31 | pub fn add(self, other: T) -> T { self }
5 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
7 = note: `-D clippy::should-implement-trait` implied by `-D warnings`
9 error: methods called `into_*` usually take self by value; consider choosing a less ambiguous name
10 --> $DIR/methods.rs:42:17
12 42 | fn into_u16(&self) -> u16 { 0 }
15 = note: `-D clippy::wrong-self-convention` implied by `-D warnings`
17 error: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
18 --> $DIR/methods.rs:44:21
20 44 | fn to_something(self) -> u32 { 0 }
23 error: methods called `new` usually take no self; consider choosing a less ambiguous name
24 --> $DIR/methods.rs:46:12
26 46 | fn new(self) -> Self { unimplemented!(); }
29 error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
30 --> $DIR/methods.rs:114:13
32 114 | let _ = opt.map(|x| x + 1)
35 116 | | .unwrap_or(0); // should lint even though this call is on a separate line
36 | |____________________________^
38 = note: `-D clippy::option-map-unwrap-or` implied by `-D warnings`
39 = note: replace `map(|x| x + 1).unwrap_or(0)` with `map_or(0, |x| x + 1)`
41 error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
42 --> $DIR/methods.rs:118:13
44 118 | let _ = opt.map(|x| {
48 121 | | ).unwrap_or(0);
49 | |____________________________^
51 error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
52 --> $DIR/methods.rs:122:13
54 122 | let _ = opt.map(|x| x + 1)
59 | |__________________^
61 error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead
62 --> $DIR/methods.rs:127:13
64 127 | let _ = opt.map(|x| Some(x + 1)).unwrap_or(None);
65 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
67 = note: replace `map(|x| Some(x + 1)).unwrap_or(None)` with `and_then(|x| Some(x + 1))`
69 error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead
70 --> $DIR/methods.rs:129:13
72 129 | let _ = opt.map(|x| {
76 132 | | ).unwrap_or(None);
77 | |_____________________^
79 error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead
80 --> $DIR/methods.rs:133:13
84 134 | | .map(|x| Some(x + 1))
85 135 | | .unwrap_or(None);
86 | |________________________^
88 = note: replace `map(|x| Some(x + 1)).unwrap_or(None)` with `and_then(|x| Some(x + 1))`
90 error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
91 --> $DIR/methods.rs:141:13
93 141 | let _ = opt.map(|x| x + 1)
96 143 | | .unwrap_or_else(|| 0); // should lint even though this call is on a separate line
97 | |____________________________________^
99 = note: `-D clippy::option-map-unwrap-or-else` implied by `-D warnings`
100 = note: replace `map(|x| x + 1).unwrap_or_else(|| 0)` with `map_or_else(|| 0, |x| x + 1)`
102 error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
103 --> $DIR/methods.rs:145:13
105 145 | let _ = opt.map(|x| {
109 148 | | ).unwrap_or_else(|| 0);
110 | |____________________________________^
112 error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
113 --> $DIR/methods.rs:149:13
115 149 | let _ = opt.map(|x| x + 1)
117 150 | | .unwrap_or_else(||
120 | |_________________^
122 error: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead
123 --> $DIR/methods.rs:158:13
125 158 | let _ = opt.map_or(None, |x| Some(x + 1));
126 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `opt.and_then(|x| Some(x + 1))`
128 = note: `-D clippy::option-map-or-none` implied by `-D warnings`
130 error: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead
131 --> $DIR/methods.rs:160:13
133 160 | let _ = opt.map_or(None, |x| {
138 | |_________________^
139 help: try using and_then instead
141 160 | let _ = opt.and_then(|x| {
146 error: called `map(f).unwrap_or_else(g)` on a Result value. This can be done more directly by calling `ok().map_or_else(g, f)` instead
147 --> $DIR/methods.rs:173:13
149 173 | let _ = res.map(|x| x + 1)
152 175 | | .unwrap_or_else(|e| 0); // should lint even though this call is on a separate line
153 | |_____________________________________^
155 = note: `-D clippy::result-map-unwrap-or-else` implied by `-D warnings`
156 = note: replace `map(|x| x + 1).unwrap_or_else(|e| 0)` with `ok().map_or_else(|e| 0, |x| x + 1)`
158 error: called `map(f).unwrap_or_else(g)` on a Result value. This can be done more directly by calling `ok().map_or_else(g, f)` instead
159 --> $DIR/methods.rs:177:13
161 177 | let _ = res.map(|x| {
165 180 | | ).unwrap_or_else(|e| 0);
166 | |_____________________________________^
168 error: called `map(f).unwrap_or_else(g)` on a Result value. This can be done more directly by calling `ok().map_or_else(g, f)` instead
169 --> $DIR/methods.rs:181:13
171 181 | let _ = res.map(|x| x + 1)
173 182 | | .unwrap_or_else(|e|
176 | |_________________^
178 error: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
179 --> $DIR/methods.rs:244:13
181 244 | let _ = v.iter().filter(|&x| *x < 0).next();
182 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
184 = note: `-D clippy::filter-next` implied by `-D warnings`
185 = note: replace `filter(|&x| *x < 0).next()` with `find(|&x| *x < 0)`
187 error: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
188 --> $DIR/methods.rs:247:13
190 247 | let _ = v.iter().filter(|&x| {
195 | |___________________________^
197 error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
198 --> $DIR/methods.rs:262:13
200 262 | let _ = v.iter().find(|&x| *x < 0).is_some();
201 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
203 = note: `-D clippy::search-is-some` implied by `-D warnings`
204 = note: replace `find(|&x| *x < 0).is_some()` with `any(|&x| *x < 0)`
206 error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
207 --> $DIR/methods.rs:265:13
209 265 | let _ = v.iter().find(|&x| {
214 | |______________________________^
216 error: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.
217 --> $DIR/methods.rs:271:13
219 271 | let _ = v.iter().position(|&x| x < 0).is_some();
220 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
222 = note: replace `position(|&x| x < 0).is_some()` with `any(|&x| x < 0)`
224 error: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.
225 --> $DIR/methods.rs:274:13
227 274 | let _ = v.iter().position(|&x| {
232 | |______________________________^
234 error: called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.
235 --> $DIR/methods.rs:280:13
237 280 | let _ = v.iter().rposition(|&x| x < 0).is_some();
238 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
240 = note: replace `rposition(|&x| x < 0).is_some()` with `any(|&x| x < 0)`
242 error: called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.
243 --> $DIR/methods.rs:283:13
245 283 | let _ = v.iter().rposition(|&x| {
250 | |______________________________^
252 error: use of `unwrap_or` followed by a function call
253 --> $DIR/methods.rs:318:22
255 318 | with_constructor.unwrap_or(make());
256 | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(make)`
258 = note: `-D clippy::or-fun-call` implied by `-D warnings`
260 error: use of `unwrap_or` followed by a call to `new`
261 --> $DIR/methods.rs:321:5
263 321 | with_new.unwrap_or(Vec::new());
264 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_new.unwrap_or_default()`
266 error: use of `unwrap_or` followed by a function call
267 --> $DIR/methods.rs:324:21
269 324 | with_const_args.unwrap_or(Vec::with_capacity(12));
270 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Vec::with_capacity(12))`
272 error: use of `unwrap_or` followed by a function call
273 --> $DIR/methods.rs:327:14
275 327 | with_err.unwrap_or(make());
276 | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| make())`
278 error: use of `unwrap_or` followed by a function call
279 --> $DIR/methods.rs:330:19
281 330 | with_err_args.unwrap_or(Vec::with_capacity(12));
282 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| Vec::with_capacity(12))`
284 error: use of `unwrap_or` followed by a call to `default`
285 --> $DIR/methods.rs:333:5
287 333 | with_default_trait.unwrap_or(Default::default());
288 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_default_trait.unwrap_or_default()`
290 error: use of `unwrap_or` followed by a call to `default`
291 --> $DIR/methods.rs:336:5
293 336 | with_default_type.unwrap_or(u64::default());
294 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_default_type.unwrap_or_default()`
296 error: use of `unwrap_or` followed by a function call
297 --> $DIR/methods.rs:339:14
299 339 | with_vec.unwrap_or(vec![]);
300 | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ))`
302 error: use of `unwrap_or` followed by a function call
303 --> $DIR/methods.rs:344:21
305 344 | without_default.unwrap_or(Foo::new());
306 | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(Foo::new)`
308 error: use of `or_insert` followed by a function call
309 --> $DIR/methods.rs:347:19
311 347 | map.entry(42).or_insert(String::new());
312 | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(String::new)`
314 error: use of `or_insert` followed by a function call
315 --> $DIR/methods.rs:350:21
317 350 | btree.entry(42).or_insert(String::new());
318 | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(String::new)`
320 error: use of `unwrap_or` followed by a function call
321 --> $DIR/methods.rs:353:21
323 353 | let _ = stringy.unwrap_or("".to_owned());
324 | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())`
326 error: `error_code` is shadowed by `123_i32`
327 --> $DIR/methods.rs:387:9
329 387 | let error_code = 123_i32;
332 = note: `-D clippy::shadow-unrelated` implied by `-D warnings`
333 note: initialization happens here
334 --> $DIR/methods.rs:387:22
336 387 | let error_code = 123_i32;
338 note: previous binding is here
339 --> $DIR/methods.rs:374:9
341 374 | let error_code = 123_i32;
344 error: use of `expect` followed by a function call
345 --> $DIR/methods.rs:376:26
347 376 | with_none_and_format.expect(&format!("Error {}: fake error", error_code));
348 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Error {}: fake error", error_code))`
350 = note: `-D clippy::expect-fun-call` implied by `-D warnings`
352 error: use of `expect` followed by a function call
353 --> $DIR/methods.rs:379:26
355 379 | with_none_and_as_str.expect(format!("Error {}: fake error", error_code).as_str());
356 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Error {}: fake error", error_code))`
358 error: use of `expect` followed by a function call
359 --> $DIR/methods.rs:389:25
361 389 | with_err_and_format.expect(&format!("Error {}: fake error", error_code));
362 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error {}: fake error", error_code))`
364 error: use of `expect` followed by a function call
365 --> $DIR/methods.rs:392:25
367 392 | with_err_and_as_str.expect(format!("Error {}: fake error", error_code).as_str());
368 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error {}: fake error", error_code))`
370 error: use of `expect` followed by a function call
371 --> $DIR/methods.rs:407:17
373 407 | Some("foo").expect({ &format!("error") });
374 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| { let msg = { &format!("error") }; panic!(msg) }))`
376 error: use of `expect` followed by a function call
377 --> $DIR/methods.rs:408:17
379 408 | Some("foo").expect(format!("error").as_ref());
380 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("error"))`
382 error: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable
383 --> $DIR/methods.rs:419:23
385 419 | let bad_vec = some_vec.iter().nth(3);
386 | ^^^^^^^^^^^^^^^^^^^^^^
388 = note: `-D clippy::iter-nth` implied by `-D warnings`
390 error: called `.iter().nth()` on a slice. Calling `.get()` is both faster and more readable
391 --> $DIR/methods.rs:420:26
393 420 | let bad_slice = &some_vec[..].iter().nth(3);
394 | ^^^^^^^^^^^^^^^^^^^^^^^^^^
396 error: called `.iter().nth()` on a slice. Calling `.get()` is both faster and more readable
397 --> $DIR/methods.rs:421:31
399 421 | let bad_boxed_slice = boxed_slice.iter().nth(3);
400 | ^^^^^^^^^^^^^^^^^^^^^^^^^
402 error: called `.iter().nth()` on a VecDeque. Calling `.get()` is both faster and more readable
403 --> $DIR/methods.rs:422:29
405 422 | let bad_vec_deque = some_vec_deque.iter().nth(3);
406 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
408 error: called `.iter_mut().nth()` on a Vec. Calling `.get_mut()` is both faster and more readable
409 --> $DIR/methods.rs:427:23
411 427 | let bad_vec = some_vec.iter_mut().nth(3);
412 | ^^^^^^^^^^^^^^^^^^^^^^^^^^
414 error: called `.iter_mut().nth()` on a slice. Calling `.get_mut()` is both faster and more readable
415 --> $DIR/methods.rs:430:26
417 430 | let bad_slice = &some_vec[..].iter_mut().nth(3);
418 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
420 error: called `.iter_mut().nth()` on a VecDeque. Calling `.get_mut()` is both faster and more readable
421 --> $DIR/methods.rs:433:29
423 433 | let bad_vec_deque = some_vec_deque.iter_mut().nth(3);
424 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
426 error: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
427 --> $DIR/methods.rs:445:13
429 445 | let _ = some_vec.iter().skip(42).next();
430 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
432 = note: `-D clippy::iter-skip-next` implied by `-D warnings`
434 error: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
435 --> $DIR/methods.rs:446:13
437 446 | let _ = some_vec.iter().cycle().skip(42).next();
438 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
440 error: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
441 --> $DIR/methods.rs:447:13
443 447 | let _ = (1..10).skip(10).next();
444 | ^^^^^^^^^^^^^^^^^^^^^^^
446 error: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
447 --> $DIR/methods.rs:448:14
449 448 | let _ = &some_vec[..].iter().skip(3).next();
450 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
452 error: used unwrap() on an Option value. If you don't want to handle the None case gracefully, consider using expect() to provide a better panic message
453 --> $DIR/methods.rs:457:13
455 457 | let _ = opt.unwrap();
458 = note: `-D clippy::option-unwrap-used` implied by `-D warnings`
460 error: aborting due to 57 previous errors