5 #![warn(clippy, clippy_pedantic)]
6 #![allow(blacklisted_name, unused, print_stdout, non_ascii_literal, new_without_default, new_without_default_derive, missing_docs_in_private_items)]
8 use std::collections::BTreeMap;
9 use std::collections::HashMap;
10 use std::collections::HashSet;
11 use std::collections::VecDeque;
13 use std::iter::FromIterator;
14 use std::rc::{self, Rc};
15 use std::sync::{self, Arc};
20 fn add(self, other: T) -> T { self }
21 fn drop(&mut self) { }
23 fn sub(&self, other: T) -> &T { self } // no error, self is a ref
24 fn div(self) -> T { self } // no error, different #arguments
25 fn rem(self, other: T) { } // no error, wrong return type
27 fn into_u32(self) -> u32 { 0 } // fine
28 fn into_u16(&self) -> u16 { 0 }
30 fn to_something(self) -> u32 { 0 }
40 // The lifetime is different, but that’s irrelevant, see #734
41 #[allow(needless_lifetimes)]
42 pub fn new<'b>(s: &'b str) -> Lt<'b> { unimplemented!() }
50 // The lifetime is different, but that’s irrelevant, see #734
51 pub fn new(s: &str) -> Lt2 { unimplemented!() }
59 // The lifetime is different, but that’s irrelevant, see #734
60 pub fn new() -> Lt3<'static> { unimplemented!() }
67 fn new() -> Self { U }
68 fn to_something(self) -> u32 { 0 } // ok because U is Copy
76 fn new() -> Option<V<T>> { None }
81 fn mul(self, other: T) -> T { self } // no error, obviously
84 /// Utility macro to test linting behavior in `option_methods()`
85 /// The lints included in `option_methods()` should not lint if the call to map is partially
87 macro_rules! opt_map {
88 ($opt:expr, $map:expr) => {($opt).map($map)};
91 /// Checks implementation of the following lints:
92 /// * `OPTION_MAP_UNWRAP_OR`
93 /// * `OPTION_MAP_UNWRAP_OR_ELSE`
97 // Check OPTION_MAP_UNWRAP_OR
99 let _ = opt.map(|x| x + 1)
101 .unwrap_or(0); // should lint even though this call is on a separate line
103 let _ = opt.map(|x| {
107 let _ = opt.map(|x| x + 1)
111 // map(f).unwrap_or(None) case
112 let _ = opt.map(|x| Some(x + 1)).unwrap_or(None);
114 let _ = opt_map!(opt, |x| x + 1).unwrap_or(0); // should not lint
116 // Check OPTION_MAP_UNWRAP_OR_ELSE
118 let _ = opt.map(|x| x + 1)
120 .unwrap_or_else(|| 0); // should lint even though this call is on a separate line
122 let _ = opt.map(|x| {
125 ).unwrap_or_else(|| 0);
126 let _ = opt.map(|x| x + 1)
131 let _ = opt_map!(opt, |x| x + 1).unwrap_or_else(|| 0); // should not lint
134 /// Struct to generate false positives for things with .iter()
135 #[derive(Copy, Clone)]
139 fn iter(self) -> IteratorFalsePositives {
140 IteratorFalsePositives { foo: 0 }
143 fn iter_mut(self) -> IteratorFalsePositives {
144 IteratorFalsePositives { foo: 0 }
148 /// Struct to generate false positive for Iterator-based lints
149 #[derive(Copy, Clone)]
150 struct IteratorFalsePositives {
154 impl IteratorFalsePositives {
155 fn filter(self) -> IteratorFalsePositives {
159 fn next(self) -> IteratorFalsePositives {
163 fn find(self) -> Option<u32> {
167 fn position(self) -> Option<u32> {
171 fn rposition(self) -> Option<u32> {
175 fn nth(self, n: usize) -> Option<u32> {
179 fn skip(self, _: usize) -> IteratorFalsePositives {
184 #[derive(Copy, Clone)]
188 fn chars(self) -> std::str::Chars<'static> {
193 /// Checks implementation of `FILTER_NEXT` lint
195 let v = vec![3, 2, 1, 0, -1, -2, -3];
197 // check single-line case
198 let _ = v.iter().filter(|&x| *x < 0).next();
200 // check multi-line case
201 let _ = v.iter().filter(|&x| {
206 // check that we don't lint if the caller is not an Iterator
207 let foo = IteratorFalsePositives { foo: 0 };
208 let _ = foo.filter().next();
211 /// Checks implementation of `SEARCH_IS_SOME` lint
212 fn search_is_some() {
213 let v = vec![3, 2, 1, 0, -1, -2, -3];
215 // check `find().is_some()`, single-line
216 let _ = v.iter().find(|&x| *x < 0).is_some();
218 // check `find().is_some()`, multi-line
219 let _ = v.iter().find(|&x| {
224 // check `position().is_some()`, single-line
225 let _ = v.iter().position(|&x| x < 0).is_some();
227 // check `position().is_some()`, multi-line
228 let _ = v.iter().position(|&x| {
233 // check `rposition().is_some()`, single-line
234 let _ = v.iter().rposition(|&x| x < 0).is_some();
236 // check `rposition().is_some()`, multi-line
237 let _ = v.iter().rposition(|&x| {
242 // check that we don't lint if the caller is not an Iterator
243 let foo = IteratorFalsePositives { foo: 0 };
244 let _ = foo.find().is_some();
245 let _ = foo.position().is_some();
246 let _ = foo.rposition().is_some();
249 /// Checks implementation of the `OR_FUN_CALL` lint
254 fn new() -> Foo { Foo }
261 const fn make_const(i: i32) -> i32 { i }
263 fn make<T>() -> T { unimplemented!(); }
265 let with_enum = Some(Enum::A(1));
266 with_enum.unwrap_or(Enum::A(5));
268 let with_const_fn = Some(1);
269 with_const_fn.unwrap_or(make_const(5));
271 let with_constructor = Some(vec![1]);
272 with_constructor.unwrap_or(make());
274 let with_new = Some(vec![1]);
275 with_new.unwrap_or(Vec::new());
277 let with_const_args = Some(vec![1]);
278 with_const_args.unwrap_or(Vec::with_capacity(12));
280 let with_err : Result<_, ()> = Ok(vec![1]);
281 with_err.unwrap_or(make());
283 let with_err_args : Result<_, ()> = Ok(vec![1]);
284 with_err_args.unwrap_or(Vec::with_capacity(12));
286 let with_default_trait = Some(1);
287 with_default_trait.unwrap_or(Default::default());
289 let with_default_type = Some(1);
290 with_default_type.unwrap_or(u64::default());
292 let with_vec = Some(vec![1]);
293 with_vec.unwrap_or(vec![]);
295 // FIXME #944: ~|SUGGESTION with_vec.unwrap_or_else(|| vec![]);
297 let without_default = Some(Foo);
298 without_default.unwrap_or(Foo::new());
300 let mut map = HashMap::<u64, String>::new();
301 map.entry(42).or_insert(String::new());
303 let mut btree = BTreeMap::<u64, String>::new();
304 btree.entry(42).or_insert(String::new());
306 let stringy = Some(String::from(""));
307 let _ = stringy.unwrap_or("".to_owned());
310 /// Checks implementation of `ITER_NTH` lint
312 let mut some_vec = vec![0, 1, 2, 3];
313 let mut boxed_slice: Box<[u8]> = Box::new([0, 1, 2, 3]);
314 let mut some_vec_deque: VecDeque<_> = some_vec.iter().cloned().collect();
317 // Make sure we lint `.iter()` for relevant types
318 let bad_vec = some_vec.iter().nth(3);
319 let bad_slice = &some_vec[..].iter().nth(3);
320 let bad_boxed_slice = boxed_slice.iter().nth(3);
321 let bad_vec_deque = some_vec_deque.iter().nth(3);
325 // Make sure we lint `.iter_mut()` for relevant types
326 let bad_vec = some_vec.iter_mut().nth(3);
329 let bad_slice = &some_vec[..].iter_mut().nth(3);
332 let bad_vec_deque = some_vec_deque.iter_mut().nth(3);
335 // Make sure we don't lint for non-relevant types
336 let false_positive = HasIter;
337 let ok = false_positive.iter().nth(3);
338 let ok_mut = false_positive.iter_mut().nth(3);
341 /// Checks implementation of `ITER_SKIP_NEXT` lint
342 fn iter_skip_next() {
343 let mut some_vec = vec![0, 1, 2, 3];
344 let _ = some_vec.iter().skip(42).next();
345 let _ = some_vec.iter().cycle().skip(42).next();
346 let _ = (1..10).skip(10).next();
347 let _ = &some_vec[..].iter().skip(3).next();
348 let foo = IteratorFalsePositives { foo : 0 };
349 let _ = foo.skip(42).next();
350 let _ = foo.filter().skip(42).next();
353 struct GetFalsePositive {
357 impl GetFalsePositive {
358 fn get(&self, pos: usize) -> Option<&u32> { self.arr.get(pos) }
359 fn get_mut(&mut self, pos: usize) -> Option<&mut u32> { self.arr.get_mut(pos) }
362 /// Checks implementation of `GET_UNWRAP` lint
364 let mut boxed_slice: Box<[u8]> = Box::new([0, 1, 2, 3]);
365 let mut some_slice = &mut [0, 1, 2, 3];
366 let mut some_vec = vec![0, 1, 2, 3];
367 let mut some_vecdeque: VecDeque<_> = some_vec.iter().cloned().collect();
368 let mut some_hashmap: HashMap<u8, char> = HashMap::from_iter(vec![(1, 'a'), (2, 'b')]);
369 let mut some_btreemap: BTreeMap<u8, char> = BTreeMap::from_iter(vec![(1, 'a'), (2, 'b')]);
370 let mut false_positive = GetFalsePositive { arr: [0, 1, 2] };
372 { // Test `get().unwrap()`
373 let _ = boxed_slice.get(1).unwrap();
374 let _ = some_slice.get(0).unwrap();
375 let _ = some_vec.get(0).unwrap();
376 let _ = some_vecdeque.get(0).unwrap();
377 let _ = some_hashmap.get(&1).unwrap();
378 let _ = some_btreemap.get(&1).unwrap();
379 let _ = false_positive.get(0).unwrap();
382 { // Test `get_mut().unwrap()`
383 *boxed_slice.get_mut(0).unwrap() = 1;
384 *some_slice.get_mut(0).unwrap() = 1;
385 *some_vec.get_mut(0).unwrap() = 1;
386 *some_vecdeque.get_mut(0).unwrap() = 1;
387 // Check false positives
388 *some_hashmap.get_mut(&1).unwrap() = 'b';
389 *some_btreemap.get_mut(&1).unwrap() = 'b';
390 *false_positive.get_mut(0).unwrap() = 1;
395 #[allow(similar_names)]
400 let _ = opt.unwrap();
402 let res: Result<i32, ()> = Ok(0);
403 let _ = res.unwrap();
405 res.ok().expect("disaster!");
406 // the following should not warn, since `expect` isn't implemented unless
407 // the error type implements `Debug`
408 let res2: Result<i32, MyError> = Ok(0);
409 res2.ok().expect("oh noes!");
410 let res3: Result<u32, MyErrorWithParam<u8>>= Ok(0);
411 res3.ok().expect("whoof");
412 let res4: Result<u32, io::Error> = Ok(0);
413 res4.ok().expect("argh");
414 let res5: io::Result<u32> = Ok(0);
415 res5.ok().expect("oops");
416 let res6: Result<u32, &str> = Ok(0);
417 res6.ok().expect("meh");
420 struct MyError(()); // doesn't implement Debug
423 struct MyErrorWithParam<T> {
427 #[allow(unnecessary_operation)]
429 "".chars().next() == Some(' ');
430 Some(' ') != "".chars().next();
433 fn str_extend_chars() {
435 let def = String::from("def");
436 let mut s = String::new();
439 s.extend(abc.chars());
442 s.extend("abc".chars());
445 s.extend(def.chars());
447 s.extend(abc.chars().skip(1));
448 s.extend("abc".chars().skip(1));
449 s.extend(['a', 'b', 'c'].iter());
458 vec![1].clone(); // ok, not a Copy type
459 Some(vec![1]).clone(); // ok, not a Copy type
463 fn clone_on_ref_ptr() {
464 let rc = Rc::new(true);
465 let arc = Arc::new(true);
467 let rcweak = Rc::downgrade(&rc);
468 let arc_weak = Arc::downgrade(&arc);
477 rc::Weak::clone(&rcweak);
480 sync::Weak::clone(&arc_weak);
485 fn clone_on_copy_generic<T: Copy>(t: T) {
491 fn clone_on_double_ref() {
494 let z: &Vec<_> = y.clone();
496 println!("{:p} {:p}",*y, z);
499 fn single_char_pattern() {
507 // Not yet testing for multi-byte characters
508 // Changing `r.len() == 1` to `r.chars().count() == 1` in `lint_single_char_pattern`
509 // should have done this but produced an ICE
511 // We may not want to suggest changing these anyway
512 // See: https://github.com/rust-lang-nursery/rust-clippy/issues/650#issuecomment-184328984
516 // Can't use this lint for unicode code points which don't fit in a char
524 x.split_terminator("x");
525 x.rsplit_terminator("x");
530 x.match_indices("x");
531 x.rmatch_indices("x");
532 x.trim_left_matches("x");
533 x.trim_right_matches("x");
535 let h = HashSet::<String>::new();
536 h.contains("X"); // should not warn
539 #[allow(result_unwrap_used)]
540 fn temporary_cstring() {
541 use std::ffi::CString;
543 CString::new("foo").unwrap().as_ptr();
546 fn iter_clone_collect() {
548 let v2 : Vec<isize> = v.iter().cloned().collect();
549 let v3 : HashSet<isize> = v.iter().cloned().collect();
550 let v4 : VecDeque<isize> = v.iter().cloned().collect();
553 fn chars_cmp_with_unwrap() {
554 let s = String::from("foo");
555 if s.chars().next().unwrap() == 'f' { // s.starts_with('f')
558 if s.chars().next_back().unwrap() == 'o' { // s.ends_with('o')
561 if s.chars().last().unwrap() == 'o' { // s.ends_with('o')
564 if s.chars().next().unwrap() != 'f' { // !s.starts_with('f')
567 if s.chars().next_back().unwrap() != 'o' { // !s.ends_with('o')
570 if s.chars().last().unwrap() != 'o' { // !s.ends_with('o')
575 #[allow(unnecessary_operation)]
577 "".chars().last() == Some(' ');
578 Some(' ') != "".chars().last();
579 "".chars().next_back() == Some(' ');
580 Some(' ') != "".chars().next_back();