1 // aux-build:option_helpers.rs
2 // compile-flags: --edition 2018
4 #![feature(async_await)]
5 #![warn(clippy::all, clippy::pedantic, clippy::option_unwrap_used)]
7 clippy::blacklisted_name,
10 clippy::non_ascii_literal,
11 clippy::new_without_default,
12 clippy::missing_docs_in_private_items,
13 clippy::needless_pass_by_value,
14 clippy::default_trait_access,
16 clippy::new_ret_no_self,
17 clippy::useless_format,
18 clippy::wrong_self_convention
22 extern crate option_helpers;
24 use std::collections::BTreeMap;
25 use std::collections::HashMap;
26 use std::collections::HashSet;
27 use std::collections::VecDeque;
28 use std::iter::FromIterator;
30 use std::rc::{self, Rc};
31 use std::sync::{self, Arc};
33 use option_helpers::IteratorFalsePositives;
38 pub fn add(self, other: T) -> T {
42 // no error, not public interface
43 pub(crate) fn drop(&mut self) {}
45 // no error, private function
46 fn neg(self) -> Self {
50 // no error, private function
51 fn eq(&self, other: T) -> bool {
55 // No error; self is a ref.
56 fn sub(&self, other: T) -> &T {
60 // No error; different number of arguments.
65 // No error; wrong return type.
66 fn rem(self, other: T) {}
69 fn into_u32(self) -> u32 {
73 fn into_u16(&self) -> u16 {
77 fn to_something(self) -> u32 {
81 fn new(self) -> Self {
91 // The lifetime is different, but that’s irrelevant; see issue #734.
92 #[allow(clippy::needless_lifetimes)]
93 pub fn new<'b>(s: &'b str) -> Lt<'b> {
103 // The lifetime is different, but that’s irrelevant; see issue #734.
104 pub fn new(s: &str) -> Lt2 {
114 // The lifetime is different, but that’s irrelevant; see issue #734.
115 pub fn new() -> Lt3<'static> {
120 #[derive(Clone, Copy)]
127 // Ok because `U` is `Copy`.
128 fn to_something(self) -> u32 {
138 fn new() -> Option<V<T>> {
146 async fn new() -> Option<Self> {
153 // No error, obviously.
154 fn mul(self, other: T) -> T {
159 /// Checks implementation of the following lints:
160 /// * `OPTION_MAP_UNWRAP_OR`
161 /// * `OPTION_MAP_UNWRAP_OR_ELSE`
163 fn option_methods() {
166 // Check `OPTION_MAP_UNWRAP_OR`.
168 let _ = opt.map(|x| x + 1)
169 // Should lint even though this call is on a separate line.
172 let _ = opt.map(|x| {
176 let _ = opt.map(|x| x + 1)
180 // Single line `map(f).unwrap_or(None)` case.
181 let _ = opt.map(|x| Some(x + 1)).unwrap_or(None);
182 // Multi-line `map(f).unwrap_or(None)` cases.
183 let _ = opt.map(|x| {
188 .map(|x| Some(x + 1))
191 let _ = opt_map!(opt, |x| x + 1).unwrap_or(0); // should not lint
193 // Should not lint if not copyable
194 let id: String = "identifier".to_string();
195 let _ = Some("prefix").map(|p| format!("{}.{}", p, id)).unwrap_or(id);
196 // ...but DO lint if the `unwrap_or` argument is not used in the `map`
197 let id: String = "identifier".to_string();
198 let _ = Some("prefix").map(|p| format!("{}.", p)).unwrap_or(id);
200 // Check OPTION_MAP_UNWRAP_OR_ELSE
202 let _ = opt.map(|x| x + 1)
203 // Should lint even though this call is on a separate line.
204 .unwrap_or_else(|| 0);
206 let _ = opt.map(|x| {
209 ).unwrap_or_else(|| 0);
210 let _ = opt.map(|x| x + 1)
216 let _ = opt_map!(opt, |x| x + 1).unwrap_or_else(|| 0);
220 let mut frequencies = HashMap::new();
229 frequencies.insert(word.to_owned(), 1);
234 /// Checks implementation of `FILTER_NEXT` lint.
237 let v = vec![3, 2, 1, 0, -1, -2, -3];
240 let _ = v.iter().filter(|&x| *x < 0).next();
243 let _ = v.iter().filter(|&x| {
248 // Check that hat we don't lint if the caller is not an `Iterator`.
249 let foo = IteratorFalsePositives { foo: 0 };
250 let _ = foo.filter().next();
253 /// Checks implementation of `SEARCH_IS_SOME` lint.
255 fn search_is_some() {
256 let v = vec![3, 2, 1, 0, -1, -2, -3];
258 // Check `find().is_some()`, single-line case.
259 let _ = v.iter().find(|&x| *x < 0).is_some();
261 // Check `find().is_some()`, multi-line case.
262 let _ = v.iter().find(|&x| {
267 // Check `position().is_some()`, single-line case.
268 let _ = v.iter().position(|&x| x < 0).is_some();
270 // Check `position().is_some()`, multi-line case.
271 let _ = v.iter().position(|&x| {
276 // Check `rposition().is_some()`, single-line case.
277 let _ = v.iter().rposition(|&x| x < 0).is_some();
279 // Check `rposition().is_some()`, multi-line case.
280 let _ = v.iter().rposition(|&x| {
285 // Check that we don't lint if the caller is not an `Iterator`.
286 let foo = IteratorFalsePositives { foo: 0 };
287 let _ = foo.find().is_some();
288 let _ = foo.position().is_some();
289 let _ = foo.rposition().is_some();
292 #[allow(clippy::similar_names)]
295 let _ = opt.unwrap();