3 #![allow(dead_code, unused)]
5 use std::collections::*;
8 struct Unrelated(Vec<u8>);
10 fn next(&self) -> std::slice::Iter<u8> {
14 fn iter(&self) -> std::slice::Iter<u8> {
20 clippy::needless_range_loop,
21 clippy::explicit_iter_loop,
22 clippy::explicit_into_iter_loop,
23 clippy::iter_next_loop,
24 clippy::reverse_range_loop,
29 clippy::shadow_unrelated,
30 clippy::unnecessary_mut_passed,
33 #[allow(clippy::many_single_char_names, unused_variables)]
35 const MAX_LEN: usize = 42;
36 let mut vec = vec![1, 2, 3, 4];
51 // not an error, this is the range with only one element “5”
56 // not an error, the start index is less than the end index
65 for i in (10..0).map(|x| x * 2) {
66 // not an error, it can't be known what arbitrary methods do to a range
70 // testing that the empty range lint folds constants
75 for i in (5 + 2)..(3 - 1) {
79 for i in (2 * 2)..(2 * 3) {
80 // no error, 4..6 is fine
86 // no error, not constant-foldable
92 // no error, id_col does not exist outside the loop
93 let mut id_col = vec![0f64; 10];
97 for _v in vec.iter() {}
99 for _v in vec.iter_mut() {}
101 let out_vec = vec![1, 2, 3];
102 for _v in out_vec.into_iter() {}
104 for _v in &vec {} // these are fine
105 for _v in &mut vec {} // these are fine
107 for _v in [1, 2, 3].iter() {}
109 for _v in (&mut [1, 2, 3]).iter() {} // no error
111 for _v in [0; 32].iter() {}
113 for _v in [0; 33].iter() {} // no error
115 let ll: LinkedList<()> = LinkedList::new();
116 for _v in ll.iter() {}
118 let vd: VecDeque<()> = VecDeque::new();
119 for _v in vd.iter() {}
121 let bh: BinaryHeap<()> = BinaryHeap::new();
122 for _v in bh.iter() {}
124 let hm: HashMap<(), ()> = HashMap::new();
125 for _v in hm.iter() {}
127 let bt: BTreeMap<(), ()> = BTreeMap::new();
128 for _v in bt.iter() {}
130 let hs: HashSet<()> = HashSet::new();
131 for _v in hs.iter() {}
133 let bs: BTreeSet<()> = BTreeSet::new();
134 for _v in bs.iter() {}
136 let u = Unrelated(vec![]);
137 for _v in u.next() {} // no error
138 for _v in u.iter() {} // no error
140 let mut out = vec![];
141 vec.iter().cloned().map(|x| out.push(x)).collect::<Vec<_>>();
142 let _y = vec.iter().cloned().map(|x| out.push(x)).collect::<Vec<_>>(); // this is fine
144 // Loop with explicit counter variable
146 // Potential false positives
237 let mut _x = &mut index;
247 println!("index: {}", index);
249 fn f<T>(_: &T, _: &T) -> bool {
252 fn g<T>(_: &mut [T], _: usize, _: usize) {
255 for i in 1..vec.len() {
256 if f(&vec[i - 1], &vec[i]) {
257 g(&mut vec, i - 1, i);
261 for mid in 1..vec.len() {
262 let (_, _) = vec.split_at(mid);
266 fn partition<T: PartialOrd + Send>(v: &mut [T]) -> usize {
267 let pivot = v.len() - 1;
270 if v[j] <= v[pivot] {
279 #[warn(clippy::needless_range_loop)]
280 pub fn manual_copy_same_destination(dst: &mut [i32], d: usize, s: usize) {
281 // Same source and destination - don't trigger lint
282 for i in 0..dst.len() {
283 dst[d + i] = dst[s + i];
289 fn new_for_index(index: usize) -> Self;
290 fn index(&self) -> usize;
293 pub fn test<H: Handle>() -> H {
295 let next_handle = H::new_for_index(x);
296 println!("{}", next_handle.index());
302 // explicit_into_iter_loop bad suggestions
303 #[warn(clippy::explicit_into_iter_loop, clippy::explicit_iter_loop)]
305 fn takes_iterator<T>(iterator: &T)
307 for<'a> &'a T: IntoIterator<Item = &'a String>,
309 for i in iterator.into_iter() {
315 impl IntoIterator for &T {
317 type IntoIter = std::vec::IntoIter<Self::Item>;
318 fn into_iter(self) -> Self::IntoIter {
328 // This case is handled by `explicit_iter_loop`. No idea why.
329 for _ in t.into_iter() {}
331 for _ in r.into_iter() {}
333 // No suggestion for this.
334 // We'd have to suggest `for _ in *rr {}` which is less clear.
335 for _ in rr.into_iter() {}