1 use std::collections::*;
4 static STATIC: [usize; 4] = [0, 1, 8, 16];
5 const CONST: [usize; 4] = [0, 1, 8, 16];
8 struct Unrelated(Vec<u8>);
10 fn next(&self) -> std::slice::Iter<u8> {
14 fn iter(&self) -> std::slice::Iter<u8> {
20 clippy::needless_range_loop,
21 clippy::explicit_iter_loop,
22 clippy::explicit_into_iter_loop,
23 clippy::iter_next_loop,
24 clippy::reverse_range_loop,
27 #[warn(clippy::unused_collect)]
30 clippy::shadow_unrelated,
31 clippy::unnecessary_mut_passed,
32 clippy::cognitive_complexity,
35 #[allow(clippy::many_single_char_names, unused_variables, clippy::into_iter_on_array)]
37 const MAX_LEN: usize = 42;
38 let mut vec = vec![1, 2, 3, 4];
57 // not an error, this is the range with only one element “5”
62 // not an error, the start index is less than the end index
71 for i in (10..0).map(|x| x * 2) {
72 // not an error, it can't be known what arbitrary methods do to a range
76 // testing that the empty range lint folds constants
81 for i in (5 + 2)..(3 - 1) {
85 for i in (5 + 2)..(8 - 1) {
89 for i in (2 * 2)..(2 * 3) {
90 // no error, 4..6 is fine
96 // no error, not constant-foldable
102 // no error, id_col does not exist outside the loop
103 let mut id_col = vec![0f64; 10];
107 for _v in vec.iter() {}
109 for _v in vec.iter_mut() {}
111 let out_vec = vec![1, 2, 3];
112 for _v in out_vec.into_iter() {}
114 let array = [1, 2, 3];
115 for _v in array.into_iter() {}
117 for _v in &vec {} // these are fine
118 for _v in &mut vec {} // these are fine
120 for _v in [1, 2, 3].iter() {}
122 for _v in (&mut [1, 2, 3]).iter() {} // no error
124 for _v in [0; 32].iter() {}
126 for _v in [0; 33].iter() {} // no error
128 let ll: LinkedList<()> = LinkedList::new();
129 for _v in ll.iter() {}
131 let vd: VecDeque<()> = VecDeque::new();
132 for _v in vd.iter() {}
134 let bh: BinaryHeap<()> = BinaryHeap::new();
135 for _v in bh.iter() {}
137 let hm: HashMap<(), ()> = HashMap::new();
138 for _v in hm.iter() {}
140 let bt: BTreeMap<(), ()> = BTreeMap::new();
141 for _v in bt.iter() {}
143 let hs: HashSet<()> = HashSet::new();
144 for _v in hs.iter() {}
146 let bs: BTreeSet<()> = BTreeSet::new();
147 for _v in bs.iter() {}
149 for _v in vec.iter().next() {}
151 let u = Unrelated(vec![]);
152 for _v in u.next() {} // no error
153 for _v in u.iter() {} // no error
155 let mut out = vec![];
156 vec.iter().cloned().map(|x| out.push(x)).collect::<Vec<_>>();
157 let _y = vec.iter().cloned().map(|x| out.push(x)).collect::<Vec<_>>(); // this is fine
159 // Loop with explicit counter variable
161 // Potential false positives
252 let mut _x = &mut index;
262 println!("index: {}", index);
264 fn f<T>(_: &T, _: &T) -> bool {
267 fn g<T>(_: &mut [T], _: usize, _: usize) {
270 for i in 1..vec.len() {
271 if f(&vec[i - 1], &vec[i]) {
272 g(&mut vec, i - 1, i);
276 for mid in 1..vec.len() {
277 let (_, _) = vec.split_at(mid);
282 fn partition<T: PartialOrd + Send>(v: &mut [T]) -> usize {
283 let pivot = v.len() - 1;
286 if v[j] <= v[pivot] {
295 #[warn(clippy::needless_range_loop)]
296 pub fn manual_copy_same_destination(dst: &mut [i32], d: usize, s: usize) {
297 // Same source and destination - don't trigger lint
298 for i in 0..dst.len() {
299 dst[d + i] = dst[s + i];
305 fn new_for_index(index: usize) -> Self;
306 fn index(&self) -> usize;
309 pub fn test<H: Handle>() -> H {
311 let next_handle = H::new_for_index(x);
312 println!("{}", next_handle.index());