1 #![cfg_attr(feature = "deny-warnings", deny(warnings))]
2 #![warn(rust_2018_idioms, unused_lifetimes)]
3 #![allow(clippy::single_match_else)]
5 use rustc_tools_util::VersionInfo;
9 fn consistent_clippy_crate_versions() {
10 fn read_version(path: &str) -> String {
11 let contents = fs::read_to_string(path).unwrap_or_else(|e| panic!("error reading `{path}`: {e:?}"));
14 .filter_map(|l| l.split_once('='))
15 .find_map(|(k, v)| (k.trim() == "version").then(|| v.trim()))
16 .unwrap_or_else(|| panic!("error finding version in `{path}`"))
20 // do not run this test inside the upstream rustc repo:
21 // https://github.com/rust-lang/rust-clippy/issues/6683
22 if option_env!("RUSTC_TEST_SUITE").is_some() {
26 let clippy_version = read_version("Cargo.toml");
29 "declare_clippy_lint/Cargo.toml",
30 "clippy_lints/Cargo.toml",
31 "clippy_utils/Cargo.toml",
35 assert_eq!(clippy_version, read_version(path), "{path} version differs");
40 fn check_that_clippy_has_the_same_major_version_as_rustc() {
41 // do not run this test inside the upstream rustc repo:
42 // https://github.com/rust-lang/rust-clippy/issues/6683
43 if option_env!("RUSTC_TEST_SUITE").is_some() {
47 let clippy_version = rustc_tools_util::get_version_info!();
48 let clippy_major = clippy_version.major;
49 let clippy_minor = clippy_version.minor;
50 let clippy_patch = clippy_version.patch;
52 // get the rustc version either from the rustc installed with the toolchain file or from
53 // `RUSTC_REAL` if Clippy is build in the Rust repo with `./x.py`.
54 let rustc = std::env::var("RUSTC_REAL").unwrap_or_else(|_| "rustc".to_string());
55 let rustc_version = String::from_utf8(
56 std::process::Command::new(rustc)
59 .expect("failed to run `rustc --version`")
63 // extract "1 XX 0" from "rustc 1.XX.0-nightly (<commit> <date>)"
64 let vsplit: Vec<&str> = rustc_version
73 match vsplit.as_slice() {
74 [rustc_major, rustc_minor, _rustc_patch] => {
75 // clippy 0.1.XX should correspond to rustc 1.XX.0
76 assert_eq!(clippy_major, 0); // this will probably stay the same for a long time
78 clippy_minor.to_string(),
80 "clippy minor version does not equal rustc major version"
83 clippy_patch.to_string(),
85 "clippy patch version does not equal rustc minor version"
87 // do not check rustc_patch because when a stable-patch-release is made (like 1.50.2),
88 // we don't want our tests failing suddenly
91 panic!("Failed to parse rustc version: {vsplit:?}");