1 use clippy_utils::diagnostics::span_lint_and_sugg;
2 use clippy_utils::source::snippet;
3 use clippy_utils::ty::is_type_diagnostic_item;
4 use clippy_utils::{match_def_path, path_to_local, path_to_local_id, paths};
5 use if_chain::if_chain;
6 use rustc_ast::ast::LitKind;
7 use rustc_errors::Applicability;
8 use rustc_hir::{BindingAnnotation, Block, Expr, ExprKind, HirId, Local, PatKind, QPath, Stmt, StmtKind};
9 use rustc_lint::{LateContext, LateLintPass, LintContext};
10 use rustc_middle::lint::in_external_macro;
11 use rustc_session::{declare_tool_lint, impl_lint_pass};
12 use rustc_span::{symbol::sym, Span};
13 use std::convert::TryInto;
15 declare_clippy_lint! {
17 /// Checks for calls to `push` immediately after creating a new `Vec`.
19 /// ### Why is this bad?
20 /// The `vec![]` macro is both more performant and easier to read than
21 /// multiple `push` calls.
25 /// let mut v = Vec::new();
32 pub VEC_INIT_THEN_PUSH,
34 "`push` immediately after `Vec` creation"
37 impl_lint_pass!(VecInitThenPush => [VEC_INIT_THEN_PUSH]);
40 pub struct VecInitThenPush {
41 searcher: Option<VecPushSearcher>,
44 #[derive(Clone, Copy)]
49 struct VecPushSearcher {
57 impl VecPushSearcher {
58 fn display_err(&self, cx: &LateContext<'_>) {
60 _ if self.found == 0 => return,
61 VecInitKind::WithCapacity(x) if x > self.found => return,
65 let mut s = if self.lhs_is_local {
70 s.push_str(&snippet(cx, self.lhs_span, ".."));
71 s.push_str(" = vec![..];");
77 "calls to `push` immediately after creation",
78 "consider using the `vec![]` macro",
80 Applicability::HasPlaceholders,
85 impl LateLintPass<'_> for VecInitThenPush {
86 fn check_block(&mut self, _: &LateContext<'tcx>, _: &'tcx Block<'tcx>) {
90 fn check_local(&mut self, cx: &LateContext<'tcx>, local: &'tcx Local<'tcx>) {
92 if !in_external_macro(cx.sess(), local.span);
93 if let Some(init) = local.init;
94 if let PatKind::Binding(BindingAnnotation::Mutable, id, _, None) = local.pat.kind;
95 if let Some(init_kind) = get_vec_init_kind(cx, init);
97 self.searcher = Some(VecPushSearcher {
101 lhs_span: local.ty.map_or(local.pat.span, |t| local.pat.span.to(t.span)),
102 err_span: local.span,
109 fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
111 if self.searcher.is_none();
112 if !in_external_macro(cx.sess(), expr.span);
113 if let ExprKind::Assign(left, right, _) = expr.kind;
114 if let Some(id) = path_to_local(left);
115 if let Some(init_kind) = get_vec_init_kind(cx, right);
117 self.searcher = Some(VecPushSearcher {
129 fn check_stmt(&mut self, cx: &LateContext<'tcx>, stmt: &'tcx Stmt<'_>) {
130 if let Some(searcher) = self.searcher.take() {
132 if let StmtKind::Expr(expr) | StmtKind::Semi(expr) = stmt.kind;
133 if let ExprKind::MethodCall(path, _, [self_arg, _], _) = expr.kind;
134 if path_to_local_id(self_arg, searcher.local_id);
135 if path.ident.name.as_str() == "push";
137 self.searcher = Some(VecPushSearcher {
138 found: searcher.found + 1,
139 err_span: searcher.err_span.to(stmt.span),
143 searcher.display_err(cx);
149 fn check_block_post(&mut self, cx: &LateContext<'tcx>, _: &'tcx Block<'tcx>) {
150 if let Some(searcher) = self.searcher.take() {
151 searcher.display_err(cx);
156 fn get_vec_init_kind<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'tcx>) -> Option<VecInitKind> {
157 if let ExprKind::Call(func, args) = expr.kind {
159 ExprKind::Path(QPath::TypeRelative(ty, name))
160 if is_type_diagnostic_item(cx, cx.typeck_results().node_type(ty.hir_id), sym::Vec) =>
162 if name.ident.name == sym::new {
163 return Some(VecInitKind::New);
164 } else if name.ident.name.as_str() == "with_capacity" {
165 return args.get(0).and_then(|arg| {
167 if let ExprKind::Lit(lit) = &arg.kind;
168 if let LitKind::Int(num, _) = lit.node;
170 Some(VecInitKind::WithCapacity(num.try_into().ok()?))
178 ExprKind::Path(QPath::Resolved(_, path))
179 if match_def_path(cx, path.res.opt_def_id()?, &paths::DEFAULT_TRAIT_METHOD)
180 && is_type_diagnostic_item(cx, cx.typeck_results().expr_ty(expr), sym::Vec) =>
182 return Some(VecInitKind::New);