1 use clippy_utils::diagnostics::span_lint_hir_and_then;
2 use clippy_utils::source::{snippet_opt, snippet_with_context};
3 use clippy_utils::{fn_def_id, path_to_local_id};
4 use if_chain::if_chain;
5 use rustc_ast::ast::Attribute;
6 use rustc_errors::Applicability;
7 use rustc_hir::intravisit::{walk_expr, FnKind, Visitor};
8 use rustc_hir::{Block, Body, Expr, ExprKind, FnDecl, HirId, MatchSource, PatKind, StmtKind};
9 use rustc_lint::{LateContext, LateLintPass, LintContext};
10 use rustc_middle::lint::in_external_macro;
11 use rustc_middle::ty::subst::GenericArgKind;
12 use rustc_session::{declare_lint_pass, declare_tool_lint};
13 use rustc_span::source_map::Span;
16 declare_clippy_lint! {
18 /// Checks for `let`-bindings, which are subsequently
21 /// ### Why is this bad?
22 /// It is just extraneous code. Remove it to make your code
27 /// fn foo() -> String {
28 /// let x = String::new();
34 /// fn foo() -> String {
38 #[clippy::version = "pre 1.29.0"]
41 "creating a let-binding and then immediately returning it like `let x = expr; x` at the end of a block"
44 declare_clippy_lint! {
46 /// Checks for return statements at the end of a block.
48 /// ### Why is this bad?
49 /// Removing the `return` and semicolon will make the code
54 /// fn foo(x: usize) -> usize {
60 /// fn foo(x: usize) -> usize {
64 #[clippy::version = "pre 1.29.0"]
67 "using a return statement like `return expr;` where an expression would suffice"
70 #[derive(PartialEq, Eq, Copy, Clone)]
77 declare_lint_pass!(Return => [LET_AND_RETURN, NEEDLESS_RETURN]);
79 impl<'tcx> LateLintPass<'tcx> for Return {
80 fn check_block(&mut self, cx: &LateContext<'tcx>, block: &'tcx Block<'_>) {
81 // we need both a let-binding stmt and an expr
83 if let Some(retexpr) = block.expr;
84 if let Some(stmt) = block.stmts.iter().last();
85 if let StmtKind::Local(local) = &stmt.kind;
86 if local.ty.is_none();
87 if cx.tcx.hir().attrs(local.hir_id).is_empty();
88 if let Some(initexpr) = &local.init;
89 if let PatKind::Binding(_, local_id, _, _) = local.pat.kind;
90 if path_to_local_id(retexpr, local_id);
91 if !last_statement_borrows(cx, initexpr);
92 if !in_external_macro(cx.sess(), initexpr.span);
93 if !in_external_macro(cx.sess(), retexpr.span);
94 if !local.span.from_expansion();
96 span_lint_hir_and_then(
101 "returning the result of a `let` binding from a block",
103 err.span_label(local.span, "unnecessary `let` binding");
105 if let Some(mut snippet) = snippet_opt(cx, initexpr.span) {
106 if !cx.typeck_results().expr_adjustments(retexpr).is_empty() {
107 snippet.push_str(" as _");
109 err.multipart_suggestion(
110 "return the expression directly",
112 (local.span, String::new()),
113 (retexpr.span, snippet),
115 Applicability::MachineApplicable,
118 err.span_help(initexpr.span, "this expression can be directly returned");
128 cx: &LateContext<'tcx>,
130 _: &'tcx FnDecl<'tcx>,
131 body: &'tcx Body<'tcx>,
137 // when returning without value in closure, replace this `return`
138 // with an empty block to prevent invalid suggestion (see #6501)
139 let replacement = if let ExprKind::Ret(None) = &body.value.kind {
140 RetReplacement::Block
142 RetReplacement::Empty
144 check_final_expr(cx, &body.value, Some(body.value.span), replacement);
146 FnKind::ItemFn(..) | FnKind::Method(..) => {
147 if let ExprKind::Block(block, _) = body.value.kind {
148 check_block_return(cx, block);
155 fn attr_is_cfg(attr: &Attribute) -> bool {
156 attr.meta_item_list().is_some() && attr.has_name(sym::cfg)
159 fn check_block_return<'tcx>(cx: &LateContext<'tcx>, block: &Block<'tcx>) {
160 if let Some(expr) = block.expr {
161 check_final_expr(cx, expr, Some(expr.span), RetReplacement::Empty);
162 } else if let Some(stmt) = block.stmts.iter().last() {
164 StmtKind::Expr(expr) | StmtKind::Semi(expr) => {
165 check_final_expr(cx, expr, Some(stmt.span), RetReplacement::Empty);
172 fn check_final_expr<'tcx>(
173 cx: &LateContext<'tcx>,
174 expr: &'tcx Expr<'tcx>,
176 replacement: RetReplacement,
179 // simple return is always "bad"
180 ExprKind::Ret(ref inner) => {
181 // allow `#[cfg(a)] return a; #[cfg(b)] return b;`
182 let attrs = cx.tcx.hir().attrs(expr.hir_id);
183 if !attrs.iter().any(attr_is_cfg) {
184 let borrows = inner.map_or(false, |inner| last_statement_borrows(cx, inner));
188 inner.map_or(expr.hir_id, |inner| inner.hir_id),
189 span.expect("`else return` is not possible"),
190 inner.as_ref().map(|i| i.span),
196 // a whole block? check it!
197 ExprKind::Block(block, _) => {
198 check_block_return(cx, block);
200 ExprKind::If(_, then, else_clause_opt) => {
201 if let ExprKind::Block(ifblock, _) = then.kind {
202 check_block_return(cx, ifblock);
204 if let Some(else_clause) = else_clause_opt {
205 check_final_expr(cx, else_clause, None, RetReplacement::Empty);
208 // a match expr, check all arms
209 // an if/if let expr, check both exprs
210 // note, if without else is going to be a type checking error anyways
211 // (except for unit type functions) so we don't match it
212 ExprKind::Match(_, arms, MatchSource::Normal) => {
213 for arm in arms.iter() {
214 check_final_expr(cx, arm.body, Some(arm.body.span), RetReplacement::Unit);
217 ExprKind::DropTemps(expr) => check_final_expr(cx, expr, None, RetReplacement::Empty),
223 cx: &LateContext<'_>,
224 emission_place: HirId,
226 inner_span: Option<Span>,
227 replacement: RetReplacement,
229 if ret_span.from_expansion() {
233 Some(inner_span) => {
234 let mut applicability = Applicability::MachineApplicable;
235 span_lint_hir_and_then(
240 "unneeded `return` statement",
242 let (snippet, _) = snippet_with_context(cx, inner_span, ret_span.ctxt(), "..", &mut applicability);
243 diag.span_suggestion(ret_span, "remove `return`", snippet, applicability);
247 None => match replacement {
248 RetReplacement::Empty => {
249 span_lint_hir_and_then(
254 "unneeded `return` statement",
256 diag.span_suggestion(
260 Applicability::MachineApplicable,
265 RetReplacement::Block => {
266 span_lint_hir_and_then(
271 "unneeded `return` statement",
273 diag.span_suggestion(
275 "replace `return` with an empty block",
277 Applicability::MachineApplicable,
282 RetReplacement::Unit => {
283 span_lint_hir_and_then(
288 "unneeded `return` statement",
290 diag.span_suggestion(
292 "replace `return` with a unit value",
294 Applicability::MachineApplicable,
303 fn last_statement_borrows<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'tcx>) -> bool {
304 let mut visitor = BorrowVisitor { cx, borrows: false };
305 walk_expr(&mut visitor, expr);
309 struct BorrowVisitor<'a, 'tcx> {
310 cx: &'a LateContext<'tcx>,
314 impl<'tcx> Visitor<'tcx> for BorrowVisitor<'_, 'tcx> {
315 fn visit_expr(&mut self, expr: &'tcx Expr<'_>) {
316 if self.borrows || expr.span.from_expansion() {
320 if let Some(def_id) = fn_def_id(self.cx, expr) {
328 .any(|arg| matches!(arg.unpack(), GenericArgKind::Lifetime(_)));
331 walk_expr(self, expr);