1 //! Checks for uses of mutex where an atomic value could be used
3 //! This lint is **warn** by default
5 use clippy_utils::diagnostics::span_lint;
6 use clippy_utils::ty::is_type_diagnostic_item;
8 use rustc_lint::{LateContext, LateLintPass};
9 use rustc_middle::ty::{self, Ty};
10 use rustc_session::{declare_lint_pass, declare_tool_lint};
13 declare_clippy_lint! {
15 /// Checks for usages of `Mutex<X>` where an atomic will do.
17 /// ### Why is this bad?
18 /// Using a mutex just to make access to a plain bool or
19 /// reference sequential is shooting flies with cannons.
20 /// `std::sync::atomic::AtomicBool` and `std::sync::atomic::AtomicPtr` are leaner and
23 /// ### Known problems
24 /// This lint cannot detect if the mutex is actually used
25 /// for waiting before a critical section.
32 /// # use std::sync::Mutex;
33 /// let x = Mutex::new(&y);
36 /// # use std::sync::atomic::AtomicBool;
37 /// let x = AtomicBool::new(y);
41 "using a mutex where an atomic value could be used instead"
44 declare_clippy_lint! {
46 /// Checks for usages of `Mutex<X>` where `X` is an integral
49 /// ### Why is this bad?
50 /// Using a mutex just to make access to a plain integer
52 /// shooting flies with cannons. `std::sync::atomic::AtomicUsize` is leaner and faster.
54 /// ### Known problems
55 /// This lint cannot detect if the mutex is actually used
56 /// for waiting before a critical section.
60 /// # use std::sync::Mutex;
61 /// let x = Mutex::new(0usize);
64 /// # use std::sync::atomic::AtomicUsize;
65 /// let x = AtomicUsize::new(0usize);
69 "using a mutex for an integer type"
72 declare_lint_pass!(Mutex => [MUTEX_ATOMIC, MUTEX_INTEGER]);
74 impl<'tcx> LateLintPass<'tcx> for Mutex {
75 fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
76 let ty = cx.typeck_results().expr_ty(expr);
77 if let ty::Adt(_, subst) = ty.kind() {
78 if is_type_diagnostic_item(cx, ty, sym::Mutex) {
79 let mutex_param = subst.type_at(0);
80 if let Some(atomic_name) = get_atomic_name(mutex_param) {
82 "consider using an `{}` instead of a `Mutex` here; if you just want the locking \
83 behavior and not the internal type, consider using `Mutex<()>`",
86 match *mutex_param.kind() {
87 ty::Uint(t) if t != ty::UintTy::Usize => span_lint(cx, MUTEX_INTEGER, expr.span, &msg),
88 ty::Int(t) if t != ty::IntTy::Isize => span_lint(cx, MUTEX_INTEGER, expr.span, &msg),
89 _ => span_lint(cx, MUTEX_ATOMIC, expr.span, &msg),
97 fn get_atomic_name(ty: Ty<'_>) -> Option<&'static str> {
99 ty::Bool => Some("AtomicBool"),
100 ty::Uint(_) => Some("AtomicUsize"),
101 ty::Int(_) => Some("AtomicIsize"),
102 ty::RawPtr(_) => Some("AtomicPtr"),