src/tools/clippy/clippy_lints/src/methods/unnecessary_lazy_eval.rs

   1 use clippy_utils::diagnostics::span_lint_and_then;
   2 use clippy_utils::source::snippet;
   3 use clippy_utils::ty::is_type_diagnostic_item;
   4 use clippy_utils::{eager_or_lazy, usage};
   5 use rustc_errors::Applicability;
   6 use rustc_hir as hir;
   7 use rustc_lint::LateContext;
   8 use rustc_span::sym;
   9
  10 use super::UNNECESSARY_LAZY_EVALUATIONS;
  11
  12 /// lint use of `<fn>_else(simple closure)` for `Option`s and `Result`s that can be
  13 /// replaced with `<fn>(return value of simple closure)`
  14 pub(super) fn check<'tcx>(
  15     cx: &LateContext<'tcx>,
  16     expr: &'tcx hir::Expr<'_>,
  17     recv: &'tcx hir::Expr<'_>,
  18     arg: &'tcx hir::Expr<'_>,
  19     simplify_using: &str,
  20 ) {
  21     let is_option = is_type_diagnostic_item(cx, cx.typeck_results().expr_ty(recv), sym::Option);
  22     let is_result = is_type_diagnostic_item(cx, cx.typeck_results().expr_ty(recv), sym::Result);
  23     let is_bool = cx.typeck_results().expr_ty(recv).is_bool();
  24
  25     if is_option || is_result || is_bool {
  26         if let hir::ExprKind::Closure(&hir::Closure { body, .. }) = arg.kind {
  27             let body = cx.tcx.hir().body(body);
  28             let body_expr = &body.value;
  29
  30             if usage::BindingUsageFinder::are_params_used(cx, body) {
  31                 return;
  32             }
  33
  34             if eager_or_lazy::switch_to_eager_eval(cx, body_expr) {
  35                 let msg = if is_option {
  36                     "unnecessary closure used to substitute value for `Option::None`"
  37                 } else if is_result {
  38                     "unnecessary closure used to substitute value for `Result::Err`"
  39                 } else {
  40                     "unnecessary closure used with `bool::then`"
  41                 };
  42                 let applicability = if body
  43                     .params
  44                     .iter()
  45                     // bindings are checked to be unused above
  46                     .all(|param| matches!(param.pat.kind, hir::PatKind::Binding(..) | hir::PatKind::Wild))
  47                 {
  48                     Applicability::MachineApplicable
  49                 } else {
  50                     // replacing the lambda may break type inference
  51                     Applicability::MaybeIncorrect
  52                 };
  53
  54                 // This is a duplicate of what's happening in clippy_lints::methods::method_call,
  55                 // which isn't ideal, We want to get the method call span,
  56                 // but prefer to avoid changing the signature of the function itself.
  57                 if let hir::ExprKind::MethodCall(_, _, span) = expr.kind {
  58                     span_lint_and_then(cx, UNNECESSARY_LAZY_EVALUATIONS, expr.span, msg, |diag| {
  59                         diag.span_suggestion(
  60                             span,
  61                             &format!("use `{}(..)` instead", simplify_using),
  62                             format!("{}({})", simplify_using, snippet(cx, body_expr.span, "..")),
  63                             applicability,
  64                         );
  65                     });
  66                 }
  67             }
  68         }
  69     }
  70 }