1 use clippy_utils::diagnostics::span_lint;
2 use clippy_utils::usage::mutated_variables;
3 use clippy_utils::{is_lang_ctor, is_trait_method, path_to_local_id};
5 use rustc_hir::intravisit::{walk_expr, Visitor};
6 use rustc_hir::LangItem::{OptionNone, OptionSome};
7 use rustc_lint::LateContext;
11 use super::UNNECESSARY_FILTER_MAP;
13 pub(super) fn check(cx: &LateContext<'_>, expr: &hir::Expr<'_>, arg: &hir::Expr<'_>) {
14 if !is_trait_method(cx, expr, sym::Iterator) {
18 if let hir::ExprKind::Closure(_, _, body_id, ..) = arg.kind {
19 let body = cx.tcx.hir().body(body_id);
20 let arg_id = body.params[0].pat.hir_id;
22 mutated_variables(&body.value, cx).map_or(true, |used_mutably| used_mutably.contains(&arg_id));
24 let (mut found_mapping, mut found_filtering) = check_expression(cx, arg_id, &body.value);
26 let mut return_visitor = ReturnVisitor::new(cx, arg_id);
27 return_visitor.visit_expr(&body.value);
28 found_mapping |= return_visitor.found_mapping;
29 found_filtering |= return_visitor.found_filtering;
31 let sugg = if !found_filtering {
33 } else if !found_mapping && !mutates_arg {
34 let in_ty = cx.typeck_results().node_type(body.params[0].hir_id);
35 match cx.typeck_results().expr_ty(&body.value).kind() {
37 if cx.tcx.is_diagnostic_item(sym::Option, adt.did) && in_ty == subst.type_at(0) =>
48 UNNECESSARY_FILTER_MAP,
50 &format!("this `.filter_map` can be written more simply using `.{}`", sugg),
55 // returns (found_mapping, found_filtering)
56 fn check_expression<'tcx>(cx: &LateContext<'tcx>, arg_id: hir::HirId, expr: &'tcx hir::Expr<'_>) -> (bool, bool) {
58 hir::ExprKind::Call(func, args) => {
59 if let hir::ExprKind::Path(ref path) = func.kind {
60 if is_lang_ctor(cx, path, OptionSome) {
61 if path_to_local_id(&args[0], arg_id) {
62 return (false, false);
69 hir::ExprKind::Block(block, _) => block
72 .map_or((false, false), |expr| check_expression(cx, arg_id, expr)),
73 hir::ExprKind::Match(_, arms, _) => {
74 let mut found_mapping = false;
75 let mut found_filtering = false;
77 let (m, f) = check_expression(cx, arg_id, arm.body);
81 (found_mapping, found_filtering)
83 // There must be an else_arm or there will be a type error
84 hir::ExprKind::If(_, if_arm, Some(else_arm)) => {
85 let if_check = check_expression(cx, arg_id, if_arm);
86 let else_check = check_expression(cx, arg_id, else_arm);
87 (if_check.0 | else_check.0, if_check.1 | else_check.1)
89 hir::ExprKind::Path(path) if is_lang_ctor(cx, path, OptionNone) => (false, true),
94 struct ReturnVisitor<'a, 'tcx> {
95 cx: &'a LateContext<'tcx>,
97 // Found a non-None return that isn't Some(input)
99 // Found a return that isn't Some
100 found_filtering: bool,
103 impl<'a, 'tcx> ReturnVisitor<'a, 'tcx> {
104 fn new(cx: &'a LateContext<'tcx>, arg_id: hir::HirId) -> ReturnVisitor<'a, 'tcx> {
108 found_mapping: false,
109 found_filtering: false,
114 impl<'a, 'tcx> Visitor<'tcx> for ReturnVisitor<'a, 'tcx> {
115 fn visit_expr(&mut self, expr: &'tcx hir::Expr<'_>) {
116 if let hir::ExprKind::Ret(Some(expr)) = &expr.kind {
117 let (found_mapping, found_filtering) = check_expression(self.cx, self.arg_id, expr);
118 self.found_mapping |= found_mapping;
119 self.found_filtering |= found_filtering;
121 walk_expr(self, expr);