src/tools/clippy/clippy_lints/src/methods/stable_sort_primitive.rs

   1 use clippy_utils::diagnostics::span_lint_and_then;
   2 use clippy_utils::is_slice_of_primitives;
   3 use clippy_utils::source::snippet_with_context;
   4 use rustc_errors::Applicability;
   5 use rustc_hir::Expr;
   6 use rustc_lint::LateContext;
   7
   8 use super::STABLE_SORT_PRIMITIVE;
   9
  10 pub(super) fn check<'tcx>(cx: &LateContext<'tcx>, e: &'tcx Expr<'_>, recv: &'tcx Expr<'_>) {
  11     if let Some(method_id) = cx.typeck_results().type_dependent_def_id(e.hir_id)
  12         && let Some(impl_id) = cx.tcx.impl_of_method(method_id)
  13         && cx.tcx.type_of(impl_id).is_slice()
  14         && let Some(slice_type) = is_slice_of_primitives(cx, recv)
  15     {
  16         span_lint_and_then(
  17             cx,
  18             STABLE_SORT_PRIMITIVE,
  19             e.span,
  20             &format!("used `sort` on primitive type `{slice_type}`"),
  21             |diag| {
  22                 let mut app = Applicability::MachineApplicable;
  23                 let recv_snip = snippet_with_context(cx, recv.span, e.span.ctxt(), "..", &mut app).0;
  24                 diag.span_suggestion(e.span, "try", format!("{recv_snip}.sort_unstable()"), app);
  25                 diag.note(
  26                     "an unstable sort typically performs faster without any observable difference for this data type",
  27                 );
  28             },
  29         );
  30     }
  31 }