src/tools/clippy/clippy_lints/src/methods/single_char_push_string.rs

   1 use crate::methods::get_hint_if_single_char_arg;
   2 use crate::utils::{snippet_with_applicability, span_lint_and_sugg};
   3 use rustc_errors::Applicability;
   4 use rustc_hir as hir;
   5 use rustc_lint::LateContext;
   6
   7 use super::SINGLE_CHAR_ADD_STR;
   8
   9 /// lint for length-1 `str`s as argument for `push_str`
  10 pub(super) fn check(cx: &LateContext<'_>, expr: &hir::Expr<'_>, args: &[hir::Expr<'_>]) {
  11     let mut applicability = Applicability::MachineApplicable;
  12     if let Some(extension_string) = get_hint_if_single_char_arg(cx, &args[1], &mut applicability) {
  13         let base_string_snippet =
  14             snippet_with_applicability(cx, args[0].span.source_callsite(), "..", &mut applicability);
  15         let sugg = format!("{}.push({})", base_string_snippet, extension_string);
  16         span_lint_and_sugg(
  17             cx,
  18             SINGLE_CHAR_ADD_STR,
  19             expr.span,
  20             "calling `push_str()` using a single-character string literal",
  21             "consider using `push` with a character literal",
  22             sugg,
  23             applicability,
  24         );
  25     }
  26 }