1 use clippy_utils::diagnostics::span_lint_and_help;
2 use clippy_utils::is_in_test_function;
3 use clippy_utils::ty::is_type_diagnostic_item;
5 use rustc_lint::LateContext;
8 use super::EXPECT_USED;
10 /// lint use of `expect()` or `expect_err` for `Result` and `expect()` for `Option`.
16 allow_expect_in_tests: bool,
18 let obj_ty = cx.typeck_results().expr_ty(recv).peel_refs();
20 let mess = if is_type_diagnostic_item(cx, obj_ty, sym::Option) && !is_err {
21 Some((EXPECT_USED, "an Option", "None", ""))
22 } else if is_type_diagnostic_item(cx, obj_ty, sym::Result) {
23 Some((EXPECT_USED, "a Result", if is_err { "Ok" } else { "Err" }, "an "))
28 let method = if is_err { "expect_err" } else { "expect" };
30 if allow_expect_in_tests && is_in_test_function(cx.tcx, expr.hir_id) {
34 if let Some((lint, kind, none_value, none_prefix)) = mess {
39 &format!("used `{method}()` on `{kind}` value"),
41 &format!("if this value is {none_prefix}`{none_value}`, it will panic"),