1 use crate::consts::{constant, Constant};
2 use crate::utils::usage::mutated_variables;
4 eq_expr_value, higher, match_def_path, meets_msrv, multispan_sugg, paths, snippet, span_lint_and_then,
7 use if_chain::if_chain;
8 use rustc_ast::ast::LitKind;
9 use rustc_hir::def::Res;
10 use rustc_hir::intravisit::{walk_expr, NestedVisitorMap, Visitor};
11 use rustc_hir::BinOpKind;
12 use rustc_hir::{BorrowKind, Expr, ExprKind};
13 use rustc_lint::{LateContext, LateLintPass, LintContext};
14 use rustc_middle::hir::map::Map;
16 use rustc_semver::RustcVersion;
17 use rustc_session::{declare_tool_lint, impl_lint_pass};
18 use rustc_span::source_map::Spanned;
21 const MANUAL_STRIP_MSRV: RustcVersion = RustcVersion::new(1, 45, 0);
23 declare_clippy_lint! {
25 /// Suggests using `strip_{prefix,suffix}` over `str::{starts,ends}_with` and slicing using
26 /// the pattern's length.
28 /// **Why is this bad?**
29 /// Using `str:strip_{prefix,suffix}` is safer and may have better performance as there is no
30 /// slicing which may panic and the compiler does not need to insert this panic code. It is
31 /// also sometimes more readable as it removes the need for duplicating or storing the pattern
32 /// used by `str::{starts,ends}_with` and in the slicing.
34 /// **Known problems:**
40 /// let s = "hello, world!";
41 /// if s.starts_with("hello, ") {
42 /// assert_eq!(s["hello, ".len()..].to_uppercase(), "WORLD!");
47 /// let s = "hello, world!";
48 /// if let Some(end) = s.strip_prefix("hello, ") {
49 /// assert_eq!(end.to_uppercase(), "WORLD!");
54 "suggests using `strip_{prefix,suffix}` over `str::{starts,ends}_with` and slicing"
57 pub struct ManualStrip {
58 msrv: Option<RustcVersion>,
63 pub fn new(msrv: Option<RustcVersion>) -> Self {
68 impl_lint_pass!(ManualStrip => [MANUAL_STRIP]);
70 #[derive(Clone, Copy, Debug, Eq, PartialEq)]
76 impl<'tcx> LateLintPass<'tcx> for ManualStrip {
77 fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
78 if !meets_msrv(self.msrv.as_ref(), &MANUAL_STRIP_MSRV) {
83 if let ExprKind::If(cond, then, _) = &expr.kind;
84 if let ExprKind::MethodCall(_, _, [target_arg, pattern], _) = cond.kind;
85 if let Some(method_def_id) = cx.typeck_results().type_dependent_def_id(cond.hir_id);
86 if let ExprKind::Path(target_path) = &target_arg.kind;
88 let strip_kind = if match_def_path(cx, method_def_id, &paths::STR_STARTS_WITH) {
90 } else if match_def_path(cx, method_def_id, &paths::STR_ENDS_WITH) {
95 let target_res = cx.qpath_res(&target_path, target_arg.hir_id);
96 if target_res == Res::Err {
101 if let Res::Local(hir_id) = target_res;
102 if let Some(used_mutably) = mutated_variables(then, cx);
103 if used_mutably.contains(&hir_id);
109 let strippings = find_stripping(cx, strip_kind, target_res, pattern, then);
110 if !strippings.is_empty() {
112 let kind_word = match strip_kind {
113 StripKind::Prefix => "prefix",
114 StripKind::Suffix => "suffix",
117 let test_span = expr.span.until(then.span);
118 span_lint_and_then(cx, MANUAL_STRIP, strippings[0], &format!("stripping a {} manually", kind_word), |diag| {
119 diag.span_note(test_span, &format!("the {} was tested here", kind_word));
122 &format!("try using the `strip_{}` method", kind_word),
124 format!("if let Some(<stripped>) = {}.strip_{}({}) ",
125 snippet(cx, target_arg.span, ".."),
127 snippet(cx, pattern.span, "..")))]
128 .into_iter().chain(strippings.into_iter().map(|span| (span, "<stripped>".into()))),
136 extract_msrv_attr!(LateContext);
139 // Returns `Some(arg)` if `expr` matches `arg.len()` and `None` otherwise.
140 fn len_arg<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) -> Option<&'tcx Expr<'tcx>> {
142 if let ExprKind::MethodCall(_, _, [arg], _) = expr.kind;
143 if let Some(method_def_id) = cx.typeck_results().type_dependent_def_id(expr.hir_id);
144 if match_def_path(cx, method_def_id, &paths::STR_LEN);
153 // Returns the length of the `expr` if it's a constant string or char.
154 fn constant_length(cx: &LateContext<'_>, expr: &Expr<'_>) -> Option<u128> {
155 let (value, _) = constant(cx, cx.typeck_results(), expr)?;
157 Constant::Str(value) => Some(value.len() as u128),
158 Constant::Char(value) => Some(value.len_utf8() as u128),
163 // Tests if `expr` equals the length of the pattern.
164 fn eq_pattern_length<'tcx>(cx: &LateContext<'tcx>, pattern: &Expr<'_>, expr: &'tcx Expr<'_>) -> bool {
165 if let ExprKind::Lit(Spanned {
166 node: LitKind::Int(n, _),
170 constant_length(cx, pattern).map_or(false, |length| length == n)
172 len_arg(cx, expr).map_or(false, |arg| eq_expr_value(cx, pattern, arg))
176 // Tests if `expr` is a `&str`.
177 fn is_ref_str(cx: &LateContext<'_>, expr: &Expr<'_>) -> bool {
178 match cx.typeck_results().expr_ty_adjusted(&expr).kind() {
179 ty::Ref(_, ty, _) => ty.is_str(),
184 // Removes the outer `AddrOf` expression if needed.
185 fn peel_ref<'a>(expr: &'a Expr<'_>) -> &'a Expr<'a> {
186 if let ExprKind::AddrOf(BorrowKind::Ref, _, unref) = &expr.kind {
193 // Find expressions where `target` is stripped using the length of `pattern`.
194 // We'll suggest replacing these expressions with the result of the `strip_{prefix,suffix}`
196 fn find_stripping<'tcx>(
197 cx: &LateContext<'tcx>,
198 strip_kind: StripKind,
200 pattern: &'tcx Expr<'_>,
201 expr: &'tcx Expr<'_>,
203 struct StrippingFinder<'a, 'tcx> {
204 cx: &'a LateContext<'tcx>,
205 strip_kind: StripKind,
207 pattern: &'tcx Expr<'tcx>,
211 impl<'a, 'tcx> Visitor<'tcx> for StrippingFinder<'a, 'tcx> {
212 type Map = Map<'tcx>;
213 fn nested_visit_map(&mut self) -> NestedVisitorMap<Self::Map> {
214 NestedVisitorMap::None
217 fn visit_expr(&mut self, ex: &'tcx Expr<'_>) {
219 if is_ref_str(self.cx, ex);
220 let unref = peel_ref(ex);
221 if let ExprKind::Index(indexed, index) = &unref.kind;
222 if let Some(higher::Range { start, end, .. }) = higher::range(index);
223 if let ExprKind::Path(path) = &indexed.kind;
224 if self.cx.qpath_res(path, ex.hir_id) == self.target;
226 match (self.strip_kind, start, end) {
227 (StripKind::Prefix, Some(start), None) => {
228 if eq_pattern_length(self.cx, self.pattern, start) {
229 self.results.push(ex.span);
233 (StripKind::Suffix, None, Some(end)) => {
235 if let ExprKind::Binary(Spanned { node: BinOpKind::Sub, .. }, left, right) = end.kind;
236 if let Some(left_arg) = len_arg(self.cx, left);
237 if let ExprKind::Path(left_path) = &left_arg.kind;
238 if self.cx.qpath_res(left_path, left_arg.hir_id) == self.target;
239 if eq_pattern_length(self.cx, self.pattern, right);
241 self.results.push(ex.span);
255 let mut finder = StrippingFinder {
262 walk_expr(&mut finder, expr);