1 use clippy_utils::diagnostics::span_lint_and_sugg;
2 use clippy_utils::in_macro;
3 use clippy_utils::source::snippet;
4 use hir::def::{DefKind, Res};
5 use if_chain::if_chain;
7 use rustc_data_structures::fx::{FxHashMap, FxHashSet};
8 use rustc_errors::Applicability;
10 use rustc_lint::{LateContext, LateLintPass, LintContext};
11 use rustc_session::{declare_tool_lint, impl_lint_pass};
12 use rustc_span::{edition::Edition, sym, Span};
14 declare_clippy_lint! {
16 /// Checks for `#[macro_use] use...`.
18 /// ### Why is this bad?
19 /// Since the Rust 2018 edition you can import
20 /// macro's directly, this is considered idiomatic.
27 pub MACRO_USE_IMPORTS,
29 "#[macro_use] is no longer needed"
32 #[derive(Clone, Debug, PartialEq, Eq)]
38 /// `MacroRefData` includes the name of the macro.
39 #[derive(Debug, Clone)]
40 pub struct MacroRefData {
45 pub fn new(name: String) -> Self {
51 #[allow(clippy::module_name_repetitions)]
52 pub struct MacroUseImports {
53 /// the actual import path used and the span of the attribute above it.
54 imports: Vec<(String, Span)>,
55 /// the span of the macro reference, kept to ensure only one reference is used per macro call.
56 collected: FxHashSet<Span>,
57 mac_refs: Vec<MacroRefData>,
60 impl_lint_pass!(MacroUseImports => [MACRO_USE_IMPORTS]);
62 impl MacroUseImports {
63 fn push_unique_macro(&mut self, cx: &LateContext<'_>, span: Span) {
64 let call_site = span.source_callsite();
65 let name = snippet(cx, cx.sess().source_map().span_until_char(call_site, '!'), "_");
66 if let Some(_callee) = span.source_callee() {
67 if !self.collected.contains(&call_site) {
68 let name = if name.contains("::") {
69 name.split("::").last().unwrap().to_string()
74 self.mac_refs.push(MacroRefData::new(name));
75 self.collected.insert(call_site);
80 fn push_unique_macro_pat_ty(&mut self, cx: &LateContext<'_>, span: Span) {
81 let call_site = span.source_callsite();
82 let name = snippet(cx, cx.sess().source_map().span_until_char(call_site, '!'), "_");
83 if let Some(_callee) = span.source_callee() {
84 if !self.collected.contains(&call_site) {
86 .push(MacroRefData::new(name.to_string()));
87 self.collected.insert(call_site);
93 impl<'tcx> LateLintPass<'tcx> for MacroUseImports {
94 fn check_item(&mut self, cx: &LateContext<'_>, item: &hir::Item<'_>) {
96 if cx.sess().opts.edition >= Edition::Edition2018;
97 if let hir::ItemKind::Use(path, _kind) = &item.kind;
98 let attrs = cx.tcx.hir().attrs(item.hir_id());
99 if let Some(mac_attr) = attrs.iter().find(|attr| attr.has_name(sym::macro_use));
100 if let Res::Def(DefKind::Mod, id) = path.res;
103 for kid in cx.tcx.item_children(id).iter() {
104 if let Res::Def(DefKind::Macro(_mac_type), mac_id) = kid.res {
105 let span = mac_attr.span;
106 let def_path = cx.tcx.def_path_str(mac_id);
107 self.imports.push((def_path, span));
111 if in_macro(item.span) {
112 self.push_unique_macro_pat_ty(cx, item.span);
117 fn check_attribute(&mut self, cx: &LateContext<'_>, attr: &ast::Attribute) {
118 if in_macro(attr.span) {
119 self.push_unique_macro(cx, attr.span);
122 fn check_expr(&mut self, cx: &LateContext<'_>, expr: &hir::Expr<'_>) {
123 if in_macro(expr.span) {
124 self.push_unique_macro(cx, expr.span);
127 fn check_stmt(&mut self, cx: &LateContext<'_>, stmt: &hir::Stmt<'_>) {
128 if in_macro(stmt.span) {
129 self.push_unique_macro(cx, stmt.span);
132 fn check_pat(&mut self, cx: &LateContext<'_>, pat: &hir::Pat<'_>) {
133 if in_macro(pat.span) {
134 self.push_unique_macro_pat_ty(cx, pat.span);
137 fn check_ty(&mut self, cx: &LateContext<'_>, ty: &hir::Ty<'_>) {
138 if in_macro(ty.span) {
139 self.push_unique_macro_pat_ty(cx, ty.span);
142 #[allow(clippy::too_many_lines)]
143 fn check_crate_post(&mut self, cx: &LateContext<'_>, _krate: &hir::Crate<'_>) {
144 let mut used = FxHashMap::default();
145 let mut check_dup = vec![];
146 for (import, span) in &self.imports {
147 let found_idx = self.mac_refs.iter().position(|mac| import.ends_with(&mac.name));
149 if let Some(idx) = found_idx {
150 self.mac_refs.remove(idx);
151 let seg = import.split("::").collect::<Vec<_>>();
153 match seg.as_slice() {
154 // an empty path is impossible
155 // a path should always consist of 2 or more segments
158 if !check_dup.contains(&(*item).to_string()) {
159 used.entry(((*root).to_string(), span))
160 .or_insert_with(Vec::new)
161 .push((*item).to_string());
162 check_dup.push((*item).to_string());
165 [root, rest @ ..] => {
166 if rest.iter().all(|item| !check_dup.contains(&(*item).to_string())) {
170 if check_dup.contains(&(*item).to_string()) {
173 Some((*item).to_string())
176 .collect::<Vec<_>>();
177 used.entry(((*root).to_string(), span))
178 .or_insert_with(Vec::new)
179 .push(filtered.join("::"));
180 check_dup.extend(filtered);
182 let rest = rest.to_vec();
183 used.entry(((*root).to_string(), span))
184 .or_insert_with(Vec::new)
185 .push(rest.join("::"));
186 check_dup.extend(rest.iter().map(ToString::to_string));
193 let mut suggestions = vec![];
194 for ((root, span), path) in used {
196 suggestions.push((span, format!("{}::{}", root, path[0])));
198 suggestions.push((span, format!("{}::{{{}}}", root, path.join(", "))));
202 // If mac_refs is not empty we have encountered an import we could not handle
203 // such as `std::prelude::v1::foo` or some other macro that expands to an import.
204 if self.mac_refs.is_empty() {
205 for (span, import) in suggestions {
206 let help = format!("use {};", import);
211 "`macro_use` attributes are no longer needed in the Rust 2018 edition",
212 "remove the attribute and import the macro directly, try",
214 Applicability::MaybeIncorrect,