1 // error-pattern:cargo-clippy
3 #![feature(box_patterns)]
4 #![feature(drain_filter)]
5 #![feature(in_band_lifetimes)]
8 #![feature(rustc_private)]
9 #![feature(stmt_expr_attributes)]
10 #![feature(control_flow_enum)]
11 #![recursion_limit = "512"]
12 #![cfg_attr(feature = "deny-warnings", deny(warnings))]
13 #![allow(clippy::missing_docs_in_private_items, clippy::must_use_candidate)]
14 #![warn(trivial_casts, trivial_numeric_casts)]
15 // warn on lints, that are included in `rust-lang/rust`s bootstrap
16 #![warn(rust_2018_idioms, unused_lifetimes)]
17 // warn on rustc internal lints
18 #![warn(rustc::internal)]
20 // FIXME: switch to something more ergonomic here, once available.
21 // (Currently there is no way to opt into sysroot crates without `extern crate`.)
22 extern crate rustc_ast;
23 extern crate rustc_ast_pretty;
24 extern crate rustc_data_structures;
25 extern crate rustc_driver;
26 extern crate rustc_errors;
27 extern crate rustc_hir;
28 extern crate rustc_hir_pretty;
29 extern crate rustc_index;
30 extern crate rustc_infer;
31 extern crate rustc_lexer;
32 extern crate rustc_lint;
33 extern crate rustc_middle;
34 extern crate rustc_mir_dataflow;
35 extern crate rustc_parse;
36 extern crate rustc_parse_format;
37 extern crate rustc_session;
38 extern crate rustc_span;
39 extern crate rustc_target;
40 extern crate rustc_trait_selection;
41 extern crate rustc_typeck;
44 extern crate clippy_utils;
46 use clippy_utils::parse_msrv;
47 use rustc_data_structures::fx::FxHashSet;
48 use rustc_lint::LintId;
49 use rustc_session::Session;
51 /// Macro used to declare a Clippy lint.
53 /// Every lint declaration consists of 4 parts:
55 /// 1. The documentation, which is used for the website
56 /// 2. The `LINT_NAME`. See [lint naming][lint_naming] on lint naming conventions.
57 /// 3. The `lint_level`, which is a mapping from *one* of our lint groups to `Allow`, `Warn` or
58 /// `Deny`. The lint level here has nothing to do with what lint groups the lint is a part of.
59 /// 4. The `description` that contains a short explanation on what's wrong with code where the
60 /// lint is triggered.
62 /// Currently the categories `style`, `correctness`, `suspicious`, `complexity` and `perf` are
63 /// enabled by default. As said in the README.md of this repository, if the lint level mapping
64 /// changes, please update README.md.
69 /// #![feature(rustc_private)]
70 /// extern crate rustc_session;
71 /// use rustc_session::declare_tool_lint;
72 /// use clippy_lints::declare_clippy_lint;
74 /// declare_clippy_lint! {
75 /// /// ### What it does
76 /// /// Checks for ... (describe what the lint matches).
78 /// /// ### Why is this bad?
79 /// /// Supply the reason for linting the code.
84 /// /// Insert a short example of code that triggers the lint
87 /// /// Insert a short example of improved code that doesn't trigger the lint
94 /// [lint_naming]: https://rust-lang.github.io/rfcs/0344-conventions-galore.html#lints
96 macro_rules! declare_clippy_lint {
97 { $(#[$attr:meta])* pub $name:tt, style, $description:tt } => {
99 $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
102 { $(#[$attr:meta])* pub $name:tt, correctness, $description:tt } => {
104 $(#[$attr])* pub clippy::$name, Deny, $description, report_in_external_macro: true
107 { $(#[$attr:meta])* pub $name:tt, suspicious, $description:tt } => {
109 $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
112 { $(#[$attr:meta])* pub $name:tt, complexity, $description:tt } => {
114 $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
117 { $(#[$attr:meta])* pub $name:tt, perf, $description:tt } => {
119 $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
122 { $(#[$attr:meta])* pub $name:tt, pedantic, $description:tt } => {
124 $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
127 { $(#[$attr:meta])* pub $name:tt, restriction, $description:tt } => {
129 $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
132 { $(#[$attr:meta])* pub $name:tt, cargo, $description:tt } => {
134 $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
137 { $(#[$attr:meta])* pub $name:tt, nursery, $description:tt } => {
139 $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
142 { $(#[$attr:meta])* pub $name:tt, internal, $description:tt } => {
144 $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
147 { $(#[$attr:meta])* pub $name:tt, internal_warn, $description:tt } => {
149 $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
154 #[cfg(feature = "metadata-collector-lint")]
155 mod deprecated_lints;
158 // begin lints modules, do not remove this comment, it’s used in `update_lints`
159 mod absurd_extreme_comparisons;
164 mod assertions_on_constants;
166 mod async_yields_async;
168 mod await_holding_invalid;
170 mod blacklisted_name;
171 mod blocks_in_if_conditions;
172 mod bool_assert_comparison;
175 mod cargo_common_metadata;
176 mod case_sensitive_file_extension_comparisons;
178 mod checked_conversions;
179 mod cognitive_complexity;
181 mod collapsible_match;
182 mod comparison_chain;
188 mod default_numeric_fallback;
192 mod disallowed_method;
193 mod disallowed_script_idents;
196 mod double_comparison;
200 mod else_if_without_else;
206 mod equatable_if_let;
210 mod eval_order_dependence;
212 mod exhaustive_items;
215 mod fallible_impl_from;
217 mod float_equality_without_abs;
219 mod floating_point_arithmetic;
223 mod from_str_radix_10;
226 mod get_last_with_len;
231 mod if_then_some_else_none;
234 mod implicit_saturating_sub;
235 mod inconsistent_struct_constructor;
236 mod indexing_slicing;
239 mod inherent_to_string;
240 mod inline_fn_without_body;
242 mod integer_division;
243 mod invalid_upcast_comparisons;
244 mod items_after_statements;
245 mod iter_not_returning_iterator;
246 mod large_const_arrays;
247 mod large_enum_variant;
248 mod large_stack_arrays;
253 mod literal_representation;
259 mod manual_non_exhaustive;
262 mod manual_unwrap_or;
266 mod match_on_vec_items;
275 mod missing_const_for_fn;
277 mod missing_enforced_import_rename;
280 mod modulo_arithmetic;
281 mod multiple_crate_versions;
286 mod mutable_debug_assertion;
288 mod needless_arbitrary_self_type;
289 mod needless_bitwise_bool;
292 mod needless_borrowed_ref;
293 mod needless_continue;
294 mod needless_for_each;
295 mod needless_option_as_deref;
296 mod needless_pass_by_value;
297 mod needless_question_mark;
299 mod neg_cmp_op_on_partial_ord;
301 mod new_without_default;
304 mod non_expressive_names;
305 mod non_octal_unix_permissions;
306 mod non_send_fields_in_send_ty;
307 mod nonstandard_macro_braces;
309 mod option_env_unwrap;
310 mod option_if_let_else;
311 mod overflow_check_conditional;
312 mod panic_in_result_fn;
313 mod panic_unimplemented;
314 mod partialeq_ne_impl;
315 mod pass_by_ref_or_value;
316 mod path_buf_push_overwrite;
317 mod pattern_type_mismatch;
321 mod ptr_offset_with_cast;
325 mod redundant_closure_call;
327 mod redundant_field_names;
328 mod redundant_pub_crate;
329 mod redundant_slicing;
330 mod redundant_static_lifetimes;
336 mod same_name_method;
338 mod self_named_constructors;
339 mod semicolon_if_nothing_returned;
342 mod single_component_path_imports;
343 mod size_of_in_element_count;
344 mod slow_vector_initialization;
345 mod stable_sort_primitive;
347 mod strlen_on_c_strings;
348 mod suspicious_operation_groupings;
349 mod suspicious_trait_impl;
351 mod tabs_in_doc_comments;
352 mod temporary_assignment;
353 mod to_digit_is_some;
354 mod to_string_in_display;
357 mod transmuting_null;
360 mod undropped_manually_drops;
362 mod unit_return_expecting_ord;
365 mod unnecessary_self_imports;
366 mod unnecessary_sort_by;
367 mod unnecessary_wraps;
368 mod unnested_or_patterns;
369 mod unsafe_removed_from_name;
371 mod unused_io_amount;
375 mod unwrap_in_result;
376 mod upper_case_acronyms;
378 mod useless_conversion;
380 mod vec_init_then_push;
381 mod vec_resize_to_zero;
382 mod verbose_file_reads;
383 mod wildcard_dependencies;
384 mod wildcard_imports;
387 mod zero_sized_map_values;
388 // end lints modules, do not remove this comment, it’s used in `update_lints`
390 pub use crate::utils::conf::Conf;
391 use crate::utils::conf::TryConf;
393 /// Register all pre expansion lints
395 /// Pre-expansion lints run before any macro expansion has happened.
397 /// Note that due to the architecture of the compiler, currently `cfg_attr` attributes on crate
398 /// level (i.e `#![cfg_attr(...)]`) will still be expanded even when using a pre-expansion pass.
400 /// Used in `./src/driver.rs`.
401 pub fn register_pre_expansion_lints(store: &mut rustc_lint::LintStore) {
402 // NOTE: Do not add any more pre-expansion passes. These should be removed eventually.
403 store.register_pre_expansion_pass(|| Box::new(write::Write::default()));
404 store.register_pre_expansion_pass(|| Box::new(attrs::EarlyAttributes));
405 store.register_pre_expansion_pass(|| Box::new(dbg_macro::DbgMacro));
409 pub fn read_conf(sess: &Session) -> Conf {
410 let file_name = match utils::conf::lookup_conf_file() {
411 Ok(Some(path)) => path,
412 Ok(None) => return Conf::default(),
414 sess.struct_err(&format!("error finding Clippy's configuration file: {}", error))
416 return Conf::default();
420 let TryConf { conf, errors } = utils::conf::read(&file_name);
421 // all conf errors are non-fatal, we just use the default conf in case of error
422 for error in errors {
423 sess.struct_err(&format!(
424 "error reading Clippy's configuration file `{}`: {}",
434 /// Register all lints and lint groups with the rustc plugin registry
436 /// Used in `./src/driver.rs`.
437 #[allow(clippy::too_many_lines)]
439 pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf: &Conf) {
440 register_removed_non_tool_lints(store);
442 include!("lib.deprecated.rs");
444 include!("lib.register_lints.rs");
445 include!("lib.register_restriction.rs");
446 include!("lib.register_pedantic.rs");
448 #[cfg(feature = "internal-lints")]
449 include!("lib.register_internal.rs");
451 include!("lib.register_all.rs");
452 include!("lib.register_style.rs");
453 include!("lib.register_complexity.rs");
454 include!("lib.register_correctness.rs");
455 include!("lib.register_suspicious.rs");
456 include!("lib.register_perf.rs");
457 include!("lib.register_cargo.rs");
458 include!("lib.register_nursery.rs");
460 #[cfg(feature = "metadata-collector-lint")]
462 if std::env::var("ENABLE_METADATA_COLLECTION").eq(&Ok("1".to_string())) {
463 store.register_late_pass(|| Box::new(utils::internal_lints::metadata_collector::MetadataCollector::new()));
468 // all the internal lints
469 #[cfg(feature = "internal-lints")]
471 store.register_early_pass(|| Box::new(utils::internal_lints::ClippyLintsInternal));
472 store.register_early_pass(|| Box::new(utils::internal_lints::ProduceIce));
473 store.register_late_pass(|| Box::new(utils::inspector::DeepCodeInspector));
474 store.register_late_pass(|| Box::new(utils::internal_lints::CollapsibleCalls));
475 store.register_late_pass(|| Box::new(utils::internal_lints::CompilerLintFunctions::new()));
476 store.register_late_pass(|| Box::new(utils::internal_lints::IfChainStyle));
477 store.register_late_pass(|| Box::new(utils::internal_lints::InvalidPaths));
478 store.register_late_pass(|| Box::new(utils::internal_lints::InterningDefinedSymbol::default()));
479 store.register_late_pass(|| Box::new(utils::internal_lints::LintWithoutLintPass::default()));
480 store.register_late_pass(|| Box::new(utils::internal_lints::MatchTypeOnDiagItem));
481 store.register_late_pass(|| Box::new(utils::internal_lints::OuterExpnDataPass));
484 store.register_late_pass(|| Box::new(utils::author::Author));
485 store.register_late_pass(|| Box::new(await_holding_invalid::AwaitHolding));
486 store.register_late_pass(|| Box::new(serde_api::SerdeApi));
487 let vec_box_size_threshold = conf.vec_box_size_threshold;
488 let type_complexity_threshold = conf.type_complexity_threshold;
489 let avoid_breaking_exported_api = conf.avoid_breaking_exported_api;
490 store.register_late_pass(move || Box::new(types::Types::new(
491 vec_box_size_threshold,
492 type_complexity_threshold,
493 avoid_breaking_exported_api,
495 store.register_late_pass(|| Box::new(booleans::NonminimalBool));
496 store.register_late_pass(|| Box::new(needless_bitwise_bool::NeedlessBitwiseBool));
497 store.register_late_pass(|| Box::new(eq_op::EqOp));
498 store.register_late_pass(|| Box::new(enum_clike::UnportableVariant));
499 store.register_late_pass(|| Box::new(float_literal::FloatLiteral));
500 let verbose_bit_mask_threshold = conf.verbose_bit_mask_threshold;
501 store.register_late_pass(move || Box::new(bit_mask::BitMask::new(verbose_bit_mask_threshold)));
502 store.register_late_pass(|| Box::new(ptr::Ptr));
503 store.register_late_pass(|| Box::new(ptr_eq::PtrEq));
504 store.register_late_pass(|| Box::new(needless_bool::NeedlessBool));
505 store.register_late_pass(|| Box::new(needless_option_as_deref::OptionNeedlessDeref));
506 store.register_late_pass(|| Box::new(needless_bool::BoolComparison));
507 store.register_late_pass(|| Box::new(needless_for_each::NeedlessForEach));
508 store.register_late_pass(|| Box::new(misc::MiscLints));
509 store.register_late_pass(|| Box::new(eta_reduction::EtaReduction));
510 store.register_late_pass(|| Box::new(identity_op::IdentityOp));
511 store.register_late_pass(|| Box::new(erasing_op::ErasingOp));
512 store.register_late_pass(|| Box::new(mut_mut::MutMut));
513 store.register_late_pass(|| Box::new(mut_reference::UnnecessaryMutPassed));
514 store.register_late_pass(|| Box::new(len_zero::LenZero));
515 store.register_late_pass(|| Box::new(attrs::Attributes));
516 store.register_late_pass(|| Box::new(blocks_in_if_conditions::BlocksInIfConditions));
517 store.register_late_pass(|| Box::new(collapsible_match::CollapsibleMatch));
518 store.register_late_pass(|| Box::new(unicode::Unicode));
519 store.register_late_pass(|| Box::new(unit_return_expecting_ord::UnitReturnExpectingOrd));
520 store.register_late_pass(|| Box::new(strings::StringAdd));
521 store.register_late_pass(|| Box::new(implicit_return::ImplicitReturn));
522 store.register_late_pass(|| Box::new(implicit_saturating_sub::ImplicitSaturatingSub));
523 store.register_late_pass(|| Box::new(default_numeric_fallback::DefaultNumericFallback));
524 store.register_late_pass(|| Box::new(inconsistent_struct_constructor::InconsistentStructConstructor));
525 store.register_late_pass(|| Box::new(non_octal_unix_permissions::NonOctalUnixPermissions));
526 store.register_early_pass(|| Box::new(unnecessary_self_imports::UnnecessarySelfImports));
528 let msrv = conf.msrv.as_ref().and_then(|s| {
529 parse_msrv(s, None, None).or_else(|| {
530 sess.err(&format!("error reading Clippy's configuration file. `{}` is not a valid Rust version", s));
535 let avoid_breaking_exported_api = conf.avoid_breaking_exported_api;
536 store.register_late_pass(move || Box::new(approx_const::ApproxConstant::new(msrv)));
537 store.register_late_pass(move || Box::new(methods::Methods::new(avoid_breaking_exported_api, msrv)));
538 store.register_late_pass(move || Box::new(matches::Matches::new(msrv)));
539 store.register_early_pass(move || Box::new(manual_non_exhaustive::ManualNonExhaustive::new(msrv)));
540 store.register_late_pass(move || Box::new(manual_strip::ManualStrip::new(msrv)));
541 store.register_early_pass(move || Box::new(redundant_static_lifetimes::RedundantStaticLifetimes::new(msrv)));
542 store.register_early_pass(move || Box::new(redundant_field_names::RedundantFieldNames::new(msrv)));
543 store.register_late_pass(move || Box::new(checked_conversions::CheckedConversions::new(msrv)));
544 store.register_late_pass(move || Box::new(mem_replace::MemReplace::new(msrv)));
545 store.register_late_pass(move || Box::new(ranges::Ranges::new(msrv)));
546 store.register_late_pass(move || Box::new(from_over_into::FromOverInto::new(msrv)));
547 store.register_late_pass(move || Box::new(use_self::UseSelf::new(msrv)));
548 store.register_late_pass(move || Box::new(missing_const_for_fn::MissingConstForFn::new(msrv)));
549 store.register_late_pass(move || Box::new(needless_question_mark::NeedlessQuestionMark));
550 store.register_late_pass(move || Box::new(casts::Casts::new(msrv)));
551 store.register_early_pass(move || Box::new(unnested_or_patterns::UnnestedOrPatterns::new(msrv)));
553 store.register_late_pass(|| Box::new(size_of_in_element_count::SizeOfInElementCount));
554 store.register_late_pass(|| Box::new(same_name_method::SameNameMethod));
555 store.register_late_pass(|| Box::new(map_clone::MapClone));
556 store.register_late_pass(|| Box::new(map_err_ignore::MapErrIgnore));
557 store.register_late_pass(|| Box::new(shadow::Shadow::default()));
558 store.register_late_pass(|| Box::new(unit_types::UnitTypes));
559 store.register_late_pass(|| Box::new(loops::Loops));
560 store.register_late_pass(|| Box::new(main_recursion::MainRecursion::default()));
561 store.register_late_pass(|| Box::new(lifetimes::Lifetimes));
562 store.register_late_pass(|| Box::new(entry::HashMapPass));
563 store.register_late_pass(|| Box::new(minmax::MinMaxPass));
564 store.register_late_pass(|| Box::new(open_options::OpenOptions));
565 store.register_late_pass(|| Box::new(zero_div_zero::ZeroDiv));
566 store.register_late_pass(|| Box::new(mutex_atomic::Mutex));
567 store.register_late_pass(|| Box::new(needless_update::NeedlessUpdate));
568 store.register_late_pass(|| Box::new(needless_borrow::NeedlessBorrow::default()));
569 store.register_late_pass(|| Box::new(needless_borrowed_ref::NeedlessBorrowedRef));
570 store.register_late_pass(|| Box::new(no_effect::NoEffect));
571 store.register_late_pass(|| Box::new(temporary_assignment::TemporaryAssignment));
572 store.register_late_pass(|| Box::new(transmute::Transmute));
573 let cognitive_complexity_threshold = conf.cognitive_complexity_threshold;
574 store.register_late_pass(move || Box::new(cognitive_complexity::CognitiveComplexity::new(cognitive_complexity_threshold)));
575 let too_large_for_stack = conf.too_large_for_stack;
576 store.register_late_pass(move || Box::new(escape::BoxedLocal{too_large_for_stack}));
577 store.register_late_pass(move || Box::new(vec::UselessVec{too_large_for_stack}));
578 store.register_late_pass(|| Box::new(panic_unimplemented::PanicUnimplemented));
579 store.register_late_pass(|| Box::new(strings::StringLitAsBytes));
580 store.register_late_pass(|| Box::new(derive::Derive));
581 store.register_late_pass(|| Box::new(derivable_impls::DerivableImpls));
582 store.register_late_pass(|| Box::new(get_last_with_len::GetLastWithLen));
583 store.register_late_pass(|| Box::new(drop_forget_ref::DropForgetRef));
584 store.register_late_pass(|| Box::new(empty_enum::EmptyEnum));
585 store.register_late_pass(|| Box::new(absurd_extreme_comparisons::AbsurdExtremeComparisons));
586 store.register_late_pass(|| Box::new(invalid_upcast_comparisons::InvalidUpcastComparisons));
587 store.register_late_pass(|| Box::new(regex::Regex));
588 store.register_late_pass(|| Box::new(copies::CopyAndPaste));
589 store.register_late_pass(|| Box::new(copy_iterator::CopyIterator));
590 store.register_late_pass(|| Box::new(format::UselessFormat));
591 store.register_late_pass(|| Box::new(swap::Swap));
592 store.register_late_pass(|| Box::new(overflow_check_conditional::OverflowCheckConditional));
593 store.register_late_pass(|| Box::new(new_without_default::NewWithoutDefault::default()));
594 let blacklisted_names = conf.blacklisted_names.iter().cloned().collect::<FxHashSet<_>>();
595 store.register_late_pass(move || Box::new(blacklisted_name::BlacklistedName::new(blacklisted_names.clone())));
596 let too_many_arguments_threshold = conf.too_many_arguments_threshold;
597 let too_many_lines_threshold = conf.too_many_lines_threshold;
598 store.register_late_pass(move || Box::new(functions::Functions::new(too_many_arguments_threshold, too_many_lines_threshold)));
599 let doc_valid_idents = conf.doc_valid_idents.iter().cloned().collect::<FxHashSet<_>>();
600 store.register_late_pass(move || Box::new(doc::DocMarkdown::new(doc_valid_idents.clone())));
601 store.register_late_pass(|| Box::new(neg_multiply::NegMultiply));
602 store.register_late_pass(|| Box::new(mem_forget::MemForget));
603 store.register_late_pass(|| Box::new(arithmetic::Arithmetic::default()));
604 store.register_late_pass(|| Box::new(assign_ops::AssignOps));
605 store.register_late_pass(|| Box::new(let_if_seq::LetIfSeq));
606 store.register_late_pass(|| Box::new(eval_order_dependence::EvalOrderDependence));
607 store.register_late_pass(|| Box::new(missing_doc::MissingDoc::new()));
608 store.register_late_pass(|| Box::new(missing_inline::MissingInline));
609 store.register_late_pass(move || Box::new(exhaustive_items::ExhaustiveItems));
610 store.register_late_pass(|| Box::new(match_result_ok::MatchResultOk));
611 store.register_late_pass(|| Box::new(partialeq_ne_impl::PartialEqNeImpl));
612 store.register_late_pass(|| Box::new(unused_io_amount::UnusedIoAmount));
613 let enum_variant_size_threshold = conf.enum_variant_size_threshold;
614 store.register_late_pass(move || Box::new(large_enum_variant::LargeEnumVariant::new(enum_variant_size_threshold)));
615 store.register_late_pass(|| Box::new(explicit_write::ExplicitWrite));
616 store.register_late_pass(|| Box::new(needless_pass_by_value::NeedlessPassByValue));
617 let pass_by_ref_or_value = pass_by_ref_or_value::PassByRefOrValue::new(
618 conf.trivial_copy_size_limit,
619 conf.pass_by_value_size_limit,
620 conf.avoid_breaking_exported_api,
623 store.register_late_pass(move || Box::new(pass_by_ref_or_value));
624 store.register_late_pass(|| Box::new(ref_option_ref::RefOptionRef));
625 store.register_late_pass(|| Box::new(try_err::TryErr));
626 store.register_late_pass(|| Box::new(bytecount::ByteCount));
627 store.register_late_pass(|| Box::new(infinite_iter::InfiniteIter));
628 store.register_late_pass(|| Box::new(inline_fn_without_body::InlineFnWithoutBody));
629 store.register_late_pass(|| Box::new(useless_conversion::UselessConversion::default()));
630 store.register_late_pass(|| Box::new(implicit_hasher::ImplicitHasher));
631 store.register_late_pass(|| Box::new(fallible_impl_from::FallibleImplFrom));
632 store.register_late_pass(|| Box::new(double_comparison::DoubleComparisons));
633 store.register_late_pass(|| Box::new(question_mark::QuestionMark));
634 store.register_early_pass(|| Box::new(suspicious_operation_groupings::SuspiciousOperationGroupings));
635 store.register_late_pass(|| Box::new(suspicious_trait_impl::SuspiciousImpl));
636 store.register_late_pass(|| Box::new(map_unit_fn::MapUnit));
637 store.register_late_pass(|| Box::new(inherent_impl::MultipleInherentImpl));
638 store.register_late_pass(|| Box::new(neg_cmp_op_on_partial_ord::NoNegCompOpForPartialOrd));
639 store.register_late_pass(|| Box::new(unwrap::Unwrap));
640 store.register_late_pass(|| Box::new(duration_subsec::DurationSubsec));
641 store.register_late_pass(|| Box::new(indexing_slicing::IndexingSlicing));
642 store.register_late_pass(|| Box::new(non_copy_const::NonCopyConst));
643 store.register_late_pass(|| Box::new(ptr_offset_with_cast::PtrOffsetWithCast));
644 store.register_late_pass(|| Box::new(redundant_clone::RedundantClone));
645 store.register_late_pass(|| Box::new(slow_vector_initialization::SlowVectorInit));
646 store.register_late_pass(|| Box::new(unnecessary_sort_by::UnnecessarySortBy));
647 store.register_late_pass(move || Box::new(unnecessary_wraps::UnnecessaryWraps::new(avoid_breaking_exported_api)));
648 store.register_late_pass(|| Box::new(assertions_on_constants::AssertionsOnConstants));
649 store.register_late_pass(|| Box::new(transmuting_null::TransmutingNull));
650 store.register_late_pass(|| Box::new(path_buf_push_overwrite::PathBufPushOverwrite));
651 store.register_late_pass(|| Box::new(integer_division::IntegerDivision));
652 store.register_late_pass(|| Box::new(inherent_to_string::InherentToString));
653 let max_trait_bounds = conf.max_trait_bounds;
654 store.register_late_pass(move || Box::new(trait_bounds::TraitBounds::new(max_trait_bounds)));
655 store.register_late_pass(|| Box::new(comparison_chain::ComparisonChain));
656 store.register_late_pass(|| Box::new(mut_key::MutableKeyType));
657 store.register_late_pass(|| Box::new(modulo_arithmetic::ModuloArithmetic));
658 store.register_early_pass(|| Box::new(reference::DerefAddrOf));
659 store.register_early_pass(|| Box::new(reference::RefInDeref));
660 store.register_early_pass(|| Box::new(double_parens::DoubleParens));
661 store.register_late_pass(|| Box::new(to_string_in_display::ToStringInDisplay::new()));
662 store.register_early_pass(|| Box::new(unsafe_removed_from_name::UnsafeNameRemoval));
663 store.register_early_pass(|| Box::new(if_not_else::IfNotElse));
664 store.register_early_pass(|| Box::new(else_if_without_else::ElseIfWithoutElse));
665 store.register_early_pass(|| Box::new(int_plus_one::IntPlusOne));
666 store.register_early_pass(|| Box::new(formatting::Formatting));
667 store.register_early_pass(|| Box::new(misc_early::MiscEarlyLints));
668 store.register_early_pass(|| Box::new(redundant_closure_call::RedundantClosureCall));
669 store.register_late_pass(|| Box::new(redundant_closure_call::RedundantClosureCall));
670 store.register_early_pass(|| Box::new(unused_unit::UnusedUnit));
671 store.register_late_pass(|| Box::new(returns::Return));
672 store.register_early_pass(|| Box::new(collapsible_if::CollapsibleIf));
673 store.register_early_pass(|| Box::new(items_after_statements::ItemsAfterStatements));
674 store.register_early_pass(|| Box::new(precedence::Precedence));
675 store.register_early_pass(|| Box::new(needless_continue::NeedlessContinue));
676 store.register_early_pass(|| Box::new(redundant_else::RedundantElse));
677 store.register_late_pass(|| Box::new(create_dir::CreateDir));
678 store.register_early_pass(|| Box::new(needless_arbitrary_self_type::NeedlessArbitrarySelfType));
679 let cargo_ignore_publish = conf.cargo_ignore_publish;
680 store.register_late_pass(move || Box::new(cargo_common_metadata::CargoCommonMetadata::new(cargo_ignore_publish)));
681 store.register_late_pass(|| Box::new(multiple_crate_versions::MultipleCrateVersions));
682 store.register_late_pass(|| Box::new(wildcard_dependencies::WildcardDependencies));
683 let literal_representation_lint_fraction_readability = conf.unreadable_literal_lint_fractions;
684 store.register_early_pass(move || Box::new(literal_representation::LiteralDigitGrouping::new(literal_representation_lint_fraction_readability)));
685 let literal_representation_threshold = conf.literal_representation_threshold;
686 store.register_early_pass(move || Box::new(literal_representation::DecimalLiteralRepresentation::new(literal_representation_threshold)));
687 let enum_variant_name_threshold = conf.enum_variant_name_threshold;
688 store.register_late_pass(move || Box::new(enum_variants::EnumVariantNames::new(enum_variant_name_threshold, avoid_breaking_exported_api)));
689 store.register_early_pass(|| Box::new(tabs_in_doc_comments::TabsInDocComments));
690 let upper_case_acronyms_aggressive = conf.upper_case_acronyms_aggressive;
691 store.register_late_pass(move || Box::new(upper_case_acronyms::UpperCaseAcronyms::new(avoid_breaking_exported_api, upper_case_acronyms_aggressive)));
692 store.register_late_pass(|| Box::new(default::Default::default()));
693 store.register_late_pass(|| Box::new(unused_self::UnusedSelf));
694 store.register_late_pass(|| Box::new(mutable_debug_assertion::DebugAssertWithMutCall));
695 store.register_late_pass(|| Box::new(exit::Exit));
696 store.register_late_pass(|| Box::new(to_digit_is_some::ToDigitIsSome));
697 let array_size_threshold = conf.array_size_threshold;
698 store.register_late_pass(move || Box::new(large_stack_arrays::LargeStackArrays::new(array_size_threshold)));
699 store.register_late_pass(move || Box::new(large_const_arrays::LargeConstArrays::new(array_size_threshold)));
700 store.register_late_pass(|| Box::new(floating_point_arithmetic::FloatingPointArithmetic));
701 store.register_early_pass(|| Box::new(as_conversions::AsConversions));
702 store.register_late_pass(|| Box::new(let_underscore::LetUnderscore));
703 store.register_early_pass(|| Box::new(single_component_path_imports::SingleComponentPathImports));
704 let max_fn_params_bools = conf.max_fn_params_bools;
705 let max_struct_bools = conf.max_struct_bools;
706 store.register_early_pass(move || Box::new(excessive_bools::ExcessiveBools::new(max_struct_bools, max_fn_params_bools)));
707 store.register_early_pass(|| Box::new(option_env_unwrap::OptionEnvUnwrap));
708 let warn_on_all_wildcard_imports = conf.warn_on_all_wildcard_imports;
709 store.register_late_pass(move || Box::new(wildcard_imports::WildcardImports::new(warn_on_all_wildcard_imports)));
710 store.register_late_pass(|| Box::new(verbose_file_reads::VerboseFileReads));
711 store.register_late_pass(|| Box::new(redundant_pub_crate::RedundantPubCrate::default()));
712 store.register_late_pass(|| Box::new(unnamed_address::UnnamedAddress));
713 store.register_late_pass(|| Box::new(dereference::Dereferencing::default()));
714 store.register_late_pass(|| Box::new(option_if_let_else::OptionIfLetElse));
715 store.register_late_pass(|| Box::new(future_not_send::FutureNotSend));
716 store.register_late_pass(|| Box::new(if_let_mutex::IfLetMutex));
717 store.register_late_pass(|| Box::new(equatable_if_let::PatternEquality));
718 store.register_late_pass(|| Box::new(mut_mutex_lock::MutMutexLock));
719 store.register_late_pass(|| Box::new(match_on_vec_items::MatchOnVecItems));
720 store.register_late_pass(|| Box::new(manual_async_fn::ManualAsyncFn));
721 store.register_late_pass(|| Box::new(vec_resize_to_zero::VecResizeToZero));
722 store.register_late_pass(|| Box::new(panic_in_result_fn::PanicInResultFn));
723 let single_char_binding_names_threshold = conf.single_char_binding_names_threshold;
724 store.register_early_pass(move || Box::new(non_expressive_names::NonExpressiveNames {
725 single_char_binding_names_threshold,
727 let macro_matcher = conf.standard_macro_braces.iter().cloned().collect::<FxHashSet<_>>();
728 store.register_early_pass(move || Box::new(nonstandard_macro_braces::MacroBraces::new(¯o_matcher)));
729 store.register_late_pass(|| Box::new(macro_use::MacroUseImports::default()));
730 store.register_late_pass(|| Box::new(pattern_type_mismatch::PatternTypeMismatch));
731 store.register_late_pass(|| Box::new(stable_sort_primitive::StableSortPrimitive));
732 store.register_late_pass(|| Box::new(repeat_once::RepeatOnce));
733 store.register_late_pass(|| Box::new(unwrap_in_result::UnwrapInResult));
734 store.register_late_pass(|| Box::new(self_assignment::SelfAssignment));
735 store.register_late_pass(|| Box::new(manual_unwrap_or::ManualUnwrapOr));
736 store.register_late_pass(|| Box::new(manual_ok_or::ManualOkOr));
737 store.register_late_pass(|| Box::new(float_equality_without_abs::FloatEqualityWithoutAbs));
738 store.register_late_pass(|| Box::new(semicolon_if_nothing_returned::SemicolonIfNothingReturned));
739 store.register_late_pass(|| Box::new(async_yields_async::AsyncYieldsAsync));
740 let disallowed_methods = conf.disallowed_methods.clone();
741 store.register_late_pass(move || Box::new(disallowed_method::DisallowedMethod::new(disallowed_methods.clone())));
742 store.register_early_pass(|| Box::new(asm_syntax::InlineAsmX86AttSyntax));
743 store.register_early_pass(|| Box::new(asm_syntax::InlineAsmX86IntelSyntax));
744 store.register_late_pass(|| Box::new(undropped_manually_drops::UndroppedManuallyDrops));
745 store.register_late_pass(|| Box::new(strings::StrToString));
746 store.register_late_pass(|| Box::new(strings::StringToString));
747 store.register_late_pass(|| Box::new(zero_sized_map_values::ZeroSizedMapValues));
748 store.register_late_pass(|| Box::new(vec_init_then_push::VecInitThenPush::default()));
749 store.register_late_pass(|| Box::new(case_sensitive_file_extension_comparisons::CaseSensitiveFileExtensionComparisons));
750 store.register_late_pass(|| Box::new(redundant_slicing::RedundantSlicing));
751 store.register_late_pass(|| Box::new(from_str_radix_10::FromStrRadix10));
752 store.register_late_pass(|| Box::new(manual_map::ManualMap));
753 store.register_late_pass(move || Box::new(if_then_some_else_none::IfThenSomeElseNone::new(msrv)));
754 store.register_late_pass(|| Box::new(bool_assert_comparison::BoolAssertComparison));
755 store.register_early_pass(move || Box::new(module_style::ModStyle));
756 store.register_late_pass(|| Box::new(unused_async::UnusedAsync));
757 let disallowed_types = conf.disallowed_types.iter().cloned().collect::<FxHashSet<_>>();
758 store.register_late_pass(move || Box::new(disallowed_type::DisallowedType::new(&disallowed_types)));
759 let import_renames = conf.enforced_import_renames.clone();
760 store.register_late_pass(move || Box::new(missing_enforced_import_rename::ImportRename::new(import_renames.clone())));
761 let scripts = conf.allowed_scripts.clone();
762 store.register_early_pass(move || Box::new(disallowed_script_idents::DisallowedScriptIdents::new(&scripts)));
763 store.register_late_pass(|| Box::new(strlen_on_c_strings::StrlenOnCStrings));
764 store.register_late_pass(move || Box::new(self_named_constructors::SelfNamedConstructors));
765 store.register_late_pass(move || Box::new(feature_name::FeatureName));
766 store.register_late_pass(move || Box::new(iter_not_returning_iterator::IterNotReturningIterator));
767 store.register_late_pass(move || Box::new(if_then_panic::IfThenPanic));
768 let enable_raw_pointer_heuristic_for_send = conf.enable_raw_pointer_heuristic_for_send;
769 store.register_late_pass(move || Box::new(non_send_fields_in_send_ty::NonSendFieldInSendTy::new(enable_raw_pointer_heuristic_for_send)));
773 fn register_removed_non_tool_lints(store: &mut rustc_lint::LintStore) {
774 store.register_removed(
776 "`assert!()` will be more flexible with RFC 2011",
778 store.register_removed(
780 "`.extend_from_slice(_)` is a faster way to extend a Vec by a slice",
782 store.register_removed(
783 "range_step_by_zero",
784 "`iterator.step_by(0)` panics nowadays",
786 store.register_removed(
788 "`Vec::as_slice` has been stabilized in 1.7",
790 store.register_removed(
791 "unstable_as_mut_slice",
792 "`Vec::as_mut_slice` has been stabilized in 1.7",
794 store.register_removed(
795 "misaligned_transmute",
796 "this lint has been split into cast_ptr_alignment and transmute_ptr_to_ptr",
798 store.register_removed(
800 "using compound assignment operators (e.g., `+=`) is harmless",
802 store.register_removed(
803 "if_let_redundant_pattern_matching",
804 "this lint has been changed to redundant_pattern_matching",
806 store.register_removed(
807 "unsafe_vector_initialization",
808 "the replacement suggested by this lint had substantially different behavior",
810 store.register_removed(
811 "reverse_range_loop",
812 "this lint is now included in reversed_empty_ranges",
816 /// Register renamed lints.
818 /// Used in `./src/driver.rs`.
819 pub fn register_renamed(ls: &mut rustc_lint::LintStore) {
820 ls.register_renamed("clippy::stutter", "clippy::module_name_repetitions");
821 ls.register_renamed("clippy::new_without_default_derive", "clippy::new_without_default");
822 ls.register_renamed("clippy::cyclomatic_complexity", "clippy::cognitive_complexity");
823 ls.register_renamed("clippy::const_static_lifetime", "clippy::redundant_static_lifetimes");
824 ls.register_renamed("clippy::option_and_then_some", "clippy::bind_instead_of_map");
825 ls.register_renamed("clippy::box_vec", "clippy::box_collection");
826 ls.register_renamed("clippy::block_in_if_condition_expr", "clippy::blocks_in_if_conditions");
827 ls.register_renamed("clippy::block_in_if_condition_stmt", "clippy::blocks_in_if_conditions");
828 ls.register_renamed("clippy::option_map_unwrap_or", "clippy::map_unwrap_or");
829 ls.register_renamed("clippy::option_map_unwrap_or_else", "clippy::map_unwrap_or");
830 ls.register_renamed("clippy::result_map_unwrap_or_else", "clippy::map_unwrap_or");
831 ls.register_renamed("clippy::option_unwrap_used", "clippy::unwrap_used");
832 ls.register_renamed("clippy::result_unwrap_used", "clippy::unwrap_used");
833 ls.register_renamed("clippy::option_expect_used", "clippy::expect_used");
834 ls.register_renamed("clippy::result_expect_used", "clippy::expect_used");
835 ls.register_renamed("clippy::for_loop_over_option", "clippy::for_loops_over_fallibles");
836 ls.register_renamed("clippy::for_loop_over_result", "clippy::for_loops_over_fallibles");
837 ls.register_renamed("clippy::identity_conversion", "clippy::useless_conversion");
838 ls.register_renamed("clippy::zero_width_space", "clippy::invisible_characters");
839 ls.register_renamed("clippy::single_char_push_str", "clippy::single_char_add_str");
840 ls.register_renamed("clippy::if_let_some_result", "clippy::match_result_ok");
843 ls.register_renamed("clippy::invalid_ref", "invalid_value");
844 ls.register_renamed("clippy::into_iter_on_array", "array_into_iter");
845 ls.register_renamed("clippy::unused_label", "unused_labels");
846 ls.register_renamed("clippy::drop_bounds", "drop_bounds");
847 ls.register_renamed("clippy::temporary_cstring_as_ptr", "temporary_cstring_as_ptr");
848 ls.register_renamed("clippy::panic_params", "non_fmt_panics");
849 ls.register_renamed("clippy::unknown_clippy_lints", "unknown_lints");
850 ls.register_renamed("clippy::invalid_atomic_ordering", "invalid_atomic_ordering");
851 ls.register_renamed("clippy::mem_discriminant_non_enum", "enum_intrinsics_non_enums");
854 // only exists to let the dogfood integration test works.
855 // Don't run clippy as an executable directly
858 panic!("Please use the cargo-clippy executable");