1 #![feature(array_windows)]
2 #![feature(binary_heap_into_iter_sorted)]
3 #![feature(box_patterns)]
4 #![feature(control_flow_enum)]
5 #![feature(drain_filter)]
6 #![feature(iter_intersperse)]
7 #![feature(let_chains)]
9 #![feature(lint_reasons)]
10 #![feature(never_type)]
11 #![feature(once_cell)]
12 #![feature(rustc_private)]
13 #![feature(stmt_expr_attributes)]
14 #![recursion_limit = "512"]
15 #![cfg_attr(feature = "deny-warnings", deny(warnings))]
16 #![allow(clippy::missing_docs_in_private_items, clippy::must_use_candidate)]
17 #![warn(trivial_casts, trivial_numeric_casts)]
18 // warn on lints, that are included in `rust-lang/rust`s bootstrap
19 #![warn(rust_2018_idioms, unused_lifetimes)]
20 // warn on rustc internal lints
21 #![warn(rustc::internal)]
22 // Disable this rustc lint for now, as it was also done in rustc
23 #![allow(rustc::potential_query_instability)]
25 // FIXME: switch to something more ergonomic here, once available.
26 // (Currently there is no way to opt into sysroot crates without `extern crate`.)
27 extern crate rustc_arena;
28 extern crate rustc_ast;
29 extern crate rustc_ast_pretty;
30 extern crate rustc_attr;
31 extern crate rustc_data_structures;
32 extern crate rustc_driver;
33 extern crate rustc_errors;
34 extern crate rustc_hir;
35 extern crate rustc_hir_pretty;
36 extern crate rustc_index;
37 extern crate rustc_infer;
38 extern crate rustc_lexer;
39 extern crate rustc_lint;
40 extern crate rustc_middle;
41 extern crate rustc_mir_dataflow;
42 extern crate rustc_parse;
43 extern crate rustc_parse_format;
44 extern crate rustc_session;
45 extern crate rustc_span;
46 extern crate rustc_target;
47 extern crate rustc_trait_selection;
48 extern crate rustc_typeck;
51 extern crate clippy_utils;
53 use clippy_utils::parse_msrv;
54 use rustc_data_structures::fx::FxHashSet;
55 use rustc_lint::LintId;
56 use rustc_semver::RustcVersion;
57 use rustc_session::Session;
59 /// Macro used to declare a Clippy lint.
61 /// Every lint declaration consists of 4 parts:
63 /// 1. The documentation, which is used for the website
64 /// 2. The `LINT_NAME`. See [lint naming][lint_naming] on lint naming conventions.
65 /// 3. The `lint_level`, which is a mapping from *one* of our lint groups to `Allow`, `Warn` or
66 /// `Deny`. The lint level here has nothing to do with what lint groups the lint is a part of.
67 /// 4. The `description` that contains a short explanation on what's wrong with code where the
68 /// lint is triggered.
70 /// Currently the categories `style`, `correctness`, `suspicious`, `complexity` and `perf` are
71 /// enabled by default. As said in the README.md of this repository, if the lint level mapping
72 /// changes, please update README.md.
77 /// #![feature(rustc_private)]
78 /// extern crate rustc_session;
79 /// use rustc_session::declare_tool_lint;
80 /// use clippy_lints::declare_clippy_lint;
82 /// declare_clippy_lint! {
83 /// /// ### What it does
84 /// /// Checks for ... (describe what the lint matches).
86 /// /// ### Why is this bad?
87 /// /// Supply the reason for linting the code.
91 /// /// Insert a short example of code that triggers the lint
96 /// /// Insert a short example of improved code that doesn't trigger the lint
103 /// [lint_naming]: https://rust-lang.github.io/rfcs/0344-conventions-galore.html#lints
105 macro_rules! declare_clippy_lint {
106 { $(#[$attr:meta])* pub $name:tt, style, $description:tt } => {
108 $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
111 { $(#[$attr:meta])* pub $name:tt, correctness, $description:tt } => {
113 $(#[$attr])* pub clippy::$name, Deny, $description, report_in_external_macro: true
116 { $(#[$attr:meta])* pub $name:tt, suspicious, $description:tt } => {
118 $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
121 { $(#[$attr:meta])* pub $name:tt, complexity, $description:tt } => {
123 $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
126 { $(#[$attr:meta])* pub $name:tt, perf, $description:tt } => {
128 $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
131 { $(#[$attr:meta])* pub $name:tt, pedantic, $description:tt } => {
133 $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
136 { $(#[$attr:meta])* pub $name:tt, restriction, $description:tt } => {
138 $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
141 { $(#[$attr:meta])* pub $name:tt, cargo, $description:tt } => {
143 $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
146 { $(#[$attr:meta])* pub $name:tt, nursery, $description:tt } => {
148 $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
151 { $(#[$attr:meta])* pub $name:tt, internal, $description:tt } => {
153 $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
156 { $(#[$attr:meta])* pub $name:tt, internal_warn, $description:tt } => {
158 $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
163 #[cfg(feature = "internal")]
164 pub mod deprecated_lints;
165 #[cfg_attr(feature = "internal", allow(clippy::missing_clippy_version_attribute))]
170 // begin lints modules, do not remove this comment, it’s used in `update_lints`
171 mod almost_complete_letter_range;
176 mod assertions_on_constants;
177 mod async_yields_async;
179 mod await_holding_invalid;
180 mod blacklisted_name;
181 mod blocks_in_if_conditions;
182 mod bool_assert_comparison;
185 mod borrow_deref_ref;
187 mod bytes_count_to_len;
189 mod case_sensitive_file_extension_comparisons;
191 mod checked_conversions;
192 mod cognitive_complexity;
194 mod comparison_chain;
197 mod crate_in_macro_def;
201 mod default_instead_of_iter_empty;
202 mod default_numeric_fallback;
203 mod default_union_representation;
207 mod disallowed_methods;
208 mod disallowed_script_idents;
209 mod disallowed_types;
211 mod doc_link_with_quotes;
215 mod else_if_without_else;
218 mod empty_structs_with_brackets;
222 mod equatable_if_let;
226 mod exhaustive_items;
229 mod fallible_impl_from;
231 mod floating_point_arithmetic;
235 mod format_push_string;
238 mod from_str_radix_10;
244 mod if_then_some_else_none;
247 mod implicit_saturating_sub;
248 mod inconsistent_struct_constructor;
249 mod index_refutable_slice;
250 mod indexing_slicing;
253 mod inherent_to_string;
254 mod init_numbered_fields;
255 mod inline_fn_without_body;
257 mod invalid_upcast_comparisons;
258 mod items_after_statements;
259 mod iter_not_returning_iterator;
260 mod large_const_arrays;
261 mod large_enum_variant;
262 mod large_include_file;
263 mod large_stack_arrays;
268 mod literal_representation;
275 mod manual_non_exhaustive;
277 mod manual_rem_euclid;
291 mod mismatching_type_param_order;
292 mod missing_const_for_fn;
294 mod missing_enforced_import_rename;
296 mod mixed_read_write_in_expression;
302 mod mutable_debug_assertion;
304 mod needless_arbitrary_self_type;
306 mod needless_borrowed_ref;
307 mod needless_continue;
308 mod needless_for_each;
309 mod needless_late_init;
310 mod needless_parens_on_range_literals;
311 mod needless_pass_by_value;
312 mod needless_question_mark;
314 mod neg_cmp_op_on_partial_ord;
316 mod new_without_default;
319 mod non_expressive_names;
320 mod non_octal_unix_permissions;
321 mod non_send_fields_in_send_ty;
322 mod nonstandard_macro_braces;
324 mod only_used_in_recursion;
327 mod option_env_unwrap;
328 mod option_if_let_else;
329 mod overflow_check_conditional;
330 mod panic_in_result_fn;
331 mod panic_unimplemented;
332 mod partialeq_ne_impl;
333 mod pass_by_ref_or_value;
334 mod path_buf_push_overwrite;
335 mod pattern_type_mismatch;
338 mod ptr_offset_with_cast;
342 mod rc_clone_in_vec_init;
343 mod read_zero_byte_vec;
345 mod redundant_closure_call;
347 mod redundant_field_names;
348 mod redundant_pub_crate;
349 mod redundant_slicing;
350 mod redundant_static_lifetimes;
355 mod return_self_not_must_use;
357 mod same_name_method;
358 mod self_named_constructors;
359 mod semicolon_if_nothing_returned;
362 mod single_char_lifetime_names;
363 mod single_component_path_imports;
364 mod size_of_in_element_count;
365 mod slow_vector_initialization;
366 mod stable_sort_primitive;
368 mod strlen_on_c_strings;
369 mod suspicious_operation_groupings;
370 mod suspicious_trait_impl;
373 mod tabs_in_doc_comments;
374 mod temporary_assignment;
375 mod to_digit_is_some;
376 mod trailing_empty_array;
379 mod transmuting_null;
381 mod undocumented_unsafe_blocks;
385 mod unit_return_expecting_ord;
388 mod unnecessary_owned_empty_strings;
389 mod unnecessary_self_imports;
390 mod unnecessary_sort_by;
391 mod unnecessary_wraps;
392 mod unnested_or_patterns;
393 mod unsafe_removed_from_name;
395 mod unused_io_amount;
400 mod unwrap_in_result;
401 mod upper_case_acronyms;
403 mod useless_conversion;
405 mod vec_init_then_push;
406 mod vec_resize_to_zero;
407 mod verbose_file_reads;
408 mod wildcard_imports;
411 mod zero_sized_map_values;
412 // end lints modules, do not remove this comment, it’s used in `update_lints`
414 pub use crate::utils::conf::Conf;
415 use crate::utils::conf::{format_error, TryConf};
417 /// Register all pre expansion lints
419 /// Pre-expansion lints run before any macro expansion has happened.
421 /// Note that due to the architecture of the compiler, currently `cfg_attr` attributes on crate
422 /// level (i.e `#![cfg_attr(...)]`) will still be expanded even when using a pre-expansion pass.
424 /// Used in `./src/driver.rs`.
425 pub fn register_pre_expansion_lints(store: &mut rustc_lint::LintStore, sess: &Session, conf: &Conf) {
426 // NOTE: Do not add any more pre-expansion passes. These should be removed eventually.
428 let msrv = conf.msrv.as_ref().and_then(|s| {
429 parse_msrv(s, None, None).or_else(|| {
431 "error reading Clippy's configuration file. `{}` is not a valid Rust version",
438 store.register_pre_expansion_pass(|| Box::new(write::Write::default()));
439 store.register_pre_expansion_pass(move || Box::new(attrs::EarlyAttributes { msrv }));
442 fn read_msrv(conf: &Conf, sess: &Session) -> Option<RustcVersion> {
443 let cargo_msrv = std::env::var("CARGO_PKG_RUST_VERSION")
445 .and_then(|v| parse_msrv(&v, None, None));
446 let clippy_msrv = conf.msrv.as_ref().and_then(|s| {
447 parse_msrv(s, None, None).or_else(|| {
449 "error reading Clippy's configuration file. `{}` is not a valid Rust version",
456 if let Some(cargo_msrv) = cargo_msrv {
457 if let Some(clippy_msrv) = clippy_msrv {
458 // if both files have an msrv, let's compare them and emit a warning if they differ
459 if clippy_msrv != cargo_msrv {
461 "the MSRV in `clippy.toml` and `Cargo.toml` differ; using `{}` from `clippy.toml`",
476 pub fn read_conf(sess: &Session) -> Conf {
477 let file_name = match utils::conf::lookup_conf_file() {
478 Ok(Some(path)) => path,
479 Ok(None) => return Conf::default(),
481 sess.struct_err(&format!("error finding Clippy's configuration file: {}", error))
483 return Conf::default();
487 let TryConf { conf, errors } = utils::conf::read(&file_name);
488 // all conf errors are non-fatal, we just use the default conf in case of error
489 for error in errors {
491 "error reading Clippy's configuration file `{}`: {}",
500 /// Register all lints and lint groups with the rustc plugin registry
502 /// Used in `./src/driver.rs`.
503 #[expect(clippy::too_many_lines)]
504 pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf: &Conf) {
505 register_removed_non_tool_lints(store);
507 include!("lib.deprecated.rs");
509 include!("lib.register_lints.rs");
510 include!("lib.register_restriction.rs");
511 include!("lib.register_pedantic.rs");
513 #[cfg(feature = "internal")]
514 include!("lib.register_internal.rs");
516 include!("lib.register_all.rs");
517 include!("lib.register_style.rs");
518 include!("lib.register_complexity.rs");
519 include!("lib.register_correctness.rs");
520 include!("lib.register_suspicious.rs");
521 include!("lib.register_perf.rs");
522 include!("lib.register_cargo.rs");
523 include!("lib.register_nursery.rs");
525 #[cfg(feature = "internal")]
527 if std::env::var("ENABLE_METADATA_COLLECTION").eq(&Ok("1".to_string())) {
528 store.register_late_pass(|| Box::new(utils::internal_lints::metadata_collector::MetadataCollector::new()));
533 // all the internal lints
534 #[cfg(feature = "internal")]
536 store.register_early_pass(|| Box::new(utils::internal_lints::ClippyLintsInternal));
537 store.register_early_pass(|| Box::new(utils::internal_lints::ProduceIce));
538 store.register_late_pass(|| Box::new(utils::internal_lints::CollapsibleCalls));
539 store.register_late_pass(|| Box::new(utils::internal_lints::CompilerLintFunctions::new()));
540 store.register_late_pass(|| Box::new(utils::internal_lints::IfChainStyle));
541 store.register_late_pass(|| Box::new(utils::internal_lints::InvalidPaths));
542 store.register_late_pass(|| Box::new(utils::internal_lints::InterningDefinedSymbol::default()));
543 store.register_late_pass(|| Box::new(utils::internal_lints::LintWithoutLintPass::default()));
544 store.register_late_pass(|| Box::new(utils::internal_lints::MatchTypeOnDiagItem));
545 store.register_late_pass(|| Box::new(utils::internal_lints::OuterExpnDataPass));
546 store.register_late_pass(|| Box::new(utils::internal_lints::MsrvAttrImpl));
549 store.register_late_pass(|| Box::new(utils::dump_hir::DumpHir));
550 store.register_late_pass(|| Box::new(utils::author::Author));
551 let await_holding_invalid_types = conf.await_holding_invalid_types.clone();
552 store.register_late_pass(move || {
553 Box::new(await_holding_invalid::AwaitHolding::new(
554 await_holding_invalid_types.clone(),
557 store.register_late_pass(|| Box::new(serde_api::SerdeApi));
558 let vec_box_size_threshold = conf.vec_box_size_threshold;
559 let type_complexity_threshold = conf.type_complexity_threshold;
560 let avoid_breaking_exported_api = conf.avoid_breaking_exported_api;
561 store.register_late_pass(move || {
562 Box::new(types::Types::new(
563 vec_box_size_threshold,
564 type_complexity_threshold,
565 avoid_breaking_exported_api,
568 store.register_late_pass(|| Box::new(booleans::NonminimalBool));
569 store.register_late_pass(|| Box::new(enum_clike::UnportableVariant));
570 store.register_late_pass(|| Box::new(float_literal::FloatLiteral));
571 store.register_late_pass(|| Box::new(ptr::Ptr));
572 store.register_late_pass(|| Box::new(needless_bool::NeedlessBool));
573 store.register_late_pass(|| Box::new(needless_bool::BoolComparison));
574 store.register_late_pass(|| Box::new(needless_for_each::NeedlessForEach));
575 store.register_late_pass(|| Box::new(misc::MiscLints));
576 store.register_late_pass(|| Box::new(eta_reduction::EtaReduction));
577 store.register_late_pass(|| Box::new(mut_mut::MutMut));
578 store.register_late_pass(|| Box::new(mut_reference::UnnecessaryMutPassed));
579 store.register_late_pass(|| Box::new(len_zero::LenZero));
580 store.register_late_pass(|| Box::new(attrs::Attributes));
581 store.register_late_pass(|| Box::new(blocks_in_if_conditions::BlocksInIfConditions));
582 store.register_late_pass(|| Box::new(unicode::Unicode));
583 store.register_late_pass(|| Box::new(uninit_vec::UninitVec));
584 store.register_late_pass(|| Box::new(unit_hash::UnitHash));
585 store.register_late_pass(|| Box::new(unit_return_expecting_ord::UnitReturnExpectingOrd));
586 store.register_late_pass(|| Box::new(strings::StringAdd));
587 store.register_late_pass(|| Box::new(implicit_return::ImplicitReturn));
588 store.register_late_pass(|| Box::new(implicit_saturating_sub::ImplicitSaturatingSub));
589 store.register_late_pass(|| Box::new(default_numeric_fallback::DefaultNumericFallback));
590 store.register_late_pass(|| Box::new(inconsistent_struct_constructor::InconsistentStructConstructor));
591 store.register_late_pass(|| Box::new(non_octal_unix_permissions::NonOctalUnixPermissions));
592 store.register_early_pass(|| Box::new(unnecessary_self_imports::UnnecessarySelfImports));
594 let msrv = read_msrv(conf, sess);
595 let avoid_breaking_exported_api = conf.avoid_breaking_exported_api;
596 let allow_expect_in_tests = conf.allow_expect_in_tests;
597 let allow_unwrap_in_tests = conf.allow_unwrap_in_tests;
598 store.register_late_pass(move || Box::new(approx_const::ApproxConstant::new(msrv)));
599 store.register_late_pass(move || {
600 Box::new(methods::Methods::new(
601 avoid_breaking_exported_api,
603 allow_expect_in_tests,
604 allow_unwrap_in_tests,
607 store.register_late_pass(move || Box::new(matches::Matches::new(msrv)));
608 store.register_early_pass(move || Box::new(manual_non_exhaustive::ManualNonExhaustiveStruct::new(msrv)));
609 store.register_late_pass(move || Box::new(manual_non_exhaustive::ManualNonExhaustiveEnum::new(msrv)));
610 store.register_late_pass(move || Box::new(manual_strip::ManualStrip::new(msrv)));
611 store.register_early_pass(move || Box::new(redundant_static_lifetimes::RedundantStaticLifetimes::new(msrv)));
612 store.register_early_pass(move || Box::new(redundant_field_names::RedundantFieldNames::new(msrv)));
613 store.register_late_pass(move || Box::new(checked_conversions::CheckedConversions::new(msrv)));
614 store.register_late_pass(move || Box::new(mem_replace::MemReplace::new(msrv)));
615 store.register_late_pass(move || Box::new(ranges::Ranges::new(msrv)));
616 store.register_late_pass(move || Box::new(from_over_into::FromOverInto::new(msrv)));
617 store.register_late_pass(move || Box::new(use_self::UseSelf::new(msrv)));
618 store.register_late_pass(move || Box::new(missing_const_for_fn::MissingConstForFn::new(msrv)));
619 store.register_late_pass(move || Box::new(needless_question_mark::NeedlessQuestionMark));
620 store.register_late_pass(move || Box::new(casts::Casts::new(msrv)));
621 store.register_early_pass(move || Box::new(unnested_or_patterns::UnnestedOrPatterns::new(msrv)));
622 store.register_late_pass(move || Box::new(map_clone::MapClone::new(msrv)));
624 store.register_late_pass(|| Box::new(size_of_in_element_count::SizeOfInElementCount));
625 store.register_late_pass(|| Box::new(same_name_method::SameNameMethod));
626 let max_suggested_slice_pattern_length = conf.max_suggested_slice_pattern_length;
627 store.register_late_pass(move || {
628 Box::new(index_refutable_slice::IndexRefutableSlice::new(
629 max_suggested_slice_pattern_length,
633 store.register_late_pass(|| Box::new(map_err_ignore::MapErrIgnore));
634 store.register_late_pass(|| Box::new(shadow::Shadow::default()));
635 store.register_late_pass(|| Box::new(unit_types::UnitTypes));
636 store.register_late_pass(|| Box::new(loops::Loops));
637 store.register_late_pass(|| Box::new(main_recursion::MainRecursion::default()));
638 store.register_late_pass(|| Box::new(lifetimes::Lifetimes));
639 store.register_late_pass(|| Box::new(entry::HashMapPass));
640 store.register_late_pass(|| Box::new(minmax::MinMaxPass));
641 store.register_late_pass(|| Box::new(open_options::OpenOptions));
642 store.register_late_pass(|| Box::new(zero_div_zero::ZeroDiv));
643 store.register_late_pass(|| Box::new(mutex_atomic::Mutex));
644 store.register_late_pass(|| Box::new(needless_update::NeedlessUpdate));
645 store.register_late_pass(|| Box::new(needless_borrowed_ref::NeedlessBorrowedRef));
646 store.register_late_pass(|| Box::new(borrow_deref_ref::BorrowDerefRef));
647 store.register_late_pass(|| Box::new(no_effect::NoEffect));
648 store.register_late_pass(|| Box::new(temporary_assignment::TemporaryAssignment));
649 store.register_late_pass(move || Box::new(transmute::Transmute::new(msrv)));
650 let cognitive_complexity_threshold = conf.cognitive_complexity_threshold;
651 store.register_late_pass(move || {
652 Box::new(cognitive_complexity::CognitiveComplexity::new(
653 cognitive_complexity_threshold,
656 let too_large_for_stack = conf.too_large_for_stack;
657 store.register_late_pass(move || Box::new(escape::BoxedLocal { too_large_for_stack }));
658 store.register_late_pass(move || Box::new(vec::UselessVec { too_large_for_stack }));
659 store.register_late_pass(|| Box::new(panic_unimplemented::PanicUnimplemented));
660 store.register_late_pass(|| Box::new(strings::StringLitAsBytes));
661 store.register_late_pass(|| Box::new(derive::Derive));
662 store.register_late_pass(|| Box::new(derivable_impls::DerivableImpls));
663 store.register_late_pass(|| Box::new(drop_forget_ref::DropForgetRef));
664 store.register_late_pass(|| Box::new(empty_enum::EmptyEnum));
665 store.register_late_pass(|| Box::new(invalid_upcast_comparisons::InvalidUpcastComparisons));
666 store.register_late_pass(|| Box::new(regex::Regex));
667 store.register_late_pass(|| Box::new(copies::CopyAndPaste));
668 store.register_late_pass(|| Box::new(copy_iterator::CopyIterator));
669 store.register_late_pass(|| Box::new(format::UselessFormat));
670 store.register_late_pass(|| Box::new(swap::Swap));
671 store.register_late_pass(|| Box::new(overflow_check_conditional::OverflowCheckConditional));
672 store.register_late_pass(|| Box::new(new_without_default::NewWithoutDefault::default()));
673 let blacklisted_names = conf.blacklisted_names.iter().cloned().collect::<FxHashSet<_>>();
674 store.register_late_pass(move || Box::new(blacklisted_name::BlacklistedName::new(blacklisted_names.clone())));
675 let too_many_arguments_threshold = conf.too_many_arguments_threshold;
676 let too_many_lines_threshold = conf.too_many_lines_threshold;
677 store.register_late_pass(move || {
678 Box::new(functions::Functions::new(
679 too_many_arguments_threshold,
680 too_many_lines_threshold,
683 let doc_valid_idents = conf.doc_valid_idents.iter().cloned().collect::<FxHashSet<_>>();
684 store.register_late_pass(move || Box::new(doc::DocMarkdown::new(doc_valid_idents.clone())));
685 store.register_late_pass(|| Box::new(neg_multiply::NegMultiply));
686 store.register_late_pass(|| Box::new(mem_forget::MemForget));
687 store.register_late_pass(|| Box::new(let_if_seq::LetIfSeq));
688 store.register_late_pass(|| Box::new(mixed_read_write_in_expression::EvalOrderDependence));
689 store.register_late_pass(|| Box::new(missing_doc::MissingDoc::new()));
690 store.register_late_pass(|| Box::new(missing_inline::MissingInline));
691 store.register_late_pass(move || Box::new(exhaustive_items::ExhaustiveItems));
692 store.register_late_pass(|| Box::new(match_result_ok::MatchResultOk));
693 store.register_late_pass(|| Box::new(partialeq_ne_impl::PartialEqNeImpl));
694 store.register_late_pass(|| Box::new(unused_io_amount::UnusedIoAmount));
695 let enum_variant_size_threshold = conf.enum_variant_size_threshold;
696 store.register_late_pass(move || Box::new(large_enum_variant::LargeEnumVariant::new(enum_variant_size_threshold)));
697 store.register_late_pass(|| Box::new(explicit_write::ExplicitWrite));
698 store.register_late_pass(|| Box::new(needless_pass_by_value::NeedlessPassByValue));
699 let pass_by_ref_or_value = pass_by_ref_or_value::PassByRefOrValue::new(
700 conf.trivial_copy_size_limit,
701 conf.pass_by_value_size_limit,
702 conf.avoid_breaking_exported_api,
705 store.register_late_pass(move || Box::new(pass_by_ref_or_value));
706 store.register_late_pass(|| Box::new(ref_option_ref::RefOptionRef));
707 store.register_late_pass(|| Box::new(bytecount::ByteCount));
708 store.register_late_pass(|| Box::new(infinite_iter::InfiniteIter));
709 store.register_late_pass(|| Box::new(inline_fn_without_body::InlineFnWithoutBody));
710 store.register_late_pass(|| Box::new(useless_conversion::UselessConversion::default()));
711 store.register_late_pass(|| Box::new(implicit_hasher::ImplicitHasher));
712 store.register_late_pass(|| Box::new(fallible_impl_from::FallibleImplFrom));
713 store.register_late_pass(|| Box::new(question_mark::QuestionMark));
714 store.register_early_pass(|| Box::new(suspicious_operation_groupings::SuspiciousOperationGroupings));
715 store.register_late_pass(|| Box::new(suspicious_trait_impl::SuspiciousImpl));
716 store.register_late_pass(|| Box::new(map_unit_fn::MapUnit));
717 store.register_late_pass(|| Box::new(inherent_impl::MultipleInherentImpl));
718 store.register_late_pass(|| Box::new(neg_cmp_op_on_partial_ord::NoNegCompOpForPartialOrd));
719 store.register_late_pass(|| Box::new(unwrap::Unwrap));
720 store.register_late_pass(|| Box::new(indexing_slicing::IndexingSlicing));
721 store.register_late_pass(|| Box::new(non_copy_const::NonCopyConst));
722 store.register_late_pass(|| Box::new(ptr_offset_with_cast::PtrOffsetWithCast));
723 store.register_late_pass(|| Box::new(redundant_clone::RedundantClone));
724 store.register_late_pass(|| Box::new(slow_vector_initialization::SlowVectorInit));
725 store.register_late_pass(|| Box::new(unnecessary_sort_by::UnnecessarySortBy));
726 store.register_late_pass(move || Box::new(unnecessary_wraps::UnnecessaryWraps::new(avoid_breaking_exported_api)));
727 store.register_late_pass(|| Box::new(assertions_on_constants::AssertionsOnConstants));
728 store.register_late_pass(|| Box::new(transmuting_null::TransmutingNull));
729 store.register_late_pass(|| Box::new(path_buf_push_overwrite::PathBufPushOverwrite));
730 store.register_late_pass(|| Box::new(inherent_to_string::InherentToString));
731 let max_trait_bounds = conf.max_trait_bounds;
732 store.register_late_pass(move || Box::new(trait_bounds::TraitBounds::new(max_trait_bounds)));
733 store.register_late_pass(|| Box::new(comparison_chain::ComparisonChain));
734 store.register_late_pass(|| Box::new(mut_key::MutableKeyType));
735 store.register_early_pass(|| Box::new(reference::DerefAddrOf));
736 store.register_early_pass(|| Box::new(double_parens::DoubleParens));
737 store.register_late_pass(|| Box::new(format_impl::FormatImpl::new()));
738 store.register_early_pass(|| Box::new(unsafe_removed_from_name::UnsafeNameRemoval));
739 store.register_early_pass(|| Box::new(else_if_without_else::ElseIfWithoutElse));
740 store.register_early_pass(|| Box::new(int_plus_one::IntPlusOne));
741 store.register_early_pass(|| Box::new(formatting::Formatting));
742 store.register_early_pass(|| Box::new(misc_early::MiscEarlyLints));
743 store.register_early_pass(|| Box::new(redundant_closure_call::RedundantClosureCall));
744 store.register_late_pass(|| Box::new(redundant_closure_call::RedundantClosureCall));
745 store.register_early_pass(|| Box::new(unused_unit::UnusedUnit));
746 store.register_late_pass(|| Box::new(returns::Return));
747 store.register_early_pass(|| Box::new(collapsible_if::CollapsibleIf));
748 store.register_early_pass(|| Box::new(items_after_statements::ItemsAfterStatements));
749 store.register_early_pass(|| Box::new(precedence::Precedence));
750 store.register_late_pass(|| Box::new(needless_parens_on_range_literals::NeedlessParensOnRangeLiterals));
751 store.register_early_pass(|| Box::new(needless_continue::NeedlessContinue));
752 store.register_early_pass(|| Box::new(redundant_else::RedundantElse));
753 store.register_late_pass(|| Box::new(create_dir::CreateDir));
754 store.register_early_pass(|| Box::new(needless_arbitrary_self_type::NeedlessArbitrarySelfType));
755 let literal_representation_lint_fraction_readability = conf.unreadable_literal_lint_fractions;
756 store.register_early_pass(move || {
757 Box::new(literal_representation::LiteralDigitGrouping::new(
758 literal_representation_lint_fraction_readability,
761 let literal_representation_threshold = conf.literal_representation_threshold;
762 store.register_early_pass(move || {
763 Box::new(literal_representation::DecimalLiteralRepresentation::new(
764 literal_representation_threshold,
767 let enum_variant_name_threshold = conf.enum_variant_name_threshold;
768 store.register_late_pass(move || {
769 Box::new(enum_variants::EnumVariantNames::new(
770 enum_variant_name_threshold,
771 avoid_breaking_exported_api,
774 store.register_early_pass(|| Box::new(tabs_in_doc_comments::TabsInDocComments));
775 let upper_case_acronyms_aggressive = conf.upper_case_acronyms_aggressive;
776 store.register_late_pass(move || {
777 Box::new(upper_case_acronyms::UpperCaseAcronyms::new(
778 avoid_breaking_exported_api,
779 upper_case_acronyms_aggressive,
782 store.register_late_pass(|| Box::new(default::Default::default()));
783 store.register_late_pass(|| Box::new(unused_self::UnusedSelf));
784 store.register_late_pass(|| Box::new(mutable_debug_assertion::DebugAssertWithMutCall));
785 store.register_late_pass(|| Box::new(exit::Exit));
786 store.register_late_pass(|| Box::new(to_digit_is_some::ToDigitIsSome));
787 let array_size_threshold = conf.array_size_threshold;
788 store.register_late_pass(move || Box::new(large_stack_arrays::LargeStackArrays::new(array_size_threshold)));
789 store.register_late_pass(move || Box::new(large_const_arrays::LargeConstArrays::new(array_size_threshold)));
790 store.register_late_pass(|| Box::new(floating_point_arithmetic::FloatingPointArithmetic));
791 store.register_early_pass(|| Box::new(as_conversions::AsConversions));
792 store.register_late_pass(|| Box::new(let_underscore::LetUnderscore));
793 store.register_early_pass(|| Box::new(single_component_path_imports::SingleComponentPathImports));
794 let max_fn_params_bools = conf.max_fn_params_bools;
795 let max_struct_bools = conf.max_struct_bools;
796 store.register_early_pass(move || {
797 Box::new(excessive_bools::ExcessiveBools::new(
802 store.register_early_pass(|| Box::new(option_env_unwrap::OptionEnvUnwrap));
803 let warn_on_all_wildcard_imports = conf.warn_on_all_wildcard_imports;
804 store.register_late_pass(move || Box::new(wildcard_imports::WildcardImports::new(warn_on_all_wildcard_imports)));
805 store.register_late_pass(|| Box::new(verbose_file_reads::VerboseFileReads));
806 store.register_late_pass(|| Box::new(redundant_pub_crate::RedundantPubCrate::default()));
807 store.register_late_pass(|| Box::new(unnamed_address::UnnamedAddress));
808 store.register_late_pass(|| Box::new(dereference::Dereferencing::default()));
809 store.register_late_pass(|| Box::new(option_if_let_else::OptionIfLetElse));
810 store.register_late_pass(|| Box::new(future_not_send::FutureNotSend));
811 store.register_late_pass(|| Box::new(if_let_mutex::IfLetMutex));
812 store.register_late_pass(|| Box::new(if_not_else::IfNotElse));
813 store.register_late_pass(|| Box::new(equatable_if_let::PatternEquality));
814 store.register_late_pass(|| Box::new(mut_mutex_lock::MutMutexLock));
815 store.register_late_pass(|| Box::new(manual_async_fn::ManualAsyncFn));
816 store.register_late_pass(|| Box::new(vec_resize_to_zero::VecResizeToZero));
817 store.register_late_pass(|| Box::new(panic_in_result_fn::PanicInResultFn));
818 let single_char_binding_names_threshold = conf.single_char_binding_names_threshold;
819 store.register_early_pass(move || {
820 Box::new(non_expressive_names::NonExpressiveNames {
821 single_char_binding_names_threshold,
824 let macro_matcher = conf.standard_macro_braces.iter().cloned().collect::<FxHashSet<_>>();
825 store.register_early_pass(move || Box::new(nonstandard_macro_braces::MacroBraces::new(¯o_matcher)));
826 store.register_late_pass(|| Box::new(macro_use::MacroUseImports::default()));
827 store.register_late_pass(|| Box::new(pattern_type_mismatch::PatternTypeMismatch));
828 store.register_late_pass(|| Box::new(stable_sort_primitive::StableSortPrimitive));
829 store.register_late_pass(|| Box::new(repeat_once::RepeatOnce));
830 store.register_late_pass(|| Box::new(unwrap_in_result::UnwrapInResult));
831 store.register_late_pass(|| Box::new(manual_ok_or::ManualOkOr));
832 store.register_late_pass(|| Box::new(semicolon_if_nothing_returned::SemicolonIfNothingReturned));
833 store.register_late_pass(|| Box::new(async_yields_async::AsyncYieldsAsync));
834 let disallowed_methods = conf.disallowed_methods.clone();
835 store.register_late_pass(move || Box::new(disallowed_methods::DisallowedMethods::new(disallowed_methods.clone())));
836 store.register_early_pass(|| Box::new(asm_syntax::InlineAsmX86AttSyntax));
837 store.register_early_pass(|| Box::new(asm_syntax::InlineAsmX86IntelSyntax));
838 store.register_late_pass(|| Box::new(empty_drop::EmptyDrop));
839 store.register_late_pass(|| Box::new(strings::StrToString));
840 store.register_late_pass(|| Box::new(strings::StringToString));
841 store.register_late_pass(|| Box::new(zero_sized_map_values::ZeroSizedMapValues));
842 store.register_late_pass(|| Box::new(vec_init_then_push::VecInitThenPush::default()));
843 store.register_late_pass(|| {
844 Box::new(case_sensitive_file_extension_comparisons::CaseSensitiveFileExtensionComparisons)
846 store.register_late_pass(|| Box::new(redundant_slicing::RedundantSlicing));
847 store.register_late_pass(|| Box::new(from_str_radix_10::FromStrRadix10));
848 store.register_late_pass(move || Box::new(if_then_some_else_none::IfThenSomeElseNone::new(msrv)));
849 store.register_late_pass(|| Box::new(bool_assert_comparison::BoolAssertComparison));
850 store.register_early_pass(move || Box::new(module_style::ModStyle));
851 store.register_late_pass(|| Box::new(unused_async::UnusedAsync));
852 let disallowed_types = conf.disallowed_types.clone();
853 store.register_late_pass(move || Box::new(disallowed_types::DisallowedTypes::new(disallowed_types.clone())));
854 let import_renames = conf.enforced_import_renames.clone();
855 store.register_late_pass(move || {
856 Box::new(missing_enforced_import_rename::ImportRename::new(
857 import_renames.clone(),
860 let scripts = conf.allowed_scripts.clone();
861 store.register_early_pass(move || Box::new(disallowed_script_idents::DisallowedScriptIdents::new(&scripts)));
862 store.register_late_pass(|| Box::new(strlen_on_c_strings::StrlenOnCStrings));
863 store.register_late_pass(move || Box::new(self_named_constructors::SelfNamedConstructors));
864 store.register_late_pass(move || Box::new(iter_not_returning_iterator::IterNotReturningIterator));
865 store.register_late_pass(move || Box::new(manual_assert::ManualAssert));
866 let enable_raw_pointer_heuristic_for_send = conf.enable_raw_pointer_heuristic_for_send;
867 store.register_late_pass(move || {
868 Box::new(non_send_fields_in_send_ty::NonSendFieldInSendTy::new(
869 enable_raw_pointer_heuristic_for_send,
872 store.register_late_pass(move || Box::new(undocumented_unsafe_blocks::UndocumentedUnsafeBlocks));
873 store.register_late_pass(move || Box::new(format_args::FormatArgs));
874 store.register_late_pass(|| Box::new(trailing_empty_array::TrailingEmptyArray));
875 store.register_early_pass(|| Box::new(octal_escapes::OctalEscapes));
876 store.register_late_pass(|| Box::new(needless_late_init::NeedlessLateInit));
877 store.register_late_pass(|| Box::new(return_self_not_must_use::ReturnSelfNotMustUse));
878 store.register_late_pass(|| Box::new(init_numbered_fields::NumberedFields));
879 store.register_early_pass(|| Box::new(single_char_lifetime_names::SingleCharLifetimeNames));
880 store.register_late_pass(move || Box::new(borrow_as_ptr::BorrowAsPtr::new(msrv)));
881 store.register_late_pass(move || Box::new(manual_bits::ManualBits::new(msrv)));
882 store.register_late_pass(|| Box::new(default_union_representation::DefaultUnionRepresentation));
883 store.register_early_pass(|| Box::new(doc_link_with_quotes::DocLinkWithQuotes));
884 store.register_late_pass(|| Box::new(only_used_in_recursion::OnlyUsedInRecursion));
885 let allow_dbg_in_tests = conf.allow_dbg_in_tests;
886 store.register_late_pass(move || Box::new(dbg_macro::DbgMacro::new(allow_dbg_in_tests)));
887 let cargo_ignore_publish = conf.cargo_ignore_publish;
888 store.register_late_pass(move || {
889 Box::new(cargo::Cargo {
890 ignore_publish: cargo_ignore_publish,
893 store.register_early_pass(|| Box::new(crate_in_macro_def::CrateInMacroDef));
894 store.register_early_pass(|| Box::new(empty_structs_with_brackets::EmptyStructsWithBrackets));
895 store.register_late_pass(|| Box::new(unnecessary_owned_empty_strings::UnnecessaryOwnedEmptyStrings));
896 store.register_early_pass(|| Box::new(pub_use::PubUse));
897 store.register_late_pass(|| Box::new(format_push_string::FormatPushString));
898 store.register_late_pass(|| Box::new(bytes_count_to_len::BytesCountToLen));
899 let max_include_file_size = conf.max_include_file_size;
900 store.register_late_pass(move || Box::new(large_include_file::LargeIncludeFile::new(max_include_file_size)));
901 store.register_late_pass(|| Box::new(strings::TrimSplitWhitespace));
902 store.register_late_pass(|| Box::new(rc_clone_in_vec_init::RcCloneInVecInit));
903 store.register_early_pass(|| Box::new(duplicate_mod::DuplicateMod::default()));
904 store.register_late_pass(|| Box::new(get_first::GetFirst));
905 store.register_early_pass(|| Box::new(unused_rounding::UnusedRounding));
906 store.register_early_pass(move || Box::new(almost_complete_letter_range::AlmostCompleteLetterRange::new(msrv)));
907 store.register_late_pass(|| Box::new(swap_ptr_to_ref::SwapPtrToRef));
908 store.register_late_pass(|| Box::new(mismatching_type_param_order::TypeParamMismatch));
909 store.register_late_pass(|| Box::new(as_underscore::AsUnderscore));
910 store.register_late_pass(|| Box::new(read_zero_byte_vec::ReadZeroByteVec));
911 store.register_late_pass(|| Box::new(default_instead_of_iter_empty::DefaultIterEmpty));
912 store.register_late_pass(move || Box::new(manual_rem_euclid::ManualRemEuclid::new(msrv)));
913 store.register_late_pass(move || Box::new(manual_retain::ManualRetain::new(msrv)));
914 let verbose_bit_mask_threshold = conf.verbose_bit_mask_threshold;
915 store.register_late_pass(move || Box::new(operators::Operators::new(verbose_bit_mask_threshold)));
916 // add lints here, do not remove this comment, it's used in `new_lint`
920 fn register_removed_non_tool_lints(store: &mut rustc_lint::LintStore) {
921 store.register_removed(
923 "`assert!()` will be more flexible with RFC 2011",
925 store.register_removed(
927 "`.extend_from_slice(_)` is a faster way to extend a Vec by a slice",
929 store.register_removed(
930 "range_step_by_zero",
931 "`iterator.step_by(0)` panics nowadays",
933 store.register_removed(
935 "`Vec::as_slice` has been stabilized in 1.7",
937 store.register_removed(
938 "unstable_as_mut_slice",
939 "`Vec::as_mut_slice` has been stabilized in 1.7",
941 store.register_removed(
942 "misaligned_transmute",
943 "this lint has been split into cast_ptr_alignment and transmute_ptr_to_ptr",
945 store.register_removed(
947 "using compound assignment operators (e.g., `+=`) is harmless",
949 store.register_removed(
950 "if_let_redundant_pattern_matching",
951 "this lint has been changed to redundant_pattern_matching",
953 store.register_removed(
954 "unsafe_vector_initialization",
955 "the replacement suggested by this lint had substantially different behavior",
957 store.register_removed(
958 "reverse_range_loop",
959 "this lint is now included in reversed_empty_ranges",
963 /// Register renamed lints.
965 /// Used in `./src/driver.rs`.
966 pub fn register_renamed(ls: &mut rustc_lint::LintStore) {
967 for (old_name, new_name) in renamed_lints::RENAMED_LINTS {
968 ls.register_renamed(old_name, new_name);
972 // only exists to let the dogfood integration test works.
973 // Don't run clippy as an executable directly
976 panic!("Please use the cargo-clippy executable");