]> git.lizzy.rs Git - rust.git/blob - src/tools/clippy/clippy_lints/src/lib.rs
rustc_typeck to rustc_hir_analysis
[rust.git] / src / tools / clippy / clippy_lints / src / lib.rs
1 #![feature(array_windows)]
2 #![feature(binary_heap_into_iter_sorted)]
3 #![feature(box_patterns)]
4 #![feature(control_flow_enum)]
5 #![feature(drain_filter)]
6 #![feature(iter_intersperse)]
7 #![feature(let_chains)]
8 #![feature(lint_reasons)]
9 #![feature(never_type)]
10 #![feature(once_cell)]
11 #![feature(rustc_private)]
12 #![feature(stmt_expr_attributes)]
13 #![recursion_limit = "512"]
14 #![cfg_attr(feature = "deny-warnings", deny(warnings))]
15 #![allow(clippy::missing_docs_in_private_items, clippy::must_use_candidate)]
16 #![warn(trivial_casts, trivial_numeric_casts)]
17 // warn on lints, that are included in `rust-lang/rust`s bootstrap
18 #![warn(rust_2018_idioms, unused_lifetimes)]
19 // warn on rustc internal lints
20 #![warn(rustc::internal)]
21 // Disable this rustc lint for now, as it was also done in rustc
22 #![allow(rustc::potential_query_instability)]
23
24 // FIXME: switch to something more ergonomic here, once available.
25 // (Currently there is no way to opt into sysroot crates without `extern crate`.)
26 extern crate rustc_arena;
27 extern crate rustc_ast;
28 extern crate rustc_ast_pretty;
29 extern crate rustc_attr;
30 extern crate rustc_data_structures;
31 extern crate rustc_driver;
32 extern crate rustc_errors;
33 extern crate rustc_hir;
34 extern crate rustc_hir_pretty;
35 extern crate rustc_index;
36 extern crate rustc_infer;
37 extern crate rustc_lexer;
38 extern crate rustc_lint;
39 extern crate rustc_middle;
40 extern crate rustc_mir_dataflow;
41 extern crate rustc_parse;
42 extern crate rustc_session;
43 extern crate rustc_span;
44 extern crate rustc_target;
45 extern crate rustc_trait_selection;
46 extern crate rustc_hir_analysis;
47
48 #[macro_use]
49 extern crate clippy_utils;
50
51 use clippy_utils::parse_msrv;
52 use rustc_data_structures::fx::FxHashSet;
53 use rustc_lint::LintId;
54 use rustc_semver::RustcVersion;
55 use rustc_session::Session;
56
57 /// Macro used to declare a Clippy lint.
58 ///
59 /// Every lint declaration consists of 4 parts:
60 ///
61 /// 1. The documentation, which is used for the website
62 /// 2. The `LINT_NAME`. See [lint naming][lint_naming] on lint naming conventions.
63 /// 3. The `lint_level`, which is a mapping from *one* of our lint groups to `Allow`, `Warn` or
64 ///    `Deny`. The lint level here has nothing to do with what lint groups the lint is a part of.
65 /// 4. The `description` that contains a short explanation on what's wrong with code where the
66 ///    lint is triggered.
67 ///
68 /// Currently the categories `style`, `correctness`, `suspicious`, `complexity` and `perf` are
69 /// enabled by default. As said in the README.md of this repository, if the lint level mapping
70 /// changes, please update README.md.
71 ///
72 /// # Example
73 ///
74 /// ```
75 /// #![feature(rustc_private)]
76 /// extern crate rustc_session;
77 /// use rustc_session::declare_tool_lint;
78 /// use clippy_lints::declare_clippy_lint;
79 ///
80 /// declare_clippy_lint! {
81 ///     /// ### What it does
82 ///     /// Checks for ... (describe what the lint matches).
83 ///     ///
84 ///     /// ### Why is this bad?
85 ///     /// Supply the reason for linting the code.
86 ///     ///
87 ///     /// ### Example
88 ///     /// ```rust
89 ///     /// Insert a short example of code that triggers the lint
90 ///     /// ```
91 ///     ///
92 ///     /// Use instead:
93 ///     /// ```rust
94 ///     /// Insert a short example of improved code that doesn't trigger the lint
95 ///     /// ```
96 ///     pub LINT_NAME,
97 ///     pedantic,
98 ///     "description"
99 /// }
100 /// ```
101 /// [lint_naming]: https://rust-lang.github.io/rfcs/0344-conventions-galore.html#lints
102 #[macro_export]
103 macro_rules! declare_clippy_lint {
104     { $(#[$attr:meta])* pub $name:tt, style, $description:tt } => {
105         declare_tool_lint! {
106             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
107         }
108     };
109     { $(#[$attr:meta])* pub $name:tt, correctness, $description:tt } => {
110         declare_tool_lint! {
111             $(#[$attr])* pub clippy::$name, Deny, $description, report_in_external_macro: true
112         }
113     };
114     { $(#[$attr:meta])* pub $name:tt, suspicious, $description:tt } => {
115         declare_tool_lint! {
116             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
117         }
118     };
119     { $(#[$attr:meta])* pub $name:tt, complexity, $description:tt } => {
120         declare_tool_lint! {
121             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
122         }
123     };
124     { $(#[$attr:meta])* pub $name:tt, perf, $description:tt } => {
125         declare_tool_lint! {
126             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
127         }
128     };
129     { $(#[$attr:meta])* pub $name:tt, pedantic, $description:tt } => {
130         declare_tool_lint! {
131             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
132         }
133     };
134     { $(#[$attr:meta])* pub $name:tt, restriction, $description:tt } => {
135         declare_tool_lint! {
136             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
137         }
138     };
139     { $(#[$attr:meta])* pub $name:tt, cargo, $description:tt } => {
140         declare_tool_lint! {
141             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
142         }
143     };
144     { $(#[$attr:meta])* pub $name:tt, nursery, $description:tt } => {
145         declare_tool_lint! {
146             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
147         }
148     };
149     { $(#[$attr:meta])* pub $name:tt, internal, $description:tt } => {
150         declare_tool_lint! {
151             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
152         }
153     };
154     { $(#[$attr:meta])* pub $name:tt, internal_warn, $description:tt } => {
155         declare_tool_lint! {
156             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
157         }
158     };
159 }
160
161 #[cfg(feature = "internal")]
162 pub mod deprecated_lints;
163 #[cfg_attr(feature = "internal", allow(clippy::missing_clippy_version_attribute))]
164 mod utils;
165
166 mod renamed_lints;
167
168 // begin lints modules, do not remove this comment, it’s used in `update_lints`
169 mod almost_complete_letter_range;
170 mod approx_const;
171 mod as_conversions;
172 mod asm_syntax;
173 mod assertions_on_constants;
174 mod assertions_on_result_states;
175 mod async_yields_async;
176 mod attrs;
177 mod await_holding_invalid;
178 mod blocks_in_if_conditions;
179 mod bool_assert_comparison;
180 mod bool_to_int_with_if;
181 mod booleans;
182 mod borrow_deref_ref;
183 mod cargo;
184 mod casts;
185 mod checked_conversions;
186 mod cognitive_complexity;
187 mod collapsible_if;
188 mod comparison_chain;
189 mod copies;
190 mod copy_iterator;
191 mod crate_in_macro_def;
192 mod create_dir;
193 mod dbg_macro;
194 mod default;
195 mod default_instead_of_iter_empty;
196 mod default_numeric_fallback;
197 mod default_union_representation;
198 mod dereference;
199 mod derivable_impls;
200 mod derive;
201 mod disallowed_methods;
202 mod disallowed_names;
203 mod disallowed_script_idents;
204 mod disallowed_types;
205 mod doc;
206 mod doc_link_with_quotes;
207 mod double_parens;
208 mod drop_forget_ref;
209 mod duplicate_mod;
210 mod else_if_without_else;
211 mod empty_drop;
212 mod empty_enum;
213 mod empty_structs_with_brackets;
214 mod entry;
215 mod enum_clike;
216 mod enum_variants;
217 mod equatable_if_let;
218 mod escape;
219 mod eta_reduction;
220 mod excessive_bools;
221 mod exhaustive_items;
222 mod exit;
223 mod explicit_write;
224 mod fallible_impl_from;
225 mod float_literal;
226 mod floating_point_arithmetic;
227 mod format;
228 mod format_args;
229 mod format_impl;
230 mod format_push_string;
231 mod formatting;
232 mod from_over_into;
233 mod from_str_radix_10;
234 mod functions;
235 mod future_not_send;
236 mod if_let_mutex;
237 mod if_not_else;
238 mod if_then_some_else_none;
239 mod implicit_hasher;
240 mod implicit_return;
241 mod implicit_saturating_sub;
242 mod inconsistent_struct_constructor;
243 mod index_refutable_slice;
244 mod indexing_slicing;
245 mod infinite_iter;
246 mod inherent_impl;
247 mod inherent_to_string;
248 mod init_numbered_fields;
249 mod inline_fn_without_body;
250 mod int_plus_one;
251 mod invalid_upcast_comparisons;
252 mod invalid_utf8_in_unchecked;
253 mod items_after_statements;
254 mod iter_not_returning_iterator;
255 mod large_const_arrays;
256 mod large_enum_variant;
257 mod large_include_file;
258 mod large_stack_arrays;
259 mod len_zero;
260 mod let_if_seq;
261 mod let_underscore;
262 mod lifetimes;
263 mod literal_representation;
264 mod loops;
265 mod macro_use;
266 mod main_recursion;
267 mod manual_assert;
268 mod manual_async_fn;
269 mod manual_bits;
270 mod manual_instant_elapsed;
271 mod manual_non_exhaustive;
272 mod manual_rem_euclid;
273 mod manual_retain;
274 mod manual_string_new;
275 mod manual_strip;
276 mod map_unit_fn;
277 mod match_result_ok;
278 mod matches;
279 mod mem_forget;
280 mod mem_replace;
281 mod methods;
282 mod minmax;
283 mod misc;
284 mod misc_early;
285 mod mismatching_type_param_order;
286 mod missing_const_for_fn;
287 mod missing_doc;
288 mod missing_enforced_import_rename;
289 mod missing_inline;
290 mod mixed_read_write_in_expression;
291 mod module_style;
292 mod multi_assignments;
293 mod mut_key;
294 mod mut_mut;
295 mod mut_reference;
296 mod mutable_debug_assertion;
297 mod mutex_atomic;
298 mod needless_arbitrary_self_type;
299 mod needless_bool;
300 mod needless_borrowed_ref;
301 mod needless_continue;
302 mod needless_for_each;
303 mod needless_late_init;
304 mod needless_parens_on_range_literals;
305 mod needless_pass_by_value;
306 mod needless_question_mark;
307 mod needless_update;
308 mod neg_cmp_op_on_partial_ord;
309 mod neg_multiply;
310 mod new_without_default;
311 mod no_effect;
312 mod non_copy_const;
313 mod non_expressive_names;
314 mod non_octal_unix_permissions;
315 mod non_send_fields_in_send_ty;
316 mod nonstandard_macro_braces;
317 mod octal_escapes;
318 mod only_used_in_recursion;
319 mod operators;
320 mod option_env_unwrap;
321 mod option_if_let_else;
322 mod overflow_check_conditional;
323 mod panic_in_result_fn;
324 mod panic_unimplemented;
325 mod partialeq_ne_impl;
326 mod partialeq_to_none;
327 mod pass_by_ref_or_value;
328 mod pattern_type_mismatch;
329 mod precedence;
330 mod ptr;
331 mod ptr_offset_with_cast;
332 mod pub_use;
333 mod question_mark;
334 mod ranges;
335 mod rc_clone_in_vec_init;
336 mod read_zero_byte_vec;
337 mod redundant_clone;
338 mod redundant_closure_call;
339 mod redundant_else;
340 mod redundant_field_names;
341 mod redundant_pub_crate;
342 mod redundant_slicing;
343 mod redundant_static_lifetimes;
344 mod ref_option_ref;
345 mod reference;
346 mod regex;
347 mod return_self_not_must_use;
348 mod returns;
349 mod same_name_method;
350 mod self_named_constructors;
351 mod semicolon_if_nothing_returned;
352 mod serde_api;
353 mod shadow;
354 mod single_char_lifetime_names;
355 mod single_component_path_imports;
356 mod size_of_in_element_count;
357 mod slow_vector_initialization;
358 mod std_instead_of_core;
359 mod strings;
360 mod strlen_on_c_strings;
361 mod suspicious_operation_groupings;
362 mod suspicious_trait_impl;
363 mod swap;
364 mod swap_ptr_to_ref;
365 mod tabs_in_doc_comments;
366 mod temporary_assignment;
367 mod to_digit_is_some;
368 mod trailing_empty_array;
369 mod trait_bounds;
370 mod transmute;
371 mod types;
372 mod undocumented_unsafe_blocks;
373 mod unicode;
374 mod uninit_vec;
375 mod unit_return_expecting_ord;
376 mod unit_types;
377 mod unnamed_address;
378 mod unnecessary_owned_empty_strings;
379 mod unnecessary_self_imports;
380 mod unnecessary_wraps;
381 mod unnested_or_patterns;
382 mod unsafe_removed_from_name;
383 mod unused_async;
384 mod unused_io_amount;
385 mod unused_peekable;
386 mod unused_rounding;
387 mod unused_self;
388 mod unused_unit;
389 mod unwrap;
390 mod unwrap_in_result;
391 mod upper_case_acronyms;
392 mod use_self;
393 mod useless_conversion;
394 mod vec;
395 mod vec_init_then_push;
396 mod wildcard_imports;
397 mod write;
398 mod zero_div_zero;
399 mod zero_sized_map_values;
400 // end lints modules, do not remove this comment, it’s used in `update_lints`
401
402 pub use crate::utils::conf::Conf;
403 use crate::utils::conf::{format_error, TryConf};
404
405 /// Register all pre expansion lints
406 ///
407 /// Pre-expansion lints run before any macro expansion has happened.
408 ///
409 /// Note that due to the architecture of the compiler, currently `cfg_attr` attributes on crate
410 /// level (i.e `#![cfg_attr(...)]`) will still be expanded even when using a pre-expansion pass.
411 ///
412 /// Used in `./src/driver.rs`.
413 pub fn register_pre_expansion_lints(store: &mut rustc_lint::LintStore, sess: &Session, conf: &Conf) {
414     // NOTE: Do not add any more pre-expansion passes. These should be removed eventually.
415
416     let msrv = conf.msrv.as_ref().and_then(|s| {
417         parse_msrv(s, None, None).or_else(|| {
418             sess.err(&format!(
419                 "error reading Clippy's configuration file. `{}` is not a valid Rust version",
420                 s
421             ));
422             None
423         })
424     });
425
426     store.register_pre_expansion_pass(move || Box::new(attrs::EarlyAttributes { msrv }));
427 }
428
429 fn read_msrv(conf: &Conf, sess: &Session) -> Option<RustcVersion> {
430     let cargo_msrv = std::env::var("CARGO_PKG_RUST_VERSION")
431         .ok()
432         .and_then(|v| parse_msrv(&v, None, None));
433     let clippy_msrv = conf.msrv.as_ref().and_then(|s| {
434         parse_msrv(s, None, None).or_else(|| {
435             sess.err(&format!(
436                 "error reading Clippy's configuration file. `{}` is not a valid Rust version",
437                 s
438             ));
439             None
440         })
441     });
442
443     if let Some(cargo_msrv) = cargo_msrv {
444         if let Some(clippy_msrv) = clippy_msrv {
445             // if both files have an msrv, let's compare them and emit a warning if they differ
446             if clippy_msrv != cargo_msrv {
447                 sess.warn(&format!(
448                     "the MSRV in `clippy.toml` and `Cargo.toml` differ; using `{}` from `clippy.toml`",
449                     clippy_msrv
450                 ));
451             }
452
453             Some(clippy_msrv)
454         } else {
455             Some(cargo_msrv)
456         }
457     } else {
458         clippy_msrv
459     }
460 }
461
462 #[doc(hidden)]
463 pub fn read_conf(sess: &Session) -> Conf {
464     let file_name = match utils::conf::lookup_conf_file() {
465         Ok(Some(path)) => path,
466         Ok(None) => return Conf::default(),
467         Err(error) => {
468             sess.struct_err(&format!("error finding Clippy's configuration file: {}", error))
469                 .emit();
470             return Conf::default();
471         },
472     };
473
474     let TryConf { conf, errors, warnings } = utils::conf::read(&file_name);
475     // all conf errors are non-fatal, we just use the default conf in case of error
476     for error in errors {
477         sess.err(&format!(
478             "error reading Clippy's configuration file `{}`: {}",
479             file_name.display(),
480             format_error(error)
481         ));
482     }
483
484     for warning in warnings {
485         sess.struct_warn(&format!(
486             "error reading Clippy's configuration file `{}`: {}",
487             file_name.display(),
488             format_error(warning)
489         ))
490         .emit();
491     }
492
493     conf
494 }
495
496 /// Register all lints and lint groups with the rustc plugin registry
497 ///
498 /// Used in `./src/driver.rs`.
499 #[expect(clippy::too_many_lines)]
500 pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf: &Conf) {
501     register_removed_non_tool_lints(store);
502
503     include!("lib.deprecated.rs");
504
505     include!("lib.register_lints.rs");
506     include!("lib.register_restriction.rs");
507     include!("lib.register_pedantic.rs");
508
509     #[cfg(feature = "internal")]
510     include!("lib.register_internal.rs");
511
512     include!("lib.register_all.rs");
513     include!("lib.register_style.rs");
514     include!("lib.register_complexity.rs");
515     include!("lib.register_correctness.rs");
516     include!("lib.register_suspicious.rs");
517     include!("lib.register_perf.rs");
518     include!("lib.register_cargo.rs");
519     include!("lib.register_nursery.rs");
520
521     #[cfg(feature = "internal")]
522     {
523         if std::env::var("ENABLE_METADATA_COLLECTION").eq(&Ok("1".to_string())) {
524             store.register_late_pass(|_| Box::new(utils::internal_lints::metadata_collector::MetadataCollector::new()));
525             return;
526         }
527     }
528
529     // all the internal lints
530     #[cfg(feature = "internal")]
531     {
532         store.register_early_pass(|| Box::new(utils::internal_lints::ClippyLintsInternal));
533         store.register_early_pass(|| Box::new(utils::internal_lints::ProduceIce));
534         store.register_late_pass(|_| Box::new(utils::internal_lints::CollapsibleCalls));
535         store.register_late_pass(|_| Box::new(utils::internal_lints::CompilerLintFunctions::new()));
536         store.register_late_pass(|_| Box::new(utils::internal_lints::IfChainStyle));
537         store.register_late_pass(|_| Box::new(utils::internal_lints::InvalidPaths));
538         store.register_late_pass(|_| Box::new(utils::internal_lints::InterningDefinedSymbol::default()));
539         store.register_late_pass(|_| Box::new(utils::internal_lints::LintWithoutLintPass::default()));
540         store.register_late_pass(|_| Box::new(utils::internal_lints::MatchTypeOnDiagItem));
541         store.register_late_pass(|_| Box::new(utils::internal_lints::OuterExpnDataPass));
542         store.register_late_pass(|_| Box::new(utils::internal_lints::MsrvAttrImpl));
543     }
544
545     let arithmetic_side_effects_allowed = conf.arithmetic_side_effects_allowed.clone();
546     store.register_late_pass(move |_| {
547         Box::new(operators::arithmetic_side_effects::ArithmeticSideEffects::new(
548             arithmetic_side_effects_allowed.clone(),
549         ))
550     });
551     store.register_late_pass(|_| Box::new(utils::dump_hir::DumpHir));
552     store.register_late_pass(|_| Box::new(utils::author::Author));
553     let await_holding_invalid_types = conf.await_holding_invalid_types.clone();
554     store.register_late_pass(move |_| {
555         Box::new(await_holding_invalid::AwaitHolding::new(
556             await_holding_invalid_types.clone(),
557         ))
558     });
559     store.register_late_pass(|_| Box::new(serde_api::SerdeApi));
560     let vec_box_size_threshold = conf.vec_box_size_threshold;
561     let type_complexity_threshold = conf.type_complexity_threshold;
562     let avoid_breaking_exported_api = conf.avoid_breaking_exported_api;
563     store.register_late_pass(move |_| {
564         Box::new(types::Types::new(
565             vec_box_size_threshold,
566             type_complexity_threshold,
567             avoid_breaking_exported_api,
568         ))
569     });
570     store.register_late_pass(|_| Box::new(booleans::NonminimalBool));
571     store.register_late_pass(|_| Box::new(enum_clike::UnportableVariant));
572     store.register_late_pass(|_| Box::new(float_literal::FloatLiteral));
573     store.register_late_pass(|_| Box::new(ptr::Ptr));
574     store.register_late_pass(|_| Box::new(needless_bool::NeedlessBool));
575     store.register_late_pass(|_| Box::new(needless_bool::BoolComparison));
576     store.register_late_pass(|_| Box::new(needless_for_each::NeedlessForEach));
577     store.register_late_pass(|_| Box::new(misc::MiscLints));
578     store.register_late_pass(|_| Box::new(eta_reduction::EtaReduction));
579     store.register_late_pass(|_| Box::new(mut_mut::MutMut));
580     store.register_late_pass(|_| Box::new(mut_reference::UnnecessaryMutPassed));
581     store.register_late_pass(|_| Box::new(len_zero::LenZero));
582     store.register_late_pass(|_| Box::new(attrs::Attributes));
583     store.register_late_pass(|_| Box::new(blocks_in_if_conditions::BlocksInIfConditions));
584     store.register_late_pass(|_| Box::new(unicode::Unicode));
585     store.register_late_pass(|_| Box::new(uninit_vec::UninitVec));
586     store.register_late_pass(|_| Box::new(unit_return_expecting_ord::UnitReturnExpectingOrd));
587     store.register_late_pass(|_| Box::new(strings::StringAdd));
588     store.register_late_pass(|_| Box::new(implicit_return::ImplicitReturn));
589     store.register_late_pass(|_| Box::new(implicit_saturating_sub::ImplicitSaturatingSub));
590     store.register_late_pass(|_| Box::new(default_numeric_fallback::DefaultNumericFallback));
591     store.register_late_pass(|_| Box::new(inconsistent_struct_constructor::InconsistentStructConstructor));
592     store.register_late_pass(|_| Box::new(non_octal_unix_permissions::NonOctalUnixPermissions));
593     store.register_early_pass(|| Box::new(unnecessary_self_imports::UnnecessarySelfImports));
594
595     let msrv = read_msrv(conf, sess);
596     let avoid_breaking_exported_api = conf.avoid_breaking_exported_api;
597     let allow_expect_in_tests = conf.allow_expect_in_tests;
598     let allow_unwrap_in_tests = conf.allow_unwrap_in_tests;
599     store.register_late_pass(move |_| Box::new(approx_const::ApproxConstant::new(msrv)));
600     store.register_late_pass(move |_| {
601         Box::new(methods::Methods::new(
602             avoid_breaking_exported_api,
603             msrv,
604             allow_expect_in_tests,
605             allow_unwrap_in_tests,
606         ))
607     });
608     store.register_late_pass(move |_| Box::new(matches::Matches::new(msrv)));
609     store.register_early_pass(move || Box::new(manual_non_exhaustive::ManualNonExhaustiveStruct::new(msrv)));
610     store.register_late_pass(move |_| Box::new(manual_non_exhaustive::ManualNonExhaustiveEnum::new(msrv)));
611     store.register_late_pass(move |_| Box::new(manual_strip::ManualStrip::new(msrv)));
612     store.register_early_pass(move || Box::new(redundant_static_lifetimes::RedundantStaticLifetimes::new(msrv)));
613     store.register_early_pass(move || Box::new(redundant_field_names::RedundantFieldNames::new(msrv)));
614     store.register_late_pass(move |_| Box::new(checked_conversions::CheckedConversions::new(msrv)));
615     store.register_late_pass(move |_| Box::new(mem_replace::MemReplace::new(msrv)));
616     store.register_late_pass(move |_| Box::new(ranges::Ranges::new(msrv)));
617     store.register_late_pass(move |_| Box::new(from_over_into::FromOverInto::new(msrv)));
618     store.register_late_pass(move |_| Box::new(use_self::UseSelf::new(msrv)));
619     store.register_late_pass(move |_| Box::new(missing_const_for_fn::MissingConstForFn::new(msrv)));
620     store.register_late_pass(move |_| Box::new(needless_question_mark::NeedlessQuestionMark));
621     store.register_late_pass(move |_| Box::new(casts::Casts::new(msrv)));
622     store.register_early_pass(move || Box::new(unnested_or_patterns::UnnestedOrPatterns::new(msrv)));
623     store.register_late_pass(|_| Box::new(size_of_in_element_count::SizeOfInElementCount));
624     store.register_late_pass(|_| Box::new(same_name_method::SameNameMethod));
625     let max_suggested_slice_pattern_length = conf.max_suggested_slice_pattern_length;
626     store.register_late_pass(move |_| {
627         Box::new(index_refutable_slice::IndexRefutableSlice::new(
628             max_suggested_slice_pattern_length,
629             msrv,
630         ))
631     });
632     store.register_late_pass(|_| Box::new(shadow::Shadow::default()));
633     store.register_late_pass(|_| Box::new(unit_types::UnitTypes));
634     store.register_late_pass(|_| Box::new(loops::Loops));
635     store.register_late_pass(|_| Box::new(main_recursion::MainRecursion::default()));
636     store.register_late_pass(|_| Box::new(lifetimes::Lifetimes));
637     store.register_late_pass(|_| Box::new(entry::HashMapPass));
638     store.register_late_pass(|_| Box::new(minmax::MinMaxPass));
639     store.register_late_pass(|_| Box::new(zero_div_zero::ZeroDiv));
640     store.register_late_pass(|_| Box::new(mutex_atomic::Mutex));
641     store.register_late_pass(|_| Box::new(needless_update::NeedlessUpdate));
642     store.register_late_pass(|_| Box::new(needless_borrowed_ref::NeedlessBorrowedRef));
643     store.register_late_pass(|_| Box::new(borrow_deref_ref::BorrowDerefRef));
644     store.register_late_pass(|_| Box::new(no_effect::NoEffect));
645     store.register_late_pass(|_| Box::new(temporary_assignment::TemporaryAssignment));
646     store.register_late_pass(move |_| Box::new(transmute::Transmute::new(msrv)));
647     let cognitive_complexity_threshold = conf.cognitive_complexity_threshold;
648     store.register_late_pass(move |_| {
649         Box::new(cognitive_complexity::CognitiveComplexity::new(
650             cognitive_complexity_threshold,
651         ))
652     });
653     let too_large_for_stack = conf.too_large_for_stack;
654     store.register_late_pass(move |_| Box::new(escape::BoxedLocal { too_large_for_stack }));
655     store.register_late_pass(move |_| Box::new(vec::UselessVec { too_large_for_stack }));
656     store.register_late_pass(|_| Box::new(panic_unimplemented::PanicUnimplemented));
657     store.register_late_pass(|_| Box::new(strings::StringLitAsBytes));
658     store.register_late_pass(|_| Box::new(derive::Derive));
659     store.register_late_pass(|_| Box::new(derivable_impls::DerivableImpls));
660     store.register_late_pass(|_| Box::new(drop_forget_ref::DropForgetRef));
661     store.register_late_pass(|_| Box::new(empty_enum::EmptyEnum));
662     store.register_late_pass(|_| Box::new(invalid_upcast_comparisons::InvalidUpcastComparisons));
663     store.register_late_pass(|_| Box::new(regex::Regex));
664     store.register_late_pass(|_| Box::new(copies::CopyAndPaste));
665     store.register_late_pass(|_| Box::new(copy_iterator::CopyIterator));
666     store.register_late_pass(|_| Box::new(format::UselessFormat));
667     store.register_late_pass(|_| Box::new(swap::Swap));
668     store.register_late_pass(|_| Box::new(overflow_check_conditional::OverflowCheckConditional));
669     store.register_late_pass(|_| Box::new(new_without_default::NewWithoutDefault::default()));
670     let disallowed_names = conf.disallowed_names.iter().cloned().collect::<FxHashSet<_>>();
671     store.register_late_pass(move |_| Box::new(disallowed_names::DisallowedNames::new(disallowed_names.clone())));
672     let too_many_arguments_threshold = conf.too_many_arguments_threshold;
673     let too_many_lines_threshold = conf.too_many_lines_threshold;
674     let large_error_threshold = conf.large_error_threshold;
675     store.register_late_pass(move |_| {
676         Box::new(functions::Functions::new(
677             too_many_arguments_threshold,
678             too_many_lines_threshold,
679             large_error_threshold,
680         ))
681     });
682     let doc_valid_idents = conf.doc_valid_idents.iter().cloned().collect::<FxHashSet<_>>();
683     store.register_late_pass(move |_| Box::new(doc::DocMarkdown::new(doc_valid_idents.clone())));
684     store.register_late_pass(|_| Box::new(neg_multiply::NegMultiply));
685     store.register_late_pass(|_| Box::new(mem_forget::MemForget));
686     store.register_late_pass(|_| Box::new(let_if_seq::LetIfSeq));
687     store.register_late_pass(|_| Box::new(mixed_read_write_in_expression::EvalOrderDependence));
688     store.register_late_pass(|_| Box::new(missing_doc::MissingDoc::new()));
689     store.register_late_pass(|_| Box::new(missing_inline::MissingInline));
690     store.register_late_pass(move |_| Box::new(exhaustive_items::ExhaustiveItems));
691     store.register_late_pass(|_| Box::new(match_result_ok::MatchResultOk));
692     store.register_late_pass(|_| Box::new(partialeq_ne_impl::PartialEqNeImpl));
693     store.register_late_pass(|_| Box::new(unused_io_amount::UnusedIoAmount));
694     let enum_variant_size_threshold = conf.enum_variant_size_threshold;
695     store.register_late_pass(move |_| Box::new(large_enum_variant::LargeEnumVariant::new(enum_variant_size_threshold)));
696     store.register_late_pass(|_| Box::new(explicit_write::ExplicitWrite));
697     store.register_late_pass(|_| Box::new(needless_pass_by_value::NeedlessPassByValue));
698     let pass_by_ref_or_value = pass_by_ref_or_value::PassByRefOrValue::new(
699         conf.trivial_copy_size_limit,
700         conf.pass_by_value_size_limit,
701         conf.avoid_breaking_exported_api,
702         &sess.target,
703     );
704     store.register_late_pass(move |_| Box::new(pass_by_ref_or_value));
705     store.register_late_pass(|_| Box::new(ref_option_ref::RefOptionRef));
706     store.register_late_pass(|_| Box::new(infinite_iter::InfiniteIter));
707     store.register_late_pass(|_| Box::new(inline_fn_without_body::InlineFnWithoutBody));
708     store.register_late_pass(|_| Box::new(useless_conversion::UselessConversion::default()));
709     store.register_late_pass(|_| Box::new(implicit_hasher::ImplicitHasher));
710     store.register_late_pass(|_| Box::new(fallible_impl_from::FallibleImplFrom));
711     store.register_late_pass(|_| Box::new(question_mark::QuestionMark));
712     store.register_early_pass(|| Box::new(suspicious_operation_groupings::SuspiciousOperationGroupings));
713     store.register_late_pass(|_| Box::new(suspicious_trait_impl::SuspiciousImpl));
714     store.register_late_pass(|_| Box::new(map_unit_fn::MapUnit));
715     store.register_late_pass(|_| Box::new(inherent_impl::MultipleInherentImpl));
716     store.register_late_pass(|_| Box::new(neg_cmp_op_on_partial_ord::NoNegCompOpForPartialOrd));
717     store.register_late_pass(|_| Box::new(unwrap::Unwrap));
718     store.register_late_pass(|_| Box::new(indexing_slicing::IndexingSlicing));
719     store.register_late_pass(|_| Box::new(non_copy_const::NonCopyConst));
720     store.register_late_pass(|_| Box::new(ptr_offset_with_cast::PtrOffsetWithCast));
721     store.register_late_pass(|_| Box::new(redundant_clone::RedundantClone));
722     store.register_late_pass(|_| Box::new(slow_vector_initialization::SlowVectorInit));
723     store.register_late_pass(move |_| Box::new(unnecessary_wraps::UnnecessaryWraps::new(avoid_breaking_exported_api)));
724     store.register_late_pass(|_| Box::new(assertions_on_constants::AssertionsOnConstants));
725     store.register_late_pass(|_| Box::new(assertions_on_result_states::AssertionsOnResultStates));
726     store.register_late_pass(|_| Box::new(inherent_to_string::InherentToString));
727     let max_trait_bounds = conf.max_trait_bounds;
728     store.register_late_pass(move |_| Box::new(trait_bounds::TraitBounds::new(max_trait_bounds)));
729     store.register_late_pass(|_| Box::new(comparison_chain::ComparisonChain));
730     store.register_late_pass(|_| Box::new(mut_key::MutableKeyType));
731     store.register_early_pass(|| Box::new(reference::DerefAddrOf));
732     store.register_early_pass(|| Box::new(double_parens::DoubleParens));
733     store.register_late_pass(|_| Box::new(format_impl::FormatImpl::new()));
734     store.register_early_pass(|| Box::new(unsafe_removed_from_name::UnsafeNameRemoval));
735     store.register_early_pass(|| Box::new(else_if_without_else::ElseIfWithoutElse));
736     store.register_early_pass(|| Box::new(int_plus_one::IntPlusOne));
737     store.register_early_pass(|| Box::new(formatting::Formatting));
738     store.register_early_pass(|| Box::new(misc_early::MiscEarlyLints));
739     store.register_early_pass(|| Box::new(redundant_closure_call::RedundantClosureCall));
740     store.register_late_pass(|_| Box::new(redundant_closure_call::RedundantClosureCall));
741     store.register_early_pass(|| Box::new(unused_unit::UnusedUnit));
742     store.register_late_pass(|_| Box::new(returns::Return));
743     store.register_early_pass(|| Box::new(collapsible_if::CollapsibleIf));
744     store.register_early_pass(|| Box::new(items_after_statements::ItemsAfterStatements));
745     store.register_early_pass(|| Box::new(precedence::Precedence));
746     store.register_late_pass(|_| Box::new(needless_parens_on_range_literals::NeedlessParensOnRangeLiterals));
747     store.register_early_pass(|| Box::new(needless_continue::NeedlessContinue));
748     store.register_early_pass(|| Box::new(redundant_else::RedundantElse));
749     store.register_late_pass(|_| Box::new(create_dir::CreateDir));
750     store.register_early_pass(|| Box::new(needless_arbitrary_self_type::NeedlessArbitrarySelfType));
751     let literal_representation_lint_fraction_readability = conf.unreadable_literal_lint_fractions;
752     store.register_early_pass(move || {
753         Box::new(literal_representation::LiteralDigitGrouping::new(
754             literal_representation_lint_fraction_readability,
755         ))
756     });
757     let literal_representation_threshold = conf.literal_representation_threshold;
758     store.register_early_pass(move || {
759         Box::new(literal_representation::DecimalLiteralRepresentation::new(
760             literal_representation_threshold,
761         ))
762     });
763     let enum_variant_name_threshold = conf.enum_variant_name_threshold;
764     store.register_late_pass(move |_| {
765         Box::new(enum_variants::EnumVariantNames::new(
766             enum_variant_name_threshold,
767             avoid_breaking_exported_api,
768         ))
769     });
770     store.register_early_pass(|| Box::new(tabs_in_doc_comments::TabsInDocComments));
771     let upper_case_acronyms_aggressive = conf.upper_case_acronyms_aggressive;
772     store.register_late_pass(move |_| {
773         Box::new(upper_case_acronyms::UpperCaseAcronyms::new(
774             avoid_breaking_exported_api,
775             upper_case_acronyms_aggressive,
776         ))
777     });
778     store.register_late_pass(|_| Box::new(default::Default::default()));
779     store.register_late_pass(move |_| Box::new(unused_self::UnusedSelf::new(avoid_breaking_exported_api)));
780     store.register_late_pass(|_| Box::new(mutable_debug_assertion::DebugAssertWithMutCall));
781     store.register_late_pass(|_| Box::new(exit::Exit));
782     store.register_late_pass(|_| Box::new(to_digit_is_some::ToDigitIsSome));
783     let array_size_threshold = conf.array_size_threshold;
784     store.register_late_pass(move |_| Box::new(large_stack_arrays::LargeStackArrays::new(array_size_threshold)));
785     store.register_late_pass(move |_| Box::new(large_const_arrays::LargeConstArrays::new(array_size_threshold)));
786     store.register_late_pass(|_| Box::new(floating_point_arithmetic::FloatingPointArithmetic));
787     store.register_early_pass(|| Box::new(as_conversions::AsConversions));
788     store.register_late_pass(|_| Box::new(let_underscore::LetUnderscore));
789     store.register_early_pass(|| Box::new(single_component_path_imports::SingleComponentPathImports));
790     let max_fn_params_bools = conf.max_fn_params_bools;
791     let max_struct_bools = conf.max_struct_bools;
792     store.register_early_pass(move || {
793         Box::new(excessive_bools::ExcessiveBools::new(
794             max_struct_bools,
795             max_fn_params_bools,
796         ))
797     });
798     store.register_early_pass(|| Box::new(option_env_unwrap::OptionEnvUnwrap));
799     let warn_on_all_wildcard_imports = conf.warn_on_all_wildcard_imports;
800     store.register_late_pass(move |_| Box::new(wildcard_imports::WildcardImports::new(warn_on_all_wildcard_imports)));
801     store.register_late_pass(|_| Box::new(redundant_pub_crate::RedundantPubCrate::default()));
802     store.register_late_pass(|_| Box::new(unnamed_address::UnnamedAddress));
803     store.register_late_pass(move |_| Box::new(dereference::Dereferencing::new(msrv)));
804     store.register_late_pass(|_| Box::new(option_if_let_else::OptionIfLetElse));
805     store.register_late_pass(|_| Box::new(future_not_send::FutureNotSend));
806     store.register_late_pass(|_| Box::new(if_let_mutex::IfLetMutex));
807     store.register_late_pass(|_| Box::new(if_not_else::IfNotElse));
808     store.register_late_pass(|_| Box::new(equatable_if_let::PatternEquality));
809     store.register_late_pass(|_| Box::new(manual_async_fn::ManualAsyncFn));
810     store.register_late_pass(|_| Box::new(panic_in_result_fn::PanicInResultFn));
811     let single_char_binding_names_threshold = conf.single_char_binding_names_threshold;
812     store.register_early_pass(move || {
813         Box::new(non_expressive_names::NonExpressiveNames {
814             single_char_binding_names_threshold,
815         })
816     });
817     let macro_matcher = conf.standard_macro_braces.iter().cloned().collect::<FxHashSet<_>>();
818     store.register_early_pass(move || Box::new(nonstandard_macro_braces::MacroBraces::new(&macro_matcher)));
819     store.register_late_pass(|_| Box::new(macro_use::MacroUseImports::default()));
820     store.register_late_pass(|_| Box::new(pattern_type_mismatch::PatternTypeMismatch));
821     store.register_late_pass(|_| Box::new(unwrap_in_result::UnwrapInResult));
822     store.register_late_pass(|_| Box::new(semicolon_if_nothing_returned::SemicolonIfNothingReturned));
823     store.register_late_pass(|_| Box::new(async_yields_async::AsyncYieldsAsync));
824     let disallowed_methods = conf.disallowed_methods.clone();
825     store.register_late_pass(move |_| Box::new(disallowed_methods::DisallowedMethods::new(disallowed_methods.clone())));
826     store.register_early_pass(|| Box::new(asm_syntax::InlineAsmX86AttSyntax));
827     store.register_early_pass(|| Box::new(asm_syntax::InlineAsmX86IntelSyntax));
828     store.register_late_pass(|_| Box::new(empty_drop::EmptyDrop));
829     store.register_late_pass(|_| Box::new(strings::StrToString));
830     store.register_late_pass(|_| Box::new(strings::StringToString));
831     store.register_late_pass(|_| Box::new(zero_sized_map_values::ZeroSizedMapValues));
832     store.register_late_pass(|_| Box::new(vec_init_then_push::VecInitThenPush::default()));
833     store.register_late_pass(|_| Box::new(redundant_slicing::RedundantSlicing));
834     store.register_late_pass(|_| Box::new(from_str_radix_10::FromStrRadix10));
835     store.register_late_pass(move |_| Box::new(if_then_some_else_none::IfThenSomeElseNone::new(msrv)));
836     store.register_late_pass(|_| Box::new(bool_assert_comparison::BoolAssertComparison));
837     store.register_early_pass(move || Box::new(module_style::ModStyle));
838     store.register_late_pass(|_| Box::new(unused_async::UnusedAsync));
839     let disallowed_types = conf.disallowed_types.clone();
840     store.register_late_pass(move |_| Box::new(disallowed_types::DisallowedTypes::new(disallowed_types.clone())));
841     let import_renames = conf.enforced_import_renames.clone();
842     store.register_late_pass(move |_| {
843         Box::new(missing_enforced_import_rename::ImportRename::new(
844             import_renames.clone(),
845         ))
846     });
847     let scripts = conf.allowed_scripts.clone();
848     store.register_early_pass(move || Box::new(disallowed_script_idents::DisallowedScriptIdents::new(&scripts)));
849     store.register_late_pass(|_| Box::new(strlen_on_c_strings::StrlenOnCStrings));
850     store.register_late_pass(move |_| Box::new(self_named_constructors::SelfNamedConstructors));
851     store.register_late_pass(move |_| Box::new(iter_not_returning_iterator::IterNotReturningIterator));
852     store.register_late_pass(move |_| Box::new(manual_assert::ManualAssert));
853     let enable_raw_pointer_heuristic_for_send = conf.enable_raw_pointer_heuristic_for_send;
854     store.register_late_pass(move |_| {
855         Box::new(non_send_fields_in_send_ty::NonSendFieldInSendTy::new(
856             enable_raw_pointer_heuristic_for_send,
857         ))
858     });
859     store.register_late_pass(move |_| Box::new(undocumented_unsafe_blocks::UndocumentedUnsafeBlocks));
860     store.register_late_pass(move |_| Box::new(format_args::FormatArgs));
861     store.register_late_pass(|_| Box::new(trailing_empty_array::TrailingEmptyArray));
862     store.register_early_pass(|| Box::new(octal_escapes::OctalEscapes));
863     store.register_late_pass(|_| Box::new(needless_late_init::NeedlessLateInit));
864     store.register_late_pass(|_| Box::new(return_self_not_must_use::ReturnSelfNotMustUse));
865     store.register_late_pass(|_| Box::new(init_numbered_fields::NumberedFields));
866     store.register_early_pass(|| Box::new(single_char_lifetime_names::SingleCharLifetimeNames));
867     store.register_late_pass(move |_| Box::new(manual_bits::ManualBits::new(msrv)));
868     store.register_late_pass(|_| Box::new(default_union_representation::DefaultUnionRepresentation));
869     store.register_early_pass(|| Box::new(doc_link_with_quotes::DocLinkWithQuotes));
870     store.register_late_pass(|_| Box::new(only_used_in_recursion::OnlyUsedInRecursion::default()));
871     let allow_dbg_in_tests = conf.allow_dbg_in_tests;
872     store.register_late_pass(move |_| Box::new(dbg_macro::DbgMacro::new(allow_dbg_in_tests)));
873     let cargo_ignore_publish = conf.cargo_ignore_publish;
874     store.register_late_pass(move |_| {
875         Box::new(cargo::Cargo {
876             ignore_publish: cargo_ignore_publish,
877         })
878     });
879     store.register_late_pass(|_| Box::new(write::Write::default()));
880     store.register_early_pass(|| Box::new(crate_in_macro_def::CrateInMacroDef));
881     store.register_early_pass(|| Box::new(empty_structs_with_brackets::EmptyStructsWithBrackets));
882     store.register_late_pass(|_| Box::new(unnecessary_owned_empty_strings::UnnecessaryOwnedEmptyStrings));
883     store.register_early_pass(|| Box::new(pub_use::PubUse));
884     store.register_late_pass(|_| Box::new(format_push_string::FormatPushString));
885     let max_include_file_size = conf.max_include_file_size;
886     store.register_late_pass(move |_| Box::new(large_include_file::LargeIncludeFile::new(max_include_file_size)));
887     store.register_late_pass(|_| Box::new(strings::TrimSplitWhitespace));
888     store.register_late_pass(|_| Box::new(rc_clone_in_vec_init::RcCloneInVecInit));
889     store.register_early_pass(|| Box::new(duplicate_mod::DuplicateMod::default()));
890     store.register_early_pass(|| Box::new(unused_rounding::UnusedRounding));
891     store.register_early_pass(move || Box::new(almost_complete_letter_range::AlmostCompleteLetterRange::new(msrv)));
892     store.register_late_pass(|_| Box::new(swap_ptr_to_ref::SwapPtrToRef));
893     store.register_late_pass(|_| Box::new(mismatching_type_param_order::TypeParamMismatch));
894     store.register_late_pass(|_| Box::new(read_zero_byte_vec::ReadZeroByteVec));
895     store.register_late_pass(|_| Box::new(default_instead_of_iter_empty::DefaultIterEmpty));
896     store.register_late_pass(move |_| Box::new(manual_rem_euclid::ManualRemEuclid::new(msrv)));
897     store.register_late_pass(move |_| Box::new(manual_retain::ManualRetain::new(msrv)));
898     let verbose_bit_mask_threshold = conf.verbose_bit_mask_threshold;
899     store.register_late_pass(move |_| Box::new(operators::Operators::new(verbose_bit_mask_threshold)));
900     store.register_late_pass(|_| Box::new(invalid_utf8_in_unchecked::InvalidUtf8InUnchecked));
901     store.register_late_pass(|_| Box::new(std_instead_of_core::StdReexports::default()));
902     store.register_late_pass(|_| Box::new(manual_instant_elapsed::ManualInstantElapsed));
903     store.register_late_pass(|_| Box::new(partialeq_to_none::PartialeqToNone));
904     store.register_late_pass(|_| Box::new(manual_string_new::ManualStringNew));
905     store.register_late_pass(|_| Box::new(unused_peekable::UnusedPeekable));
906     store.register_early_pass(|| Box::new(multi_assignments::MultiAssignments));
907     store.register_late_pass(|_| Box::new(bool_to_int_with_if::BoolToIntWithIf));
908     // add lints here, do not remove this comment, it's used in `new_lint`
909 }
910
911 #[rustfmt::skip]
912 fn register_removed_non_tool_lints(store: &mut rustc_lint::LintStore) {
913     store.register_removed(
914         "should_assert_eq",
915         "`assert!()` will be more flexible with RFC 2011",
916     );
917     store.register_removed(
918         "extend_from_slice",
919         "`.extend_from_slice(_)` is a faster way to extend a Vec by a slice",
920     );
921     store.register_removed(
922         "range_step_by_zero",
923         "`iterator.step_by(0)` panics nowadays",
924     );
925     store.register_removed(
926         "unstable_as_slice",
927         "`Vec::as_slice` has been stabilized in 1.7",
928     );
929     store.register_removed(
930         "unstable_as_mut_slice",
931         "`Vec::as_mut_slice` has been stabilized in 1.7",
932     );
933     store.register_removed(
934         "misaligned_transmute",
935         "this lint has been split into cast_ptr_alignment and transmute_ptr_to_ptr",
936     );
937     store.register_removed(
938         "assign_ops",
939         "using compound assignment operators (e.g., `+=`) is harmless",
940     );
941     store.register_removed(
942         "if_let_redundant_pattern_matching",
943         "this lint has been changed to redundant_pattern_matching",
944     );
945     store.register_removed(
946         "unsafe_vector_initialization",
947         "the replacement suggested by this lint had substantially different behavior",
948     );
949     store.register_removed(
950         "reverse_range_loop",
951         "this lint is now included in reversed_empty_ranges",
952     );
953 }
954
955 /// Register renamed lints.
956 ///
957 /// Used in `./src/driver.rs`.
958 pub fn register_renamed(ls: &mut rustc_lint::LintStore) {
959     for (old_name, new_name) in renamed_lints::RENAMED_LINTS {
960         ls.register_renamed(old_name, new_name);
961     }
962 }
963
964 // only exists to let the dogfood integration test works.
965 // Don't run clippy as an executable directly
966 #[allow(dead_code)]
967 fn main() {
968     panic!("Please use the cargo-clippy executable");
969 }