1 #![feature(array_windows)]
2 #![feature(binary_heap_into_iter_sorted)]
3 #![feature(box_patterns)]
4 #![feature(control_flow_enum)]
5 #![feature(drain_filter)]
6 #![feature(iter_intersperse)]
7 #![feature(let_chains)]
8 #![feature(lint_reasons)]
9 #![feature(never_type)]
10 #![feature(once_cell)]
11 #![feature(rustc_private)]
12 #![feature(stmt_expr_attributes)]
13 #![recursion_limit = "512"]
14 #![cfg_attr(feature = "deny-warnings", deny(warnings))]
15 #![allow(clippy::missing_docs_in_private_items, clippy::must_use_candidate)]
16 #![warn(trivial_casts, trivial_numeric_casts)]
17 // warn on lints, that are included in `rust-lang/rust`s bootstrap
18 #![warn(rust_2018_idioms, unused_lifetimes)]
19 // warn on rustc internal lints
20 #![warn(rustc::internal)]
21 // Disable this rustc lint for now, as it was also done in rustc
22 #![allow(rustc::potential_query_instability)]
24 // FIXME: switch to something more ergonomic here, once available.
25 // (Currently there is no way to opt into sysroot crates without `extern crate`.)
26 extern crate rustc_arena;
27 extern crate rustc_ast;
28 extern crate rustc_ast_pretty;
29 extern crate rustc_data_structures;
30 extern crate rustc_driver;
31 extern crate rustc_errors;
32 extern crate rustc_hir;
33 extern crate rustc_hir_analysis;
34 extern crate rustc_hir_pretty;
35 extern crate rustc_hir_typeck;
36 extern crate rustc_index;
37 extern crate rustc_infer;
38 extern crate rustc_lexer;
39 extern crate rustc_lint;
40 extern crate rustc_middle;
41 extern crate rustc_parse;
42 extern crate rustc_session;
43 extern crate rustc_span;
44 extern crate rustc_target;
45 extern crate rustc_trait_selection;
48 extern crate clippy_utils;
50 extern crate declare_clippy_lint;
53 use std::path::PathBuf;
55 use clippy_utils::parse_msrv;
56 use rustc_data_structures::fx::FxHashSet;
57 use rustc_lint::{Lint, LintId};
58 use rustc_semver::RustcVersion;
59 use rustc_session::Session;
61 #[cfg(feature = "internal")]
62 pub mod deprecated_lints;
63 #[cfg_attr(feature = "internal", allow(clippy::missing_clippy_version_attribute))]
69 // begin lints modules, do not remove this comment, it’s used in `update_lints`
70 mod almost_complete_letter_range;
74 mod assertions_on_constants;
75 mod assertions_on_result_states;
76 mod async_yields_async;
78 mod await_holding_invalid;
79 mod blocks_in_if_conditions;
80 mod bool_assert_comparison;
81 mod bool_to_int_with_if;
87 mod checked_conversions;
88 mod cognitive_complexity;
93 mod crate_in_macro_def;
97 mod default_instead_of_iter_empty;
98 mod default_numeric_fallback;
99 mod default_union_representation;
103 mod disallowed_macros;
104 mod disallowed_methods;
105 mod disallowed_names;
106 mod disallowed_script_idents;
107 mod disallowed_types;
112 mod else_if_without_else;
115 mod empty_structs_with_brackets;
119 mod equatable_if_let;
123 mod exhaustive_items;
126 mod fallible_impl_from;
128 mod floating_point_arithmetic;
132 mod format_push_string;
135 mod from_raw_with_void_ptr;
136 mod from_str_radix_10;
141 mod if_then_some_else_none;
144 mod implicit_saturating_add;
145 mod implicit_saturating_sub;
146 mod inconsistent_struct_constructor;
147 mod index_refutable_slice;
148 mod indexing_slicing;
151 mod inherent_to_string;
152 mod init_numbered_fields;
153 mod inline_fn_without_body;
154 mod instant_subtraction;
156 mod invalid_upcast_comparisons;
157 mod invalid_utf8_in_unchecked;
158 mod items_after_statements;
159 mod iter_not_returning_iterator;
160 mod large_const_arrays;
161 mod large_enum_variant;
162 mod large_include_file;
163 mod large_stack_arrays;
168 mod literal_representation;
176 mod manual_is_ascii_check;
178 mod manual_non_exhaustive;
179 mod manual_rem_euclid;
181 mod manual_string_new;
192 mod mismatching_type_param_order;
193 mod missing_const_for_fn;
195 mod missing_enforced_import_rename;
197 mod missing_trait_methods;
198 mod mixed_read_write_in_expression;
200 mod multi_assignments;
204 mod mutable_debug_assertion;
206 mod needless_arbitrary_self_type;
208 mod needless_borrowed_ref;
209 mod needless_continue;
210 mod needless_for_each;
211 mod needless_late_init;
212 mod needless_parens_on_range_literals;
213 mod needless_pass_by_value;
214 mod needless_question_mark;
216 mod neg_cmp_op_on_partial_ord;
218 mod new_without_default;
221 mod non_expressive_names;
222 mod non_octal_unix_permissions;
223 mod non_send_fields_in_send_ty;
224 mod nonstandard_macro_braces;
226 mod only_used_in_recursion;
228 mod option_env_unwrap;
229 mod option_if_let_else;
230 mod overflow_check_conditional;
231 mod panic_in_result_fn;
232 mod panic_unimplemented;
233 mod partial_pub_fields;
234 mod partialeq_ne_impl;
235 mod partialeq_to_none;
236 mod pass_by_ref_or_value;
237 mod pattern_type_mismatch;
240 mod ptr_offset_with_cast;
244 mod rc_clone_in_vec_init;
245 mod read_zero_byte_vec;
247 mod redundant_closure_call;
249 mod redundant_field_names;
250 mod redundant_pub_crate;
251 mod redundant_slicing;
252 mod redundant_static_lifetimes;
256 mod return_self_not_must_use;
258 mod same_name_method;
259 mod self_named_constructors;
260 mod semicolon_if_nothing_returned;
263 mod single_char_lifetime_names;
264 mod single_component_path_imports;
265 mod size_of_in_element_count;
266 mod slow_vector_initialization;
267 mod std_instead_of_core;
269 mod strlen_on_c_strings;
270 mod suspicious_operation_groupings;
271 mod suspicious_trait_impl;
272 mod suspicious_xor_used_as_pow;
275 mod tabs_in_doc_comments;
276 mod temporary_assignment;
277 mod to_digit_is_some;
278 mod trailing_empty_array;
282 mod undocumented_unsafe_blocks;
285 mod unit_return_expecting_ord;
288 mod unnecessary_owned_empty_strings;
289 mod unnecessary_self_imports;
290 mod unnecessary_wraps;
291 mod unnested_or_patterns;
292 mod unsafe_removed_from_name;
294 mod unused_io_amount;
300 mod unwrap_in_result;
301 mod upper_case_acronyms;
303 mod useless_conversion;
305 mod vec_init_then_push;
306 mod wildcard_imports;
309 mod zero_sized_map_values;
310 // end lints modules, do not remove this comment, it’s used in `update_lints`
312 use crate::utils::conf::{format_error, TryConf};
313 pub use crate::utils::conf::{lookup_conf_file, Conf};
315 /// Register all pre expansion lints
317 /// Pre-expansion lints run before any macro expansion has happened.
319 /// Note that due to the architecture of the compiler, currently `cfg_attr` attributes on crate
320 /// level (i.e `#![cfg_attr(...)]`) will still be expanded even when using a pre-expansion pass.
322 /// Used in `./src/driver.rs`.
323 pub fn register_pre_expansion_lints(store: &mut rustc_lint::LintStore, sess: &Session, conf: &Conf) {
324 // NOTE: Do not add any more pre-expansion passes. These should be removed eventually.
326 let msrv = conf.msrv.as_ref().and_then(|s| {
327 parse_msrv(s, None, None).or_else(|| {
329 "error reading Clippy's configuration file. `{s}` is not a valid Rust version"
335 store.register_pre_expansion_pass(move || Box::new(attrs::EarlyAttributes { msrv }));
338 fn read_msrv(conf: &Conf, sess: &Session) -> Option<RustcVersion> {
339 let cargo_msrv = std::env::var("CARGO_PKG_RUST_VERSION")
341 .and_then(|v| parse_msrv(&v, None, None));
342 let clippy_msrv = conf.msrv.as_ref().and_then(|s| {
343 parse_msrv(s, None, None).or_else(|| {
345 "error reading Clippy's configuration file. `{s}` is not a valid Rust version"
351 if let Some(cargo_msrv) = cargo_msrv {
352 if let Some(clippy_msrv) = clippy_msrv {
353 // if both files have an msrv, let's compare them and emit a warning if they differ
354 if clippy_msrv != cargo_msrv {
356 "the MSRV in `clippy.toml` and `Cargo.toml` differ; using `{clippy_msrv}` from `clippy.toml`"
370 pub fn read_conf(sess: &Session, path: &io::Result<Option<PathBuf>>) -> Conf {
371 let file_name = match path {
372 Ok(Some(path)) => path,
373 Ok(None) => return Conf::default(),
375 sess.struct_err(&format!("error finding Clippy's configuration file: {error}"))
377 return Conf::default();
381 let TryConf { conf, errors, warnings } = utils::conf::read(file_name);
382 // all conf errors are non-fatal, we just use the default conf in case of error
383 for error in errors {
385 "error reading Clippy's configuration file `{}`: {}",
391 for warning in warnings {
392 sess.struct_warn(format!(
393 "error reading Clippy's configuration file `{}`: {}",
395 format_error(warning)
404 struct RegistrationGroups {
407 complexity: Vec<LintId>,
408 correctness: Vec<LintId>,
409 nursery: Vec<LintId>,
410 pedantic: Vec<LintId>,
412 restriction: Vec<LintId>,
414 suspicious: Vec<LintId>,
415 #[cfg(feature = "internal")]
416 internal: Vec<LintId>,
419 impl RegistrationGroups {
421 fn register(self, store: &mut rustc_lint::LintStore) {
422 store.register_group(true, "clippy::all", Some("clippy_all"), self.all);
423 store.register_group(true, "clippy::cargo", Some("clippy_cargo"), self.cargo);
424 store.register_group(true, "clippy::complexity", Some("clippy_complexity"), self.complexity);
425 store.register_group(true, "clippy::correctness", Some("clippy_correctness"), self.correctness);
426 store.register_group(true, "clippy::nursery", Some("clippy_nursery"), self.nursery);
427 store.register_group(true, "clippy::pedantic", Some("clippy_pedantic"), self.pedantic);
428 store.register_group(true, "clippy::perf", Some("clippy_perf"), self.perf);
429 store.register_group(true, "clippy::restriction", Some("clippy_restriction"), self.restriction);
430 store.register_group(true, "clippy::style", Some("clippy_style"), self.style);
431 store.register_group(true, "clippy::suspicious", Some("clippy_suspicious"), self.suspicious);
432 #[cfg(feature = "internal")]
433 store.register_group(true, "clippy::internal", Some("clippy_internal"), self.internal);
437 #[derive(Copy, Clone)]
438 pub(crate) enum LintCategory {
448 #[cfg(feature = "internal")]
451 #[allow(clippy::enum_glob_use)]
455 fn is_all(self) -> bool {
456 matches!(self, Correctness | Suspicious | Style | Complexity | Perf)
459 fn group(self, groups: &mut RegistrationGroups) -> &mut Vec<LintId> {
461 Cargo => &mut groups.cargo,
462 Complexity => &mut groups.complexity,
463 Correctness => &mut groups.correctness,
464 Nursery => &mut groups.nursery,
465 Pedantic => &mut groups.pedantic,
466 Perf => &mut groups.perf,
467 Restriction => &mut groups.restriction,
468 Style => &mut groups.style,
469 Suspicious => &mut groups.suspicious,
470 #[cfg(feature = "internal")]
471 Internal => &mut groups.internal,
476 pub(crate) struct LintInfo {
477 /// Double reference to maintain pointer equality
478 lint: &'static &'static Lint,
479 category: LintCategory,
480 explanation: &'static str,
483 pub fn explain(name: &str) {
484 let target = format!("clippy::{}", name.to_ascii_uppercase());
485 match declared_lints::LINTS.iter().find(|info| info.lint.name == target) {
486 Some(info) => print!("{}", info.explanation),
487 None => println!("unknown lint: {name}"),
491 fn register_categories(store: &mut rustc_lint::LintStore) {
492 let mut groups = RegistrationGroups::default();
494 for LintInfo { lint, category, .. } in declared_lints::LINTS {
495 if category.is_all() {
496 groups.all.push(LintId::of(lint));
499 category.group(&mut groups).push(LintId::of(lint));
502 let lints: Vec<&'static Lint> = declared_lints::LINTS.iter().map(|info| *info.lint).collect();
504 store.register_lints(&lints);
505 groups.register(store);
508 /// Register all lints and lint groups with the rustc plugin registry
510 /// Used in `./src/driver.rs`.
511 #[expect(clippy::too_many_lines)]
512 pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf: &Conf) {
513 register_removed_non_tool_lints(store);
514 register_categories(store);
516 include!("lib.deprecated.rs");
518 #[cfg(feature = "internal")]
520 if std::env::var("ENABLE_METADATA_COLLECTION").eq(&Ok("1".to_string())) {
521 store.register_late_pass(|_| Box::new(utils::internal_lints::metadata_collector::MetadataCollector::new()));
526 // all the internal lints
527 #[cfg(feature = "internal")]
529 store.register_early_pass(|| Box::new(utils::internal_lints::clippy_lints_internal::ClippyLintsInternal));
530 store.register_early_pass(|| Box::new(utils::internal_lints::produce_ice::ProduceIce));
531 store.register_late_pass(|_| Box::new(utils::internal_lints::collapsible_calls::CollapsibleCalls));
532 store.register_late_pass(|_| {
533 Box::new(utils::internal_lints::compiler_lint_functions::CompilerLintFunctions::new())
535 store.register_late_pass(|_| Box::new(utils::internal_lints::if_chain_style::IfChainStyle));
536 store.register_late_pass(|_| Box::new(utils::internal_lints::invalid_paths::InvalidPaths));
537 store.register_late_pass(|_| {
538 Box::<utils::internal_lints::interning_defined_symbol::InterningDefinedSymbol>::default()
540 store.register_late_pass(|_| {
541 Box::<utils::internal_lints::lint_without_lint_pass::LintWithoutLintPass>::default()
543 store.register_late_pass(|_| Box::<utils::internal_lints::unnecessary_def_path::UnnecessaryDefPath>::default());
544 store.register_late_pass(|_| Box::new(utils::internal_lints::outer_expn_data_pass::OuterExpnDataPass));
545 store.register_late_pass(|_| Box::new(utils::internal_lints::msrv_attr_impl::MsrvAttrImpl));
548 let arithmetic_side_effects_allowed = conf.arithmetic_side_effects_allowed.clone();
549 store.register_late_pass(move |_| {
550 Box::new(operators::arithmetic_side_effects::ArithmeticSideEffects::new(
551 arithmetic_side_effects_allowed.clone(),
554 store.register_late_pass(|_| Box::new(utils::dump_hir::DumpHir));
555 store.register_late_pass(|_| Box::new(utils::author::Author));
556 let await_holding_invalid_types = conf.await_holding_invalid_types.clone();
557 store.register_late_pass(move |_| {
558 Box::new(await_holding_invalid::AwaitHolding::new(
559 await_holding_invalid_types.clone(),
562 store.register_late_pass(|_| Box::new(serde_api::SerdeApi));
563 let vec_box_size_threshold = conf.vec_box_size_threshold;
564 let type_complexity_threshold = conf.type_complexity_threshold;
565 let avoid_breaking_exported_api = conf.avoid_breaking_exported_api;
566 store.register_late_pass(move |_| {
567 Box::new(types::Types::new(
568 vec_box_size_threshold,
569 type_complexity_threshold,
570 avoid_breaking_exported_api,
573 store.register_late_pass(|_| Box::new(booleans::NonminimalBool));
574 store.register_late_pass(|_| Box::new(enum_clike::UnportableVariant));
575 store.register_late_pass(|_| Box::new(float_literal::FloatLiteral));
576 store.register_late_pass(|_| Box::new(ptr::Ptr));
577 store.register_late_pass(|_| Box::new(needless_bool::NeedlessBool));
578 store.register_late_pass(|_| Box::new(needless_bool::BoolComparison));
579 store.register_late_pass(|_| Box::new(needless_for_each::NeedlessForEach));
580 store.register_late_pass(|_| Box::new(misc::MiscLints));
581 store.register_late_pass(|_| Box::new(eta_reduction::EtaReduction));
582 store.register_late_pass(|_| Box::new(mut_mut::MutMut));
583 store.register_late_pass(|_| Box::new(mut_reference::UnnecessaryMutPassed));
584 store.register_late_pass(|_| Box::new(len_zero::LenZero));
585 store.register_late_pass(|_| Box::new(attrs::Attributes));
586 store.register_late_pass(|_| Box::new(blocks_in_if_conditions::BlocksInIfConditions));
587 store.register_late_pass(|_| Box::new(unicode::Unicode));
588 store.register_late_pass(|_| Box::new(uninit_vec::UninitVec));
589 store.register_late_pass(|_| Box::new(unit_return_expecting_ord::UnitReturnExpectingOrd));
590 store.register_late_pass(|_| Box::new(strings::StringAdd));
591 store.register_late_pass(|_| Box::new(implicit_return::ImplicitReturn));
592 store.register_late_pass(|_| Box::new(implicit_saturating_sub::ImplicitSaturatingSub));
593 store.register_late_pass(|_| Box::new(default_numeric_fallback::DefaultNumericFallback));
594 store.register_late_pass(|_| Box::new(inconsistent_struct_constructor::InconsistentStructConstructor));
595 store.register_late_pass(|_| Box::new(non_octal_unix_permissions::NonOctalUnixPermissions));
596 store.register_early_pass(|| Box::new(unnecessary_self_imports::UnnecessarySelfImports));
598 let msrv = read_msrv(conf, sess);
599 let avoid_breaking_exported_api = conf.avoid_breaking_exported_api;
600 let allow_expect_in_tests = conf.allow_expect_in_tests;
601 let allow_unwrap_in_tests = conf.allow_unwrap_in_tests;
602 store.register_late_pass(move |_| Box::new(approx_const::ApproxConstant::new(msrv)));
603 store.register_late_pass(move |_| {
604 Box::new(methods::Methods::new(
605 avoid_breaking_exported_api,
607 allow_expect_in_tests,
608 allow_unwrap_in_tests,
611 store.register_late_pass(move |_| Box::new(matches::Matches::new(msrv)));
612 let matches_for_let_else = conf.matches_for_let_else;
613 store.register_late_pass(move |_| Box::new(manual_let_else::ManualLetElse::new(msrv, matches_for_let_else)));
614 store.register_early_pass(move || Box::new(manual_non_exhaustive::ManualNonExhaustiveStruct::new(msrv)));
615 store.register_late_pass(move |_| Box::new(manual_non_exhaustive::ManualNonExhaustiveEnum::new(msrv)));
616 store.register_late_pass(move |_| Box::new(manual_strip::ManualStrip::new(msrv)));
617 store.register_early_pass(move || Box::new(redundant_static_lifetimes::RedundantStaticLifetimes::new(msrv)));
618 store.register_early_pass(move || Box::new(redundant_field_names::RedundantFieldNames::new(msrv)));
619 store.register_late_pass(move |_| Box::new(checked_conversions::CheckedConversions::new(msrv)));
620 store.register_late_pass(move |_| Box::new(mem_replace::MemReplace::new(msrv)));
621 store.register_late_pass(move |_| Box::new(ranges::Ranges::new(msrv)));
622 store.register_late_pass(move |_| Box::new(from_over_into::FromOverInto::new(msrv)));
623 store.register_late_pass(move |_| Box::new(use_self::UseSelf::new(msrv)));
624 store.register_late_pass(move |_| Box::new(missing_const_for_fn::MissingConstForFn::new(msrv)));
625 store.register_late_pass(move |_| Box::new(needless_question_mark::NeedlessQuestionMark));
626 store.register_late_pass(move |_| Box::new(casts::Casts::new(msrv)));
627 store.register_early_pass(move || Box::new(unnested_or_patterns::UnnestedOrPatterns::new(msrv)));
628 store.register_late_pass(|_| Box::new(size_of_in_element_count::SizeOfInElementCount));
629 store.register_late_pass(|_| Box::new(same_name_method::SameNameMethod));
630 let max_suggested_slice_pattern_length = conf.max_suggested_slice_pattern_length;
631 store.register_late_pass(move |_| {
632 Box::new(index_refutable_slice::IndexRefutableSlice::new(
633 max_suggested_slice_pattern_length,
637 store.register_late_pass(|_| Box::<shadow::Shadow>::default());
638 store.register_late_pass(|_| Box::new(unit_types::UnitTypes));
639 store.register_late_pass(|_| Box::new(loops::Loops));
640 store.register_late_pass(|_| Box::<main_recursion::MainRecursion>::default());
641 store.register_late_pass(|_| Box::new(lifetimes::Lifetimes));
642 store.register_late_pass(|_| Box::new(entry::HashMapPass));
643 store.register_late_pass(|_| Box::new(minmax::MinMaxPass));
644 store.register_late_pass(|_| Box::new(zero_div_zero::ZeroDiv));
645 store.register_late_pass(|_| Box::new(mutex_atomic::Mutex));
646 store.register_late_pass(|_| Box::new(needless_update::NeedlessUpdate));
647 store.register_late_pass(|_| Box::new(needless_borrowed_ref::NeedlessBorrowedRef));
648 store.register_late_pass(|_| Box::new(borrow_deref_ref::BorrowDerefRef));
649 store.register_late_pass(|_| Box::new(no_effect::NoEffect));
650 store.register_late_pass(|_| Box::new(temporary_assignment::TemporaryAssignment));
651 store.register_late_pass(move |_| Box::new(transmute::Transmute::new(msrv)));
652 let cognitive_complexity_threshold = conf.cognitive_complexity_threshold;
653 store.register_late_pass(move |_| {
654 Box::new(cognitive_complexity::CognitiveComplexity::new(
655 cognitive_complexity_threshold,
658 let too_large_for_stack = conf.too_large_for_stack;
659 store.register_late_pass(move |_| Box::new(escape::BoxedLocal { too_large_for_stack }));
660 store.register_late_pass(move |_| Box::new(vec::UselessVec { too_large_for_stack }));
661 store.register_late_pass(|_| Box::new(panic_unimplemented::PanicUnimplemented));
662 store.register_late_pass(|_| Box::new(strings::StringLitAsBytes));
663 store.register_late_pass(|_| Box::new(derive::Derive));
664 store.register_late_pass(|_| Box::new(derivable_impls::DerivableImpls));
665 store.register_late_pass(|_| Box::new(drop_forget_ref::DropForgetRef));
666 store.register_late_pass(|_| Box::new(empty_enum::EmptyEnum));
667 store.register_late_pass(|_| Box::new(invalid_upcast_comparisons::InvalidUpcastComparisons));
668 store.register_late_pass(|_| Box::new(regex::Regex));
669 store.register_late_pass(|_| Box::new(copies::CopyAndPaste));
670 store.register_late_pass(|_| Box::new(copy_iterator::CopyIterator));
671 store.register_late_pass(|_| Box::new(format::UselessFormat));
672 store.register_late_pass(|_| Box::new(swap::Swap));
673 store.register_late_pass(|_| Box::new(overflow_check_conditional::OverflowCheckConditional));
674 store.register_late_pass(|_| Box::<new_without_default::NewWithoutDefault>::default());
675 let disallowed_names = conf.disallowed_names.iter().cloned().collect::<FxHashSet<_>>();
676 store.register_late_pass(move |_| Box::new(disallowed_names::DisallowedNames::new(disallowed_names.clone())));
677 let too_many_arguments_threshold = conf.too_many_arguments_threshold;
678 let too_many_lines_threshold = conf.too_many_lines_threshold;
679 let large_error_threshold = conf.large_error_threshold;
680 store.register_late_pass(move |_| {
681 Box::new(functions::Functions::new(
682 too_many_arguments_threshold,
683 too_many_lines_threshold,
684 large_error_threshold,
687 let doc_valid_idents = conf.doc_valid_idents.iter().cloned().collect::<FxHashSet<_>>();
688 store.register_late_pass(move |_| Box::new(doc::DocMarkdown::new(doc_valid_idents.clone())));
689 store.register_late_pass(|_| Box::new(neg_multiply::NegMultiply));
690 store.register_late_pass(|_| Box::new(mem_forget::MemForget));
691 store.register_late_pass(|_| Box::new(let_if_seq::LetIfSeq));
692 store.register_late_pass(|_| Box::new(mixed_read_write_in_expression::EvalOrderDependence));
693 store.register_late_pass(|_| Box::new(missing_doc::MissingDoc::new()));
694 store.register_late_pass(|_| Box::new(missing_inline::MissingInline));
695 store.register_late_pass(move |_| Box::new(exhaustive_items::ExhaustiveItems));
696 store.register_late_pass(|_| Box::new(match_result_ok::MatchResultOk));
697 store.register_late_pass(|_| Box::new(partialeq_ne_impl::PartialEqNeImpl));
698 store.register_late_pass(|_| Box::new(unused_io_amount::UnusedIoAmount));
699 let enum_variant_size_threshold = conf.enum_variant_size_threshold;
700 store.register_late_pass(move |_| Box::new(large_enum_variant::LargeEnumVariant::new(enum_variant_size_threshold)));
701 store.register_late_pass(|_| Box::new(explicit_write::ExplicitWrite));
702 store.register_late_pass(|_| Box::new(needless_pass_by_value::NeedlessPassByValue));
703 let pass_by_ref_or_value = pass_by_ref_or_value::PassByRefOrValue::new(
704 conf.trivial_copy_size_limit,
705 conf.pass_by_value_size_limit,
706 conf.avoid_breaking_exported_api,
709 store.register_late_pass(move |_| Box::new(pass_by_ref_or_value));
710 store.register_late_pass(|_| Box::new(ref_option_ref::RefOptionRef));
711 store.register_late_pass(|_| Box::new(infinite_iter::InfiniteIter));
712 store.register_late_pass(|_| Box::new(inline_fn_without_body::InlineFnWithoutBody));
713 store.register_late_pass(|_| Box::<useless_conversion::UselessConversion>::default());
714 store.register_late_pass(|_| Box::new(implicit_hasher::ImplicitHasher));
715 store.register_late_pass(|_| Box::new(fallible_impl_from::FallibleImplFrom));
716 store.register_late_pass(|_| Box::new(question_mark::QuestionMark));
717 store.register_early_pass(|| Box::new(suspicious_operation_groupings::SuspiciousOperationGroupings));
718 store.register_late_pass(|_| Box::new(suspicious_trait_impl::SuspiciousImpl));
719 store.register_late_pass(|_| Box::new(map_unit_fn::MapUnit));
720 store.register_late_pass(|_| Box::new(inherent_impl::MultipleInherentImpl));
721 store.register_late_pass(|_| Box::new(neg_cmp_op_on_partial_ord::NoNegCompOpForPartialOrd));
722 store.register_late_pass(|_| Box::new(unwrap::Unwrap));
723 store.register_late_pass(|_| Box::new(indexing_slicing::IndexingSlicing));
724 store.register_late_pass(|_| Box::new(non_copy_const::NonCopyConst));
725 store.register_late_pass(|_| Box::new(ptr_offset_with_cast::PtrOffsetWithCast));
726 store.register_late_pass(|_| Box::new(redundant_clone::RedundantClone));
727 store.register_late_pass(|_| Box::new(slow_vector_initialization::SlowVectorInit));
728 store.register_late_pass(move |_| Box::new(unnecessary_wraps::UnnecessaryWraps::new(avoid_breaking_exported_api)));
729 store.register_late_pass(|_| Box::new(assertions_on_constants::AssertionsOnConstants));
730 store.register_late_pass(|_| Box::new(assertions_on_result_states::AssertionsOnResultStates));
731 store.register_late_pass(|_| Box::new(inherent_to_string::InherentToString));
732 let max_trait_bounds = conf.max_trait_bounds;
733 store.register_late_pass(move |_| Box::new(trait_bounds::TraitBounds::new(max_trait_bounds)));
734 store.register_late_pass(|_| Box::new(comparison_chain::ComparisonChain));
735 let ignore_interior_mutability = conf.ignore_interior_mutability.clone();
736 store.register_late_pass(move |_| Box::new(mut_key::MutableKeyType::new(ignore_interior_mutability.clone())));
737 store.register_early_pass(|| Box::new(reference::DerefAddrOf));
738 store.register_early_pass(|| Box::new(double_parens::DoubleParens));
739 store.register_late_pass(|_| Box::new(format_impl::FormatImpl::new()));
740 store.register_early_pass(|| Box::new(unsafe_removed_from_name::UnsafeNameRemoval));
741 store.register_early_pass(|| Box::new(else_if_without_else::ElseIfWithoutElse));
742 store.register_early_pass(|| Box::new(int_plus_one::IntPlusOne));
743 store.register_early_pass(|| Box::new(formatting::Formatting));
744 store.register_early_pass(|| Box::new(misc_early::MiscEarlyLints));
745 store.register_early_pass(|| Box::new(redundant_closure_call::RedundantClosureCall));
746 store.register_late_pass(|_| Box::new(redundant_closure_call::RedundantClosureCall));
747 store.register_early_pass(|| Box::new(unused_unit::UnusedUnit));
748 store.register_late_pass(|_| Box::new(returns::Return));
749 store.register_early_pass(|| Box::new(collapsible_if::CollapsibleIf));
750 store.register_early_pass(|| Box::new(items_after_statements::ItemsAfterStatements));
751 store.register_early_pass(|| Box::new(precedence::Precedence));
752 store.register_late_pass(|_| Box::new(needless_parens_on_range_literals::NeedlessParensOnRangeLiterals));
753 store.register_early_pass(|| Box::new(needless_continue::NeedlessContinue));
754 store.register_early_pass(|| Box::new(redundant_else::RedundantElse));
755 store.register_late_pass(|_| Box::new(create_dir::CreateDir));
756 store.register_early_pass(|| Box::new(needless_arbitrary_self_type::NeedlessArbitrarySelfType));
757 let literal_representation_lint_fraction_readability = conf.unreadable_literal_lint_fractions;
758 store.register_early_pass(move || {
759 Box::new(literal_representation::LiteralDigitGrouping::new(
760 literal_representation_lint_fraction_readability,
763 let literal_representation_threshold = conf.literal_representation_threshold;
764 store.register_early_pass(move || {
765 Box::new(literal_representation::DecimalLiteralRepresentation::new(
766 literal_representation_threshold,
769 let enum_variant_name_threshold = conf.enum_variant_name_threshold;
770 store.register_late_pass(move |_| {
771 Box::new(enum_variants::EnumVariantNames::new(
772 enum_variant_name_threshold,
773 avoid_breaking_exported_api,
776 store.register_early_pass(|| Box::new(tabs_in_doc_comments::TabsInDocComments));
777 let upper_case_acronyms_aggressive = conf.upper_case_acronyms_aggressive;
778 store.register_late_pass(move |_| {
779 Box::new(upper_case_acronyms::UpperCaseAcronyms::new(
780 avoid_breaking_exported_api,
781 upper_case_acronyms_aggressive,
784 store.register_late_pass(|_| Box::<default::Default>::default());
785 store.register_late_pass(move |_| Box::new(unused_self::UnusedSelf::new(avoid_breaking_exported_api)));
786 store.register_late_pass(|_| Box::new(mutable_debug_assertion::DebugAssertWithMutCall));
787 store.register_late_pass(|_| Box::new(exit::Exit));
788 store.register_late_pass(|_| Box::new(to_digit_is_some::ToDigitIsSome));
789 let array_size_threshold = conf.array_size_threshold;
790 store.register_late_pass(move |_| Box::new(large_stack_arrays::LargeStackArrays::new(array_size_threshold)));
791 store.register_late_pass(move |_| Box::new(large_const_arrays::LargeConstArrays::new(array_size_threshold)));
792 store.register_late_pass(|_| Box::new(floating_point_arithmetic::FloatingPointArithmetic));
793 store.register_early_pass(|| Box::new(as_conversions::AsConversions));
794 store.register_late_pass(|_| Box::new(let_underscore::LetUnderscore));
795 store.register_early_pass(|| Box::<single_component_path_imports::SingleComponentPathImports>::default());
796 let max_fn_params_bools = conf.max_fn_params_bools;
797 let max_struct_bools = conf.max_struct_bools;
798 store.register_late_pass(move |_| {
799 Box::new(excessive_bools::ExcessiveBools::new(
804 store.register_early_pass(|| Box::new(option_env_unwrap::OptionEnvUnwrap));
805 let warn_on_all_wildcard_imports = conf.warn_on_all_wildcard_imports;
806 store.register_late_pass(move |_| Box::new(wildcard_imports::WildcardImports::new(warn_on_all_wildcard_imports)));
807 store.register_late_pass(|_| Box::<redundant_pub_crate::RedundantPubCrate>::default());
808 store.register_late_pass(|_| Box::new(unnamed_address::UnnamedAddress));
809 store.register_late_pass(move |_| Box::new(dereference::Dereferencing::new(msrv)));
810 store.register_late_pass(|_| Box::new(option_if_let_else::OptionIfLetElse));
811 store.register_late_pass(|_| Box::new(future_not_send::FutureNotSend));
812 store.register_late_pass(|_| Box::new(if_let_mutex::IfLetMutex));
813 store.register_late_pass(|_| Box::new(if_not_else::IfNotElse));
814 store.register_late_pass(|_| Box::new(equatable_if_let::PatternEquality));
815 store.register_late_pass(|_| Box::new(manual_async_fn::ManualAsyncFn));
816 store.register_late_pass(|_| Box::new(panic_in_result_fn::PanicInResultFn));
817 let single_char_binding_names_threshold = conf.single_char_binding_names_threshold;
818 store.register_early_pass(move || {
819 Box::new(non_expressive_names::NonExpressiveNames {
820 single_char_binding_names_threshold,
823 let macro_matcher = conf.standard_macro_braces.iter().cloned().collect::<FxHashSet<_>>();
824 store.register_early_pass(move || Box::new(nonstandard_macro_braces::MacroBraces::new(¯o_matcher)));
825 store.register_late_pass(|_| Box::<macro_use::MacroUseImports>::default());
826 store.register_late_pass(|_| Box::new(pattern_type_mismatch::PatternTypeMismatch));
827 store.register_late_pass(|_| Box::new(unwrap_in_result::UnwrapInResult));
828 store.register_late_pass(|_| Box::new(semicolon_if_nothing_returned::SemicolonIfNothingReturned));
829 store.register_late_pass(|_| Box::new(async_yields_async::AsyncYieldsAsync));
830 let disallowed_macros = conf.disallowed_macros.clone();
831 store.register_late_pass(move |_| Box::new(disallowed_macros::DisallowedMacros::new(disallowed_macros.clone())));
832 let disallowed_methods = conf.disallowed_methods.clone();
833 store.register_late_pass(move |_| Box::new(disallowed_methods::DisallowedMethods::new(disallowed_methods.clone())));
834 store.register_early_pass(|| Box::new(asm_syntax::InlineAsmX86AttSyntax));
835 store.register_early_pass(|| Box::new(asm_syntax::InlineAsmX86IntelSyntax));
836 store.register_late_pass(|_| Box::new(empty_drop::EmptyDrop));
837 store.register_late_pass(|_| Box::new(strings::StrToString));
838 store.register_late_pass(|_| Box::new(strings::StringToString));
839 store.register_late_pass(|_| Box::new(zero_sized_map_values::ZeroSizedMapValues));
840 store.register_late_pass(|_| Box::<vec_init_then_push::VecInitThenPush>::default());
841 store.register_late_pass(|_| Box::new(redundant_slicing::RedundantSlicing));
842 store.register_late_pass(|_| Box::new(from_str_radix_10::FromStrRadix10));
843 store.register_late_pass(move |_| Box::new(if_then_some_else_none::IfThenSomeElseNone::new(msrv)));
844 store.register_late_pass(|_| Box::new(bool_assert_comparison::BoolAssertComparison));
845 store.register_early_pass(move || Box::new(module_style::ModStyle));
846 store.register_late_pass(|_| Box::new(unused_async::UnusedAsync));
847 let disallowed_types = conf.disallowed_types.clone();
848 store.register_late_pass(move |_| Box::new(disallowed_types::DisallowedTypes::new(disallowed_types.clone())));
849 let import_renames = conf.enforced_import_renames.clone();
850 store.register_late_pass(move |_| {
851 Box::new(missing_enforced_import_rename::ImportRename::new(
852 import_renames.clone(),
855 let scripts = conf.allowed_scripts.clone();
856 store.register_early_pass(move || Box::new(disallowed_script_idents::DisallowedScriptIdents::new(&scripts)));
857 store.register_late_pass(|_| Box::new(strlen_on_c_strings::StrlenOnCStrings));
858 store.register_late_pass(move |_| Box::new(self_named_constructors::SelfNamedConstructors));
859 store.register_late_pass(move |_| Box::new(iter_not_returning_iterator::IterNotReturningIterator));
860 store.register_late_pass(move |_| Box::new(manual_assert::ManualAssert));
861 let enable_raw_pointer_heuristic_for_send = conf.enable_raw_pointer_heuristic_for_send;
862 store.register_late_pass(move |_| {
863 Box::new(non_send_fields_in_send_ty::NonSendFieldInSendTy::new(
864 enable_raw_pointer_heuristic_for_send,
867 store.register_late_pass(move |_| Box::new(undocumented_unsafe_blocks::UndocumentedUnsafeBlocks));
868 store.register_late_pass(move |_| Box::new(format_args::FormatArgs::new(msrv)));
869 store.register_late_pass(|_| Box::new(trailing_empty_array::TrailingEmptyArray));
870 store.register_early_pass(|| Box::new(octal_escapes::OctalEscapes));
871 store.register_late_pass(|_| Box::new(needless_late_init::NeedlessLateInit));
872 store.register_late_pass(|_| Box::new(return_self_not_must_use::ReturnSelfNotMustUse));
873 store.register_late_pass(|_| Box::new(init_numbered_fields::NumberedFields));
874 store.register_early_pass(|| Box::new(single_char_lifetime_names::SingleCharLifetimeNames));
875 store.register_late_pass(move |_| Box::new(manual_bits::ManualBits::new(msrv)));
876 store.register_late_pass(|_| Box::new(default_union_representation::DefaultUnionRepresentation));
877 store.register_late_pass(|_| Box::<only_used_in_recursion::OnlyUsedInRecursion>::default());
878 let allow_dbg_in_tests = conf.allow_dbg_in_tests;
879 store.register_late_pass(move |_| Box::new(dbg_macro::DbgMacro::new(allow_dbg_in_tests)));
880 let allow_print_in_tests = conf.allow_print_in_tests;
881 store.register_late_pass(move |_| Box::new(write::Write::new(allow_print_in_tests)));
882 let cargo_ignore_publish = conf.cargo_ignore_publish;
883 store.register_late_pass(move |_| {
884 Box::new(cargo::Cargo {
885 ignore_publish: cargo_ignore_publish,
888 store.register_early_pass(|| Box::new(crate_in_macro_def::CrateInMacroDef));
889 store.register_early_pass(|| Box::new(empty_structs_with_brackets::EmptyStructsWithBrackets));
890 store.register_late_pass(|_| Box::new(unnecessary_owned_empty_strings::UnnecessaryOwnedEmptyStrings));
891 store.register_early_pass(|| Box::new(pub_use::PubUse));
892 store.register_late_pass(|_| Box::new(format_push_string::FormatPushString));
893 let max_include_file_size = conf.max_include_file_size;
894 store.register_late_pass(move |_| Box::new(large_include_file::LargeIncludeFile::new(max_include_file_size)));
895 store.register_late_pass(|_| Box::new(strings::TrimSplitWhitespace));
896 store.register_late_pass(|_| Box::new(rc_clone_in_vec_init::RcCloneInVecInit));
897 store.register_early_pass(|| Box::<duplicate_mod::DuplicateMod>::default());
898 store.register_early_pass(|| Box::new(unused_rounding::UnusedRounding));
899 store.register_early_pass(move || Box::new(almost_complete_letter_range::AlmostCompleteLetterRange::new(msrv)));
900 store.register_late_pass(|_| Box::new(swap_ptr_to_ref::SwapPtrToRef));
901 store.register_late_pass(|_| Box::new(mismatching_type_param_order::TypeParamMismatch));
902 store.register_late_pass(|_| Box::new(read_zero_byte_vec::ReadZeroByteVec));
903 store.register_late_pass(|_| Box::new(default_instead_of_iter_empty::DefaultIterEmpty));
904 store.register_late_pass(move |_| Box::new(manual_rem_euclid::ManualRemEuclid::new(msrv)));
905 store.register_late_pass(move |_| Box::new(manual_retain::ManualRetain::new(msrv)));
906 let verbose_bit_mask_threshold = conf.verbose_bit_mask_threshold;
907 store.register_late_pass(move |_| Box::new(operators::Operators::new(verbose_bit_mask_threshold)));
908 store.register_late_pass(|_| Box::new(invalid_utf8_in_unchecked::InvalidUtf8InUnchecked));
909 store.register_late_pass(|_| Box::<std_instead_of_core::StdReexports>::default());
910 store.register_late_pass(move |_| Box::new(instant_subtraction::InstantSubtraction::new(msrv)));
911 store.register_late_pass(|_| Box::new(partialeq_to_none::PartialeqToNone));
912 store.register_late_pass(move |_| Box::new(manual_clamp::ManualClamp::new(msrv)));
913 store.register_late_pass(|_| Box::new(manual_string_new::ManualStringNew));
914 store.register_late_pass(|_| Box::new(unused_peekable::UnusedPeekable));
915 store.register_early_pass(|| Box::new(multi_assignments::MultiAssignments));
916 store.register_late_pass(|_| Box::new(bool_to_int_with_if::BoolToIntWithIf));
917 store.register_late_pass(|_| Box::new(box_default::BoxDefault));
918 store.register_late_pass(|_| Box::new(implicit_saturating_add::ImplicitSaturatingAdd));
919 store.register_early_pass(|| Box::new(partial_pub_fields::PartialPubFields));
920 store.register_late_pass(|_| Box::new(missing_trait_methods::MissingTraitMethods));
921 store.register_late_pass(|_| Box::new(from_raw_with_void_ptr::FromRawWithVoidPtr));
922 store.register_late_pass(|_| Box::new(suspicious_xor_used_as_pow::ConfusingXorAndPow));
923 store.register_late_pass(move |_| Box::new(manual_is_ascii_check::ManualIsAsciiCheck::new(msrv)));
924 // add lints here, do not remove this comment, it's used in `new_lint`
928 fn register_removed_non_tool_lints(store: &mut rustc_lint::LintStore) {
929 store.register_removed(
931 "`assert!()` will be more flexible with RFC 2011",
933 store.register_removed(
935 "`.extend_from_slice(_)` is a faster way to extend a Vec by a slice",
937 store.register_removed(
938 "range_step_by_zero",
939 "`iterator.step_by(0)` panics nowadays",
941 store.register_removed(
943 "`Vec::as_slice` has been stabilized in 1.7",
945 store.register_removed(
946 "unstable_as_mut_slice",
947 "`Vec::as_mut_slice` has been stabilized in 1.7",
949 store.register_removed(
950 "misaligned_transmute",
951 "this lint has been split into cast_ptr_alignment and transmute_ptr_to_ptr",
953 store.register_removed(
955 "using compound assignment operators (e.g., `+=`) is harmless",
957 store.register_removed(
958 "if_let_redundant_pattern_matching",
959 "this lint has been changed to redundant_pattern_matching",
961 store.register_removed(
962 "unsafe_vector_initialization",
963 "the replacement suggested by this lint had substantially different behavior",
965 store.register_removed(
966 "reverse_range_loop",
967 "this lint is now included in reversed_empty_ranges",
971 /// Register renamed lints.
973 /// Used in `./src/driver.rs`.
974 pub fn register_renamed(ls: &mut rustc_lint::LintStore) {
975 for (old_name, new_name) in renamed_lints::RENAMED_LINTS {
976 ls.register_renamed(old_name, new_name);
980 // only exists to let the dogfood integration test works.
981 // Don't run clippy as an executable directly
984 panic!("Please use the cargo-clippy executable");