1 //! Lint on if expressions with an else if, but without a final else branch.
3 use clippy_utils::diagnostics::span_lint_and_help;
4 use rustc_ast::ast::{Expr, ExprKind};
5 use rustc_lint::{EarlyContext, EarlyLintPass};
6 use rustc_middle::lint::in_external_macro;
7 use rustc_session::{declare_lint_pass, declare_tool_lint};
11 /// Checks for usage of if expressions with an `else if` branch,
12 /// but without a final `else` branch.
14 /// ### Why is this bad?
15 /// Some coding guidelines require this (e.g., MISRA-C:2004 Rule 14.10).
22 /// if x.is_positive() {
24 /// } else if x.is_negative() {
35 /// if x.is_positive() {
37 /// } else if x.is_negative() {
40 /// // We don't care about zero.
43 #[clippy::version = "pre 1.29.0"]
44 pub ELSE_IF_WITHOUT_ELSE,
46 "`if` expression with an `else if`, but without a final `else` branch"
49 declare_lint_pass!(ElseIfWithoutElse => [ELSE_IF_WITHOUT_ELSE]);
51 impl EarlyLintPass for ElseIfWithoutElse {
52 fn check_expr(&mut self, cx: &EarlyContext<'_>, mut item: &Expr) {
53 if in_external_macro(cx.sess, item.span) {
57 while let ExprKind::If(_, _, Some(ref els)) = item.kind {
58 if let ExprKind::If(_, _, None) = els.kind {
63 "`if` expression with an `else if`, but without a final `else`",
65 "add an `else` block here",