1 macro_rules! declare_deprecated_lint {
2 (pub $name: ident, $_reason: expr) => {
3 declare_lint!(pub $name, Allow, "deprecated lint")
7 declare_deprecated_lint! {
8 /// **What it does:** Nothing. This lint has been deprecated.
10 /// **Deprecation reason:** This used to check for `assert!(a == b)` and recommend
11 /// replacement with `assert_eq!(a, b)`, but this is no longer needed after RFC 2011.
13 "`assert!()` will be more flexible with RFC 2011"
16 declare_deprecated_lint! {
17 /// **What it does:** Nothing. This lint has been deprecated.
19 /// **Deprecation reason:** This used to check for `Vec::extend`, which was slower than
20 /// `Vec::extend_from_slice`. Thanks to specialization, this is no longer true.
21 pub EXTEND_FROM_SLICE,
22 "`.extend_from_slice(_)` is a faster way to extend a Vec by a slice"
25 declare_deprecated_lint! {
26 /// **What it does:** Nothing. This lint has been deprecated.
28 /// **Deprecation reason:** `Range::step_by(0)` used to be linted since it's
29 /// an infinite iterator, which is better expressed by `iter::repeat`,
30 /// but the method has been removed for `Iterator::step_by` which panics
32 pub RANGE_STEP_BY_ZERO,
33 "`iterator.step_by(0)` panics nowadays"
36 declare_deprecated_lint! {
37 /// **What it does:** Nothing. This lint has been deprecated.
39 /// **Deprecation reason:** This used to check for `Vec::as_slice`, which was unstable with good
40 /// stable alternatives. `Vec::as_slice` has now been stabilized.
41 pub UNSTABLE_AS_SLICE,
42 "`Vec::as_slice` has been stabilized in 1.7"
45 declare_deprecated_lint! {
46 /// **What it does:** Nothing. This lint has been deprecated.
48 /// **Deprecation reason:** This used to check for `Vec::as_mut_slice`, which was unstable with good
49 /// stable alternatives. `Vec::as_mut_slice` has now been stabilized.
50 pub UNSTABLE_AS_MUT_SLICE,
51 "`Vec::as_mut_slice` has been stabilized in 1.7"
54 declare_deprecated_lint! {
55 /// **What it does:** Nothing. This lint has been deprecated.
57 /// **Deprecation reason:** This used to check for `.to_string()` method calls on values
58 /// of type `&str`. This is not unidiomatic and with specialization coming, `to_string` could be
59 /// specialized to be as efficient as `to_owned`.
61 "using `str::to_string` is common even today and specialization will likely happen soon"
64 declare_deprecated_lint! {
65 /// **What it does:** Nothing. This lint has been deprecated.
67 /// **Deprecation reason:** This used to check for `.to_string()` method calls on values
68 /// of type `String`. This is not unidiomatic and with specialization coming, `to_string` could be
69 /// specialized to be as efficient as `clone`.
71 "using `string::to_string` is common even today and specialization will likely happen soon"
74 declare_deprecated_lint! {
75 /// **What it does:** Nothing. This lint has been deprecated.
77 /// **Deprecation reason:** This lint should never have applied to non-pointer types, as transmuting
78 /// between non-pointer types of differing alignment is well-defined behavior (it's semantically
79 /// equivalent to a memcpy). This lint has thus been refactored into two separate lints:
80 /// cast_ptr_alignment and transmute_ptr_to_ptr.
81 pub MISALIGNED_TRANSMUTE,
82 "this lint has been split into cast_ptr_alignment and transmute_ptr_to_ptr"
85 declare_deprecated_lint! {
86 /// **What it does:** Nothing. This lint has been deprecated.
88 /// **Deprecation reason:** This lint is too subjective, not having a good reason for being in clippy.
89 /// Additionally, compound assignment operators may be overloaded separately from their non-assigning
90 /// counterparts, so this lint may suggest a change in behavior or the code may not compile.
92 "using compound assignment operators (e.g., `+=`) is harmless"
95 declare_deprecated_lint! {
96 /// **What it does:** Nothing. This lint has been deprecated.
98 /// **Deprecation reason:** The original rule will only lint for `if let`. After
99 /// making it support to lint `match`, naming as `if let` is not suitable for it.
100 /// So, this lint is deprecated.
101 pub IF_LET_REDUNDANT_PATTERN_MATCHING,
102 "this lint has been changed to redundant_pattern_matching"
105 declare_deprecated_lint! {
106 /// **What it does:** Nothing. This lint has been deprecated.
108 /// **Deprecation reason:** This lint used to suggest replacing `let mut vec =
109 /// Vec::with_capacity(n); vec.set_len(n);` with `let vec = vec![0; n];`. The
110 /// replacement has very different performance characteristics so the lint is
112 pub UNSAFE_VECTOR_INITIALIZATION,
113 "the replacement suggested by this lint had substantially different behavior"
116 declare_deprecated_lint! {
117 /// **What it does:** Nothing. This lint has been deprecated.
119 /// **Deprecation reason:** This lint has been superseded by the warn-by-default
120 /// `invalid_value` rustc lint.
122 "superseded by rustc lint `invalid_value`"
125 declare_deprecated_lint! {
126 /// **What it does:** Nothing. This lint has been deprecated.
128 /// **Deprecation reason:** This lint has been superseded by #[must_use] in rustc.
130 "`collect` has been marked as #[must_use] in rustc and that covers all cases of this lint"
133 declare_deprecated_lint! {
134 /// **What it does:** Nothing. This lint has been deprecated.
136 /// **Deprecation reason:** This lint has been uplifted to rustc and is now called
137 /// `array_into_iter`.
138 pub INTO_ITER_ON_ARRAY,
139 "this lint has been uplifted to rustc and is now called `array_into_iter`"
142 declare_deprecated_lint! {
143 /// **What it does:** Nothing. This lint has been deprecated.
145 /// **Deprecation reason:** This lint has been uplifted to rustc and is now called
148 "this lint has been uplifted to rustc and is now called `unused_labels`"
151 declare_deprecated_lint! {
152 /// **What it does:** Nothing. This lint has been deprecated.
154 /// **Deprecation reason:** Associated-constants are now preferred.
156 "associated-constants `MIN`/`MAX` of integers are preferred to `{min,max}_value()` and module constants"
159 declare_deprecated_lint! {
160 /// **What it does:** Nothing. This lint has been deprecated.
162 /// **Deprecation reason:** The regex! macro does not exist anymore.
164 "the regex! macro has been removed from the regex crate in 2018"
167 declare_deprecated_lint! {
168 /// **What it does:** Nothing. This lint has been deprecated.
170 /// **Deprecation reason:** This lint has been uplifted to rustc and is now called
173 "this lint has been uplifted to rustc and is now called `drop_bounds`"
176 declare_deprecated_lint! {
177 /// **What it does:** Nothing. This lint has been deprecated.
179 /// **Deprecation reason:** This lint has been uplifted to rustc and is now called
180 /// `temporary_cstring_as_ptr`.
181 pub TEMPORARY_CSTRING_AS_PTR,
182 "this lint has been uplifted to rustc and is now called `temporary_cstring_as_ptr`"