]> git.lizzy.rs Git - rust.git/blob - src/main.rs
Be more helping with `cargo clippy --help`
[rust.git] / src / main.rs
1 // error-pattern:yummy
2 #![feature(box_syntax)]
3 #![feature(rustc_private)]
4 #![feature(static_in_const)]
5
6 #![allow(unknown_lints, missing_docs_in_private_items)]
7
8 extern crate clippy_lints;
9 extern crate getopts;
10 extern crate rustc;
11 extern crate rustc_driver;
12 extern crate rustc_errors;
13 extern crate rustc_plugin;
14 extern crate syntax;
15
16 use rustc_driver::{driver, CompilerCalls, RustcDefaultCalls, Compilation};
17 use rustc::session::{config, Session};
18 use rustc::session::config::{Input, ErrorOutputType};
19 use std::path::PathBuf;
20 use std::process::Command;
21 use syntax::ast;
22
23 use clippy_lints::utils::cargo;
24
25 struct ClippyCompilerCalls {
26     default: RustcDefaultCalls,
27     run_lints: bool,
28 }
29
30 impl ClippyCompilerCalls {
31     fn new(run_lints: bool) -> Self {
32         ClippyCompilerCalls {
33             default: RustcDefaultCalls,
34             run_lints: run_lints,
35         }
36     }
37 }
38
39 impl<'a> CompilerCalls<'a> for ClippyCompilerCalls {
40     fn early_callback(&mut self,
41                       matches: &getopts::Matches,
42                       sopts: &config::Options,
43                       cfg: &ast::CrateConfig,
44                       descriptions: &rustc_errors::registry::Registry,
45                       output: ErrorOutputType)
46                       -> Compilation {
47         self.default.early_callback(matches, sopts, cfg, descriptions, output)
48     }
49     fn no_input(&mut self,
50                 matches: &getopts::Matches,
51                 sopts: &config::Options,
52                 cfg: &ast::CrateConfig,
53                 odir: &Option<PathBuf>,
54                 ofile: &Option<PathBuf>,
55                 descriptions: &rustc_errors::registry::Registry)
56                 -> Option<(Input, Option<PathBuf>)> {
57         self.default.no_input(matches, sopts, cfg, odir, ofile, descriptions)
58     }
59     fn late_callback(&mut self,
60                      matches: &getopts::Matches,
61                      sess: &Session,
62                      cfg: &ast::CrateConfig,
63                      input: &Input,
64                      odir: &Option<PathBuf>,
65                      ofile: &Option<PathBuf>)
66                      -> Compilation {
67         self.default.late_callback(matches, sess, cfg, input, odir, ofile)
68     }
69     fn build_controller(&mut self, sess: &Session, matches: &getopts::Matches) -> driver::CompileController<'a> {
70         let mut control = self.default.build_controller(sess, matches);
71
72         if self.run_lints {
73             let old = std::mem::replace(&mut control.after_parse.callback, box |_| {});
74             control.after_parse.callback = Box::new(move |state| {
75                 {
76                     let mut registry = rustc_plugin::registry::Registry::new(state.session, state.krate.as_ref().expect("at this compilation stage the krate must be parsed").span);
77                     registry.args_hidden = Some(Vec::new());
78                     clippy_lints::register_plugins(&mut registry);
79
80                     let rustc_plugin::registry::Registry { early_lint_passes,
81                                                            late_lint_passes,
82                                                            lint_groups,
83                                                            llvm_passes,
84                                                            attributes,
85                                                            mir_passes,
86                                                            .. } = registry;
87                     let sess = &state.session;
88                     let mut ls = sess.lint_store.borrow_mut();
89                     for pass in early_lint_passes {
90                         ls.register_early_pass(Some(sess), true, pass);
91                     }
92                     for pass in late_lint_passes {
93                         ls.register_late_pass(Some(sess), true, pass);
94                     }
95
96                     for (name, to) in lint_groups {
97                         ls.register_group(Some(sess), true, name, to);
98                     }
99
100                     sess.plugin_llvm_passes.borrow_mut().extend(llvm_passes);
101                     sess.mir_passes.borrow_mut().extend(mir_passes);
102                     sess.plugin_attributes.borrow_mut().extend(attributes);
103                 }
104                 old(state);
105             });
106         }
107
108         control
109     }
110 }
111
112 use std::path::Path;
113
114 const CARGO_CLIPPY_HELP: &str = "\
115 Checks a package to catch common mistakes and improve your Rust code.
116
117 Usage:
118     cargo clippy [options] [--] [<opts>...]
119
120 Common options:
121     -h, --help               Print this message
122     --features               Features to compile for the package
123
124 Other options are the same as `cargo rustc`.
125
126 To allow or deny a lint from the command line you can use `cargo clippy --` with
127 one of:
128
129     -W --warn OPT       Set lint warnings
130     -A --allow OPT      Set lint allowed
131     -D --deny OPT       Set lint denied
132     -F --forbid OPT     Set lint forbidden\
133 ";
134
135 pub fn main() {
136     use std::env;
137
138     if env::var("CLIPPY_DOGFOOD").map(|_| true).unwrap_or(false) {
139         panic!("yummy");
140     }
141
142     let dep_path = env::current_dir().expect("current dir is not readable").join("target").join("debug").join("deps");
143
144     let home = option_env!("RUSTUP_HOME").or(option_env!("MULTIRUST_HOME"));
145     let toolchain = option_env!("RUSTUP_TOOLCHAIN").or(option_env!("MULTIRUST_TOOLCHAIN"));
146     let sys_root = if let (Some(home), Some(toolchain)) = (home, toolchain) {
147         format!("{}/toolchains/{}", home, toolchain)
148     } else {
149         option_env!("SYSROOT")
150             .map(|s| s.to_owned())
151             .or(Command::new("rustc")
152                 .arg("--print")
153                 .arg("sysroot")
154                 .output()
155                 .ok()
156                 .and_then(|out| String::from_utf8(out.stdout).ok())
157                 .map(|s| s.trim().to_owned()))
158             .expect("need to specify SYSROOT env var during clippy compilation, or use rustup or multirust")
159     };
160
161     if let Some("clippy") = std::env::args().nth(1).as_ref().map(AsRef::as_ref) {
162         // this arm is executed on the initial call to `cargo clippy`
163
164         match std::env::args().nth(2).as_ref().map(AsRef::as_ref) {
165             Some("--help") | Some("-h") => {
166                 println!("{}", CARGO_CLIPPY_HELP);
167                 return;
168             }
169             _ => (),
170         }
171
172         let manifest_path_arg = std::env::args().skip(2).find(|val| val.starts_with("--manifest-path="));
173
174         let mut metadata = cargo::metadata(manifest_path_arg.as_ref().map(AsRef::as_ref)).expect("could not obtain cargo metadata");
175
176         assert_eq!(metadata.version, 1);
177
178         let manifest_path = manifest_path_arg.map(|arg| PathBuf::from(Path::new(&arg["--manifest-path=".len()..])));
179
180         let current_dir = std::env::current_dir();
181
182         let package_index = metadata.packages.iter()
183             .position(|package| {
184                 let package_manifest_path = Path::new(&package.manifest_path);
185                 if let Some(ref manifest_path) = manifest_path {
186                     package_manifest_path == manifest_path
187                 } else {
188                     let current_dir = current_dir.as_ref().expect("could not read current directory");
189                     let package_manifest_directory = package_manifest_path.parent().expect("could not find parent directory of package manifest");
190                     package_manifest_directory == current_dir
191                 }
192             })
193             .expect("could not find matching package");
194         let package = metadata.packages.remove(package_index);
195         for target in package.targets {
196             let args = std::env::args().skip(2);
197             if let Some(first) = target.kind.get(0) {
198                 if target.kind.len() > 1 || first.ends_with("lib") {
199                     if let Err(code) = process(std::iter::once("--lib".to_owned()).chain(args), &dep_path, &sys_root) {
200                         std::process::exit(code);
201                     }
202                 } else if ["bin", "example", "test", "bench"].contains(&&**first) {
203                     if let Err(code) = process(vec![format!("--{}", first), target.name].into_iter().chain(args), &dep_path, &sys_root) {
204                         std::process::exit(code);
205                     }
206                 }
207             } else {
208                 panic!("badly formatted cargo metadata: target::kind is an empty array");
209             }
210         }
211     } else {
212         // this arm is executed when cargo-clippy runs `cargo rustc` with the `RUSTC` env var set to itself
213
214         // this conditional check for the --sysroot flag is there so users can call `cargo-clippy` directly
215         // without having to pass --sysroot or anything
216         let args: Vec<String> = if env::args().any(|s| s == "--sysroot") {
217             env::args().collect()
218         } else {
219             env::args().chain(Some("--sysroot".to_owned())).chain(Some(sys_root)).collect()
220         };
221         // this check ensures that dependencies are built but not linted and the final crate is
222         // linted but not built
223         let mut ccc = ClippyCompilerCalls::new(env::args().any(|s| s == "-Zno-trans"));
224         let (result, _) = rustc_driver::run_compiler(&args, &mut ccc, None, None);
225
226         if let Err(err_count) = result {
227             if err_count > 0 {
228                 std::process::exit(1);
229             }
230         }
231     }
232 }
233
234 fn process<P, I>(old_args: I, dep_path: P, sysroot: &str) -> Result<(), i32>
235     where P: AsRef<Path>,
236           I: Iterator<Item = String>
237 {
238
239     let mut args = vec!["rustc".to_owned()];
240
241     let mut found_dashes = false;
242     for arg in old_args {
243         found_dashes |= arg == "--";
244         args.push(arg);
245     }
246     if !found_dashes {
247         args.push("--".to_owned());
248     }
249     args.push("-L".to_owned());
250     args.push(dep_path.as_ref().to_string_lossy().into_owned());
251     args.push(String::from("--sysroot"));
252     args.push(sysroot.to_owned());
253     args.push("-Zno-trans".to_owned());
254
255     let path = std::env::current_exe().expect("current executable path invalid");
256     let exit_status = std::process::Command::new("cargo")
257         .args(&args)
258         .env("RUSTC", path)
259         .spawn().expect("could not run cargo")
260         .wait().expect("failed to wait for cargo?");
261
262     if exit_status.success() {
263         Ok(())
264     } else {
265         Err(exit_status.code().unwrap_or(-1))
266     }
267 }