1 //! This module implements [RFC 1946]: Intra-rustdoc-links
3 //! [RFC 1946]: https://github.com/rust-lang/rfcs/blob/master/text/1946-intra-rustdoc-links.md
6 use rustc_data_structures::{fx::FxHashMap, stable_set::FxHashSet};
7 use rustc_errors::{Applicability, DiagnosticBuilder};
8 use rustc_expand::base::SyntaxExtensionKind;
15 use rustc_hir::def_id::{CrateNum, DefId};
16 use rustc_middle::ty::TyCtxt;
17 use rustc_middle::{bug, ty};
18 use rustc_resolve::ParentScope;
19 use rustc_session::lint::Lint;
20 use rustc_span::hygiene::{MacroKind, SyntaxContext};
21 use rustc_span::symbol::{sym, Ident, Symbol};
22 use rustc_span::DUMMY_SP;
23 use smallvec::{smallvec, SmallVec};
25 use pulldown_cmark::LinkType;
29 use std::convert::{TryFrom, TryInto};
33 use crate::clean::{self, utils::find_nearest_parent_module, Crate, Item, ItemLink, PrimitiveType};
34 use crate::core::DocContext;
35 use crate::fold::DocFolder;
36 use crate::html::markdown::{markdown_links, MarkdownLink};
37 use crate::lint::{BROKEN_INTRA_DOC_LINKS, PRIVATE_INTRA_DOC_LINKS};
38 use crate::passes::Pass;
40 use super::span_of_attrs;
42 crate const COLLECT_INTRA_DOC_LINKS: Pass = Pass {
43 name: "collect-intra-doc-links",
44 run: collect_intra_doc_links,
45 description: "resolves intra-doc links",
48 crate fn collect_intra_doc_links(krate: Crate, cx: &mut DocContext<'_>) -> Crate {
52 kind_side_channel: Cell::new(None),
53 visited_links: FxHashMap::default(),
58 /// Top-level errors emitted by this pass.
60 Resolve(Box<ResolutionFailure<'a>>),
61 AnchorFailure(AnchorFailure),
64 impl<'a> From<ResolutionFailure<'a>> for ErrorKind<'a> {
65 fn from(err: ResolutionFailure<'a>) -> Self {
66 ErrorKind::Resolve(box err)
70 #[derive(Copy, Clone, Debug, Hash)]
73 Primitive(PrimitiveType),
76 type ResolveRes = rustc_hir::def::Res<rustc_ast::NodeId>;
79 fn descr(self) -> &'static str {
81 Res::Def(kind, id) => ResolveRes::Def(kind, id).descr(),
82 Res::Primitive(_) => "builtin type",
86 fn article(self) -> &'static str {
88 Res::Def(kind, id) => ResolveRes::Def(kind, id).article(),
89 Res::Primitive(_) => "a",
93 fn name(self, tcx: TyCtxt<'_>) -> String {
95 Res::Def(_, id) => tcx.item_name(id).to_string(),
96 Res::Primitive(prim) => prim.as_str().to_string(),
100 fn def_id(self) -> DefId {
101 self.opt_def_id().expect("called def_id() on a primitive")
104 fn opt_def_id(self) -> Option<DefId> {
106 Res::Def(_, id) => Some(id),
107 Res::Primitive(_) => None,
111 fn as_hir_res(self) -> Option<rustc_hir::def::Res> {
113 Res::Def(kind, id) => Some(rustc_hir::def::Res::Def(kind, id)),
114 // FIXME: maybe this should handle the subset of PrimitiveType that fits into hir::PrimTy?
115 Res::Primitive(_) => None,
120 impl TryFrom<ResolveRes> for Res {
123 fn try_from(res: ResolveRes) -> Result<Self, ()> {
124 use rustc_hir::def::Res::*;
126 Def(kind, id) => Ok(Res::Def(kind, id)),
127 PrimTy(prim) => Ok(Res::Primitive(PrimitiveType::from_hir(prim))),
129 NonMacroAttr(..) | Err => Result::Err(()),
130 other => bug!("unrecognized res {:?}", other),
135 /// A link failed to resolve.
137 enum ResolutionFailure<'a> {
138 /// This resolved, but with the wrong namespace.
140 /// What the link resolved to.
142 /// The expected namespace for the resolution, determined from the link's disambiguator.
144 /// E.g., for `[fn@Result]` this is [`Namespace::ValueNS`],
145 /// even though `Result`'s actual namespace is [`Namespace::TypeNS`].
146 expected_ns: Namespace,
148 /// The link failed to resolve. [`resolution_failure`] should look to see if there's
149 /// a more helpful error that can be given.
151 /// The scope the link was resolved in.
153 /// If part of the link resolved, this has the `Res`.
155 /// In `[std::io::Error::x]`, `std::io::Error` would be a partial resolution.
156 partial_res: Option<Res>,
157 /// The remaining unresolved path segments.
159 /// In `[std::io::Error::x]`, `x` would be unresolved.
160 unresolved: Cow<'a, str>,
162 /// This happens when rustdoc can't determine the parent scope for an item.
163 /// It is always a bug in rustdoc.
165 /// This link has malformed generic parameters; e.g., the angle brackets are unbalanced.
166 MalformedGenerics(MalformedGenerics),
167 /// Used to communicate that this should be ignored, but shouldn't be reported to the user.
169 /// This happens when there is no disambiguator and one of the namespaces
170 /// failed to resolve.
175 enum MalformedGenerics {
176 /// This link has unbalanced angle brackets.
178 /// For example, `Vec<T` should trigger this, as should `Vec<T>>`.
179 UnbalancedAngleBrackets,
180 /// The generics are not attached to a type.
182 /// For example, `<T>` should trigger this.
184 /// This is detected by checking if the path is empty after the generics are stripped.
186 /// The link uses fully-qualified syntax, which is currently unsupported.
188 /// For example, `<Vec as IntoIterator>::into_iter` should trigger this.
190 /// This is detected by checking if ` as ` (the keyword `as` with spaces around it) is inside
192 HasFullyQualifiedSyntax,
193 /// The link has an invalid path separator.
195 /// For example, `Vec:<T>:new()` should trigger this. Note that `Vec:new()` will **not**
196 /// trigger this because it has no generics and thus [`strip_generics_from_path`] will not be
199 /// Note that this will also **not** be triggered if the invalid path separator is inside angle
200 /// brackets because rustdoc mostly ignores what's inside angle brackets (except for
201 /// [`HasFullyQualifiedSyntax`](MalformedGenerics::HasFullyQualifiedSyntax)).
203 /// This is detected by checking if there is a colon followed by a non-colon in the link.
204 InvalidPathSeparator,
205 /// The link has too many angle brackets.
207 /// For example, `Vec<<T>>` should trigger this.
208 TooManyAngleBrackets,
209 /// The link has empty angle brackets.
211 /// For example, `Vec<>` should trigger this.
215 impl ResolutionFailure<'a> {
216 /// This resolved fully (not just partially) but is erroneous for some other reason
218 /// Returns the full resolution of the link, if present.
219 fn full_res(&self) -> Option<Res> {
221 Self::WrongNamespace { res, expected_ns: _ } => Some(*res),
228 /// User error: `[std#x#y]` is not valid
230 /// The anchor provided by the user conflicts with Rustdoc's generated anchor.
232 /// This is an unfortunate state of affairs. Not every item that can be
233 /// linked to has its own page; sometimes it is a subheading within a page,
234 /// like for associated items. In those cases, rustdoc uses an anchor to
235 /// link to the subheading. Since you can't have two anchors for the same
236 /// link, Rustdoc disallows having a user-specified anchor.
238 /// Most of the time this is fine, because you can just link to the page of
239 /// the item if you want to provide your own anchor. For primitives, though,
240 /// rustdoc uses the anchor as a side channel to know which page to link to;
241 /// it doesn't show up in the generated link. Ideally, rustdoc would remove
242 /// this limitation, allowing you to link to subheaders on primitives.
243 RustdocAnchorConflict(Res),
246 #[derive(Clone, Debug, Hash, PartialEq, Eq)]
247 struct ResolutionInfo {
249 dis: Option<Disambiguator>,
251 extra_fragment: Option<String>,
255 struct DiagnosticInfo<'a> {
259 link_range: Range<usize>,
262 #[derive(Clone, Debug, Hash)]
264 pub res: (Res, Option<String>),
265 pub side_channel: Option<(DefKind, DefId)>,
268 struct LinkCollector<'a, 'tcx> {
269 cx: &'a mut DocContext<'tcx>,
270 /// A stack of modules used to decide what scope to resolve in.
272 /// The last module will be used if the parent scope of the current item is
275 /// This is used to store the kind of associated items,
276 /// because `clean` and the disambiguator code expect them to be different.
277 /// See the code for associated items on inherent impls for details.
278 kind_side_channel: Cell<Option<(DefKind, DefId)>>,
279 /// Cache the resolved links so we can avoid resolving (and emitting errors for) the same link.
280 /// The link will be `None` if it could not be resolved (i.e. the error was cached).
281 visited_links: FxHashMap<ResolutionInfo, Option<CachedLink>>,
284 impl<'a, 'tcx> LinkCollector<'a, 'tcx> {
285 /// Given a full link, parse it as an [enum struct variant].
287 /// In particular, this will return an error whenever there aren't three
288 /// full path segments left in the link.
290 /// [enum struct variant]: hir::VariantData::Struct
293 path_str: &'path str,
295 ) -> Result<(Res, Option<String>), ErrorKind<'path>> {
296 let tcx = self.cx.tcx;
297 let no_res = || ResolutionFailure::NotResolved {
300 unresolved: path_str.into(),
303 debug!("looking for enum variant {}", path_str);
304 let mut split = path_str.rsplitn(3, "::");
305 let (variant_field_str, variant_field_name) = split
307 .map(|f| (f, Symbol::intern(f)))
308 .expect("fold_item should ensure link is non-empty");
309 let (variant_str, variant_name) =
310 // we're not sure this is a variant at all, so use the full string
311 // If there's no second component, the link looks like `[path]`.
312 // So there's no partial res and we should say the whole link failed to resolve.
313 split.next().map(|f| (f, Symbol::intern(f))).ok_or_else(no_res)?;
316 .map(|f| f.to_owned())
317 // If there's no third component, we saw `[a::b]` before and it failed to resolve.
318 // So there's no partial res.
319 .ok_or_else(no_res)?;
322 .enter_resolver(|resolver| {
323 resolver.resolve_str_path_error(DUMMY_SP, &path, TypeNS, module_id)
325 .and_then(|(_, res)| res.try_into())
326 .map_err(|()| no_res())?;
329 Res::Def(DefKind::Enum, did) => {
333 .flat_map(|imp| tcx.associated_items(*imp).in_definition_order())
334 .any(|item| item.ident.name == variant_name)
336 // This is just to let `fold_item` know that this shouldn't be considered;
337 // it's a bug for the error to make it to the user
338 return Err(ResolutionFailure::Dummy.into());
340 match tcx.type_of(did).kind() {
341 ty::Adt(def, _) if def.is_enum() => {
342 if def.all_fields().any(|item| item.ident.name == variant_field_name) {
346 "variant.{}.field.{}",
347 variant_str, variant_field_name
351 Err(ResolutionFailure::NotResolved {
353 partial_res: Some(Res::Def(DefKind::Enum, def.did)),
354 unresolved: variant_field_str.into(),
362 _ => Err(ResolutionFailure::NotResolved {
364 partial_res: Some(ty_res),
365 unresolved: variant_str.into(),
371 /// Given a primitive type, try to resolve an associated item.
373 /// HACK(jynelson): `item_str` is passed in instead of derived from `item_name` so the
374 /// lifetimes on `&'path` will work.
375 fn resolve_primitive_associated_item(
377 prim_ty: PrimitiveType,
381 item_str: &'path str,
382 ) -> Result<(Res, Option<String>), ErrorKind<'path>> {
383 let tcx = self.cx.tcx;
389 tcx.associated_items(impl_)
390 .find_by_name_and_namespace(tcx, Ident::with_dummy_span(item_name), ns, impl_)
392 let kind = item.kind;
393 self.kind_side_channel.set(Some((kind.as_def_kind(), item.def_id)));
395 ty::AssocKind::Fn => "method",
396 ty::AssocKind::Const => "associatedconstant",
397 ty::AssocKind::Type => "associatedtype",
402 Res::Primitive(prim_ty),
403 Some(format!("{}#{}.{}", prim_ty.as_str(), out, item_str)),
409 "returning primitive error for {}::{} in {} namespace",
414 ResolutionFailure::NotResolved {
416 partial_res: Some(Res::Primitive(prim_ty)),
417 unresolved: item_str.into(),
423 /// Resolves a string as a macro.
425 /// FIXME(jynelson): Can this be unified with `resolve()`?
430 ) -> Result<Res, ResolutionFailure<'a>> {
431 let path = ast::Path::from_ident(Ident::from_str(path_str));
432 self.cx.enter_resolver(|resolver| {
433 // FIXME(jynelson): does this really need 3 separate lookups?
434 if let Ok((Some(ext), res)) = resolver.resolve_macro_path(
437 &ParentScope::module(resolver.graph_root(), resolver),
441 if let SyntaxExtensionKind::LegacyBang { .. } = ext.kind {
442 return Ok(res.try_into().unwrap());
445 if let Some(&res) = resolver.all_macros().get(&Symbol::intern(path_str)) {
446 return Ok(res.try_into().unwrap());
448 debug!("resolving {} as a macro in the module {:?}", path_str, module_id);
449 if let Ok((_, res)) =
450 resolver.resolve_str_path_error(DUMMY_SP, path_str, MacroNS, module_id)
452 // don't resolve builtins like `#[derive]`
453 if let Ok(res) = res.try_into() {
457 Err(ResolutionFailure::NotResolved {
460 unresolved: path_str.into(),
465 /// Convenience wrapper around `resolve_str_path_error`.
467 /// This also handles resolving `true` and `false` as booleans.
468 /// NOTE: `resolve_str_path_error` knows only about paths, not about types.
469 /// Associated items will never be resolved by this function.
470 fn resolve_path(&self, path_str: &str, ns: Namespace, module_id: DefId) -> Option<Res> {
471 let result = self.cx.enter_resolver(|resolver| {
473 .resolve_str_path_error(DUMMY_SP, &path_str, ns, module_id)
474 .and_then(|(_, res)| res.try_into())
476 debug!("{} resolved to {:?} in namespace {:?}", path_str, result, ns);
478 // resolver doesn't know about true, false, and types that aren't paths (e.g. `()`)
480 Err(()) => resolve_primitive(path_str, ns),
481 Ok(res) => Some(res),
485 /// Resolves a string as a path within a particular namespace. Returns an
486 /// optional URL fragment in the case of variants and methods.
489 path_str: &'path str,
492 extra_fragment: &Option<String>,
493 ) -> Result<(Res, Option<String>), ErrorKind<'path>> {
494 let tcx = self.cx.tcx;
496 if let Some(res) = self.resolve_path(path_str, ns, module_id) {
498 // FIXME(#76467): make this fallthrough to lookup the associated
499 // item a separate function.
500 Res::Def(DefKind::AssocFn | DefKind::AssocConst, _) => assert_eq!(ns, ValueNS),
501 Res::Def(DefKind::AssocTy, _) => assert_eq!(ns, TypeNS),
502 Res::Def(DefKind::Variant, _) => {
503 return handle_variant(self.cx, res, extra_fragment);
505 // Not a trait item; just return what we found.
506 Res::Primitive(ty) => {
507 if extra_fragment.is_some() {
508 return Err(ErrorKind::AnchorFailure(
509 AnchorFailure::RustdocAnchorConflict(res),
512 return Ok((res, Some(ty.as_str().to_owned())));
514 _ => return Ok((res, extra_fragment.clone())),
518 // Try looking for methods and associated items.
519 let mut split = path_str.rsplitn(2, "::");
520 // NB: `split`'s first element is always defined, even if the delimiter was not present.
521 // NB: `item_str` could be empty when resolving in the root namespace (e.g. `::std`).
522 let item_str = split.next().unwrap();
523 let item_name = Symbol::intern(item_str);
524 let path_root = split
526 .map(|f| f.to_owned())
527 // If there's no `::`, it's not an associated item.
528 // So we can be sure that `rustc_resolve` was accurate when it said it wasn't resolved.
530 debug!("found no `::`, assumming {} was correctly not in scope", item_name);
531 ResolutionFailure::NotResolved {
534 unresolved: item_str.into(),
538 // FIXME: are these both necessary?
539 let ty_res = if let Some(ty_res) = resolve_primitive(&path_root, TypeNS)
540 .or_else(|| self.resolve_path(&path_root, TypeNS, module_id))
544 // FIXME: this is duplicated on the end of this function.
545 return if ns == Namespace::ValueNS {
546 self.variant_field(path_str, module_id)
548 Err(ResolutionFailure::NotResolved {
551 unresolved: path_root.into(),
557 let res = match ty_res {
558 Res::Primitive(prim) => Some(
559 self.resolve_primitive_associated_item(prim, ns, module_id, item_name, item_str),
566 | DefKind::ForeignTy,
569 debug!("looking for associated item named {} for item {:?}", item_name, did);
570 // Checks if item_name belongs to `impl SomeItem`
575 tcx.associated_items(imp).find_by_name_and_namespace(
577 Ident::with_dummy_span(item_name),
582 .map(|item| (item.kind, item.def_id))
583 // There should only ever be one associated item that matches from any inherent impl
585 // Check if item_name belongs to `impl SomeTrait for SomeItem`
586 // FIXME(#74563): This gives precedence to `impl SomeItem`:
587 // Although having both would be ambiguous, use impl version for compatibility's sake.
588 // To handle that properly resolve() would have to support
589 // something like [`ambi_fn`](<SomeStruct as SomeTrait>::ambi_fn)
592 resolve_associated_trait_item(did, module_id, item_name, ns, self.cx);
593 debug!("got associated item kind {:?}", kind);
597 if let Some((kind, id)) = assoc_item {
598 let out = match kind {
599 ty::AssocKind::Fn => "method",
600 ty::AssocKind::Const => "associatedconstant",
601 ty::AssocKind::Type => "associatedtype",
603 Some(if extra_fragment.is_some() {
604 Err(ErrorKind::AnchorFailure(AnchorFailure::RustdocAnchorConflict(ty_res)))
606 // HACK(jynelson): `clean` expects the type, not the associated item
607 // but the disambiguator logic expects the associated item.
608 // Store the kind in a side channel so that only the disambiguator logic looks at it.
609 self.kind_side_channel.set(Some((kind.as_def_kind(), id)));
610 Ok((ty_res, Some(format!("{}.{}", out, item_str))))
612 } else if ns == Namespace::ValueNS {
613 debug!("looking for variants or fields named {} for {:?}", item_name, did);
614 // FIXME(jynelson): why is this different from
616 match tcx.type_of(did).kind() {
618 let field = if def.is_enum() {
619 def.all_fields().find(|item| item.ident.name == item_name)
621 def.non_enum_variant()
624 .find(|item| item.ident.name == item_name)
627 if extra_fragment.is_some() {
636 Err(ErrorKind::AnchorFailure(
637 AnchorFailure::RustdocAnchorConflict(res),
644 if def.is_enum() { "variant" } else { "structfield" },
657 Res::Def(DefKind::Trait, did) => tcx
658 .associated_items(did)
659 .find_by_name_and_namespace(tcx, Ident::with_dummy_span(item_name), ns, did)
661 let kind = match item.kind {
662 ty::AssocKind::Const => "associatedconstant",
663 ty::AssocKind::Type => "associatedtype",
664 ty::AssocKind::Fn => {
665 if item.defaultness.has_value() {
673 if extra_fragment.is_some() {
674 Err(ErrorKind::AnchorFailure(AnchorFailure::RustdocAnchorConflict(ty_res)))
676 let res = Res::Def(item.kind.as_def_kind(), item.def_id);
677 Ok((res, Some(format!("{}.{}", kind, item_str))))
682 res.unwrap_or_else(|| {
683 if ns == Namespace::ValueNS {
684 self.variant_field(path_str, module_id)
686 Err(ResolutionFailure::NotResolved {
688 partial_res: Some(ty_res),
689 unresolved: item_str.into(),
696 /// Used for reporting better errors.
698 /// Returns whether the link resolved 'fully' in another namespace.
699 /// 'fully' here means that all parts of the link resolved, not just some path segments.
700 /// This returns the `Res` even if it was erroneous for some reason
701 /// (such as having invalid URL fragments or being in the wrong namespace).
707 extra_fragment: &Option<String>,
709 // resolve() can't be used for macro namespace
710 let result = match ns {
711 Namespace::MacroNS => self.resolve_macro(path_str, module_id).map_err(ErrorKind::from),
712 Namespace::TypeNS | Namespace::ValueNS => {
713 self.resolve(path_str, ns, module_id, extra_fragment).map(|(res, _)| res)
717 let res = match result {
718 Ok(res) => Some(res),
719 Err(ErrorKind::Resolve(box kind)) => kind.full_res(),
720 Err(ErrorKind::AnchorFailure(AnchorFailure::RustdocAnchorConflict(res))) => Some(res),
721 Err(ErrorKind::AnchorFailure(AnchorFailure::MultipleAnchors)) => None,
723 self.kind_side_channel.take().map(|(kind, id)| Res::Def(kind, id)).or(res)
727 /// Look to see if a resolved item has an associated item named `item_name`.
729 /// Given `[std::io::Error::source]`, where `source` is unresolved, this would
730 /// find `std::error::Error::source` and return
731 /// `<io::Error as error::Error>::source`.
732 fn resolve_associated_trait_item(
737 cx: &mut DocContext<'_>,
738 ) -> Option<(ty::AssocKind, DefId)> {
739 // FIXME: this should also consider blanket impls (`impl<T> X for T`). Unfortunately
740 // `get_auto_trait_and_blanket_impls` is broken because the caching behavior is wrong. In the
741 // meantime, just don't look for these blanket impls.
743 // Next consider explicit impls: `impl MyTrait for MyType`
744 // Give precedence to inherent impls.
745 let traits = traits_implemented_by(cx, did, module);
746 debug!("considering traits {:?}", traits);
747 let mut candidates = traits.iter().filter_map(|&trait_| {
749 .associated_items(trait_)
750 .find_by_name_and_namespace(cx.tcx, Ident::with_dummy_span(item_name), ns, trait_)
751 .map(|assoc| (assoc.kind, assoc.def_id))
753 // FIXME(#74563): warn about ambiguity
754 debug!("the candidates were {:?}", candidates.clone().collect::<Vec<_>>());
758 /// Given a type, return all traits in scope in `module` implemented by that type.
760 /// NOTE: this cannot be a query because more traits could be available when more crates are compiled!
761 /// So it is not stable to serialize cross-crate.
762 fn traits_implemented_by(cx: &mut DocContext<'_>, type_: DefId, module: DefId) -> FxHashSet<DefId> {
763 let mut resolver = cx.resolver.borrow_mut();
764 let in_scope_traits = cx.module_trait_cache.entry(module).or_insert_with(|| {
765 resolver.access(|resolver| {
766 let parent_scope = &ParentScope::module(resolver.get_module(module), resolver);
768 .traits_in_scope(None, parent_scope, SyntaxContext::root(), None)
770 .map(|candidate| candidate.def_id)
776 let ty = tcx.type_of(type_);
777 let iter = in_scope_traits.iter().flat_map(|&trait_| {
778 trace!("considering explicit impl for trait {:?}", trait_);
780 // Look at each trait implementation to see if it's an impl for `did`
781 tcx.find_map_relevant_impl(trait_, ty, |impl_| {
782 let trait_ref = tcx.impl_trait_ref(impl_).expect("this is not an inherent impl");
783 // Check if these are the same type.
784 let impl_type = trait_ref.self_ty();
786 "comparing type {} with kind {:?} against type {:?}",
791 // Fast path: if this is a primitive simple `==` will work
792 let saw_impl = impl_type == ty
793 || match impl_type.kind() {
794 // Check if these are the same def_id
796 debug!("adt def_id: {:?}", def.did);
799 ty::Foreign(def_id) => *def_id == type_,
803 if saw_impl { Some(trait_) } else { None }
809 /// Check for resolve collisions between a trait and its derive.
811 /// These are common and we should just resolve to the trait in that case.
812 fn is_derive_trait_collision<T>(ns: &PerNS<Result<(Res, T), ResolutionFailure<'_>>>) -> bool {
816 type_ns: Ok((Res::Def(DefKind::Trait, _), _)),
817 macro_ns: Ok((Res::Def(DefKind::Macro(MacroKind::Derive), _), _)),
823 impl<'a, 'tcx> DocFolder for LinkCollector<'a, 'tcx> {
824 fn fold_item(&mut self, mut item: Item) -> Option<Item> {
825 use rustc_middle::ty::DefIdTree;
827 let parent_node = if item.is_fake() {
830 find_nearest_parent_module(self.cx.tcx, item.def_id)
833 if parent_node.is_some() {
834 trace!("got parent node for {:?} {:?}, id {:?}", item.type_(), item.name, item.def_id);
837 // find item's parent to resolve `Self` in item's docs below
838 debug!("looking for the `Self` type");
839 let self_id = if item.is_fake() {
841 // Checking if the item is a field in an enum variant
842 } else if (matches!(self.cx.tcx.def_kind(item.def_id), DefKind::Field)
844 self.cx.tcx.def_kind(self.cx.tcx.parent(item.def_id).unwrap()),
848 self.cx.tcx.parent(item.def_id).and_then(|item_id| self.cx.tcx.parent(item_id))
850 self.cx.tcx.def_kind(item.def_id),
857 self.cx.tcx.parent(item.def_id)
858 // HACK(jynelson): `clean` marks associated types as `TypedefItem`, not as `AssocTypeItem`.
859 // Fixing this breaks `fn render_deref_methods`.
860 // As a workaround, see if the parent of the item is an `impl`; if so this must be an associated item,
861 // regardless of what rustdoc wants to call it.
862 } else if let Some(parent) = self.cx.tcx.parent(item.def_id) {
863 let parent_kind = self.cx.tcx.def_kind(parent);
864 Some(if parent_kind == DefKind::Impl { parent } else { item.def_id })
869 // FIXME(jynelson): this shouldn't go through stringification, rustdoc should just use the DefId directly
870 let self_name = self_id.and_then(|self_id| {
871 if matches!(self.cx.tcx.def_kind(self_id), DefKind::Impl) {
872 // using `ty.to_string()` (or any variant) has issues with raw idents
873 let ty = self.cx.tcx.type_of(self_id);
874 let name = match ty.kind() {
875 ty::Adt(def, _) => Some(self.cx.tcx.item_name(def.did).to_string()),
876 other if other.is_primitive() => Some(ty.to_string()),
879 debug!("using type_of(): {:?}", name);
882 let name = self.cx.tcx.opt_item_name(self_id).map(|sym| sym.to_string());
883 debug!("using item_name(): {:?}", name);
888 if item.is_mod() && item.attrs.inner_docs {
889 self.mod_ids.push(item.def_id);
892 // We want to resolve in the lexical scope of the documentation.
893 // In the presence of re-exports, this is not the same as the module of the item.
894 // Rather than merging all documentation into one, resolve it one attribute at a time
895 // so we know which module it came from.
896 for (parent_module, doc) in item.attrs.collapsed_doc_value_by_module_level() {
897 debug!("combined_docs={}", doc);
899 let (krate, parent_node) = if let Some(id) = parent_module {
902 (item.def_id.krate, parent_node)
904 // NOTE: if there are links that start in one crate and end in another, this will not resolve them.
905 // This is a degenerate case and it's not supported by rustdoc.
906 for md_link in markdown_links(&doc) {
907 let link = self.resolve_link(&item, &doc, &self_name, parent_node, krate, md_link);
908 if let Some(link) = link {
909 item.attrs.links.push(link);
914 Some(if item.is_mod() {
915 if !item.attrs.inner_docs {
916 self.mod_ids.push(item.def_id);
919 let ret = self.fold_item_recur(item);
923 self.fold_item_recur(item)
928 impl LinkCollector<'_, '_> {
929 /// This is the entry point for resolving an intra-doc link.
931 /// FIXME(jynelson): this is way too many arguments
936 self_name: &Option<String>,
937 parent_node: Option<DefId>,
939 ori_link: MarkdownLink,
940 ) -> Option<ItemLink> {
941 trace!("considering link '{}'", ori_link.link);
943 // Bail early for real links.
944 if ori_link.link.contains('/') {
948 // [] is mostly likely not supposed to be a link
949 if ori_link.link.is_empty() {
953 let diag_info = DiagnosticInfo {
956 ori_link: &ori_link.link,
957 link_range: ori_link.range.clone(),
960 let link = ori_link.link.replace("`", "");
961 let no_backticks_range = range_between_backticks(&ori_link);
962 let parts = link.split('#').collect::<Vec<_>>();
963 let (link, extra_fragment) = if parts.len() > 2 {
964 // A valid link can't have multiple #'s
965 anchor_failure(self.cx, diag_info, AnchorFailure::MultipleAnchors);
967 } else if parts.len() == 2 {
968 if parts[0].trim().is_empty() {
969 // This is an anchor to an element of the current page, nothing to do in here!
972 (parts[0], Some(parts[1].to_owned()))
977 // Parse and strip the disambiguator from the link, if present.
978 let (mut path_str, disambiguator) = match Disambiguator::from_str(&link) {
979 Ok(Some((d, path))) => (path.trim(), Some(d)),
980 Ok(None) => (link.trim(), None),
981 Err((err_msg, relative_range)) => {
982 if !should_ignore_link_with_disambiguators(link) {
983 // Only report error if we would not have ignored this link.
985 let disambiguator_range = (no_backticks_range.start + relative_range.start)
986 ..(no_backticks_range.start + relative_range.end);
987 disambiguator_error(self.cx, &item, dox, disambiguator_range, &err_msg);
993 if should_ignore_link(path_str) {
997 // We stripped `()` and `!` when parsing the disambiguator.
998 // Add them back to be displayed, but not prefix disambiguators.
1000 disambiguator.map(|d| d.display_for(path_str)).unwrap_or_else(|| path_str.to_owned());
1002 // In order to correctly resolve intra-doc links we need to
1003 // pick a base AST node to work from. If the documentation for
1004 // this module came from an inner comment (//!) then we anchor
1005 // our name resolution *inside* the module. If, on the other
1006 // hand it was an outer comment (///) then we anchor the name
1007 // resolution in the parent module on the basis that the names
1008 // used are more likely to be intended to be parent names. For
1009 // this, we set base_node to None for inner comments since
1010 // we've already pushed this node onto the resolution stack but
1011 // for outer comments we explicitly try and resolve against the
1012 // parent_node first.
1013 let base_node = if item.is_mod() && item.attrs.inner_docs {
1014 self.mod_ids.last().copied()
1019 let mut module_id = if let Some(id) = base_node {
1023 debug!("attempting to resolve item without parent module: {}", path_str);
1029 smallvec![ResolutionFailure::NoParentItem],
1035 // replace `Self` with suitable item's parent name
1036 let is_lone_self = path_str == "Self";
1037 let is_lone_crate = path_str == "crate";
1038 if path_str.starts_with("Self::") || is_lone_self {
1039 if let Some(ref name) = self_name {
1043 resolved_self = format!("{}::{}", name, &path_str[6..]);
1044 path_str = &resolved_self;
1047 } else if path_str.starts_with("crate::") || is_lone_crate {
1048 use rustc_span::def_id::CRATE_DEF_INDEX;
1050 // HACK(jynelson): rustc_resolve thinks that `crate` is the crate currently being documented.
1051 // But rustdoc wants it to mean the crate this item was originally present in.
1052 // To work around this, remove it and resolve relative to the crate root instead.
1053 // HACK(jynelson)(2): If we just strip `crate::` then suddenly primitives become ambiguous
1054 // (consider `crate::char`). Instead, change it to `self::`. This works because 'self' is now the crate root.
1055 // FIXME(#78696): This doesn't always work.
1059 resolved_self = format!("self::{}", &path_str["crate::".len()..]);
1060 path_str = &resolved_self;
1062 module_id = DefId { krate, index: CRATE_DEF_INDEX };
1065 // Strip generics from the path.
1066 let stripped_path_string;
1067 if path_str.contains(['<', '>'].as_slice()) {
1068 stripped_path_string = match strip_generics_from_path(path_str) {
1071 debug!("link has malformed generics: {}", path_str);
1077 smallvec![err_kind],
1082 path_str = &stripped_path_string;
1084 // Sanity check to make sure we don't have any angle brackets after stripping generics.
1085 assert!(!path_str.contains(['<', '>'].as_slice()));
1087 // The link is not an intra-doc link if it still contains spaces after stripping generics.
1088 if path_str.contains(' ') {
1092 let (mut res, mut fragment) = self.resolve_with_disambiguator_cached(
1096 path_str: path_str.to_owned(),
1099 diag_info.clone(), // this struct should really be Copy, but Range is not :(
1100 matches!(ori_link.kind, LinkType::Reference | LinkType::Shortcut),
1103 // Check for a primitive which might conflict with a module
1104 // Report the ambiguity and require that the user specify which one they meant.
1105 // FIXME: could there ever be a primitive not in the type namespace?
1108 None | Some(Disambiguator::Namespace(Namespace::TypeNS) | Disambiguator::Primitive)
1109 ) && !matches!(res, Res::Primitive(_))
1111 if let Some(prim) = resolve_primitive(path_str, TypeNS) {
1113 if matches!(disambiguator, Some(Disambiguator::Primitive)) {
1114 if fragment.is_some() {
1118 AnchorFailure::RustdocAnchorConflict(prim),
1123 fragment = Some(prim.name(self.cx.tcx));
1125 // `[char]` when a `char` module is in scope
1126 let candidates = vec![res, prim];
1127 ambiguity_error(self.cx, &item, path_str, dox, ori_link.range, candidates);
1133 let report_mismatch = |specified: Disambiguator, resolved: Disambiguator| {
1134 // The resolved item did not match the disambiguator; give a better error than 'not found'
1135 let msg = format!("incompatible link kind for `{}`", path_str);
1136 let callback = |diag: &mut DiagnosticBuilder<'_>, sp| {
1138 "this link resolved to {} {}, which is not {} {}",
1141 specified.article(),
1145 suggest_disambiguator(resolved, diag, path_str, dox, sp, &ori_link.range);
1149 BROKEN_INTRA_DOC_LINKS,
1158 let verify = |kind: DefKind, id: DefId| {
1159 let (kind, id) = self.kind_side_channel.take().unwrap_or((kind, id));
1160 debug!("intra-doc link to {} resolved to {:?} (id: {:?})", path_str, res, id);
1162 // Disallow e.g. linking to enums with `struct@`
1163 debug!("saw kind {:?} with disambiguator {:?}", kind, disambiguator);
1164 match (kind, disambiguator) {
1165 | (DefKind::Const | DefKind::ConstParam | DefKind::AssocConst | DefKind::AnonConst, Some(Disambiguator::Kind(DefKind::Const)))
1166 // NOTE: this allows 'method' to mean both normal functions and associated functions
1167 // This can't cause ambiguity because both are in the same namespace.
1168 | (DefKind::Fn | DefKind::AssocFn, Some(Disambiguator::Kind(DefKind::Fn)))
1169 // These are namespaces; allow anything in the namespace to match
1170 | (_, Some(Disambiguator::Namespace(_)))
1171 // If no disambiguator given, allow anything
1173 // All of these are valid, so do nothing
1175 (actual, Some(Disambiguator::Kind(expected))) if actual == expected => {}
1176 (_, Some(specified @ Disambiguator::Kind(_) | specified @ Disambiguator::Primitive)) => {
1177 report_mismatch(specified, Disambiguator::Kind(kind));
1182 // item can be non-local e.g. when using #[doc(primitive = "pointer")]
1183 if let Some((src_id, dst_id)) = id
1185 .and_then(|dst_id| item.def_id.as_local().map(|src_id| (src_id, dst_id)))
1187 use rustc_hir::def_id::LOCAL_CRATE;
1189 let hir_src = self.cx.tcx.hir().local_def_id_to_hir_id(src_id);
1190 let hir_dst = self.cx.tcx.hir().local_def_id_to_hir_id(dst_id);
1192 if self.cx.tcx.privacy_access_levels(LOCAL_CRATE).is_exported(hir_src)
1193 && !self.cx.tcx.privacy_access_levels(LOCAL_CRATE).is_exported(hir_dst)
1195 privacy_error(self.cx, &item, &path_str, dox, &ori_link);
1203 Res::Primitive(prim) => {
1204 if let Some((kind, id)) = self.kind_side_channel.take() {
1205 // We're actually resolving an associated item of a primitive, so we need to
1206 // verify the disambiguator (if any) matches the type of the associated item.
1207 // This case should really follow the same flow as the `Res::Def` branch below,
1208 // but attempting to add a call to `clean::register_res` causes an ICE. @jyn514
1209 // thinks `register_res` is only needed for cross-crate re-exports, but Rust
1210 // doesn't allow statements like `use str::trim;`, making this a (hopefully)
1211 // valid omission. See https://github.com/rust-lang/rust/pull/80660#discussion_r551585677
1212 // for discussion on the matter.
1215 // FIXME: it would be nice to check that the feature gate was enabled in the original crate, not just ignore it altogether.
1216 // However I'm not sure how to check that across crates.
1217 if prim == PrimitiveType::RawPointer
1218 && item.def_id.is_local()
1219 && !self.cx.tcx.features().intra_doc_pointers
1221 let span = super::source_span_for_markdown_range(
1227 .unwrap_or_else(|| span_of_attrs(&item.attrs).unwrap_or(item.span.inner()));
1229 rustc_session::parse::feature_err(
1230 &self.cx.tcx.sess.parse_sess,
1231 sym::intra_doc_pointers,
1233 "linking to associated items of raw pointers is experimental",
1235 .note("rustdoc does not allow disambiguating between `*const` and `*mut`, and pointers are unstable until it does")
1239 match disambiguator {
1240 Some(Disambiguator::Primitive | Disambiguator::Namespace(_)) | None => {}
1242 report_mismatch(other, Disambiguator::Primitive);
1248 Some(ItemLink { link: ori_link.link, link_text, did: None, fragment })
1250 Res::Def(kind, id) => {
1252 let id = clean::register_res(self.cx, rustc_hir::def::Res::Def(kind, id));
1253 Some(ItemLink { link: ori_link.link, link_text, did: Some(id), fragment })
1258 fn resolve_with_disambiguator_cached(
1260 key: ResolutionInfo,
1261 diag: DiagnosticInfo<'_>,
1262 cache_resolution_failure: bool,
1263 ) -> Option<(Res, Option<String>)> {
1264 // Try to look up both the result and the corresponding side channel value
1265 if let Some(ref cached) = self.visited_links.get(&key) {
1268 self.kind_side_channel.set(cached.side_channel.clone());
1269 return Some(cached.res.clone());
1271 None if cache_resolution_failure => return None,
1273 // Although we hit the cache and found a resolution error, this link isn't
1274 // supposed to cache those. Run link resolution again to emit the expected
1275 // resolution error.
1280 let res = self.resolve_with_disambiguator(&key, diag);
1282 // Cache only if resolved successfully - don't silence duplicate errors
1283 if let Some(res) = res {
1284 // Store result for the actual namespace
1285 self.visited_links.insert(
1289 side_channel: self.kind_side_channel.clone().into_inner(),
1295 if cache_resolution_failure {
1296 // For reference-style links we only want to report one resolution error
1297 // so let's cache them as well.
1298 self.visited_links.insert(key, None);
1305 /// After parsing the disambiguator, resolve the main part of the link.
1306 // FIXME(jynelson): wow this is just so much
1307 fn resolve_with_disambiguator(
1309 key: &ResolutionInfo,
1310 diag: DiagnosticInfo<'_>,
1311 ) -> Option<(Res, Option<String>)> {
1312 let disambiguator = key.dis;
1313 let path_str = &key.path_str;
1314 let base_node = key.module_id;
1315 let extra_fragment = &key.extra_fragment;
1317 match disambiguator.map(Disambiguator::ns) {
1318 Some(expected_ns @ (ValueNS | TypeNS)) => {
1319 match self.resolve(path_str, expected_ns, base_node, extra_fragment) {
1320 Ok(res) => Some(res),
1321 Err(ErrorKind::Resolve(box mut kind)) => {
1322 // We only looked in one namespace. Try to give a better error if possible.
1323 if kind.full_res().is_none() {
1324 let other_ns = if expected_ns == ValueNS { TypeNS } else { ValueNS };
1325 // FIXME: really it should be `resolution_failure` that does this, not `resolve_with_disambiguator`
1326 // See https://github.com/rust-lang/rust/pull/76955#discussion_r493953382 for a good approach
1327 for &new_ns in &[other_ns, MacroNS] {
1329 self.check_full_res(new_ns, path_str, base_node, extra_fragment)
1331 kind = ResolutionFailure::WrongNamespace { res, expected_ns };
1336 resolution_failure(self, diag, path_str, disambiguator, smallvec![kind]);
1337 // This could just be a normal link or a broken link
1338 // we could potentially check if something is
1339 // "intra-doc-link-like" and warn in that case.
1342 Err(ErrorKind::AnchorFailure(msg)) => {
1343 anchor_failure(self.cx, diag, msg);
1350 let mut candidates = PerNS {
1352 .resolve_macro(path_str, base_node)
1353 .map(|res| (res, extra_fragment.clone())),
1354 type_ns: match self.resolve(path_str, TypeNS, base_node, extra_fragment) {
1356 debug!("got res in TypeNS: {:?}", res);
1359 Err(ErrorKind::AnchorFailure(msg)) => {
1360 anchor_failure(self.cx, diag, msg);
1363 Err(ErrorKind::Resolve(box kind)) => Err(kind),
1365 value_ns: match self.resolve(path_str, ValueNS, base_node, extra_fragment) {
1367 Err(ErrorKind::AnchorFailure(msg)) => {
1368 anchor_failure(self.cx, diag, msg);
1371 Err(ErrorKind::Resolve(box kind)) => Err(kind),
1373 .and_then(|(res, fragment)| {
1374 // Constructors are picked up in the type namespace.
1376 Res::Def(DefKind::Ctor(..), _) => {
1377 Err(ResolutionFailure::WrongNamespace { res, expected_ns: TypeNS })
1380 match (fragment, extra_fragment.clone()) {
1381 (Some(fragment), Some(_)) => {
1382 // Shouldn't happen but who knows?
1383 Ok((res, Some(fragment)))
1385 (fragment, None) | (None, fragment) => Ok((res, fragment)),
1392 let len = candidates.iter().filter(|res| res.is_ok()).count();
1400 candidates.into_iter().filter_map(|res| res.err()).collect(),
1402 // this could just be a normal link
1407 Some(candidates.into_iter().filter_map(|res| res.ok()).next().unwrap())
1408 } else if len == 2 && is_derive_trait_collision(&candidates) {
1409 Some(candidates.type_ns.unwrap())
1411 if is_derive_trait_collision(&candidates) {
1412 candidates.macro_ns = Err(ResolutionFailure::Dummy);
1414 // If we're reporting an ambiguity, don't mention the namespaces that failed
1415 let candidates = candidates.map(|candidate| candidate.ok().map(|(res, _)| res));
1422 candidates.present_items().collect(),
1428 match self.resolve_macro(path_str, base_node) {
1429 Ok(res) => Some((res, extra_fragment.clone())),
1431 // `resolve_macro` only looks in the macro namespace. Try to give a better error if possible.
1432 for &ns in &[TypeNS, ValueNS] {
1434 self.check_full_res(ns, path_str, base_node, extra_fragment)
1437 ResolutionFailure::WrongNamespace { res, expected_ns: MacroNS };
1441 resolution_failure(self, diag, path_str, disambiguator, smallvec![kind]);
1450 /// Get the section of a link between the backticks,
1451 /// or the whole link if there aren't any backticks.
1459 fn range_between_backticks(ori_link: &MarkdownLink) -> Range<usize> {
1460 let after_first_backtick_group = ori_link.link.bytes().position(|b| b != b'`').unwrap_or(0);
1461 let before_second_backtick_group = ori_link
1464 .skip(after_first_backtick_group)
1465 .position(|b| b == b'`')
1466 .unwrap_or(ori_link.link.len());
1467 (ori_link.range.start + after_first_backtick_group)
1468 ..(ori_link.range.start + before_second_backtick_group)
1471 /// Returns true if we should ignore `link` due to it being unlikely
1472 /// that it is an intra-doc link. `link` should still have disambiguators
1473 /// if there were any.
1475 /// The difference between this and [`should_ignore_link()`] is that this
1476 /// check should only be used on links that still have disambiguators.
1477 fn should_ignore_link_with_disambiguators(link: &str) -> bool {
1478 link.contains(|ch: char| !(ch.is_alphanumeric() || ":_<>, !*&;@()".contains(ch)))
1481 /// Returns true if we should ignore `path_str` due to it being unlikely
1482 /// that it is an intra-doc link.
1483 fn should_ignore_link(path_str: &str) -> bool {
1484 path_str.contains(|ch: char| !(ch.is_alphanumeric() || ":_<>, !*&;".contains(ch)))
1487 #[derive(Copy, Clone, Debug, PartialEq, Eq, Hash)]
1488 /// Disambiguators for a link.
1489 crate enum Disambiguator {
1492 /// This is buggy, see <https://github.com/rust-lang/rust/pull/77875#discussion_r503583103>
1494 /// `struct@` or `f()`
1497 Namespace(Namespace),
1500 impl Disambiguator {
1501 /// The text that should be displayed when the path is rendered as HTML.
1503 /// NOTE: `path` is not the original link given by the user, but a name suitable for passing to `resolve`.
1504 fn display_for(&self, path: &str) -> String {
1506 // FIXME: this will have different output if the user had `m!()` originally.
1507 Self::Kind(DefKind::Macro(MacroKind::Bang)) => format!("{}!", path),
1508 Self::Kind(DefKind::Fn) => format!("{}()", path),
1509 _ => path.to_owned(),
1513 /// Given a link, parse and return `(disambiguator, path_str)`.
1515 /// This returns `Ok(Some(...))` if a disambiguator was found,
1516 /// `Ok(None)` if no disambiguator was found, or `Err(...)`
1517 /// if there was a problem with the disambiguator.
1518 crate fn from_str(link: &str) -> Result<Option<(Self, &str)>, (String, Range<usize>)> {
1519 use Disambiguator::{Kind, Namespace as NS, Primitive};
1521 if let Some(idx) = link.find('@') {
1522 let (prefix, rest) = link.split_at(idx);
1523 let d = match prefix {
1524 "struct" => Kind(DefKind::Struct),
1525 "enum" => Kind(DefKind::Enum),
1526 "trait" => Kind(DefKind::Trait),
1527 "union" => Kind(DefKind::Union),
1528 "module" | "mod" => Kind(DefKind::Mod),
1529 "const" | "constant" => Kind(DefKind::Const),
1530 "static" => Kind(DefKind::Static),
1531 "function" | "fn" | "method" => Kind(DefKind::Fn),
1532 "derive" => Kind(DefKind::Macro(MacroKind::Derive)),
1533 "type" => NS(Namespace::TypeNS),
1534 "value" => NS(Namespace::ValueNS),
1535 "macro" => NS(Namespace::MacroNS),
1536 "prim" | "primitive" => Primitive,
1537 _ => return Err((format!("unknown disambiguator `{}`", prefix), 0..idx)),
1539 Ok(Some((d, &rest[1..])))
1542 ("!()", DefKind::Macro(MacroKind::Bang)),
1543 ("()", DefKind::Fn),
1544 ("!", DefKind::Macro(MacroKind::Bang)),
1546 for &(suffix, kind) in &suffixes {
1547 if let Some(link) = link.strip_suffix(suffix) {
1548 // Avoid turning `!` or `()` into an empty string
1549 if !link.is_empty() {
1550 return Ok(Some((Kind(kind), link)));
1558 fn from_res(res: Res) -> Self {
1560 Res::Def(kind, _) => Disambiguator::Kind(kind),
1561 Res::Primitive(_) => Disambiguator::Primitive,
1565 /// Used for error reporting.
1566 fn suggestion(self) -> Suggestion {
1567 let kind = match self {
1568 Disambiguator::Primitive => return Suggestion::Prefix("prim"),
1569 Disambiguator::Kind(kind) => kind,
1570 Disambiguator::Namespace(_) => panic!("display_for cannot be used on namespaces"),
1572 if kind == DefKind::Macro(MacroKind::Bang) {
1573 return Suggestion::Macro;
1574 } else if kind == DefKind::Fn || kind == DefKind::AssocFn {
1575 return Suggestion::Function;
1578 let prefix = match kind {
1579 DefKind::Struct => "struct",
1580 DefKind::Enum => "enum",
1581 DefKind::Trait => "trait",
1582 DefKind::Union => "union",
1583 DefKind::Mod => "mod",
1584 DefKind::Const | DefKind::ConstParam | DefKind::AssocConst | DefKind::AnonConst => {
1587 DefKind::Static => "static",
1588 DefKind::Macro(MacroKind::Derive) => "derive",
1589 // Now handle things that don't have a specific disambiguator
1592 .expect("tried to calculate a disambiguator for a def without a namespace?")
1594 Namespace::TypeNS => "type",
1595 Namespace::ValueNS => "value",
1596 Namespace::MacroNS => "macro",
1600 Suggestion::Prefix(prefix)
1603 fn ns(self) -> Namespace {
1605 Self::Namespace(n) => n,
1607 k.ns().expect("only DefKinds with a valid namespace can be disambiguators")
1609 Self::Primitive => TypeNS,
1613 fn article(self) -> &'static str {
1615 Self::Namespace(_) => panic!("article() doesn't make sense for namespaces"),
1616 Self::Kind(k) => k.article(),
1617 Self::Primitive => "a",
1621 fn descr(self) -> &'static str {
1623 Self::Namespace(n) => n.descr(),
1624 // HACK(jynelson): by looking at the source I saw the DefId we pass
1625 // for `expected.descr()` doesn't matter, since it's not a crate
1626 Self::Kind(k) => k.descr(DefId::local(hir::def_id::DefIndex::from_usize(0))),
1627 Self::Primitive => "builtin type",
1632 /// A suggestion to show in a diagnostic.
1635 Prefix(&'static str),
1643 fn descr(&self) -> Cow<'static, str> {
1645 Self::Prefix(x) => format!("prefix with `{}@`", x).into(),
1646 Self::Function => "add parentheses".into(),
1647 Self::Macro => "add an exclamation mark".into(),
1651 fn as_help(&self, path_str: &str) -> String {
1652 // FIXME: if this is an implied shortcut link, it's bad style to suggest `@`
1654 Self::Prefix(prefix) => format!("{}@{}", prefix, path_str),
1655 Self::Function => format!("{}()", path_str),
1656 Self::Macro => format!("{}!", path_str),
1661 /// Reports a diagnostic for an intra-doc link.
1663 /// If no link range is provided, or the source span of the link cannot be determined, the span of
1664 /// the entire documentation block is used for the lint. If a range is provided but the span
1665 /// calculation fails, a note is added to the diagnostic pointing to the link in the markdown.
1667 /// The `decorate` callback is invoked in all cases to allow further customization of the
1668 /// diagnostic before emission. If the span of the link was able to be determined, the second
1669 /// parameter of the callback will contain it, and the primary span of the diagnostic will be set
1671 fn report_diagnostic(
1673 lint: &'static Lint,
1677 link_range: &Range<usize>,
1678 decorate: impl FnOnce(&mut DiagnosticBuilder<'_>, Option<rustc_span::Span>),
1680 let hir_id = match DocContext::as_local_hir_id(tcx, item.def_id) {
1681 Some(hir_id) => hir_id,
1683 // If non-local, no need to check anything.
1684 info!("ignoring warning from parent crate: {}", msg);
1689 let attrs = &item.attrs;
1690 let sp = span_of_attrs(attrs).unwrap_or(item.span.inner());
1692 tcx.struct_span_lint_hir(lint, hir_id, sp, |lint| {
1693 let mut diag = lint.build(msg);
1695 let span = super::source_span_for_markdown_range(tcx, dox, link_range, attrs);
1697 if let Some(sp) = span {
1700 // blah blah blah\nblah\nblah [blah] blah blah\nblah blah
1703 // last_new_line_offset
1704 let last_new_line_offset = dox[..link_range.start].rfind('\n').map_or(0, |n| n + 1);
1705 let line = dox[last_new_line_offset..].lines().next().unwrap_or("");
1707 // Print the line containing the `link_range` and manually mark it with '^'s.
1709 "the link appears in this line:\n\n{line}\n\
1710 {indicator: <before$}{indicator:^<found$}",
1713 before = link_range.start - last_new_line_offset,
1714 found = link_range.len(),
1718 decorate(&mut diag, span);
1724 /// Reports a link that failed to resolve.
1726 /// This also tries to resolve any intermediate path segments that weren't
1727 /// handled earlier. For example, if passed `Item::Crate(std)` and `path_str`
1728 /// `std::io::Error::x`, this will resolve `std::io::Error`.
1729 fn resolution_failure(
1730 collector: &mut LinkCollector<'_, '_>,
1731 DiagnosticInfo { item, ori_link: _, dox, link_range }: DiagnosticInfo<'_>,
1733 disambiguator: Option<Disambiguator>,
1734 kinds: SmallVec<[ResolutionFailure<'_>; 3]>,
1736 let tcx = collector.cx.tcx;
1739 BROKEN_INTRA_DOC_LINKS,
1740 &format!("unresolved link to `{}`", path_str),
1745 let item = |res: Res| format!("the {} `{}`", res.descr(), res.name(tcx),);
1746 let assoc_item_not_allowed = |res: Res| {
1747 let name = res.name(tcx);
1749 "`{}` is {} {}, not a module or type, and cannot have associated items",
1755 // ignore duplicates
1756 let mut variants_seen = SmallVec::<[_; 3]>::new();
1757 for mut failure in kinds {
1758 let variant = std::mem::discriminant(&failure);
1759 if variants_seen.contains(&variant) {
1762 variants_seen.push(variant);
1764 if let ResolutionFailure::NotResolved { module_id, partial_res, unresolved } =
1769 let module_id = *module_id;
1770 // FIXME(jynelson): this might conflict with my `Self` fix in #76467
1771 // FIXME: maybe use itertools `collect_tuple` instead?
1772 fn split(path: &str) -> Option<(&str, &str)> {
1773 let mut splitter = path.rsplitn(2, "::");
1774 splitter.next().and_then(|right| splitter.next().map(|left| (left, right)))
1777 // Check if _any_ parent of the path gets resolved.
1778 // If so, report it and say the first which failed; if not, say the first path segment didn't resolve.
1779 let mut name = path_str;
1781 let (start, end) = if let Some(x) = split(name) {
1784 // avoid bug that marked [Quux::Z] as missing Z, not Quux
1785 if partial_res.is_none() {
1786 *unresolved = name.into();
1791 for &ns in &[TypeNS, ValueNS, MacroNS] {
1793 collector.check_full_res(ns, &start, module_id, &None)
1795 debug!("found partial_res={:?}", res);
1796 *partial_res = Some(res);
1797 *unresolved = end.into();
1801 *unresolved = end.into();
1804 let last_found_module = match *partial_res {
1805 Some(Res::Def(DefKind::Mod, id)) => Some(id),
1806 None => Some(module_id),
1809 // See if this was a module: `[path]` or `[std::io::nope]`
1810 if let Some(module) = last_found_module {
1811 let note = if partial_res.is_some() {
1812 // Part of the link resolved; e.g. `std::io::nonexistent`
1813 let module_name = tcx.item_name(module);
1814 format!("no item named `{}` in module `{}`", unresolved, module_name)
1816 // None of the link resolved; e.g. `Notimported`
1817 format!("no item named `{}` in scope", unresolved)
1819 if let Some(span) = sp {
1820 diag.span_label(span, ¬e);
1825 // If the link has `::` in it, assume it was meant to be an intra-doc link.
1826 // Otherwise, the `[]` might be unrelated.
1827 // FIXME: don't show this for autolinks (`<>`), `()` style links, or reference links
1828 if !path_str.contains("::") {
1829 diag.help(r#"to escape `[` and `]` characters, add '\' before them like `\[` or `\]`"#);
1835 // Otherwise, it must be an associated item or variant
1836 let res = partial_res.expect("None case was handled by `last_found_module`");
1837 let name = res.name(tcx);
1838 let kind = match res {
1839 Res::Def(kind, _) => Some(kind),
1840 Res::Primitive(_) => None,
1842 let path_description = if let Some(kind) = kind {
1844 Mod | ForeignMod => "inner item",
1845 Struct => "field or associated item",
1846 Enum | Union => "variant or associated item",
1863 let note = assoc_item_not_allowed(res);
1864 if let Some(span) = sp {
1865 diag.span_label(span, ¬e);
1871 Trait | TyAlias | ForeignTy | OpaqueTy | TraitAlias | TyParam
1872 | Static => "associated item",
1873 Impl | GlobalAsm => unreachable!("not a path"),
1879 "the {} `{}` has no {} named `{}`",
1882 disambiguator.map_or(path_description, |d| d.descr()),
1885 if let Some(span) = sp {
1886 diag.span_label(span, ¬e);
1893 let note = match failure {
1894 ResolutionFailure::NotResolved { .. } => unreachable!("handled above"),
1895 ResolutionFailure::Dummy => continue,
1896 ResolutionFailure::WrongNamespace { res, expected_ns } => {
1897 if let Res::Def(kind, _) = res {
1898 let disambiguator = Disambiguator::Kind(kind);
1899 suggest_disambiguator(
1910 "this link resolves to {}, which is not in the {} namespace",
1915 ResolutionFailure::NoParentItem => {
1916 diag.level = rustc_errors::Level::Bug;
1917 "all intra-doc links should have a parent item".to_owned()
1919 ResolutionFailure::MalformedGenerics(variant) => match variant {
1920 MalformedGenerics::UnbalancedAngleBrackets => {
1921 String::from("unbalanced angle brackets")
1923 MalformedGenerics::MissingType => {
1924 String::from("missing type for generic parameters")
1926 MalformedGenerics::HasFullyQualifiedSyntax => {
1927 diag.note("see https://github.com/rust-lang/rust/issues/74563 for more information");
1928 String::from("fully-qualified syntax is unsupported")
1930 MalformedGenerics::InvalidPathSeparator => {
1931 String::from("has invalid path separator")
1933 MalformedGenerics::TooManyAngleBrackets => {
1934 String::from("too many angle brackets")
1936 MalformedGenerics::EmptyAngleBrackets => {
1937 String::from("empty angle brackets")
1941 if let Some(span) = sp {
1942 diag.span_label(span, ¬e);
1951 /// Report an anchor failure.
1953 cx: &DocContext<'_>,
1954 DiagnosticInfo { item, ori_link, dox, link_range }: DiagnosticInfo<'_>,
1955 failure: AnchorFailure,
1957 let msg = match failure {
1958 AnchorFailure::MultipleAnchors => format!("`{}` contains multiple anchors", ori_link),
1959 AnchorFailure::RustdocAnchorConflict(res) => format!(
1960 "`{}` contains an anchor, but links to {kind}s are already anchored",
1966 report_diagnostic(cx.tcx, BROKEN_INTRA_DOC_LINKS, &msg, item, dox, &link_range, |diag, sp| {
1967 if let Some(sp) = sp {
1968 diag.span_label(sp, "contains invalid anchor");
1973 /// Report an error in the link disambiguator.
1974 fn disambiguator_error(
1975 cx: &DocContext<'_>,
1978 link_range: Range<usize>,
1981 report_diagnostic(cx.tcx, BROKEN_INTRA_DOC_LINKS, msg, item, dox, &link_range, |_diag, _sp| {});
1984 /// Report an ambiguity error, where there were multiple possible resolutions.
1986 cx: &DocContext<'_>,
1990 link_range: Range<usize>,
1991 candidates: Vec<Res>,
1993 let mut msg = format!("`{}` is ", path_str);
1995 match candidates.as_slice() {
1996 [first_def, second_def] => {
1998 "both {} {} and {} {}",
1999 first_def.article(),
2001 second_def.article(),
2006 let mut candidates = candidates.iter().peekable();
2007 while let Some(res) = candidates.next() {
2008 if candidates.peek().is_some() {
2009 msg += &format!("{} {}, ", res.article(), res.descr());
2011 msg += &format!("and {} {}", res.article(), res.descr());
2017 report_diagnostic(cx.tcx, BROKEN_INTRA_DOC_LINKS, &msg, item, dox, &link_range, |diag, sp| {
2018 if let Some(sp) = sp {
2019 diag.span_label(sp, "ambiguous link");
2021 diag.note("ambiguous link");
2024 for res in candidates {
2025 let disambiguator = Disambiguator::from_res(res);
2026 suggest_disambiguator(disambiguator, diag, path_str, dox, sp, &link_range);
2031 /// In case of an ambiguity or mismatched disambiguator, suggest the correct
2033 fn suggest_disambiguator(
2034 disambiguator: Disambiguator,
2035 diag: &mut DiagnosticBuilder<'_>,
2038 sp: Option<rustc_span::Span>,
2039 link_range: &Range<usize>,
2041 let suggestion = disambiguator.suggestion();
2042 let help = format!("to link to the {}, {}", disambiguator.descr(), suggestion.descr());
2044 if let Some(sp) = sp {
2045 let msg = if dox.bytes().nth(link_range.start) == Some(b'`') {
2046 format!("`{}`", suggestion.as_help(path_str))
2048 suggestion.as_help(path_str)
2051 diag.span_suggestion(sp, &help, msg, Applicability::MaybeIncorrect);
2053 diag.help(&format!("{}: {}", help, suggestion.as_help(path_str)));
2057 /// Report a link from a public item to a private one.
2058 fn privacy_error(cx: &DocContext<'_>, item: &Item, path_str: &str, dox: &str, link: &MarkdownLink) {
2060 let item_name = match item.name {
2062 sym = name.as_str();
2065 None => "<unknown>",
2068 format!("public documentation for `{}` links to private item `{}`", item_name, path_str);
2070 report_diagnostic(cx.tcx, PRIVATE_INTRA_DOC_LINKS, &msg, item, dox, &link.range, |diag, sp| {
2071 if let Some(sp) = sp {
2072 diag.span_label(sp, "this item is private");
2075 let note_msg = if cx.render_options.document_private {
2076 "this link resolves only because you passed `--document-private-items`, but will break without"
2078 "this link will resolve properly if you pass `--document-private-items`"
2080 diag.note(note_msg);
2084 /// Given an enum variant's res, return the res of its enum and the associated fragment.
2086 cx: &DocContext<'_>,
2088 extra_fragment: &Option<String>,
2089 ) -> Result<(Res, Option<String>), ErrorKind<'static>> {
2090 use rustc_middle::ty::DefIdTree;
2092 if extra_fragment.is_some() {
2093 return Err(ErrorKind::AnchorFailure(AnchorFailure::RustdocAnchorConflict(res)));
2096 .parent(res.def_id())
2098 let parent_def = Res::Def(DefKind::Enum, parent);
2099 let variant = cx.tcx.expect_variant_res(res.as_hir_res().unwrap());
2100 (parent_def, Some(format!("variant.{}", variant.ident.name)))
2102 .ok_or_else(|| ResolutionFailure::NoParentItem.into())
2105 /// Resolve a primitive type or value.
2106 fn resolve_primitive(path_str: &str, ns: Namespace) -> Option<Res> {
2110 use PrimitiveType::*;
2111 let prim = match path_str {
2127 "bool" | "true" | "false" => Bool,
2128 "str" | "&str" => Str,
2129 // See #80181 for why these don't have symbols associated.
2134 "pointer" | "*const" | "*mut" => RawPointer,
2135 "reference" | "&" | "&mut" => Reference,
2137 "never" | "!" => Never,
2140 debug!("resolved primitives {:?}", prim);
2141 Some(Res::Primitive(prim))
2144 fn strip_generics_from_path(path_str: &str) -> Result<String, ResolutionFailure<'static>> {
2145 let mut stripped_segments = vec![];
2146 let mut path = path_str.chars().peekable();
2147 let mut segment = Vec::new();
2149 while let Some(chr) = path.next() {
2152 if path.next_if_eq(&':').is_some() {
2153 let stripped_segment =
2154 strip_generics_from_path_segment(mem::take(&mut segment))?;
2155 if !stripped_segment.is_empty() {
2156 stripped_segments.push(stripped_segment);
2159 return Err(ResolutionFailure::MalformedGenerics(
2160 MalformedGenerics::InvalidPathSeparator,
2169 return Err(ResolutionFailure::MalformedGenerics(
2170 MalformedGenerics::TooManyAngleBrackets,
2174 return Err(ResolutionFailure::MalformedGenerics(
2175 MalformedGenerics::EmptyAngleBrackets,
2181 while let Some(chr) = path.next_if(|c| *c != '>') {
2188 _ => segment.push(chr),
2190 trace!("raw segment: {:?}", segment);
2193 if !segment.is_empty() {
2194 let stripped_segment = strip_generics_from_path_segment(segment)?;
2195 if !stripped_segment.is_empty() {
2196 stripped_segments.push(stripped_segment);
2200 debug!("path_str: {:?}\nstripped segments: {:?}", path_str, &stripped_segments);
2202 let stripped_path = stripped_segments.join("::");
2204 if !stripped_path.is_empty() {
2207 Err(ResolutionFailure::MalformedGenerics(MalformedGenerics::MissingType))
2211 fn strip_generics_from_path_segment(
2213 ) -> Result<String, ResolutionFailure<'static>> {
2214 let mut stripped_segment = String::new();
2215 let mut param_depth = 0;
2217 let mut latest_generics_chunk = String::new();
2222 latest_generics_chunk.clear();
2223 } else if c == '>' {
2225 if latest_generics_chunk.contains(" as ") {
2226 // The segment tries to use fully-qualified syntax, which is currently unsupported.
2227 // Give a helpful error message instead of completely ignoring the angle brackets.
2228 return Err(ResolutionFailure::MalformedGenerics(
2229 MalformedGenerics::HasFullyQualifiedSyntax,
2233 if param_depth == 0 {
2234 stripped_segment.push(c);
2236 latest_generics_chunk.push(c);
2241 if param_depth == 0 {
2242 Ok(stripped_segment)
2244 // The segment has unbalanced angle brackets, e.g. `Vec<T` or `Vec<T>>`
2245 Err(ResolutionFailure::MalformedGenerics(MalformedGenerics::UnbalancedAngleBrackets))