1 //! This module implements [RFC 1946]: Intra-rustdoc-links
3 //! [RFC 1946]: https://github.com/rust-lang/rfcs/blob/master/text/1946-intra-rustdoc-links.md
6 use rustc_data_structures::{fx::FxHashMap, stable_set::FxHashSet};
7 use rustc_errors::{Applicability, DiagnosticBuilder};
8 use rustc_expand::base::SyntaxExtensionKind;
15 use rustc_hir::def_id::{CrateNum, DefId};
16 use rustc_middle::ty::TyCtxt;
17 use rustc_middle::{bug, ty};
18 use rustc_resolve::ParentScope;
19 use rustc_session::lint::Lint;
20 use rustc_span::hygiene::{MacroKind, SyntaxContext};
21 use rustc_span::symbol::{sym, Ident, Symbol};
22 use rustc_span::DUMMY_SP;
23 use smallvec::{smallvec, SmallVec};
25 use pulldown_cmark::LinkType;
29 use std::convert::{TryFrom, TryInto};
33 use crate::clean::{self, utils::find_nearest_parent_module, Crate, Item, ItemLink, PrimitiveType};
34 use crate::core::DocContext;
35 use crate::fold::DocFolder;
36 use crate::html::markdown::{markdown_links, MarkdownLink};
37 use crate::lint::{BROKEN_INTRA_DOC_LINKS, PRIVATE_INTRA_DOC_LINKS};
38 use crate::passes::Pass;
40 use super::span_of_attrs;
42 crate const COLLECT_INTRA_DOC_LINKS: Pass = Pass {
43 name: "collect-intra-doc-links",
44 run: collect_intra_doc_links,
45 description: "resolves intra-doc links",
48 crate fn collect_intra_doc_links(krate: Crate, cx: &mut DocContext<'_>) -> Crate {
52 kind_side_channel: Cell::new(None),
53 visited_links: FxHashMap::default(),
58 /// Top-level errors emitted by this pass.
60 Resolve(Box<ResolutionFailure<'a>>),
61 AnchorFailure(AnchorFailure),
64 impl<'a> From<ResolutionFailure<'a>> for ErrorKind<'a> {
65 fn from(err: ResolutionFailure<'a>) -> Self {
66 ErrorKind::Resolve(box err)
70 #[derive(Copy, Clone, Debug, Hash)]
73 Primitive(PrimitiveType),
76 type ResolveRes = rustc_hir::def::Res<rustc_ast::NodeId>;
79 fn descr(self) -> &'static str {
81 Res::Def(kind, id) => ResolveRes::Def(kind, id).descr(),
82 Res::Primitive(_) => "builtin type",
86 fn article(self) -> &'static str {
88 Res::Def(kind, id) => ResolveRes::Def(kind, id).article(),
89 Res::Primitive(_) => "a",
93 fn name(self, tcx: TyCtxt<'_>) -> String {
95 Res::Def(_, id) => tcx.item_name(id).to_string(),
96 Res::Primitive(prim) => prim.as_str().to_string(),
100 fn def_id(self) -> DefId {
101 self.opt_def_id().expect("called def_id() on a primitive")
104 fn opt_def_id(self) -> Option<DefId> {
106 Res::Def(_, id) => Some(id),
107 Res::Primitive(_) => None,
111 fn as_hir_res(self) -> Option<rustc_hir::def::Res> {
113 Res::Def(kind, id) => Some(rustc_hir::def::Res::Def(kind, id)),
114 // FIXME: maybe this should handle the subset of PrimitiveType that fits into hir::PrimTy?
115 Res::Primitive(_) => None,
120 impl TryFrom<ResolveRes> for Res {
123 fn try_from(res: ResolveRes) -> Result<Self, ()> {
124 use rustc_hir::def::Res::*;
126 Def(kind, id) => Ok(Res::Def(kind, id)),
127 PrimTy(prim) => Ok(Res::Primitive(PrimitiveType::from_hir(prim))),
129 NonMacroAttr(..) | Err => Result::Err(()),
130 other => bug!("unrecognized res {:?}", other),
135 /// A link failed to resolve.
137 enum ResolutionFailure<'a> {
138 /// This resolved, but with the wrong namespace.
140 /// What the link resolved to.
142 /// The expected namespace for the resolution, determined from the link's disambiguator.
144 /// E.g., for `[fn@Result]` this is [`Namespace::ValueNS`],
145 /// even though `Result`'s actual namespace is [`Namespace::TypeNS`].
146 expected_ns: Namespace,
148 /// The link failed to resolve. [`resolution_failure`] should look to see if there's
149 /// a more helpful error that can be given.
151 /// The scope the link was resolved in.
153 /// If part of the link resolved, this has the `Res`.
155 /// In `[std::io::Error::x]`, `std::io::Error` would be a partial resolution.
156 partial_res: Option<Res>,
157 /// The remaining unresolved path segments.
159 /// In `[std::io::Error::x]`, `x` would be unresolved.
160 unresolved: Cow<'a, str>,
162 /// This happens when rustdoc can't determine the parent scope for an item.
163 /// It is always a bug in rustdoc.
165 /// This link has malformed generic parameters; e.g., the angle brackets are unbalanced.
166 MalformedGenerics(MalformedGenerics),
167 /// Used to communicate that this should be ignored, but shouldn't be reported to the user.
169 /// This happens when there is no disambiguator and one of the namespaces
170 /// failed to resolve.
175 enum MalformedGenerics {
176 /// This link has unbalanced angle brackets.
178 /// For example, `Vec<T` should trigger this, as should `Vec<T>>`.
179 UnbalancedAngleBrackets,
180 /// The generics are not attached to a type.
182 /// For example, `<T>` should trigger this.
184 /// This is detected by checking if the path is empty after the generics are stripped.
186 /// The link uses fully-qualified syntax, which is currently unsupported.
188 /// For example, `<Vec as IntoIterator>::into_iter` should trigger this.
190 /// This is detected by checking if ` as ` (the keyword `as` with spaces around it) is inside
192 HasFullyQualifiedSyntax,
193 /// The link has an invalid path separator.
195 /// For example, `Vec:<T>:new()` should trigger this. Note that `Vec:new()` will **not**
196 /// trigger this because it has no generics and thus [`strip_generics_from_path`] will not be
199 /// Note that this will also **not** be triggered if the invalid path separator is inside angle
200 /// brackets because rustdoc mostly ignores what's inside angle brackets (except for
201 /// [`HasFullyQualifiedSyntax`](MalformedGenerics::HasFullyQualifiedSyntax)).
203 /// This is detected by checking if there is a colon followed by a non-colon in the link.
204 InvalidPathSeparator,
205 /// The link has too many angle brackets.
207 /// For example, `Vec<<T>>` should trigger this.
208 TooManyAngleBrackets,
209 /// The link has empty angle brackets.
211 /// For example, `Vec<>` should trigger this.
215 impl ResolutionFailure<'a> {
216 /// This resolved fully (not just partially) but is erroneous for some other reason
218 /// Returns the full resolution of the link, if present.
219 fn full_res(&self) -> Option<Res> {
221 Self::WrongNamespace { res, expected_ns: _ } => Some(*res),
228 /// User error: `[std#x#y]` is not valid
230 /// The anchor provided by the user conflicts with Rustdoc's generated anchor.
232 /// This is an unfortunate state of affairs. Not every item that can be
233 /// linked to has its own page; sometimes it is a subheading within a page,
234 /// like for associated items. In those cases, rustdoc uses an anchor to
235 /// link to the subheading. Since you can't have two anchors for the same
236 /// link, Rustdoc disallows having a user-specified anchor.
238 /// Most of the time this is fine, because you can just link to the page of
239 /// the item if you want to provide your own anchor. For primitives, though,
240 /// rustdoc uses the anchor as a side channel to know which page to link to;
241 /// it doesn't show up in the generated link. Ideally, rustdoc would remove
242 /// this limitation, allowing you to link to subheaders on primitives.
243 RustdocAnchorConflict(Res),
246 #[derive(Clone, Debug, Hash, PartialEq, Eq)]
247 struct ResolutionInfo {
249 dis: Option<Disambiguator>,
251 extra_fragment: Option<String>,
255 struct DiagnosticInfo<'a> {
259 link_range: Range<usize>,
262 #[derive(Clone, Debug, Hash)]
264 pub res: (Res, Option<String>),
265 pub side_channel: Option<(DefKind, DefId)>,
268 struct LinkCollector<'a, 'tcx> {
269 cx: &'a mut DocContext<'tcx>,
270 /// A stack of modules used to decide what scope to resolve in.
272 /// The last module will be used if the parent scope of the current item is
275 /// This is used to store the kind of associated items,
276 /// because `clean` and the disambiguator code expect them to be different.
277 /// See the code for associated items on inherent impls for details.
278 kind_side_channel: Cell<Option<(DefKind, DefId)>>,
279 /// Cache the resolved links so we can avoid resolving (and emitting errors for) the same link.
280 /// The link will be `None` if it could not be resolved (i.e. the error was cached).
281 visited_links: FxHashMap<ResolutionInfo, Option<CachedLink>>,
284 impl<'a, 'tcx> LinkCollector<'a, 'tcx> {
285 /// Given a full link, parse it as an [enum struct variant].
287 /// In particular, this will return an error whenever there aren't three
288 /// full path segments left in the link.
290 /// [enum struct variant]: hir::VariantData::Struct
293 path_str: &'path str,
295 ) -> Result<(Res, Option<String>), ErrorKind<'path>> {
296 let tcx = self.cx.tcx;
297 let no_res = || ResolutionFailure::NotResolved {
300 unresolved: path_str.into(),
303 debug!("looking for enum variant {}", path_str);
304 let mut split = path_str.rsplitn(3, "::");
305 let (variant_field_str, variant_field_name) = split
307 .map(|f| (f, Symbol::intern(f)))
308 .expect("fold_item should ensure link is non-empty");
309 let (variant_str, variant_name) =
310 // we're not sure this is a variant at all, so use the full string
311 // If there's no second component, the link looks like `[path]`.
312 // So there's no partial res and we should say the whole link failed to resolve.
313 split.next().map(|f| (f, Symbol::intern(f))).ok_or_else(no_res)?;
316 .map(|f| f.to_owned())
317 // If there's no third component, we saw `[a::b]` before and it failed to resolve.
318 // So there's no partial res.
319 .ok_or_else(no_res)?;
322 .enter_resolver(|resolver| {
323 resolver.resolve_str_path_error(DUMMY_SP, &path, TypeNS, module_id)
325 .and_then(|(_, res)| res.try_into())
326 .map_err(|()| no_res())?;
329 Res::Def(DefKind::Enum, did) => {
333 .flat_map(|imp| tcx.associated_items(*imp).in_definition_order())
334 .any(|item| item.ident.name == variant_name)
336 // This is just to let `fold_item` know that this shouldn't be considered;
337 // it's a bug for the error to make it to the user
338 return Err(ResolutionFailure::Dummy.into());
340 match tcx.type_of(did).kind() {
341 ty::Adt(def, _) if def.is_enum() => {
342 if def.all_fields().any(|item| item.ident.name == variant_field_name) {
346 "variant.{}.field.{}",
347 variant_str, variant_field_name
351 Err(ResolutionFailure::NotResolved {
353 partial_res: Some(Res::Def(DefKind::Enum, def.did)),
354 unresolved: variant_field_str.into(),
362 _ => Err(ResolutionFailure::NotResolved {
364 partial_res: Some(ty_res),
365 unresolved: variant_str.into(),
371 /// Given a primitive type, try to resolve an associated item.
372 fn resolve_primitive_associated_item(
374 prim_ty: PrimitiveType,
377 ) -> Option<(Res, String, Option<(DefKind, DefId)>)> {
378 let tcx = self.cx.tcx;
380 prim_ty.impls(tcx).into_iter().find_map(|&impl_| {
381 tcx.associated_items(impl_)
382 .find_by_name_and_namespace(tcx, Ident::with_dummy_span(item_name), ns, impl_)
384 let kind = item.kind;
385 let out = match kind {
386 ty::AssocKind::Fn => "method",
387 ty::AssocKind::Const => "associatedconstant",
388 ty::AssocKind::Type => "associatedtype",
390 let fragment = format!("{}#{}.{}", prim_ty.as_str(), out, item_name);
391 (Res::Primitive(prim_ty), fragment, Some((kind.as_def_kind(), item.def_id)))
396 /// Resolves a string as a macro.
398 /// FIXME(jynelson): Can this be unified with `resolve()`?
403 ) -> Result<Res, ResolutionFailure<'a>> {
404 let path = ast::Path::from_ident(Ident::from_str(path_str));
405 self.cx.enter_resolver(|resolver| {
406 // FIXME(jynelson): does this really need 3 separate lookups?
407 if let Ok((Some(ext), res)) = resolver.resolve_macro_path(
410 &ParentScope::module(resolver.graph_root(), resolver),
414 if let SyntaxExtensionKind::LegacyBang { .. } = ext.kind {
415 return Ok(res.try_into().unwrap());
418 if let Some(&res) = resolver.all_macros().get(&Symbol::intern(path_str)) {
419 return Ok(res.try_into().unwrap());
421 debug!("resolving {} as a macro in the module {:?}", path_str, module_id);
422 if let Ok((_, res)) =
423 resolver.resolve_str_path_error(DUMMY_SP, path_str, MacroNS, module_id)
425 // don't resolve builtins like `#[derive]`
426 if let Ok(res) = res.try_into() {
430 Err(ResolutionFailure::NotResolved {
433 unresolved: path_str.into(),
438 /// Convenience wrapper around `resolve_str_path_error`.
440 /// This also handles resolving `true` and `false` as booleans.
441 /// NOTE: `resolve_str_path_error` knows only about paths, not about types.
442 /// Associated items will never be resolved by this function.
443 fn resolve_path(&self, path_str: &str, ns: Namespace, module_id: DefId) -> Option<Res> {
444 let result = self.cx.enter_resolver(|resolver| {
446 .resolve_str_path_error(DUMMY_SP, &path_str, ns, module_id)
447 .and_then(|(_, res)| res.try_into())
449 debug!("{} resolved to {:?} in namespace {:?}", path_str, result, ns);
451 // resolver doesn't know about true, false, and types that aren't paths (e.g. `()`)
453 Err(()) => resolve_primitive(path_str, ns),
454 Ok(res) => Some(res),
458 /// Resolves a string as a path within a particular namespace. Returns an
459 /// optional URL fragment in the case of variants and methods.
462 path_str: &'path str,
465 extra_fragment: &Option<String>,
466 ) -> Result<(Res, Option<String>), ErrorKind<'path>> {
467 if let Some(res) = self.resolve_path(path_str, ns, module_id) {
469 // FIXME(#76467): make this fallthrough to lookup the associated
470 // item a separate function.
471 Res::Def(DefKind::AssocFn | DefKind::AssocConst, _) => assert_eq!(ns, ValueNS),
472 Res::Def(DefKind::AssocTy, _) => assert_eq!(ns, TypeNS),
473 Res::Def(DefKind::Variant, _) => {
474 return handle_variant(self.cx, res, extra_fragment);
476 // Not a trait item; just return what we found.
477 Res::Primitive(ty) => {
478 if extra_fragment.is_some() {
479 return Err(ErrorKind::AnchorFailure(
480 AnchorFailure::RustdocAnchorConflict(res),
483 return Ok((res, Some(ty.as_str().to_owned())));
485 _ => return Ok((res, extra_fragment.clone())),
489 // Try looking for methods and associated items.
490 let mut split = path_str.rsplitn(2, "::");
491 // NB: `split`'s first element is always defined, even if the delimiter was not present.
492 // NB: `item_str` could be empty when resolving in the root namespace (e.g. `::std`).
493 let item_str = split.next().unwrap();
494 let item_name = Symbol::intern(item_str);
495 let path_root = split
497 .map(|f| f.to_owned())
498 // If there's no `::`, it's not an associated item.
499 // So we can be sure that `rustc_resolve` was accurate when it said it wasn't resolved.
501 debug!("found no `::`, assumming {} was correctly not in scope", item_name);
502 ResolutionFailure::NotResolved {
505 unresolved: item_str.into(),
509 // FIXME(#83862): this arbitrarily gives precedence to primitives over modules to support
510 // links to primitives when `#[doc(primitive)]` is present. It should give an ambiguity
511 // error instead and special case *only* modules with `#[doc(primitive)]`, not all
513 resolve_primitive(&path_root, TypeNS)
514 .or_else(|| self.resolve_path(&path_root, TypeNS, module_id))
516 let (res, fragment, side_channel) =
517 self.resolve_associated_item(ty_res, item_name, ns, module_id)?;
518 let result = if extra_fragment.is_some() {
519 let diag_res = side_channel.map_or(res, |(k, r)| Res::Def(k, r));
520 Err(ErrorKind::AnchorFailure(AnchorFailure::RustdocAnchorConflict(diag_res)))
522 // HACK(jynelson): `clean` expects the type, not the associated item
523 // but the disambiguator logic expects the associated item.
524 // Store the kind in a side channel so that only the disambiguator logic looks at it.
525 if let Some((kind, id)) = side_channel {
526 self.kind_side_channel.set(Some((kind, id)));
528 Ok((res, Some(fragment)))
533 if ns == Namespace::ValueNS {
534 self.variant_field(path_str, module_id)
536 Err(ResolutionFailure::NotResolved {
539 unresolved: path_root.into(),
547 /// - None if no associated item was found
548 /// - Some((_, _, Some(_))) if an item was found and should go through a side channel
549 /// - Some((_, _, None)) otherwise
550 fn resolve_associated_item(
556 ) -> Option<(Res, String, Option<(DefKind, DefId)>)> {
557 let tcx = self.cx.tcx;
560 Res::Primitive(prim) => self.resolve_primitive_associated_item(prim, ns, item_name),
566 | DefKind::ForeignTy,
569 debug!("looking for associated item named {} for item {:?}", item_name, did);
570 // Checks if item_name belongs to `impl SomeItem`
575 tcx.associated_items(imp).find_by_name_and_namespace(
577 Ident::with_dummy_span(item_name),
582 .map(|item| (item.kind, item.def_id))
583 // There should only ever be one associated item that matches from any inherent impl
585 // Check if item_name belongs to `impl SomeTrait for SomeItem`
586 // FIXME(#74563): This gives precedence to `impl SomeItem`:
587 // Although having both would be ambiguous, use impl version for compatibility's sake.
588 // To handle that properly resolve() would have to support
589 // something like [`ambi_fn`](<SomeStruct as SomeTrait>::ambi_fn)
592 resolve_associated_trait_item(did, module_id, item_name, ns, self.cx);
593 debug!("got associated item kind {:?}", kind);
597 if let Some((kind, id)) = assoc_item {
598 let out = match kind {
599 ty::AssocKind::Fn => "method",
600 ty::AssocKind::Const => "associatedconstant",
601 ty::AssocKind::Type => "associatedtype",
603 // HACK(jynelson): `clean` expects the type, not the associated item
604 // but the disambiguator logic expects the associated item.
605 // Store the kind in a side channel so that only the disambiguator logic looks at it.
608 format!("{}.{}", out, item_name),
609 Some((kind.as_def_kind(), id)),
613 if ns != Namespace::ValueNS {
616 debug!("looking for variants or fields named {} for {:?}", item_name, did);
617 // FIXME: this doesn't really belong in `associated_item` (maybe `variant_field` is better?)
618 // NOTE: it's different from variant_field because it resolves fields and variants,
619 // not variant fields (2 path segments, not 3).
620 let def = match tcx.type_of(did).kind() {
621 ty::Adt(def, _) => def,
624 let field = if def.is_enum() {
625 def.all_fields().find(|item| item.ident.name == item_name)
627 def.non_enum_variant().fields.iter().find(|item| item.ident.name == item_name)
629 let kind = if def.is_enum() { DefKind::Variant } else { DefKind::Field };
634 if def.is_enum() { "variant" } else { "structfield" },
637 Some((kind, field.did)),
640 Res::Def(DefKind::Trait, did) => tcx
641 .associated_items(did)
642 .find_by_name_and_namespace(tcx, Ident::with_dummy_span(item_name), ns, did)
644 let kind = match item.kind {
645 ty::AssocKind::Const => "associatedconstant",
646 ty::AssocKind::Type => "associatedtype",
647 ty::AssocKind::Fn => {
648 if item.defaultness.has_value() {
656 let res = Res::Def(item.kind.as_def_kind(), item.def_id);
657 (res, format!("{}.{}", kind, item_name), None)
663 /// Used for reporting better errors.
665 /// Returns whether the link resolved 'fully' in another namespace.
666 /// 'fully' here means that all parts of the link resolved, not just some path segments.
667 /// This returns the `Res` even if it was erroneous for some reason
668 /// (such as having invalid URL fragments or being in the wrong namespace).
674 extra_fragment: &Option<String>,
676 // resolve() can't be used for macro namespace
677 let result = match ns {
678 Namespace::MacroNS => self.resolve_macro(path_str, module_id).map_err(ErrorKind::from),
679 Namespace::TypeNS | Namespace::ValueNS => {
680 self.resolve(path_str, ns, module_id, extra_fragment).map(|(res, _)| res)
684 let res = match result {
685 Ok(res) => Some(res),
686 Err(ErrorKind::Resolve(box kind)) => kind.full_res(),
687 Err(ErrorKind::AnchorFailure(AnchorFailure::RustdocAnchorConflict(res))) => Some(res),
688 Err(ErrorKind::AnchorFailure(AnchorFailure::MultipleAnchors)) => None,
690 self.kind_side_channel.take().map(|(kind, id)| Res::Def(kind, id)).or(res)
694 /// Look to see if a resolved item has an associated item named `item_name`.
696 /// Given `[std::io::Error::source]`, where `source` is unresolved, this would
697 /// find `std::error::Error::source` and return
698 /// `<io::Error as error::Error>::source`.
699 fn resolve_associated_trait_item(
704 cx: &mut DocContext<'_>,
705 ) -> Option<(ty::AssocKind, DefId)> {
706 // FIXME: this should also consider blanket impls (`impl<T> X for T`). Unfortunately
707 // `get_auto_trait_and_blanket_impls` is broken because the caching behavior is wrong. In the
708 // meantime, just don't look for these blanket impls.
710 // Next consider explicit impls: `impl MyTrait for MyType`
711 // Give precedence to inherent impls.
712 let traits = traits_implemented_by(cx, did, module);
713 debug!("considering traits {:?}", traits);
714 let mut candidates = traits.iter().filter_map(|&trait_| {
716 .associated_items(trait_)
717 .find_by_name_and_namespace(cx.tcx, Ident::with_dummy_span(item_name), ns, trait_)
718 .map(|assoc| (assoc.kind, assoc.def_id))
720 // FIXME(#74563): warn about ambiguity
721 debug!("the candidates were {:?}", candidates.clone().collect::<Vec<_>>());
725 /// Given a type, return all traits in scope in `module` implemented by that type.
727 /// NOTE: this cannot be a query because more traits could be available when more crates are compiled!
728 /// So it is not stable to serialize cross-crate.
729 fn traits_implemented_by(cx: &mut DocContext<'_>, type_: DefId, module: DefId) -> FxHashSet<DefId> {
730 let mut resolver = cx.resolver.borrow_mut();
731 let in_scope_traits = cx.module_trait_cache.entry(module).or_insert_with(|| {
732 resolver.access(|resolver| {
733 let parent_scope = &ParentScope::module(resolver.get_module(module), resolver);
735 .traits_in_scope(None, parent_scope, SyntaxContext::root(), None)
737 .map(|candidate| candidate.def_id)
743 let ty = tcx.type_of(type_);
744 let iter = in_scope_traits.iter().flat_map(|&trait_| {
745 trace!("considering explicit impl for trait {:?}", trait_);
747 // Look at each trait implementation to see if it's an impl for `did`
748 tcx.find_map_relevant_impl(trait_, ty, |impl_| {
749 let trait_ref = tcx.impl_trait_ref(impl_).expect("this is not an inherent impl");
750 // Check if these are the same type.
751 let impl_type = trait_ref.self_ty();
753 "comparing type {} with kind {:?} against type {:?}",
758 // Fast path: if this is a primitive simple `==` will work
759 let saw_impl = impl_type == ty
760 || match impl_type.kind() {
761 // Check if these are the same def_id
763 debug!("adt def_id: {:?}", def.did);
766 ty::Foreign(def_id) => *def_id == type_,
770 if saw_impl { Some(trait_) } else { None }
776 /// Check for resolve collisions between a trait and its derive.
778 /// These are common and we should just resolve to the trait in that case.
779 fn is_derive_trait_collision<T>(ns: &PerNS<Result<(Res, T), ResolutionFailure<'_>>>) -> bool {
783 type_ns: Ok((Res::Def(DefKind::Trait, _), _)),
784 macro_ns: Ok((Res::Def(DefKind::Macro(MacroKind::Derive), _), _)),
790 impl<'a, 'tcx> DocFolder for LinkCollector<'a, 'tcx> {
791 fn fold_item(&mut self, item: Item) -> Option<Item> {
792 use rustc_middle::ty::DefIdTree;
794 let parent_node = if item.is_fake() {
797 find_nearest_parent_module(self.cx.tcx, item.def_id)
800 if parent_node.is_some() {
801 trace!("got parent node for {:?} {:?}, id {:?}", item.type_(), item.name, item.def_id);
804 // find item's parent to resolve `Self` in item's docs below
805 debug!("looking for the `Self` type");
806 let self_id = if item.is_fake() {
808 // Checking if the item is a field in an enum variant
809 } else if (matches!(self.cx.tcx.def_kind(item.def_id), DefKind::Field)
811 self.cx.tcx.def_kind(self.cx.tcx.parent(item.def_id).unwrap()),
815 self.cx.tcx.parent(item.def_id).and_then(|item_id| self.cx.tcx.parent(item_id))
817 self.cx.tcx.def_kind(item.def_id),
824 self.cx.tcx.parent(item.def_id)
825 // HACK(jynelson): `clean` marks associated types as `TypedefItem`, not as `AssocTypeItem`.
826 // Fixing this breaks `fn render_deref_methods`.
827 // As a workaround, see if the parent of the item is an `impl`; if so this must be an associated item,
828 // regardless of what rustdoc wants to call it.
829 } else if let Some(parent) = self.cx.tcx.parent(item.def_id) {
830 let parent_kind = self.cx.tcx.def_kind(parent);
831 Some(if parent_kind == DefKind::Impl { parent } else { item.def_id })
836 // FIXME(jynelson): this shouldn't go through stringification, rustdoc should just use the DefId directly
837 let self_name = self_id.and_then(|self_id| {
838 if matches!(self.cx.tcx.def_kind(self_id), DefKind::Impl) {
839 // using `ty.to_string()` (or any variant) has issues with raw idents
840 let ty = self.cx.tcx.type_of(self_id);
841 let name = match ty.kind() {
842 ty::Adt(def, _) => Some(self.cx.tcx.item_name(def.did).to_string()),
843 other if other.is_primitive() => Some(ty.to_string()),
846 debug!("using type_of(): {:?}", name);
849 let name = self.cx.tcx.opt_item_name(self_id).map(|sym| sym.to_string());
850 debug!("using item_name(): {:?}", name);
855 if item.is_mod() && item.attrs.inner_docs {
856 self.mod_ids.push(item.def_id);
859 // We want to resolve in the lexical scope of the documentation.
860 // In the presence of re-exports, this is not the same as the module of the item.
861 // Rather than merging all documentation into one, resolve it one attribute at a time
862 // so we know which module it came from.
863 for (parent_module, doc) in item.attrs.collapsed_doc_value_by_module_level() {
864 debug!("combined_docs={}", doc);
866 let (krate, parent_node) = if let Some(id) = parent_module {
869 (item.def_id.krate, parent_node)
871 // NOTE: if there are links that start in one crate and end in another, this will not resolve them.
872 // This is a degenerate case and it's not supported by rustdoc.
873 for md_link in markdown_links(&doc) {
874 let link = self.resolve_link(&item, &doc, &self_name, parent_node, krate, md_link);
875 if let Some(link) = link {
876 self.cx.cache.intra_doc_links.entry(item.def_id).or_default().push(link);
881 Some(if item.is_mod() {
882 if !item.attrs.inner_docs {
883 self.mod_ids.push(item.def_id);
886 let ret = self.fold_item_recur(item);
890 self.fold_item_recur(item)
895 impl LinkCollector<'_, '_> {
896 /// This is the entry point for resolving an intra-doc link.
898 /// FIXME(jynelson): this is way too many arguments
903 self_name: &Option<String>,
904 parent_node: Option<DefId>,
906 ori_link: MarkdownLink,
907 ) -> Option<ItemLink> {
908 trace!("considering link '{}'", ori_link.link);
910 // Bail early for real links.
911 if ori_link.link.contains('/') {
915 // [] is mostly likely not supposed to be a link
916 if ori_link.link.is_empty() {
920 let diag_info = DiagnosticInfo {
923 ori_link: &ori_link.link,
924 link_range: ori_link.range.clone(),
927 let link = ori_link.link.replace("`", "");
928 let no_backticks_range = range_between_backticks(&ori_link);
929 let parts = link.split('#').collect::<Vec<_>>();
930 let (link, extra_fragment) = if parts.len() > 2 {
931 // A valid link can't have multiple #'s
932 anchor_failure(self.cx, diag_info, AnchorFailure::MultipleAnchors);
934 } else if parts.len() == 2 {
935 if parts[0].trim().is_empty() {
936 // This is an anchor to an element of the current page, nothing to do in here!
939 (parts[0], Some(parts[1].to_owned()))
944 // Parse and strip the disambiguator from the link, if present.
945 let (mut path_str, disambiguator) = match Disambiguator::from_str(&link) {
946 Ok(Some((d, path))) => (path.trim(), Some(d)),
947 Ok(None) => (link.trim(), None),
948 Err((err_msg, relative_range)) => {
949 if !should_ignore_link_with_disambiguators(link) {
950 // Only report error if we would not have ignored this link.
952 let disambiguator_range = (no_backticks_range.start + relative_range.start)
953 ..(no_backticks_range.start + relative_range.end);
954 disambiguator_error(self.cx, diag_info, disambiguator_range, &err_msg);
960 if should_ignore_link(path_str) {
964 // We stripped `()` and `!` when parsing the disambiguator.
965 // Add them back to be displayed, but not prefix disambiguators.
967 disambiguator.map(|d| d.display_for(path_str)).unwrap_or_else(|| path_str.to_owned());
969 // In order to correctly resolve intra-doc links we need to
970 // pick a base AST node to work from. If the documentation for
971 // this module came from an inner comment (//!) then we anchor
972 // our name resolution *inside* the module. If, on the other
973 // hand it was an outer comment (///) then we anchor the name
974 // resolution in the parent module on the basis that the names
975 // used are more likely to be intended to be parent names. For
976 // this, we set base_node to None for inner comments since
977 // we've already pushed this node onto the resolution stack but
978 // for outer comments we explicitly try and resolve against the
979 // parent_node first.
980 let base_node = if item.is_mod() && item.attrs.inner_docs {
981 self.mod_ids.last().copied()
986 let mut module_id = if let Some(id) = base_node {
990 debug!("attempting to resolve item without parent module: {}", path_str);
996 smallvec![ResolutionFailure::NoParentItem],
1002 // replace `Self` with suitable item's parent name
1003 let is_lone_self = path_str == "Self";
1004 let is_lone_crate = path_str == "crate";
1005 if path_str.starts_with("Self::") || is_lone_self {
1006 if let Some(ref name) = self_name {
1010 resolved_self = format!("{}::{}", name, &path_str[6..]);
1011 path_str = &resolved_self;
1014 } else if path_str.starts_with("crate::") || is_lone_crate {
1015 use rustc_span::def_id::CRATE_DEF_INDEX;
1017 // HACK(jynelson): rustc_resolve thinks that `crate` is the crate currently being documented.
1018 // But rustdoc wants it to mean the crate this item was originally present in.
1019 // To work around this, remove it and resolve relative to the crate root instead.
1020 // HACK(jynelson)(2): If we just strip `crate::` then suddenly primitives become ambiguous
1021 // (consider `crate::char`). Instead, change it to `self::`. This works because 'self' is now the crate root.
1022 // FIXME(#78696): This doesn't always work.
1026 resolved_self = format!("self::{}", &path_str["crate::".len()..]);
1027 path_str = &resolved_self;
1029 module_id = DefId { krate, index: CRATE_DEF_INDEX };
1032 // Strip generics from the path.
1033 let stripped_path_string;
1034 if path_str.contains(['<', '>'].as_slice()) {
1035 stripped_path_string = match strip_generics_from_path(path_str) {
1038 debug!("link has malformed generics: {}", path_str);
1044 smallvec![err_kind],
1049 path_str = &stripped_path_string;
1051 // Sanity check to make sure we don't have any angle brackets after stripping generics.
1052 assert!(!path_str.contains(['<', '>'].as_slice()));
1054 // The link is not an intra-doc link if it still contains spaces after stripping generics.
1055 if path_str.contains(' ') {
1059 let (mut res, mut fragment) = self.resolve_with_disambiguator_cached(
1063 path_str: path_str.to_owned(),
1066 diag_info.clone(), // this struct should really be Copy, but Range is not :(
1067 matches!(ori_link.kind, LinkType::Reference | LinkType::Shortcut),
1070 // Check for a primitive which might conflict with a module
1071 // Report the ambiguity and require that the user specify which one they meant.
1072 // FIXME: could there ever be a primitive not in the type namespace?
1075 None | Some(Disambiguator::Namespace(Namespace::TypeNS) | Disambiguator::Primitive)
1076 ) && !matches!(res, Res::Primitive(_))
1078 if let Some(prim) = resolve_primitive(path_str, TypeNS) {
1080 if matches!(disambiguator, Some(Disambiguator::Primitive)) {
1081 if fragment.is_some() {
1085 AnchorFailure::RustdocAnchorConflict(prim),
1090 fragment = Some(prim.name(self.cx.tcx));
1092 // `[char]` when a `char` module is in scope
1093 let candidates = vec![res, prim];
1094 ambiguity_error(self.cx, diag_info, path_str, candidates);
1100 let report_mismatch = |specified: Disambiguator, resolved: Disambiguator| {
1101 // The resolved item did not match the disambiguator; give a better error than 'not found'
1102 let msg = format!("incompatible link kind for `{}`", path_str);
1103 let callback = |diag: &mut DiagnosticBuilder<'_>, sp| {
1105 "this link resolved to {} {}, which is not {} {}",
1108 specified.article(),
1112 suggest_disambiguator(resolved, diag, path_str, dox, sp, &ori_link.range);
1114 report_diagnostic(self.cx.tcx, BROKEN_INTRA_DOC_LINKS, &msg, &diag_info, callback);
1117 let verify = |kind: DefKind, id: DefId| {
1118 let (kind, id) = self.kind_side_channel.take().unwrap_or((kind, id));
1119 debug!("intra-doc link to {} resolved to {:?} (id: {:?})", path_str, res, id);
1121 // Disallow e.g. linking to enums with `struct@`
1122 debug!("saw kind {:?} with disambiguator {:?}", kind, disambiguator);
1123 match (kind, disambiguator) {
1124 | (DefKind::Const | DefKind::ConstParam | DefKind::AssocConst | DefKind::AnonConst, Some(Disambiguator::Kind(DefKind::Const)))
1125 // NOTE: this allows 'method' to mean both normal functions and associated functions
1126 // This can't cause ambiguity because both are in the same namespace.
1127 | (DefKind::Fn | DefKind::AssocFn, Some(Disambiguator::Kind(DefKind::Fn)))
1128 // These are namespaces; allow anything in the namespace to match
1129 | (_, Some(Disambiguator::Namespace(_)))
1130 // If no disambiguator given, allow anything
1132 // All of these are valid, so do nothing
1134 (actual, Some(Disambiguator::Kind(expected))) if actual == expected => {}
1135 (_, Some(specified @ Disambiguator::Kind(_) | specified @ Disambiguator::Primitive)) => {
1136 report_mismatch(specified, Disambiguator::Kind(kind));
1141 // item can be non-local e.g. when using #[doc(primitive = "pointer")]
1142 if let Some((src_id, dst_id)) = id
1144 .and_then(|dst_id| item.def_id.as_local().map(|src_id| (src_id, dst_id)))
1146 use rustc_hir::def_id::LOCAL_CRATE;
1148 let hir_src = self.cx.tcx.hir().local_def_id_to_hir_id(src_id);
1149 let hir_dst = self.cx.tcx.hir().local_def_id_to_hir_id(dst_id);
1151 if self.cx.tcx.privacy_access_levels(LOCAL_CRATE).is_exported(hir_src)
1152 && !self.cx.tcx.privacy_access_levels(LOCAL_CRATE).is_exported(hir_dst)
1154 privacy_error(self.cx, &diag_info, &path_str);
1162 Res::Primitive(prim) => {
1163 if let Some((kind, id)) = self.kind_side_channel.take() {
1164 // We're actually resolving an associated item of a primitive, so we need to
1165 // verify the disambiguator (if any) matches the type of the associated item.
1166 // This case should really follow the same flow as the `Res::Def` branch below,
1167 // but attempting to add a call to `clean::register_res` causes an ICE. @jyn514
1168 // thinks `register_res` is only needed for cross-crate re-exports, but Rust
1169 // doesn't allow statements like `use str::trim;`, making this a (hopefully)
1170 // valid omission. See https://github.com/rust-lang/rust/pull/80660#discussion_r551585677
1171 // for discussion on the matter.
1174 // FIXME: it would be nice to check that the feature gate was enabled in the original crate, not just ignore it altogether.
1175 // However I'm not sure how to check that across crates.
1176 if prim == PrimitiveType::RawPointer
1177 && item.def_id.is_local()
1178 && !self.cx.tcx.features().intra_doc_pointers
1180 let span = super::source_span_for_markdown_range(
1186 .unwrap_or_else(|| span_of_attrs(&item.attrs).unwrap_or(item.span.inner()));
1188 rustc_session::parse::feature_err(
1189 &self.cx.tcx.sess.parse_sess,
1190 sym::intra_doc_pointers,
1192 "linking to associated items of raw pointers is experimental",
1194 .note("rustdoc does not allow disambiguating between `*const` and `*mut`, and pointers are unstable until it does")
1198 match disambiguator {
1199 Some(Disambiguator::Primitive | Disambiguator::Namespace(_)) | None => {}
1201 report_mismatch(other, Disambiguator::Primitive);
1207 Some(ItemLink { link: ori_link.link, link_text, did: None, fragment })
1209 Res::Def(kind, id) => {
1211 let id = clean::register_res(self.cx, rustc_hir::def::Res::Def(kind, id));
1212 Some(ItemLink { link: ori_link.link, link_text, did: Some(id), fragment })
1217 fn resolve_with_disambiguator_cached(
1219 key: ResolutionInfo,
1220 diag: DiagnosticInfo<'_>,
1221 cache_resolution_failure: bool,
1222 ) -> Option<(Res, Option<String>)> {
1223 // Try to look up both the result and the corresponding side channel value
1224 if let Some(ref cached) = self.visited_links.get(&key) {
1227 self.kind_side_channel.set(cached.side_channel.clone());
1228 return Some(cached.res.clone());
1230 None if cache_resolution_failure => return None,
1232 // Although we hit the cache and found a resolution error, this link isn't
1233 // supposed to cache those. Run link resolution again to emit the expected
1234 // resolution error.
1239 let res = self.resolve_with_disambiguator(&key, diag);
1241 // Cache only if resolved successfully - don't silence duplicate errors
1242 if let Some(res) = res {
1243 // Store result for the actual namespace
1244 self.visited_links.insert(
1248 side_channel: self.kind_side_channel.clone().into_inner(),
1254 if cache_resolution_failure {
1255 // For reference-style links we only want to report one resolution error
1256 // so let's cache them as well.
1257 self.visited_links.insert(key, None);
1264 /// After parsing the disambiguator, resolve the main part of the link.
1265 // FIXME(jynelson): wow this is just so much
1266 fn resolve_with_disambiguator(
1268 key: &ResolutionInfo,
1269 diag: DiagnosticInfo<'_>,
1270 ) -> Option<(Res, Option<String>)> {
1271 let disambiguator = key.dis;
1272 let path_str = &key.path_str;
1273 let base_node = key.module_id;
1274 let extra_fragment = &key.extra_fragment;
1276 match disambiguator.map(Disambiguator::ns) {
1277 Some(expected_ns @ (ValueNS | TypeNS)) => {
1278 match self.resolve(path_str, expected_ns, base_node, extra_fragment) {
1279 Ok(res) => Some(res),
1280 Err(ErrorKind::Resolve(box mut kind)) => {
1281 // We only looked in one namespace. Try to give a better error if possible.
1282 if kind.full_res().is_none() {
1283 let other_ns = if expected_ns == ValueNS { TypeNS } else { ValueNS };
1284 // FIXME: really it should be `resolution_failure` that does this, not `resolve_with_disambiguator`
1285 // See https://github.com/rust-lang/rust/pull/76955#discussion_r493953382 for a good approach
1286 for &new_ns in &[other_ns, MacroNS] {
1288 self.check_full_res(new_ns, path_str, base_node, extra_fragment)
1290 kind = ResolutionFailure::WrongNamespace { res, expected_ns };
1295 resolution_failure(self, diag, path_str, disambiguator, smallvec![kind]);
1296 // This could just be a normal link or a broken link
1297 // we could potentially check if something is
1298 // "intra-doc-link-like" and warn in that case.
1301 Err(ErrorKind::AnchorFailure(msg)) => {
1302 anchor_failure(self.cx, diag, msg);
1309 let mut candidates = PerNS {
1311 .resolve_macro(path_str, base_node)
1312 .map(|res| (res, extra_fragment.clone())),
1313 type_ns: match self.resolve(path_str, TypeNS, base_node, extra_fragment) {
1315 debug!("got res in TypeNS: {:?}", res);
1318 Err(ErrorKind::AnchorFailure(msg)) => {
1319 anchor_failure(self.cx, diag, msg);
1322 Err(ErrorKind::Resolve(box kind)) => Err(kind),
1324 value_ns: match self.resolve(path_str, ValueNS, base_node, extra_fragment) {
1326 Err(ErrorKind::AnchorFailure(msg)) => {
1327 anchor_failure(self.cx, diag, msg);
1330 Err(ErrorKind::Resolve(box kind)) => Err(kind),
1332 .and_then(|(res, fragment)| {
1333 // Constructors are picked up in the type namespace.
1335 Res::Def(DefKind::Ctor(..), _) => {
1336 Err(ResolutionFailure::WrongNamespace { res, expected_ns: TypeNS })
1339 match (fragment, extra_fragment.clone()) {
1340 (Some(fragment), Some(_)) => {
1341 // Shouldn't happen but who knows?
1342 Ok((res, Some(fragment)))
1344 (fragment, None) | (None, fragment) => Ok((res, fragment)),
1351 let len = candidates.iter().filter(|res| res.is_ok()).count();
1359 candidates.into_iter().filter_map(|res| res.err()).collect(),
1361 // this could just be a normal link
1366 Some(candidates.into_iter().filter_map(|res| res.ok()).next().unwrap())
1367 } else if len == 2 && is_derive_trait_collision(&candidates) {
1368 Some(candidates.type_ns.unwrap())
1370 if is_derive_trait_collision(&candidates) {
1371 candidates.macro_ns = Err(ResolutionFailure::Dummy);
1373 // If we're reporting an ambiguity, don't mention the namespaces that failed
1374 let candidates = candidates.map(|candidate| candidate.ok().map(|(res, _)| res));
1375 ambiguity_error(self.cx, diag, path_str, candidates.present_items().collect());
1380 match self.resolve_macro(path_str, base_node) {
1381 Ok(res) => Some((res, extra_fragment.clone())),
1383 // `resolve_macro` only looks in the macro namespace. Try to give a better error if possible.
1384 for &ns in &[TypeNS, ValueNS] {
1386 self.check_full_res(ns, path_str, base_node, extra_fragment)
1389 ResolutionFailure::WrongNamespace { res, expected_ns: MacroNS };
1393 resolution_failure(self, diag, path_str, disambiguator, smallvec![kind]);
1402 /// Get the section of a link between the backticks,
1403 /// or the whole link if there aren't any backticks.
1411 fn range_between_backticks(ori_link: &MarkdownLink) -> Range<usize> {
1412 let after_first_backtick_group = ori_link.link.bytes().position(|b| b != b'`').unwrap_or(0);
1413 let before_second_backtick_group = ori_link
1416 .skip(after_first_backtick_group)
1417 .position(|b| b == b'`')
1418 .unwrap_or(ori_link.link.len());
1419 (ori_link.range.start + after_first_backtick_group)
1420 ..(ori_link.range.start + before_second_backtick_group)
1423 /// Returns true if we should ignore `link` due to it being unlikely
1424 /// that it is an intra-doc link. `link` should still have disambiguators
1425 /// if there were any.
1427 /// The difference between this and [`should_ignore_link()`] is that this
1428 /// check should only be used on links that still have disambiguators.
1429 fn should_ignore_link_with_disambiguators(link: &str) -> bool {
1430 link.contains(|ch: char| !(ch.is_alphanumeric() || ":_<>, !*&;@()".contains(ch)))
1433 /// Returns true if we should ignore `path_str` due to it being unlikely
1434 /// that it is an intra-doc link.
1435 fn should_ignore_link(path_str: &str) -> bool {
1436 path_str.contains(|ch: char| !(ch.is_alphanumeric() || ":_<>, !*&;".contains(ch)))
1439 #[derive(Copy, Clone, Debug, PartialEq, Eq, Hash)]
1440 /// Disambiguators for a link.
1441 crate enum Disambiguator {
1444 /// This is buggy, see <https://github.com/rust-lang/rust/pull/77875#discussion_r503583103>
1446 /// `struct@` or `f()`
1449 Namespace(Namespace),
1452 impl Disambiguator {
1453 /// The text that should be displayed when the path is rendered as HTML.
1455 /// NOTE: `path` is not the original link given by the user, but a name suitable for passing to `resolve`.
1456 fn display_for(&self, path: &str) -> String {
1458 // FIXME: this will have different output if the user had `m!()` originally.
1459 Self::Kind(DefKind::Macro(MacroKind::Bang)) => format!("{}!", path),
1460 Self::Kind(DefKind::Fn) => format!("{}()", path),
1461 _ => path.to_owned(),
1465 /// Given a link, parse and return `(disambiguator, path_str)`.
1467 /// This returns `Ok(Some(...))` if a disambiguator was found,
1468 /// `Ok(None)` if no disambiguator was found, or `Err(...)`
1469 /// if there was a problem with the disambiguator.
1470 crate fn from_str(link: &str) -> Result<Option<(Self, &str)>, (String, Range<usize>)> {
1471 use Disambiguator::{Kind, Namespace as NS, Primitive};
1473 if let Some(idx) = link.find('@') {
1474 let (prefix, rest) = link.split_at(idx);
1475 let d = match prefix {
1476 "struct" => Kind(DefKind::Struct),
1477 "enum" => Kind(DefKind::Enum),
1478 "trait" => Kind(DefKind::Trait),
1479 "union" => Kind(DefKind::Union),
1480 "module" | "mod" => Kind(DefKind::Mod),
1481 "const" | "constant" => Kind(DefKind::Const),
1482 "static" => Kind(DefKind::Static),
1483 "function" | "fn" | "method" => Kind(DefKind::Fn),
1484 "derive" => Kind(DefKind::Macro(MacroKind::Derive)),
1485 "type" => NS(Namespace::TypeNS),
1486 "value" => NS(Namespace::ValueNS),
1487 "macro" => NS(Namespace::MacroNS),
1488 "prim" | "primitive" => Primitive,
1489 _ => return Err((format!("unknown disambiguator `{}`", prefix), 0..idx)),
1491 Ok(Some((d, &rest[1..])))
1494 ("!()", DefKind::Macro(MacroKind::Bang)),
1495 ("()", DefKind::Fn),
1496 ("!", DefKind::Macro(MacroKind::Bang)),
1498 for &(suffix, kind) in &suffixes {
1499 if let Some(link) = link.strip_suffix(suffix) {
1500 // Avoid turning `!` or `()` into an empty string
1501 if !link.is_empty() {
1502 return Ok(Some((Kind(kind), link)));
1510 fn from_res(res: Res) -> Self {
1512 Res::Def(kind, _) => Disambiguator::Kind(kind),
1513 Res::Primitive(_) => Disambiguator::Primitive,
1517 /// Used for error reporting.
1518 fn suggestion(self) -> Suggestion {
1519 let kind = match self {
1520 Disambiguator::Primitive => return Suggestion::Prefix("prim"),
1521 Disambiguator::Kind(kind) => kind,
1522 Disambiguator::Namespace(_) => panic!("display_for cannot be used on namespaces"),
1524 if kind == DefKind::Macro(MacroKind::Bang) {
1525 return Suggestion::Macro;
1526 } else if kind == DefKind::Fn || kind == DefKind::AssocFn {
1527 return Suggestion::Function;
1530 let prefix = match kind {
1531 DefKind::Struct => "struct",
1532 DefKind::Enum => "enum",
1533 DefKind::Trait => "trait",
1534 DefKind::Union => "union",
1535 DefKind::Mod => "mod",
1536 DefKind::Const | DefKind::ConstParam | DefKind::AssocConst | DefKind::AnonConst => {
1539 DefKind::Static => "static",
1540 DefKind::Macro(MacroKind::Derive) => "derive",
1541 // Now handle things that don't have a specific disambiguator
1544 .expect("tried to calculate a disambiguator for a def without a namespace?")
1546 Namespace::TypeNS => "type",
1547 Namespace::ValueNS => "value",
1548 Namespace::MacroNS => "macro",
1552 Suggestion::Prefix(prefix)
1555 fn ns(self) -> Namespace {
1557 Self::Namespace(n) => n,
1559 k.ns().expect("only DefKinds with a valid namespace can be disambiguators")
1561 Self::Primitive => TypeNS,
1565 fn article(self) -> &'static str {
1567 Self::Namespace(_) => panic!("article() doesn't make sense for namespaces"),
1568 Self::Kind(k) => k.article(),
1569 Self::Primitive => "a",
1573 fn descr(self) -> &'static str {
1575 Self::Namespace(n) => n.descr(),
1576 // HACK(jynelson): by looking at the source I saw the DefId we pass
1577 // for `expected.descr()` doesn't matter, since it's not a crate
1578 Self::Kind(k) => k.descr(DefId::local(hir::def_id::DefIndex::from_usize(0))),
1579 Self::Primitive => "builtin type",
1584 /// A suggestion to show in a diagnostic.
1587 Prefix(&'static str),
1595 fn descr(&self) -> Cow<'static, str> {
1597 Self::Prefix(x) => format!("prefix with `{}@`", x).into(),
1598 Self::Function => "add parentheses".into(),
1599 Self::Macro => "add an exclamation mark".into(),
1603 fn as_help(&self, path_str: &str) -> String {
1604 // FIXME: if this is an implied shortcut link, it's bad style to suggest `@`
1606 Self::Prefix(prefix) => format!("{}@{}", prefix, path_str),
1607 Self::Function => format!("{}()", path_str),
1608 Self::Macro => format!("{}!", path_str),
1613 /// Reports a diagnostic for an intra-doc link.
1615 /// If no link range is provided, or the source span of the link cannot be determined, the span of
1616 /// the entire documentation block is used for the lint. If a range is provided but the span
1617 /// calculation fails, a note is added to the diagnostic pointing to the link in the markdown.
1619 /// The `decorate` callback is invoked in all cases to allow further customization of the
1620 /// diagnostic before emission. If the span of the link was able to be determined, the second
1621 /// parameter of the callback will contain it, and the primary span of the diagnostic will be set
1623 fn report_diagnostic(
1625 lint: &'static Lint,
1627 DiagnosticInfo { item, ori_link: _, dox, link_range }: &DiagnosticInfo<'_>,
1628 decorate: impl FnOnce(&mut DiagnosticBuilder<'_>, Option<rustc_span::Span>),
1630 let hir_id = match DocContext::as_local_hir_id(tcx, item.def_id) {
1631 Some(hir_id) => hir_id,
1633 // If non-local, no need to check anything.
1634 info!("ignoring warning from parent crate: {}", msg);
1639 let attrs = &item.attrs;
1640 let sp = span_of_attrs(attrs).unwrap_or(item.span.inner());
1642 tcx.struct_span_lint_hir(lint, hir_id, sp, |lint| {
1643 let mut diag = lint.build(msg);
1645 let span = super::source_span_for_markdown_range(tcx, dox, link_range, attrs);
1647 if let Some(sp) = span {
1650 // blah blah blah\nblah\nblah [blah] blah blah\nblah blah
1653 // last_new_line_offset
1654 let last_new_line_offset = dox[..link_range.start].rfind('\n').map_or(0, |n| n + 1);
1655 let line = dox[last_new_line_offset..].lines().next().unwrap_or("");
1657 // Print the line containing the `link_range` and manually mark it with '^'s.
1659 "the link appears in this line:\n\n{line}\n\
1660 {indicator: <before$}{indicator:^<found$}",
1663 before = link_range.start - last_new_line_offset,
1664 found = link_range.len(),
1668 decorate(&mut diag, span);
1674 /// Reports a link that failed to resolve.
1676 /// This also tries to resolve any intermediate path segments that weren't
1677 /// handled earlier. For example, if passed `Item::Crate(std)` and `path_str`
1678 /// `std::io::Error::x`, this will resolve `std::io::Error`.
1679 fn resolution_failure(
1680 collector: &mut LinkCollector<'_, '_>,
1681 diag_info: DiagnosticInfo<'_>,
1683 disambiguator: Option<Disambiguator>,
1684 kinds: SmallVec<[ResolutionFailure<'_>; 3]>,
1686 let tcx = collector.cx.tcx;
1689 BROKEN_INTRA_DOC_LINKS,
1690 &format!("unresolved link to `{}`", path_str),
1693 let item = |res: Res| format!("the {} `{}`", res.descr(), res.name(tcx),);
1694 let assoc_item_not_allowed = |res: Res| {
1695 let name = res.name(tcx);
1697 "`{}` is {} {}, not a module or type, and cannot have associated items",
1703 // ignore duplicates
1704 let mut variants_seen = SmallVec::<[_; 3]>::new();
1705 for mut failure in kinds {
1706 let variant = std::mem::discriminant(&failure);
1707 if variants_seen.contains(&variant) {
1710 variants_seen.push(variant);
1712 if let ResolutionFailure::NotResolved { module_id, partial_res, unresolved } =
1717 let module_id = *module_id;
1718 // FIXME(jynelson): this might conflict with my `Self` fix in #76467
1719 // FIXME: maybe use itertools `collect_tuple` instead?
1720 fn split(path: &str) -> Option<(&str, &str)> {
1721 let mut splitter = path.rsplitn(2, "::");
1722 splitter.next().and_then(|right| splitter.next().map(|left| (left, right)))
1725 // Check if _any_ parent of the path gets resolved.
1726 // If so, report it and say the first which failed; if not, say the first path segment didn't resolve.
1727 let mut name = path_str;
1729 let (start, end) = if let Some(x) = split(name) {
1732 // avoid bug that marked [Quux::Z] as missing Z, not Quux
1733 if partial_res.is_none() {
1734 *unresolved = name.into();
1739 for &ns in &[TypeNS, ValueNS, MacroNS] {
1741 collector.check_full_res(ns, &start, module_id, &None)
1743 debug!("found partial_res={:?}", res);
1744 *partial_res = Some(res);
1745 *unresolved = end.into();
1749 *unresolved = end.into();
1752 let last_found_module = match *partial_res {
1753 Some(Res::Def(DefKind::Mod, id)) => Some(id),
1754 None => Some(module_id),
1757 // See if this was a module: `[path]` or `[std::io::nope]`
1758 if let Some(module) = last_found_module {
1759 let note = if partial_res.is_some() {
1760 // Part of the link resolved; e.g. `std::io::nonexistent`
1761 let module_name = tcx.item_name(module);
1762 format!("no item named `{}` in module `{}`", unresolved, module_name)
1764 // None of the link resolved; e.g. `Notimported`
1765 format!("no item named `{}` in scope", unresolved)
1767 if let Some(span) = sp {
1768 diag.span_label(span, ¬e);
1773 // If the link has `::` in it, assume it was meant to be an intra-doc link.
1774 // Otherwise, the `[]` might be unrelated.
1775 // FIXME: don't show this for autolinks (`<>`), `()` style links, or reference links
1776 if !path_str.contains("::") {
1777 diag.help(r#"to escape `[` and `]` characters, add '\' before them like `\[` or `\]`"#);
1783 // Otherwise, it must be an associated item or variant
1784 let res = partial_res.expect("None case was handled by `last_found_module`");
1785 let name = res.name(tcx);
1786 let kind = match res {
1787 Res::Def(kind, _) => Some(kind),
1788 Res::Primitive(_) => None,
1790 let path_description = if let Some(kind) = kind {
1792 Mod | ForeignMod => "inner item",
1793 Struct => "field or associated item",
1794 Enum | Union => "variant or associated item",
1811 let note = assoc_item_not_allowed(res);
1812 if let Some(span) = sp {
1813 diag.span_label(span, ¬e);
1819 Trait | TyAlias | ForeignTy | OpaqueTy | TraitAlias | TyParam
1820 | Static => "associated item",
1821 Impl | GlobalAsm => unreachable!("not a path"),
1827 "the {} `{}` has no {} named `{}`",
1830 disambiguator.map_or(path_description, |d| d.descr()),
1833 if let Some(span) = sp {
1834 diag.span_label(span, ¬e);
1841 let note = match failure {
1842 ResolutionFailure::NotResolved { .. } => unreachable!("handled above"),
1843 ResolutionFailure::Dummy => continue,
1844 ResolutionFailure::WrongNamespace { res, expected_ns } => {
1845 if let Res::Def(kind, _) = res {
1846 let disambiguator = Disambiguator::Kind(kind);
1847 suggest_disambiguator(
1853 &diag_info.link_range,
1858 "this link resolves to {}, which is not in the {} namespace",
1863 ResolutionFailure::NoParentItem => {
1864 diag.level = rustc_errors::Level::Bug;
1865 "all intra-doc links should have a parent item".to_owned()
1867 ResolutionFailure::MalformedGenerics(variant) => match variant {
1868 MalformedGenerics::UnbalancedAngleBrackets => {
1869 String::from("unbalanced angle brackets")
1871 MalformedGenerics::MissingType => {
1872 String::from("missing type for generic parameters")
1874 MalformedGenerics::HasFullyQualifiedSyntax => {
1875 diag.note("see https://github.com/rust-lang/rust/issues/74563 for more information");
1876 String::from("fully-qualified syntax is unsupported")
1878 MalformedGenerics::InvalidPathSeparator => {
1879 String::from("has invalid path separator")
1881 MalformedGenerics::TooManyAngleBrackets => {
1882 String::from("too many angle brackets")
1884 MalformedGenerics::EmptyAngleBrackets => {
1885 String::from("empty angle brackets")
1889 if let Some(span) = sp {
1890 diag.span_label(span, ¬e);
1899 /// Report an anchor failure.
1900 fn anchor_failure(cx: &DocContext<'_>, diag_info: DiagnosticInfo<'_>, failure: AnchorFailure) {
1901 let msg = match failure {
1902 AnchorFailure::MultipleAnchors => {
1903 format!("`{}` contains multiple anchors", diag_info.ori_link)
1905 AnchorFailure::RustdocAnchorConflict(res) => format!(
1906 "`{}` contains an anchor, but links to {kind}s are already anchored",
1912 report_diagnostic(cx.tcx, BROKEN_INTRA_DOC_LINKS, &msg, &diag_info, |diag, sp| {
1913 if let Some(sp) = sp {
1914 diag.span_label(sp, "contains invalid anchor");
1919 /// Report an error in the link disambiguator.
1920 fn disambiguator_error(
1921 cx: &DocContext<'_>,
1922 mut diag_info: DiagnosticInfo<'_>,
1923 disambiguator_range: Range<usize>,
1926 diag_info.link_range = disambiguator_range;
1927 report_diagnostic(cx.tcx, BROKEN_INTRA_DOC_LINKS, msg, &diag_info, |_diag, _sp| {});
1930 /// Report an ambiguity error, where there were multiple possible resolutions.
1932 cx: &DocContext<'_>,
1933 diag_info: DiagnosticInfo<'_>,
1935 candidates: Vec<Res>,
1937 let mut msg = format!("`{}` is ", path_str);
1939 match candidates.as_slice() {
1940 [first_def, second_def] => {
1942 "both {} {} and {} {}",
1943 first_def.article(),
1945 second_def.article(),
1950 let mut candidates = candidates.iter().peekable();
1951 while let Some(res) = candidates.next() {
1952 if candidates.peek().is_some() {
1953 msg += &format!("{} {}, ", res.article(), res.descr());
1955 msg += &format!("and {} {}", res.article(), res.descr());
1961 report_diagnostic(cx.tcx, BROKEN_INTRA_DOC_LINKS, &msg, &diag_info, |diag, sp| {
1962 if let Some(sp) = sp {
1963 diag.span_label(sp, "ambiguous link");
1965 diag.note("ambiguous link");
1968 for res in candidates {
1969 let disambiguator = Disambiguator::from_res(res);
1970 suggest_disambiguator(
1976 &diag_info.link_range,
1982 /// In case of an ambiguity or mismatched disambiguator, suggest the correct
1984 fn suggest_disambiguator(
1985 disambiguator: Disambiguator,
1986 diag: &mut DiagnosticBuilder<'_>,
1989 sp: Option<rustc_span::Span>,
1990 link_range: &Range<usize>,
1992 let suggestion = disambiguator.suggestion();
1993 let help = format!("to link to the {}, {}", disambiguator.descr(), suggestion.descr());
1995 if let Some(sp) = sp {
1996 let msg = if dox.bytes().nth(link_range.start) == Some(b'`') {
1997 format!("`{}`", suggestion.as_help(path_str))
1999 suggestion.as_help(path_str)
2002 diag.span_suggestion(sp, &help, msg, Applicability::MaybeIncorrect);
2004 diag.help(&format!("{}: {}", help, suggestion.as_help(path_str)));
2008 /// Report a link from a public item to a private one.
2009 fn privacy_error(cx: &DocContext<'_>, diag_info: &DiagnosticInfo<'_>, path_str: &str) {
2011 let item_name = match diag_info.item.name {
2013 sym = name.as_str();
2016 None => "<unknown>",
2019 format!("public documentation for `{}` links to private item `{}`", item_name, path_str);
2021 report_diagnostic(cx.tcx, PRIVATE_INTRA_DOC_LINKS, &msg, diag_info, |diag, sp| {
2022 if let Some(sp) = sp {
2023 diag.span_label(sp, "this item is private");
2026 let note_msg = if cx.render_options.document_private {
2027 "this link resolves only because you passed `--document-private-items`, but will break without"
2029 "this link will resolve properly if you pass `--document-private-items`"
2031 diag.note(note_msg);
2035 /// Given an enum variant's res, return the res of its enum and the associated fragment.
2037 cx: &DocContext<'_>,
2039 extra_fragment: &Option<String>,
2040 ) -> Result<(Res, Option<String>), ErrorKind<'static>> {
2041 use rustc_middle::ty::DefIdTree;
2043 if extra_fragment.is_some() {
2044 return Err(ErrorKind::AnchorFailure(AnchorFailure::RustdocAnchorConflict(res)));
2047 .parent(res.def_id())
2049 let parent_def = Res::Def(DefKind::Enum, parent);
2050 let variant = cx.tcx.expect_variant_res(res.as_hir_res().unwrap());
2051 (parent_def, Some(format!("variant.{}", variant.ident.name)))
2053 .ok_or_else(|| ResolutionFailure::NoParentItem.into())
2056 /// Resolve a primitive type or value.
2057 fn resolve_primitive(path_str: &str, ns: Namespace) -> Option<Res> {
2061 use PrimitiveType::*;
2062 let prim = match path_str {
2078 "bool" | "true" | "false" => Bool,
2079 "str" | "&str" => Str,
2080 // See #80181 for why these don't have symbols associated.
2085 "pointer" | "*const" | "*mut" => RawPointer,
2086 "reference" | "&" | "&mut" => Reference,
2088 "never" | "!" => Never,
2091 debug!("resolved primitives {:?}", prim);
2092 Some(Res::Primitive(prim))
2095 fn strip_generics_from_path(path_str: &str) -> Result<String, ResolutionFailure<'static>> {
2096 let mut stripped_segments = vec![];
2097 let mut path = path_str.chars().peekable();
2098 let mut segment = Vec::new();
2100 while let Some(chr) = path.next() {
2103 if path.next_if_eq(&':').is_some() {
2104 let stripped_segment =
2105 strip_generics_from_path_segment(mem::take(&mut segment))?;
2106 if !stripped_segment.is_empty() {
2107 stripped_segments.push(stripped_segment);
2110 return Err(ResolutionFailure::MalformedGenerics(
2111 MalformedGenerics::InvalidPathSeparator,
2120 return Err(ResolutionFailure::MalformedGenerics(
2121 MalformedGenerics::TooManyAngleBrackets,
2125 return Err(ResolutionFailure::MalformedGenerics(
2126 MalformedGenerics::EmptyAngleBrackets,
2132 while let Some(chr) = path.next_if(|c| *c != '>') {
2139 _ => segment.push(chr),
2141 trace!("raw segment: {:?}", segment);
2144 if !segment.is_empty() {
2145 let stripped_segment = strip_generics_from_path_segment(segment)?;
2146 if !stripped_segment.is_empty() {
2147 stripped_segments.push(stripped_segment);
2151 debug!("path_str: {:?}\nstripped segments: {:?}", path_str, &stripped_segments);
2153 let stripped_path = stripped_segments.join("::");
2155 if !stripped_path.is_empty() {
2158 Err(ResolutionFailure::MalformedGenerics(MalformedGenerics::MissingType))
2162 fn strip_generics_from_path_segment(
2164 ) -> Result<String, ResolutionFailure<'static>> {
2165 let mut stripped_segment = String::new();
2166 let mut param_depth = 0;
2168 let mut latest_generics_chunk = String::new();
2173 latest_generics_chunk.clear();
2174 } else if c == '>' {
2176 if latest_generics_chunk.contains(" as ") {
2177 // The segment tries to use fully-qualified syntax, which is currently unsupported.
2178 // Give a helpful error message instead of completely ignoring the angle brackets.
2179 return Err(ResolutionFailure::MalformedGenerics(
2180 MalformedGenerics::HasFullyQualifiedSyntax,
2184 if param_depth == 0 {
2185 stripped_segment.push(c);
2187 latest_generics_chunk.push(c);
2192 if param_depth == 0 {
2193 Ok(stripped_segment)
2195 // The segment has unbalanced angle brackets, e.g. `Vec<T` or `Vec<T>>`
2196 Err(ResolutionFailure::MalformedGenerics(MalformedGenerics::UnbalancedAngleBrackets))