1 use crate::namespace::Namespace;
2 use rustc::traits::{self, IntercrateMode};
4 use rustc_errors::struct_span_err;
6 use rustc_hir::def_id::{CrateNum, DefId, LOCAL_CRATE};
7 use rustc_hir::itemlikevisit::ItemLikeVisitor;
9 use rustc_error_codes::*;
11 pub fn crate_inherent_impls_overlap_check(tcx: TyCtxt<'_>, crate_num: CrateNum) {
12 assert_eq!(crate_num, LOCAL_CRATE);
13 let krate = tcx.hir().krate();
14 krate.visit_all_item_likes(&mut InherentOverlapChecker { tcx });
17 struct InherentOverlapChecker<'tcx> {
21 impl InherentOverlapChecker<'tcx> {
22 fn check_for_common_items_in_impls(
26 overlap: traits::OverlapResult<'_>,
28 let name_and_namespace = |def_id| {
29 let item = self.tcx.associated_item(def_id);
30 (item.ident.modern(), Namespace::from(item.kind))
33 let impl_items1 = self.tcx.associated_item_def_ids(impl1);
34 let impl_items2 = self.tcx.associated_item_def_ids(impl2);
36 for &item1 in &impl_items1[..] {
37 let (name, namespace) = name_and_namespace(item1);
39 for &item2 in &impl_items2[..] {
40 if (name, namespace) == name_and_namespace(item2) {
41 let mut err = struct_span_err!(
43 self.tcx.span_of_impl(item1).unwrap(),
45 "duplicate definitions with name `{}`",
49 self.tcx.span_of_impl(item1).unwrap(),
50 format!("duplicate definitions for `{}`", name),
53 self.tcx.span_of_impl(item2).unwrap(),
54 format!("other definition for `{}`", name),
57 for cause in &overlap.intercrate_ambiguity_causes {
58 cause.add_intercrate_ambiguity_hint(&mut err);
61 if overlap.involves_placeholder {
62 traits::add_placeholder_note(&mut err);
71 fn check_for_overlapping_inherent_impls(&self, ty_def_id: DefId) {
72 let impls = self.tcx.inherent_impls(ty_def_id);
74 for (i, &impl1_def_id) in impls.iter().enumerate() {
75 for &impl2_def_id in &impls[(i + 1)..] {
76 traits::overlapping_impls(
80 IntercrateMode::Issue43355,
82 self.check_for_common_items_in_impls(impl1_def_id, impl2_def_id, overlap);
92 impl ItemLikeVisitor<'v> for InherentOverlapChecker<'tcx> {
93 fn visit_item(&mut self, item: &'v hir::Item<'v>) {
95 hir::ItemKind::Enum(..)
96 | hir::ItemKind::Struct(..)
97 | hir::ItemKind::Trait(..)
98 | hir::ItemKind::Union(..) => {
99 let type_def_id = self.tcx.hir().local_def_id(item.hir_id);
100 self.check_for_overlapping_inherent_impls(type_def_id);
106 fn visit_trait_item(&mut self, _trait_item: &hir::TraitItem<'v>) {}
108 fn visit_impl_item(&mut self, _impl_item: &hir::ImplItem<'v>) {}