src/librustc_typeck/check/wfcheck.rs

   1 // Copyright 2014 The Rust Project Developers. See the COPYRIGHT
   2 // file at the top-level directory of this distribution and at
   3 // http://rust-lang.org/COPYRIGHT.
   4 //
   5 // Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
   6 // http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
   7 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
   8 // option. This file may not be copied, modified, or distributed
   9 // except according to those terms.
  10
  11 use check::{Inherited, FnCtxt};
  12 use constrained_type_params::{identify_constrained_type_params, Parameter};
  13
  14 use hir::def_id::DefId;
  15 use rustc::traits::{self, ObligationCauseCode};
  16 use rustc::ty::{self, Lift, Ty, TyCtxt};
  17 use rustc::ty::util::ExplicitSelf;
  18 use rustc::util::nodemap::{FxHashSet, FxHashMap};
  19 use rustc::middle::lang_items;
  20
  21 use syntax::ast;
  22 use syntax::feature_gate::{self, GateIssue};
  23 use syntax_pos::Span;
  24 use errors::{DiagnosticBuilder, DiagnosticId};
  25
  26 use rustc::hir::intravisit::{self, Visitor, NestedVisitorMap};
  27 use rustc::hir;
  28
  29 pub struct CheckTypeWellFormedVisitor<'a, 'tcx:'a> {
  30     tcx: TyCtxt<'a, 'tcx, 'tcx>,
  31     code: ObligationCauseCode<'tcx>,
  32 }
  33
  34 /// Helper type of a temporary returned by .for_item(...).
  35 /// Necessary because we can't write the following bound:
  36 /// F: for<'b, 'tcx> where 'gcx: 'tcx FnOnce(FnCtxt<'b, 'gcx, 'tcx>).
  37 struct CheckWfFcxBuilder<'a, 'gcx: 'a+'tcx, 'tcx: 'a> {
  38     inherited: super::InheritedBuilder<'a, 'gcx, 'tcx>,
  39     code: ObligationCauseCode<'gcx>,
  40     id: ast::NodeId,
  41     span: Span,
  42     param_env: ty::ParamEnv<'tcx>,
  43 }
  44
  45 impl<'a, 'gcx, 'tcx> CheckWfFcxBuilder<'a, 'gcx, 'tcx> {
  46     fn with_fcx<F>(&'tcx mut self, f: F) where
  47         F: for<'b> FnOnce(&FnCtxt<'b, 'gcx, 'tcx>,
  48                           &mut CheckTypeWellFormedVisitor<'b, 'gcx>) -> Vec<Ty<'tcx>>
  49     {
  50         let code = self.code.clone();
  51         let id = self.id;
  52         let span = self.span;
  53         let param_env = self.param_env;
  54         self.inherited.enter(|inh| {
  55             let fcx = FnCtxt::new(&inh, param_env, id);
  56             let wf_tys = f(&fcx, &mut CheckTypeWellFormedVisitor {
  57                 tcx: fcx.tcx.global_tcx(),
  58                 code,
  59             });
  60             fcx.select_all_obligations_or_error();
  61             fcx.regionck_item(id, span, &wf_tys);
  62         });
  63     }
  64 }
  65
  66 impl<'a, 'gcx> CheckTypeWellFormedVisitor<'a, 'gcx> {
  67     pub fn new(tcx: TyCtxt<'a, 'gcx, 'gcx>)
  68                -> CheckTypeWellFormedVisitor<'a, 'gcx> {
  69         CheckTypeWellFormedVisitor {
  70             tcx,
  71             code: ObligationCauseCode::MiscObligation
  72         }
  73     }
  74
  75     /// Checks that the field types (in a struct def'n) or argument types (in an enum def'n) are
  76     /// well-formed, meaning that they do not require any constraints not declared in the struct
  77     /// definition itself. For example, this definition would be illegal:
  78     ///
  79     ///     struct Ref<'a, T> { x: &'a T }
  80     ///
  81     /// because the type did not declare that `T:'a`.
  82     ///
  83     /// We do this check as a pre-pass before checking fn bodies because if these constraints are
  84     /// not included it frequently leads to confusing errors in fn bodies. So it's better to check
  85     /// the types first.
  86     fn check_item_well_formed(&mut self, item: &hir::Item) {
  87         let tcx = self.tcx;
  88         debug!("check_item_well_formed(it.id={}, it.name={})",
  89                item.id,
  90                tcx.item_path_str(tcx.hir.local_def_id(item.id)));
  91
  92         match item.node {
  93             // Right now we check that every default trait implementation
  94             // has an implementation of itself. Basically, a case like:
  95             //
  96             // `impl Trait for T {}`
  97             //
  98             // has a requirement of `T: Trait` which was required for default
  99             // method implementations. Although this could be improved now that
 100             // there's a better infrastructure in place for this, it's being left
 101             // for a follow-up work.
 102             //
 103             // Since there's such a requirement, we need to check *just* positive
 104             // implementations, otherwise things like:
 105             //
 106             // impl !Send for T {}
 107             //
 108             // won't be allowed unless there's an *explicit* implementation of `Send`
 109             // for `T`
 110             hir::ItemImpl(_, polarity, defaultness, _, ref trait_ref, ref self_ty, _) => {
 111                 let is_auto = tcx.impl_trait_ref(tcx.hir.local_def_id(item.id))
 112                                  .map_or(false, |trait_ref| tcx.trait_is_auto(trait_ref.def_id));
 113                 if let (hir::Defaultness::Default { .. }, true) = (defaultness, is_auto) {
 114                     tcx.sess.span_err(item.span, "impls of auto traits cannot be default");
 115                 }
 116                 if polarity == hir::ImplPolarity::Positive {
 117                     self.check_impl(item, self_ty, trait_ref);
 118                 } else {
 119                     // FIXME(#27579) what amount of WF checking do we need for neg impls?
 120                     if trait_ref.is_some() && !is_auto {
 121                         span_err!(tcx.sess, item.span, E0192,
 122                                   "negative impls are only allowed for \
 123                                    auto traits (e.g., `Send` and `Sync`)")
 124                     }
 125                 }
 126             }
 127             hir::ItemFn(..) => {
 128                 self.check_item_fn(item);
 129             }
 130             hir::ItemStatic(..) => {
 131                 self.check_item_type(item);
 132             }
 133             hir::ItemConst(..) => {
 134                 self.check_item_type(item);
 135             }
 136             hir::ItemStruct(ref struct_def, ref ast_generics) => {
 137                 self.check_type_defn(item, false, |fcx| {
 138                     vec![fcx.non_enum_variant(struct_def)]
 139                 });
 140
 141                 self.check_variances_for_type_defn(item, ast_generics);
 142             }
 143             hir::ItemUnion(ref struct_def, ref ast_generics) => {
 144                 self.check_type_defn(item, true, |fcx| {
 145                     vec![fcx.non_enum_variant(struct_def)]
 146                 });
 147
 148                 self.check_variances_for_type_defn(item, ast_generics);
 149             }
 150             hir::ItemEnum(ref enum_def, ref ast_generics) => {
 151                 self.check_type_defn(item, true, |fcx| {
 152                     fcx.enum_variants(enum_def)
 153                 });
 154
 155                 self.check_variances_for_type_defn(item, ast_generics);
 156             }
 157             hir::ItemTrait(..) => {
 158                 self.check_trait(item);
 159             }
 160             _ => {}
 161         }
 162     }
 163
 164     fn check_associated_item(&mut self,
 165                              item_id: ast::NodeId,
 166                              span: Span,
 167                              sig_if_method: Option<&hir::MethodSig>) {
 168         let code = self.code.clone();
 169         self.for_id(item_id, span).with_fcx(|fcx, this| {
 170             let item = fcx.tcx.associated_item(fcx.tcx.hir.local_def_id(item_id));
 171
 172             let (mut implied_bounds, self_ty) = match item.container {
 173                 ty::TraitContainer(_) => (vec![], fcx.tcx.mk_self_type()),
 174                 ty::ImplContainer(def_id) => (fcx.impl_implied_bounds(def_id, span),
 175                                               fcx.tcx.type_of(def_id))
 176             };
 177
 178             match item.kind {
 179                 ty::AssociatedKind::Const => {
 180                     let ty = fcx.tcx.type_of(item.def_id);
 181                     let ty = fcx.normalize_associated_types_in(span, &ty);
 182                     fcx.register_wf_obligation(ty, span, code.clone());
 183                 }
 184                 ty::AssociatedKind::Method => {
 185                     reject_shadowing_type_parameters(fcx.tcx, item.def_id);
 186                     let sig = fcx.tcx.fn_sig(item.def_id);
 187                     let sig = fcx.normalize_associated_types_in(span, &sig);
 188                     this.check_fn_or_method(fcx, span, sig,
 189                                             item.def_id, &mut implied_bounds);
 190                     let sig_if_method = sig_if_method.expect("bad signature for method");
 191                     this.check_method_receiver(fcx, sig_if_method, &item, self_ty);
 192                 }
 193                 ty::AssociatedKind::Type => {
 194                     if item.defaultness.has_value() {
 195                         let ty = fcx.tcx.type_of(item.def_id);
 196                         let ty = fcx.normalize_associated_types_in(span, &ty);
 197                         fcx.register_wf_obligation(ty, span, code.clone());
 198                     }
 199                 }
 200             }
 201
 202             implied_bounds
 203         })
 204     }
 205
 206     fn for_item<'tcx>(&self, item: &hir::Item)
 207                       -> CheckWfFcxBuilder<'a, 'gcx, 'tcx> {
 208         self.for_id(item.id, item.span)
 209     }
 210
 211     fn for_id<'tcx>(&self, id: ast::NodeId, span: Span)
 212                     -> CheckWfFcxBuilder<'a, 'gcx, 'tcx> {
 213         let def_id = self.tcx.hir.local_def_id(id);
 214         CheckWfFcxBuilder {
 215             inherited: Inherited::build(self.tcx, def_id),
 216             code: self.code.clone(),
 217             id,
 218             span,
 219             param_env: self.tcx.param_env(def_id),
 220         }
 221     }
 222
 223     /// In a type definition, we check that to ensure that the types of the fields are well-formed.
 224     fn check_type_defn<F>(&mut self, item: &hir::Item, all_sized: bool, mut lookup_fields: F)
 225         where F: for<'fcx, 'tcx> FnMut(&FnCtxt<'fcx, 'gcx, 'tcx>) -> Vec<AdtVariant<'tcx>>
 226     {
 227         self.for_item(item).with_fcx(|fcx, this| {
 228             let variants = lookup_fields(fcx);
 229             let def_id = fcx.tcx.hir.local_def_id(item.id);
 230             let packed = fcx.tcx.adt_def(def_id).repr.packed();
 231
 232             for variant in &variants {
 233                 // For DST, or when drop needs to copy things around, all
 234                 // intermediate types must be sized.
 235                 let needs_drop_copy = || {
 236                     packed && {
 237                         let ty = variant.fields.last().unwrap().ty;
 238                         let ty = fcx.tcx.erase_regions(&ty).lift_to_tcx(this.tcx)
 239                             .unwrap_or_else(|| {
 240                                 span_bug!(item.span, "inference variables in {:?}", ty)
 241                             });
 242                         ty.needs_drop(this.tcx, this.tcx.param_env(def_id))
 243                     }
 244                 };
 245                 let unsized_len = if
 246                     all_sized ||
 247                     variant.fields.is_empty() ||
 248                     needs_drop_copy()
 249                 {
 250                     0
 251                 } else {
 252                     1
 253                 };
 254                 for field in &variant.fields[..variant.fields.len() - unsized_len] {
 255                     fcx.register_bound(
 256                         field.ty,
 257                         fcx.tcx.require_lang_item(lang_items::SizedTraitLangItem),
 258                         traits::ObligationCause::new(field.span,
 259                                                      fcx.body_id,
 260                                                      traits::FieldSized(match item.node.adt_kind() {
 261                                                         Some(i) => i,
 262                                                         None => bug!(),
 263                                                      })));
 264                 }
 265
 266                 // All field types must be well-formed.
 267                 for field in &variant.fields {
 268                     fcx.register_wf_obligation(field.ty, field.span, this.code.clone())
 269                 }
 270             }
 271
 272             self.check_where_clauses(fcx, item.span, def_id);
 273
 274             vec![] // no implied bounds in a struct def'n
 275         });
 276     }
 277
 278     fn check_trait(&mut self, item: &hir::Item) {
 279         let trait_def_id = self.tcx.hir.local_def_id(item.id);
 280         self.for_item(item).with_fcx(|fcx, _| {
 281             self.check_trait_where_clauses(fcx, item.span, trait_def_id);
 282             vec![]
 283         });
 284     }
 285
 286     fn check_item_fn(&mut self, item: &hir::Item) {
 287         self.for_item(item).with_fcx(|fcx, this| {
 288             let def_id = fcx.tcx.hir.local_def_id(item.id);
 289             let sig = fcx.tcx.fn_sig(def_id);
 290             let sig = fcx.normalize_associated_types_in(item.span, &sig);
 291             let mut implied_bounds = vec![];
 292             this.check_fn_or_method(fcx, item.span, sig,
 293                                     def_id, &mut implied_bounds);
 294             implied_bounds
 295         })
 296     }
 297
 298     fn check_item_type(&mut self,
 299                        item: &hir::Item)
 300     {
 301         debug!("check_item_type: {:?}", item);
 302
 303         self.for_item(item).with_fcx(|fcx, this| {
 304             let ty = fcx.tcx.type_of(fcx.tcx.hir.local_def_id(item.id));
 305             let item_ty = fcx.normalize_associated_types_in(item.span, &ty);
 306
 307             fcx.register_wf_obligation(item_ty, item.span, this.code.clone());
 308
 309             vec![] // no implied bounds in a const etc
 310         });
 311     }
 312
 313     fn check_impl(&mut self,
 314                   item: &hir::Item,
 315                   ast_self_ty: &hir::Ty,
 316                   ast_trait_ref: &Option<hir::TraitRef>)
 317     {
 318         debug!("check_impl: {:?}", item);
 319
 320         self.for_item(item).with_fcx(|fcx, this| {
 321             let item_def_id = fcx.tcx.hir.local_def_id(item.id);
 322
 323             match *ast_trait_ref {
 324                 Some(ref ast_trait_ref) => {
 325                     let trait_ref = fcx.tcx.impl_trait_ref(item_def_id).unwrap();
 326                     let trait_ref =
 327                         fcx.normalize_associated_types_in(
 328                             ast_trait_ref.path.span, &trait_ref);
 329                     let obligations =
 330                         ty::wf::trait_obligations(fcx,
 331                                                   fcx.param_env,
 332                                                   fcx.body_id,
 333                                                   &trait_ref,
 334                                                   ast_trait_ref.path.span);
 335                     for obligation in obligations {
 336                         fcx.register_predicate(obligation);
 337                     }
 338                 }
 339                 None => {
 340                     let self_ty = fcx.tcx.type_of(item_def_id);
 341                     let self_ty = fcx.normalize_associated_types_in(item.span, &self_ty);
 342                     fcx.register_wf_obligation(self_ty, ast_self_ty.span, this.code.clone());
 343                 }
 344             }
 345
 346             this.check_where_clauses(fcx, item.span, item_def_id);
 347
 348             fcx.impl_implied_bounds(item_def_id, item.span)
 349         });
 350     }
 351
 352     /// Checks where clauses and inline bounds that are declared on def_id.
 353     fn check_where_clauses<'fcx, 'tcx>(&mut self,
 354                                        fcx: &FnCtxt<'fcx, 'gcx, 'tcx>,
 355                                        span: Span,
 356                                        def_id: DefId) {
 357         self.inner_check_where_clauses(fcx, span, def_id, false)
 358     }
 359
 360     fn check_trait_where_clauses<'fcx, 'tcx>(&mut self,
 361                                        fcx: &FnCtxt<'fcx, 'gcx, 'tcx>,
 362                                        span: Span,
 363                                        def_id: DefId) {
 364         self.inner_check_where_clauses(fcx, span, def_id, true)
 365     }
 366
 367     /// Checks where clauses and inline bounds that are declared on def_id.
 368     fn inner_check_where_clauses<'fcx, 'tcx>(&mut self,
 369                                        fcx: &FnCtxt<'fcx, 'gcx, 'tcx>,
 370                                        span: Span,
 371                                        def_id: DefId,
 372                                        is_trait: bool)
 373     {
 374         use ty::subst::Subst;
 375         use rustc::ty::TypeFoldable;
 376
 377         let mut predicates = fcx.tcx.predicates_of(def_id);
 378         let mut substituted_predicates = Vec::new();
 379
 380         let generics = self.tcx.generics_of(def_id);
 381         let defaulted_params = generics.types.iter()
 382                                              .filter(|def| def.has_default &&
 383                                                      def.index >= generics.parent_count() as u32);
 384         for param_def in defaulted_params {
 385             // Defaults must be well-formed.
 386             let d = param_def.def_id;
 387             fcx.register_wf_obligation(fcx.tcx.type_of(d), fcx.tcx.def_span(d), self.code.clone());
 388             // Check the clauses are well-formed when the param is substituted by it's default.
 389             // In trait definitions, the predicate `Self: Trait` is problematic.
 390             // Therefore we skip such predicates. This means we check less than we could.
 391             for pred in predicates.predicates.iter().filter(|p| !(is_trait && p.has_self_ty())) {
 392                 let mut skip = true;
 393                 let substs = ty::subst::Substs::for_item(fcx.tcx, def_id, |def, _| {
 394                     // All regions are identity.
 395                     fcx.tcx.mk_region(ty::ReEarlyBound(def.to_early_bound_region_data()))
 396                 }, |def, _| {
 397                     let identity_substs = fcx.tcx.mk_param_from_def(def);
 398                     if def.index != param_def.index {
 399                         identity_substs
 400                     } else {
 401                         let sized = fcx.tcx.lang_items().sized_trait();
 402                         let pred_is_sized = match pred {
 403                             ty::Predicate::Trait(p) => Some(p.def_id()) == sized,
 404                             _ => false,
 405                         };
 406                         let default_ty = fcx.tcx.type_of(def.def_id);
 407                         let default_is_self = match default_ty.sty {
 408                             ty::TyParam(ref p) => p.is_self(),
 409                             _ => false
 410                         };
 411                         // In trait defs, skip `Self: Sized` when `Self` is the default.
 412                         if is_trait && pred_is_sized && default_is_self {
 413                             identity_substs
 414                         } else {
 415                             skip = false;
 416                             default_ty
 417                         }
 418                     }
 419                 });
 420                 if skip { continue; }
 421                 substituted_predicates.push(match pred {
 422                     // In trait predicates, substitute defaults only for the LHS.
 423                     ty::Predicate::Trait(t_pred) => {
 424                         let trait_ref = t_pred.map_bound(|t_pred| {
 425                             let mut trait_subs = t_pred.trait_ref.substs.to_vec();
 426                             trait_subs[0] = t_pred.self_ty().subst(fcx.tcx, substs).into();
 427                             ty::TraitRef::new(t_pred.def_id(), fcx.tcx.intern_substs(&trait_subs))
 428                         });
 429                         ty::Predicate::Trait(trait_ref.to_poly_trait_predicate())
 430                     }
 431                     _ => pred.subst(fcx.tcx, substs)
 432                 });
 433             }
 434         }
 435
 436         predicates.predicates.extend(substituted_predicates);
 437         let predicates = predicates.instantiate_identity(fcx.tcx);
 438         let predicates = fcx.normalize_associated_types_in(span, &predicates);
 439
 440         let obligations =
 441             predicates.predicates
 442                       .iter()
 443                       .flat_map(|p| ty::wf::predicate_obligations(fcx,
 444                                                                   fcx.param_env,
 445                                                                   fcx.body_id,
 446                                                                   p,
 447                                                                   span));
 448
 449         for obligation in obligations {
 450             fcx.register_predicate(obligation);
 451         }
 452     }
 453
 454     fn check_fn_or_method<'fcx, 'tcx>(&mut self,
 455                                       fcx: &FnCtxt<'fcx, 'gcx, 'tcx>,
 456                                       span: Span,
 457                                       sig: ty::PolyFnSig<'tcx>,
 458                                       def_id: DefId,
 459                                       implied_bounds: &mut Vec<Ty<'tcx>>)
 460     {
 461         let sig = fcx.normalize_associated_types_in(span, &sig);
 462         let sig = fcx.tcx.liberate_late_bound_regions(def_id, &sig);
 463
 464         for input_ty in sig.inputs() {
 465             fcx.register_wf_obligation(&input_ty, span, self.code.clone());
 466         }
 467         implied_bounds.extend(sig.inputs());
 468
 469         fcx.register_wf_obligation(sig.output(), span, self.code.clone());
 470
 471         // FIXME(#25759) return types should not be implied bounds
 472         implied_bounds.push(sig.output());
 473
 474         self.check_where_clauses(fcx, span, def_id);
 475     }
 476
 477     fn check_method_receiver<'fcx, 'tcx>(&mut self,
 478                                          fcx: &FnCtxt<'fcx, 'gcx, 'tcx>,
 479                                          method_sig: &hir::MethodSig,
 480                                          method: &ty::AssociatedItem,
 481                                          self_ty: Ty<'tcx>)
 482     {
 483         // check that the method has a valid receiver type, given the type `Self`
 484         debug!("check_method_receiver({:?}, self_ty={:?})",
 485                method, self_ty);
 486
 487         if !method.method_has_self_argument {
 488             return;
 489         }
 490
 491         let span = method_sig.decl.inputs[0].span;
 492
 493         let sig = fcx.tcx.fn_sig(method.def_id);
 494         let sig = fcx.normalize_associated_types_in(span, &sig);
 495         let sig = fcx.tcx.liberate_late_bound_regions(method.def_id, &sig);
 496
 497         debug!("check_method_receiver: sig={:?}", sig);
 498
 499         let self_ty = fcx.normalize_associated_types_in(span, &self_ty);
 500         let self_ty = fcx.tcx.liberate_late_bound_regions(
 501             method.def_id,
 502             &ty::Binder(self_ty)
 503         );
 504
 505         let self_arg_ty = sig.inputs()[0];
 506
 507         let cause = fcx.cause(span, ObligationCauseCode::MethodReceiver);
 508         let self_arg_ty = fcx.normalize_associated_types_in(span, &self_arg_ty);
 509         let self_arg_ty = fcx.tcx.liberate_late_bound_regions(
 510             method.def_id,
 511             &ty::Binder(self_arg_ty)
 512         );
 513
 514         let mut autoderef = fcx.autoderef(span, self_arg_ty).include_raw_pointers();
 515
 516         loop {
 517             if let Some((potential_self_ty, _)) = autoderef.next() {
 518                 debug!("check_method_receiver: potential self type `{:?}` to match `{:?}`",
 519                     potential_self_ty, self_ty);
 520
 521                 if fcx.infcx.can_eq(fcx.param_env, self_ty, potential_self_ty).is_ok() {
 522                     autoderef.finalize();
 523                     if let Some(mut err) = fcx.demand_eqtype_with_origin(
 524                         &cause, self_ty, potential_self_ty) {
 525                         err.emit();
 526                     }
 527                     break
 528                 }
 529             } else {
 530                 fcx.tcx.sess.diagnostic().mut_span_err(
 531                     span, &format!("invalid `self` type: {:?}", self_arg_ty))
 532                 .note(&format!("type must be `{:?}` or a type that dereferences to it`", self_ty))
 533                 .help("consider changing to `self`, `&self`, `&mut self`, or `self: Box<Self>`")
 534                 .code(DiagnosticId::Error("E0307".into()))
 535                 .emit();
 536                 return
 537             }
 538         }
 539
 540         let is_self_ty = |ty| fcx.infcx.can_eq(fcx.param_env, self_ty, ty).is_ok();
 541         let self_kind = ExplicitSelf::determine(self_arg_ty, is_self_ty);
 542
 543         if !fcx.tcx.sess.features.borrow().arbitrary_self_types {
 544             match self_kind {
 545                 ExplicitSelf::ByValue |
 546                 ExplicitSelf::ByReference(_, _) |
 547                 ExplicitSelf::ByBox => (),
 548
 549                 ExplicitSelf::ByRawPointer(_) => {
 550                     feature_gate::feature_err(
 551                         &fcx.tcx.sess.parse_sess,
 552                         "arbitrary_self_types",
 553                         span,
 554                         GateIssue::Language,
 555                         "raw pointer `self` is unstable")
 556                     .help("consider changing to `self`, `&self`, `&mut self`, or `self: Box<Self>`")
 557                     .emit();
 558                 }
 559
 560                 ExplicitSelf::Other => {
 561                     feature_gate::feature_err(
 562                         &fcx.tcx.sess.parse_sess,
 563                         "arbitrary_self_types",
 564                         span,
 565                         GateIssue::Language,"arbitrary `self` types are unstable")
 566                     .help("consider changing to `self`, `&self`, `&mut self`, or `self: Box<Self>`")
 567                     .emit();
 568                 }
 569             }
 570         }
 571     }
 572
 573     fn check_variances_for_type_defn(&self,
 574                                      item: &hir::Item,
 575                                      ast_generics: &hir::Generics)
 576     {
 577         let item_def_id = self.tcx.hir.local_def_id(item.id);
 578         let ty = self.tcx.type_of(item_def_id);
 579         if self.tcx.has_error_field(ty) {
 580             return;
 581         }
 582
 583         let ty_predicates = self.tcx.predicates_of(item_def_id);
 584         assert_eq!(ty_predicates.parent, None);
 585         let variances = self.tcx.variances_of(item_def_id);
 586
 587         let mut constrained_parameters: FxHashSet<_> =
 588             variances.iter().enumerate()
 589                      .filter(|&(_, &variance)| variance != ty::Bivariant)
 590                      .map(|(index, _)| Parameter(index as u32))
 591                      .collect();
 592
 593         identify_constrained_type_params(self.tcx,
 594                                          ty_predicates.predicates.as_slice(),
 595                                          None,
 596                                          &mut constrained_parameters);
 597
 598         for (index, _) in variances.iter().enumerate() {
 599             if constrained_parameters.contains(&Parameter(index as u32)) {
 600                 continue;
 601             }
 602
 603             let (span, name) = match ast_generics.params[index] {
 604                 hir::GenericParam::Lifetime(ref ld) => (ld.lifetime.span, ld.lifetime.name.name()),
 605                 hir::GenericParam::Type(ref tp) => (tp.span, tp.name),
 606             };
 607             self.report_bivariance(span, name);
 608         }
 609     }
 610
 611     fn report_bivariance(&self,
 612                          span: Span,
 613                          param_name: ast::Name)
 614     {
 615         let mut err = error_392(self.tcx, span, param_name);
 616
 617         let suggested_marker_id = self.tcx.lang_items().phantom_data();
 618         match suggested_marker_id {
 619             Some(def_id) => {
 620                 err.help(
 621                     &format!("consider removing `{}` or using a marker such as `{}`",
 622                              param_name,
 623                              self.tcx.item_path_str(def_id)));
 624             }
 625             None => {
 626                 // no lang items, no help!
 627             }
 628         }
 629         err.emit();
 630     }
 631 }
 632
 633 fn reject_shadowing_type_parameters(tcx: TyCtxt, def_id: DefId) {
 634     let generics = tcx.generics_of(def_id);
 635     let parent = tcx.generics_of(generics.parent.unwrap());
 636     let impl_params: FxHashMap<_, _> = parent.types
 637                                        .iter()
 638                                        .map(|tp| (tp.name, tp.def_id))
 639                                        .collect();
 640
 641     for method_param in &generics.types {
 642         if impl_params.contains_key(&method_param.name) {
 643             // Tighten up the span to focus on only the shadowing type
 644             let type_span = tcx.def_span(method_param.def_id);
 645
 646             // The expectation here is that the original trait declaration is
 647             // local so it should be okay to just unwrap everything.
 648             let trait_def_id = impl_params[&method_param.name];
 649             let trait_decl_span = tcx.def_span(trait_def_id);
 650             error_194(tcx, type_span, trait_decl_span, method_param.name);
 651         }
 652     }
 653 }
 654
 655 impl<'a, 'tcx, 'v> Visitor<'v> for CheckTypeWellFormedVisitor<'a, 'tcx> {
 656     fn nested_visit_map<'this>(&'this mut self) -> NestedVisitorMap<'this, 'v> {
 657         NestedVisitorMap::None
 658     }
 659
 660     fn visit_item(&mut self, i: &hir::Item) {
 661         debug!("visit_item: {:?}", i);
 662         self.check_item_well_formed(i);
 663         intravisit::walk_item(self, i);
 664     }
 665
 666     fn visit_trait_item(&mut self, trait_item: &'v hir::TraitItem) {
 667         debug!("visit_trait_item: {:?}", trait_item);
 668         let method_sig = match trait_item.node {
 669             hir::TraitItemKind::Method(ref sig, _) => Some(sig),
 670             _ => None
 671         };
 672         self.check_associated_item(trait_item.id, trait_item.span, method_sig);
 673         intravisit::walk_trait_item(self, trait_item)
 674     }
 675
 676     fn visit_impl_item(&mut self, impl_item: &'v hir::ImplItem) {
 677         debug!("visit_impl_item: {:?}", impl_item);
 678         let method_sig = match impl_item.node {
 679             hir::ImplItemKind::Method(ref sig, _) => Some(sig),
 680             _ => None
 681         };
 682         self.check_associated_item(impl_item.id, impl_item.span, method_sig);
 683         intravisit::walk_impl_item(self, impl_item)
 684     }
 685 }
 686
 687 ///////////////////////////////////////////////////////////////////////////
 688 // ADT
 689
 690 struct AdtVariant<'tcx> {
 691     fields: Vec<AdtField<'tcx>>,
 692 }
 693
 694 struct AdtField<'tcx> {
 695     ty: Ty<'tcx>,
 696     span: Span,
 697 }
 698
 699 impl<'a, 'gcx, 'tcx> FnCtxt<'a, 'gcx, 'tcx> {
 700     fn non_enum_variant(&self, struct_def: &hir::VariantData) -> AdtVariant<'tcx> {
 701         let fields =
 702             struct_def.fields().iter()
 703             .map(|field| {
 704                 let field_ty = self.tcx.type_of(self.tcx.hir.local_def_id(field.id));
 705                 let field_ty = self.normalize_associated_types_in(field.span,
 706                                                                   &field_ty);
 707                 AdtField { ty: field_ty, span: field.span }
 708             })
 709             .collect();
 710         AdtVariant { fields: fields }
 711     }
 712
 713     fn enum_variants(&self, enum_def: &hir::EnumDef) -> Vec<AdtVariant<'tcx>> {
 714         enum_def.variants.iter()
 715             .map(|variant| self.non_enum_variant(&variant.node.data))
 716             .collect()
 717     }
 718
 719     fn impl_implied_bounds(&self, impl_def_id: DefId, span: Span) -> Vec<Ty<'tcx>> {
 720         match self.tcx.impl_trait_ref(impl_def_id) {
 721             Some(ref trait_ref) => {
 722                 // Trait impl: take implied bounds from all types that
 723                 // appear in the trait reference.
 724                 let trait_ref = self.normalize_associated_types_in(span, trait_ref);
 725                 trait_ref.substs.types().collect()
 726             }
 727
 728             None => {
 729                 // Inherent impl: take implied bounds from the self type.
 730                 let self_ty = self.tcx.type_of(impl_def_id);
 731                 let self_ty = self.normalize_associated_types_in(span, &self_ty);
 732                 vec![self_ty]
 733             }
 734         }
 735     }
 736 }
 737
 738 fn error_392<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>, span: Span, param_name: ast::Name)
 739                        -> DiagnosticBuilder<'tcx> {
 740     let mut err = struct_span_err!(tcx.sess, span, E0392,
 741                   "parameter `{}` is never used", param_name);
 742     err.span_label(span, "unused type parameter");
 743     err
 744 }
 745
 746 fn error_194(tcx: TyCtxt, span: Span, trait_decl_span: Span, name: ast::Name) {
 747     struct_span_err!(tcx.sess, span, E0194,
 748               "type parameter `{}` shadows another type parameter of the same name",
 749               name)
 750         .span_label(span, "shadows another type parameter")
 751         .span_label(trait_decl_span, format!("first `{}` declared here", name))
 752         .emit();
 753 }