1 //! Give useful errors and suggestions to users when an item can't be
2 //! found or is otherwise invalid.
4 use crate::check::FnCtxt;
5 use crate::middle::lang_items::FnOnceTraitLangItem;
6 use crate::namespace::Namespace;
7 use crate::util::nodemap::FxHashSet;
8 use errors::{Applicability, DiagnosticBuilder};
9 use rustc_data_structures::sync::Lrc;
10 use rustc::hir::{self, ExprKind, Node, QPath};
11 use rustc::hir::def::Def;
12 use rustc::hir::def_id::{CRATE_DEF_INDEX, LOCAL_CRATE, DefId};
13 use rustc::hir::map as hir_map;
14 use rustc::hir::print;
15 use rustc::infer::type_variable::TypeVariableOrigin;
16 use rustc::traits::Obligation;
17 use rustc::ty::{self, Adt, Ty, TyCtxt, ToPolyTraitRef, ToPredicate, TypeFoldable};
18 use rustc::ty::print::with_crate_prefix;
19 use syntax_pos::{Span, FileName};
21 use syntax::util::lev_distance::find_best_match_for_name;
23 use std::cmp::Ordering;
25 use super::{MethodError, NoMatchData, CandidateSource};
26 use super::probe::Mode;
28 impl<'a, 'gcx, 'tcx> FnCtxt<'a, 'gcx, 'tcx> {
29 fn is_fn_ty(&self, ty: &Ty<'tcx>, span: Span) -> bool {
32 // Not all of these (e.g., unsafe fns) implement `FnOnce`,
33 // so we look for these beforehand.
37 // If it's not a simple function, look for things which implement `FnOnce`.
39 let fn_once = match tcx.lang_items().require(FnOnceTraitLangItem) {
40 Ok(fn_once) => fn_once,
41 Err(..) => return false,
44 self.autoderef(span, ty).any(|(ty, _)| {
46 let fn_once_substs = tcx.mk_substs_trait(ty, &[
47 self.next_ty_var(TypeVariableOrigin::MiscVariable(span)).into()
49 let trait_ref = ty::TraitRef::new(fn_once, fn_once_substs);
50 let poly_trait_ref = trait_ref.to_poly_trait_ref();
52 Obligation::misc(span,
55 poly_trait_ref.to_predicate());
56 self.predicate_may_hold(&obligation)
63 pub fn report_method_error<'b>(&self,
66 item_name: ast::Ident,
67 source: SelfSource<'b>,
68 error: MethodError<'tcx>,
69 args: Option<&'gcx [hir::Expr]>) {
70 // Avoid suggestions when we don't know what's going on.
71 if rcvr_ty.references_error() {
75 let report_candidates = |err: &mut DiagnosticBuilder<'_>,
76 mut sources: Vec<CandidateSource>| {
79 // Dynamic limit to avoid hiding just one candidate, which is silly.
80 let limit = if sources.len() == 5 { 5 } else { 4 };
82 for (idx, source) in sources.iter().take(limit).enumerate() {
84 CandidateSource::ImplSource(impl_did) => {
85 // Provide the best span we can. Use the item, if local to crate, else
86 // the impl, if local to crate (item may be defaulted), else nothing.
87 let item = self.associated_item(impl_did, item_name, Namespace::Value)
90 self.tcx.impl_trait_ref(impl_did).unwrap().def_id,
95 let note_span = self.tcx.hir().span_if_local(item.def_id).or_else(|| {
96 self.tcx.hir().span_if_local(impl_did)
99 let impl_ty = self.impl_self_ty(span, impl_did).ty;
101 let insertion = match self.tcx.impl_trait_ref(impl_did) {
102 None => String::new(),
104 format!(" of the trait `{}`",
105 self.tcx.def_path_str(trait_ref.def_id))
109 let note_str = if sources.len() > 1 {
110 format!("candidate #{} is defined in an impl{} for the type `{}`",
115 format!("the candidate is defined in an impl{} for the type `{}`",
119 if let Some(note_span) = note_span {
120 // We have a span pointing to the method. Show note with snippet.
121 err.span_note(self.tcx.sess.source_map().def_span(note_span),
127 CandidateSource::TraitSource(trait_did) => {
129 .associated_item(trait_did, item_name, Namespace::Value)
131 let item_span = self.tcx.sess.source_map()
132 .def_span(self.tcx.def_span(item.def_id));
133 if sources.len() > 1 {
136 "candidate #{} is defined in the trait `{}`",
138 self.tcx.def_path_str(trait_did));
142 "the candidate is defined in the trait `{}`",
143 self.tcx.def_path_str(trait_did));
145 err.help(&format!("to disambiguate the method call, write `{}::{}({}{})` \
147 self.tcx.def_path_str(trait_did),
149 if rcvr_ty.is_region_ptr() && args.is_some() {
150 if rcvr_ty.is_mutable_pointer() {
158 args.map(|arg| arg.iter()
159 .map(|arg| print::to_string(print::NO_ANN,
160 |s| s.print_expr(arg)))
162 .join(", ")).unwrap_or_else(|| "...".to_owned())));
166 if sources.len() > limit {
167 err.note(&format!("and {} others", sources.len() - limit));
172 MethodError::NoMatch(NoMatchData {
173 static_candidates: static_sources,
174 unsatisfied_predicates,
181 let actual = self.resolve_type_vars_if_possible(&rcvr_ty);
182 let ty_str = self.ty_to_string(actual);
183 let is_method = mode == Mode::MethodCall;
184 let mut suggestion = None;
185 let item_kind = if is_method {
187 } else if actual.is_enum() {
188 if let Adt(ref adt_def, _) = actual.sty {
189 let names = adt_def.variants.iter().map(|s| &s.ident.name);
190 suggestion = find_best_match_for_name(names,
196 match (item_name.as_str().chars().next(), actual.is_fresh_ty()) {
197 (Some(name), false) if name.is_lowercase() => {
198 "function or associated item"
200 (Some(_), false) => "associated item",
201 (Some(_), true) | (None, false) => {
202 "variant or associated item"
204 (None, true) => "variant",
207 let mut err = if !actual.references_error() {
208 // Suggest clamping down the type if the method that is being attempted to
209 // be used exists at all, and the type is an ambiuous numeric type
210 // ({integer}/{float}).
211 let mut candidates = all_traits(self.tcx)
214 self.associated_item(info.def_id, item_name, Namespace::Value)
216 if let (true, false, SelfSource::MethodCall(expr), Some(_)) =
217 (actual.is_numeric(),
218 actual.has_concrete_skeleton(),
221 let mut err = struct_span_err!(
225 "can't call {} `{}` on ambiguous numeric type `{}`",
230 let concrete_type = if actual.is_integral() {
236 ExprKind::Lit(ref lit) => {
238 let snippet = tcx.sess.source_map().span_to_snippet(lit.span)
239 .unwrap_or_else(|_| "<numeric literal>".to_owned());
243 &format!("you must specify a concrete type for \
244 this numeric value, like `{}`", concrete_type),
245 format!("{}_{}", snippet, concrete_type),
246 Applicability::MaybeIncorrect,
249 ExprKind::Path(ref qpath) => {
251 if let &QPath::Resolved(_, ref path) = &qpath {
252 if let hir::def::Def::Local(node_id) = path.def {
253 let span = tcx.hir().span(node_id);
254 let snippet = tcx.sess.source_map().span_to_snippet(span)
256 let filename = tcx.sess.source_map().span_to_filename(span);
258 let parent_node = self.tcx.hir().get(
259 self.tcx.hir().get_parent_node(node_id),
262 "you must specify a type for this binding, like `{}`",
266 match (filename, parent_node) {
267 (FileName::Real(_), Node::Local(hir::Local {
268 source: hir::LocalSource::Normal,
273 // account for `let x: _ = 42;`
275 span.to(ty.as_ref().map(|ty| ty.span)
278 format!("{}: {}", snippet, concrete_type),
279 Applicability::MaybeIncorrect,
283 err.span_label(span, msg);
294 let mut err = struct_span_err!(
298 "no {} named `{}` found for type `{}` in the current scope",
303 if let Some(suggestion) = suggestion {
308 suggestion.to_string(),
309 Applicability::MaybeIncorrect,
315 tcx.sess.diagnostic().struct_dummy()
318 if let Some(def) = actual.ty_adt_def() {
319 if let Some(full_sp) = tcx.hir().span_if_local(def.did) {
320 let def_sp = tcx.sess.source_map().def_span(full_sp);
321 err.span_label(def_sp, format!("{} `{}` not found {}",
324 if def.is_enum() && !is_method {
332 // If the method name is the name of a field with a function or closure type,
333 // give a helping note that it has to be called as `(x.f)(...)`.
334 if let SelfSource::MethodCall(expr) = source {
335 let field_receiver = self
336 .autoderef(span, rcvr_ty)
337 .find_map(|(ty, _)| match ty.sty {
338 ty::Adt(def, substs) if !def.is_enum() => {
339 let variant = &def.non_enum_variant();
340 self.tcx.find_field_index(item_name, variant).map(|index| {
341 let field = &variant.fields[index];
342 let field_ty = field.ty(tcx, substs);
349 if let Some((field, field_ty)) = field_receiver {
350 let scope = self.tcx.hir().get_module_parent_by_hir_id(self.body_id);
351 let is_accessible = field.vis.is_accessible_from(scope, self.tcx);
354 if self.is_fn_ty(&field_ty, span) {
355 let expr_span = expr.span.to(item_name.span);
356 err.multipart_suggestion(
358 "to call the function stored in `{}`, \
359 surround the field access with parentheses",
363 (expr_span.shrink_to_lo(), '('.to_string()),
364 (expr_span.shrink_to_hi(), ')'.to_string()),
366 Applicability::MachineApplicable,
369 let call_expr = self.tcx.hir().expect_expr_by_hir_id(
370 self.tcx.hir().get_parent_node_by_hir_id(expr.hir_id),
373 let span = call_expr.span.trim_start(item_name.span).unwrap();
377 "remove the arguments",
379 Applicability::MaybeIncorrect,
384 let field_kind = if is_accessible {
389 err.span_label(item_name.span, format!("{}, not a method", field_kind));
392 err.span_label(span, format!("{} not found in `{}`", item_kind, ty_str));
395 if self.is_fn_ty(&rcvr_ty, span) {
396 macro_rules! report_function {
397 ($span:expr, $name:expr) => {
398 err.note(&format!("{} is a function, perhaps you wish to call it",
403 if let SelfSource::MethodCall(expr) = source {
404 if let Ok(expr_string) = tcx.sess.source_map().span_to_snippet(expr.span) {
405 report_function!(expr.span, expr_string);
406 } else if let ExprKind::Path(QPath::Resolved(_, ref path)) =
409 if let Some(segment) = path.segments.last() {
410 report_function!(expr.span, segment.ident);
416 if !static_sources.is_empty() {
417 err.note("found the following associated functions; to be used as methods, \
418 functions must have a `self` parameter");
419 err.span_label(span, "this is an associated function, not a method");
421 if static_sources.len() == 1 {
422 if let SelfSource::MethodCall(expr) = source {
423 err.span_suggestion(expr.span.to(span),
424 "use associated function syntax instead",
426 self.ty_to_string(actual),
428 Applicability::MachineApplicable);
430 err.help(&format!("try with `{}::{}`",
431 self.ty_to_string(actual), item_name));
434 report_candidates(&mut err, static_sources);
435 } else if static_sources.len() > 1 {
436 report_candidates(&mut err, static_sources);
439 if !unsatisfied_predicates.is_empty() {
440 let mut bound_list = unsatisfied_predicates.iter()
441 .map(|p| format!("`{} : {}`", p.self_ty(), p))
442 .collect::<Vec<_>>();
444 bound_list.dedup(); // #35677
445 let bound_list = bound_list.join("\n");
446 err.note(&format!("the method `{}` exists but the following trait bounds \
447 were not satisfied:\n{}",
452 if actual.is_numeric() && actual.is_fresh() {
455 self.suggest_traits_to_import(&mut err,
460 out_of_scope_traits);
463 if let Some(lev_candidate) = lev_candidate {
467 lev_candidate.ident.to_string(),
468 Applicability::MaybeIncorrect,
474 MethodError::Ambiguity(sources) => {
475 let mut err = struct_span_err!(self.sess(),
478 "multiple applicable items in scope");
479 err.span_label(span, format!("multiple `{}` found", item_name));
481 report_candidates(&mut err, sources);
485 MethodError::PrivateMatch(def, out_of_scope_traits) => {
486 let mut err = struct_span_err!(self.tcx.sess, span, E0624,
487 "{} `{}` is private", def.kind_name(), item_name);
488 self.suggest_valid_traits(&mut err, out_of_scope_traits);
492 MethodError::IllegalSizedBound(candidates) => {
493 let msg = format!("the `{}` method cannot be invoked on a trait object", item_name);
494 let mut err = self.sess().struct_span_err(span, &msg);
495 if !candidates.is_empty() {
496 let help = format!("{an}other candidate{s} {were} found in the following \
497 trait{s}, perhaps add a `use` for {one_of_them}:",
498 an = if candidates.len() == 1 {"an" } else { "" },
499 s = if candidates.len() == 1 { "" } else { "s" },
500 were = if candidates.len() == 1 { "was" } else { "were" },
501 one_of_them = if candidates.len() == 1 {
506 self.suggest_use_candidates(&mut err, help, candidates);
511 MethodError::BadReturnType => {
512 bug!("no return type expectations but got BadReturnType")
517 fn suggest_use_candidates(&self,
518 err: &mut DiagnosticBuilder<'_>,
520 candidates: Vec<DefId>) {
521 let module_did = self.tcx.hir().get_module_parent_by_hir_id(self.body_id);
522 let module_id = self.tcx.hir().as_local_hir_id(module_did).unwrap();
523 let krate = self.tcx.hir().krate();
524 let (span, found_use) = UsePlacementFinder::check(self.tcx, krate, module_id);
525 if let Some(span) = span {
526 let path_strings = candidates.iter().map(|did| {
527 // Produce an additional newline to separate the new use statement
528 // from the directly following item.
529 let additional_newline = if found_use {
536 with_crate_prefix(|| self.tcx.def_path_str(*did)),
541 err.span_suggestions(span, &msg, path_strings, Applicability::MaybeIncorrect);
543 let limit = if candidates.len() == 5 { 5 } else { 4 };
544 for (i, trait_did) in candidates.iter().take(limit).enumerate() {
545 if candidates.len() > 1 {
548 "\ncandidate #{}: `use {};`",
550 with_crate_prefix(|| self.tcx.def_path_str(*trait_did))
557 with_crate_prefix(|| self.tcx.def_path_str(*trait_did))
562 if candidates.len() > limit {
563 msg.push_str(&format!("\nand {} others", candidates.len() - limit));
569 fn suggest_valid_traits(&self,
570 err: &mut DiagnosticBuilder<'_>,
571 valid_out_of_scope_traits: Vec<DefId>) -> bool {
572 if !valid_out_of_scope_traits.is_empty() {
573 let mut candidates = valid_out_of_scope_traits;
576 err.help("items from traits can only be used if the trait is in scope");
577 let msg = format!("the following {traits_are} implemented but not in scope, \
578 perhaps add a `use` for {one_of_them}:",
579 traits_are = if candidates.len() == 1 {
584 one_of_them = if candidates.len() == 1 {
590 self.suggest_use_candidates(err, msg, candidates);
597 fn suggest_traits_to_import<'b>(&self,
598 err: &mut DiagnosticBuilder<'_>,
601 item_name: ast::Ident,
602 source: SelfSource<'b>,
603 valid_out_of_scope_traits: Vec<DefId>) {
604 if self.suggest_valid_traits(err, valid_out_of_scope_traits) {
608 let type_is_local = self.type_derefs_to_local(span, rcvr_ty, source);
610 // There are no traits implemented, so lets suggest some traits to
611 // implement, by finding ones that have the item name, and are
612 // legal to implement.
613 let mut candidates = all_traits(self.tcx)
616 // We approximate the coherence rules to only suggest
617 // traits that are legal to implement by requiring that
618 // either the type or trait is local. Multi-dispatch means
619 // this isn't perfect (that is, there are cases when
620 // implementing a trait would be legal but is rejected
622 (type_is_local || info.def_id.is_local()) &&
623 self.associated_item(info.def_id, item_name, Namespace::Value)
625 // We only want to suggest public or local traits (#45781).
626 item.vis == ty::Visibility::Public || info.def_id.is_local()
630 .collect::<Vec<_>>();
632 if !candidates.is_empty() {
633 // Sort from most relevant to least relevant.
634 candidates.sort_by(|a, b| a.cmp(b).reverse());
637 // FIXME #21673: this help message could be tuned to the case
638 // of a type parameter: suggest adding a trait bound rather
639 // than implementing.
640 err.help("items from traits can only be used if the trait is implemented and in scope");
641 let mut msg = format!("the following {traits_define} an item `{name}`, \
642 perhaps you need to implement {one_of_them}:",
643 traits_define = if candidates.len() == 1 {
648 one_of_them = if candidates.len() == 1 {
655 for (i, trait_info) in candidates.iter().enumerate() {
656 msg.push_str(&format!("\ncandidate #{}: `{}`",
658 self.tcx.def_path_str(trait_info.def_id)));
664 /// Checks whether there is a local type somewhere in the chain of
665 /// autoderefs of `rcvr_ty`.
666 fn type_derefs_to_local(&self,
669 source: SelfSource<'_>) -> bool {
670 fn is_local(ty: Ty<'_>) -> bool {
672 ty::Adt(def, _) => def.did.is_local(),
673 ty::Foreign(did) => did.is_local(),
675 ty::Dynamic(ref tr, ..) =>
676 tr.principal().map(|d| d.def_id().is_local()).unwrap_or(false),
678 ty::Param(_) => true,
680 // Everything else (primitive types, etc.) is effectively
681 // non-local (there are "edge" cases, e.g., `(LocalType,)`, but
682 // the noise from these sort of types is usually just really
683 // annoying, rather than any sort of help).
688 // This occurs for UFCS desugaring of `T::method`, where there is no
689 // receiver expression for the method call, and thus no autoderef.
690 if let SelfSource::QPath(_) = source {
691 return is_local(self.resolve_type_vars_with_obligations(rcvr_ty));
694 self.autoderef(span, rcvr_ty).any(|(ty, _)| is_local(ty))
698 #[derive(Copy, Clone)]
699 pub enum SelfSource<'a> {
701 MethodCall(&'a hir::Expr /* rcvr */),
704 #[derive(Copy, Clone)]
705 pub struct TraitInfo {
709 impl PartialEq for TraitInfo {
710 fn eq(&self, other: &TraitInfo) -> bool {
711 self.cmp(other) == Ordering::Equal
714 impl Eq for TraitInfo {}
715 impl PartialOrd for TraitInfo {
716 fn partial_cmp(&self, other: &TraitInfo) -> Option<Ordering> {
717 Some(self.cmp(other))
720 impl Ord for TraitInfo {
721 fn cmp(&self, other: &TraitInfo) -> Ordering {
722 // Local crates are more important than remote ones (local:
723 // `cnum == 0`), and otherwise we throw in the defid for totality.
725 let lhs = (other.def_id.krate, other.def_id);
726 let rhs = (self.def_id.krate, self.def_id);
731 /// Retrieves all traits in this crate and any dependent crates.
732 pub fn all_traits<'a, 'gcx, 'tcx>(tcx: TyCtxt<'a, 'gcx, 'tcx>) -> Vec<TraitInfo> {
733 tcx.all_traits(LOCAL_CRATE).iter().map(|&def_id| TraitInfo { def_id }).collect()
736 /// Computes all traits in this crate and any dependent crates.
737 fn compute_all_traits<'a, 'gcx, 'tcx>(tcx: TyCtxt<'a, 'gcx, 'tcx>) -> Vec<DefId> {
738 use hir::itemlikevisit;
740 let mut traits = vec![];
744 struct Visitor<'a, 'tcx: 'a> {
745 map: &'a hir_map::Map<'tcx>,
746 traits: &'a mut Vec<DefId>,
749 impl<'v, 'a, 'tcx> itemlikevisit::ItemLikeVisitor<'v> for Visitor<'a, 'tcx> {
750 fn visit_item(&mut self, i: &'v hir::Item) {
752 hir::ItemKind::Trait(..) |
753 hir::ItemKind::TraitAlias(..) => {
754 let def_id = self.map.local_def_id_from_hir_id(i.hir_id);
755 self.traits.push(def_id);
761 fn visit_trait_item(&mut self, _trait_item: &hir::TraitItem) {}
763 fn visit_impl_item(&mut self, _impl_item: &hir::ImplItem) {}
766 tcx.hir().krate().visit_all_item_likes(&mut Visitor {
773 let mut external_mods = FxHashSet::default();
774 fn handle_external_def(tcx: TyCtxt<'_, '_, '_>,
775 traits: &mut Vec<DefId>,
776 external_mods: &mut FxHashSet<DefId>,
780 Def::TraitAlias(def_id) => {
783 Def::Mod(def_id) => {
784 if !external_mods.insert(def_id) {
787 for child in tcx.item_children(def_id).iter() {
788 handle_external_def(tcx, traits, external_mods, child.def)
794 for &cnum in tcx.crates().iter() {
797 index: CRATE_DEF_INDEX,
799 handle_external_def(tcx, &mut traits, &mut external_mods, Def::Mod(def_id));
805 pub fn provide(providers: &mut ty::query::Providers<'_>) {
806 providers.all_traits = |tcx, cnum| {
807 assert_eq!(cnum, LOCAL_CRATE);
808 Lrc::new(compute_all_traits(tcx))
812 struct UsePlacementFinder<'a, 'tcx: 'a, 'gcx: 'tcx> {
813 target_module: hir::HirId,
816 tcx: TyCtxt<'a, 'gcx, 'tcx>
819 impl<'a, 'tcx, 'gcx> UsePlacementFinder<'a, 'tcx, 'gcx> {
821 tcx: TyCtxt<'a, 'gcx, 'tcx>,
822 krate: &'tcx hir::Crate,
823 target_module: hir::HirId,
824 ) -> (Option<Span>, bool) {
825 let mut finder = UsePlacementFinder {
831 hir::intravisit::walk_crate(&mut finder, krate);
832 (finder.span, finder.found_use)
836 impl<'a, 'tcx, 'gcx> hir::intravisit::Visitor<'tcx> for UsePlacementFinder<'a, 'tcx, 'gcx> {
839 module: &'tcx hir::Mod,
843 if self.span.is_some() {
846 if hir_id != self.target_module {
847 hir::intravisit::walk_mod(self, module, hir_id);
850 // Find a `use` statement.
851 for item_id in &module.item_ids {
852 let item = self.tcx.hir().expect_item(item_id.id);
854 hir::ItemKind::Use(..) => {
855 // Don't suggest placing a `use` before the prelude
856 // import or other generated ones.
857 if item.span.ctxt().outer().expn_info().is_none() {
858 self.span = Some(item.span.shrink_to_lo());
859 self.found_use = true;
863 // Don't place `use` before `extern crate`...
864 hir::ItemKind::ExternCrate(_) => {}
865 // ...but do place them before the first other item.
866 _ => if self.span.map_or(true, |span| item.span < span ) {
867 if item.span.ctxt().outer().expn_info().is_none() {
868 // Don't insert between attributes and an item.
869 if item.attrs.is_empty() {
870 self.span = Some(item.span.shrink_to_lo());
872 // Find the first attribute on the item.
873 for attr in &item.attrs {
874 if self.span.map_or(true, |span| attr.span < span) {
875 self.span = Some(attr.span.shrink_to_lo());
885 fn nested_visit_map<'this>(
887 ) -> hir::intravisit::NestedVisitorMap<'this, 'tcx> {
888 hir::intravisit::NestedVisitorMap::None