src/librustc_typeck/check/demand.rs

   1 // Copyright 2012 The Rust Project Developers. See the COPYRIGHT
   2 // file at the top-level directory of this distribution and at
   3 // http://rust-lang.org/COPYRIGHT.
   4 //
   5 // Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
   6 // http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
   7 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
   8 // option. This file may not be copied, modified, or distributed
   9 // except according to those terms.
  10
  11 use check::FnCtxt;
  12 use rustc::infer::InferOk;
  13 use rustc::traits::ObligationCause;
  14
  15 use syntax::ast;
  16 use syntax::util::parser::PREC_POSTFIX;
  17 use syntax_pos::Span;
  18 use rustc::hir;
  19 use rustc::hir::def::Def;
  20 use rustc::hir::Node;
  21 use rustc::hir::{Item, ItemKind, print};
  22 use rustc::ty::{self, Ty, AssociatedItem};
  23 use rustc::ty::adjustment::AllowTwoPhase;
  24 use errors::{Applicability, DiagnosticBuilder, SourceMapper};
  25
  26 use super::method::probe;
  27
  28 impl<'a, 'gcx, 'tcx> FnCtxt<'a, 'gcx, 'tcx> {
  29     // Requires that the two types unify, and prints an error message if
  30     // they don't.
  31     pub fn demand_suptype(&self, sp: Span, expected: Ty<'tcx>, actual: Ty<'tcx>) {
  32         self.demand_suptype_diag(sp, expected, actual).map(|mut e| e.emit());
  33     }
  34
  35     pub fn demand_suptype_diag(&self,
  36                                sp: Span,
  37                                expected: Ty<'tcx>,
  38                                actual: Ty<'tcx>) -> Option<DiagnosticBuilder<'tcx>> {
  39         let cause = &self.misc(sp);
  40         match self.at(cause, self.param_env).sup(expected, actual) {
  41             Ok(InferOk { obligations, value: () }) => {
  42                 self.register_predicates(obligations);
  43                 None
  44             },
  45             Err(e) => {
  46                 Some(self.report_mismatched_types(&cause, expected, actual, e))
  47             }
  48         }
  49     }
  50
  51     pub fn demand_eqtype(&self, sp: Span, expected: Ty<'tcx>, actual: Ty<'tcx>) {
  52         if let Some(mut err) = self.demand_eqtype_diag(sp, expected, actual) {
  53             err.emit();
  54         }
  55     }
  56
  57     pub fn demand_eqtype_diag(&self,
  58                              sp: Span,
  59                              expected: Ty<'tcx>,
  60                              actual: Ty<'tcx>) -> Option<DiagnosticBuilder<'tcx>> {
  61         self.demand_eqtype_with_origin(&self.misc(sp), expected, actual)
  62     }
  63
  64     pub fn demand_eqtype_with_origin(&self,
  65                                      cause: &ObligationCause<'tcx>,
  66                                      expected: Ty<'tcx>,
  67                                      actual: Ty<'tcx>) -> Option<DiagnosticBuilder<'tcx>> {
  68         match self.at(cause, self.param_env).eq(expected, actual) {
  69             Ok(InferOk { obligations, value: () }) => {
  70                 self.register_predicates(obligations);
  71                 None
  72             }
  73             Err(e) => {
  74                 Some(self.report_mismatched_types(cause, expected, actual, e))
  75             }
  76         }
  77     }
  78
  79     pub fn demand_coerce(&self,
  80                          expr: &hir::Expr,
  81                          checked_ty: Ty<'tcx>,
  82                          expected: Ty<'tcx>,
  83                          allow_two_phase: AllowTwoPhase)
  84                          -> Ty<'tcx> {
  85         let (ty, err) = self.demand_coerce_diag(expr, checked_ty, expected, allow_two_phase);
  86         if let Some(mut err) = err {
  87             err.emit();
  88         }
  89         ty
  90     }
  91
  92     // Checks that the type of `expr` can be coerced to `expected`.
  93     //
  94     // NB: This code relies on `self.diverges` to be accurate. In
  95     // particular, assignments to `!` will be permitted if the
  96     // diverges flag is currently "always".
  97     pub fn demand_coerce_diag(&self,
  98                               expr: &hir::Expr,
  99                               checked_ty: Ty<'tcx>,
 100                               expected: Ty<'tcx>,
 101                               allow_two_phase: AllowTwoPhase)
 102                               -> (Ty<'tcx>, Option<DiagnosticBuilder<'tcx>>) {
 103         let expected = self.resolve_type_vars_with_obligations(expected);
 104
 105         let e = match self.try_coerce(expr, checked_ty, expected, allow_two_phase) {
 106             Ok(ty) => return (ty, None),
 107             Err(e) => e
 108         };
 109
 110         let cause = self.misc(expr.span);
 111         let expr_ty = self.resolve_type_vars_with_obligations(checked_ty);
 112         let mut err = self.report_mismatched_types(&cause, expected, expr_ty, e);
 113
 114         // If the expected type is an enum with any variants whose sole
 115         // field is of the found type, suggest such variants. See Issue
 116         // #42764.
 117         if let ty::Adt(expected_adt, substs) = expected.sty {
 118             let compatible_variants = expected_adt.variants
 119                                                   .iter()
 120                                                   .filter(|variant| variant.fields.len() == 1)
 121                                                   .filter_map(|variant| {
 122                 let sole_field = &variant.fields[0];
 123                 let sole_field_ty = sole_field.ty(self.tcx, substs);
 124                 if self.can_coerce(expr_ty, sole_field_ty) {
 125                     let variant_path = self.tcx.item_path_str(variant.did);
 126                     Some(variant_path.trim_left_matches("std::prelude::v1::").to_string())
 127                 } else {
 128                     None
 129                 }
 130             }).collect::<Vec<_>>();
 131
 132             if !compatible_variants.is_empty() {
 133                 let expr_text = print::to_string(print::NO_ANN, |s| s.print_expr(expr));
 134                 let suggestions = compatible_variants.iter()
 135                     .map(|v| format!("{}({})", v, expr_text)).collect::<Vec<_>>();
 136                 err.span_suggestions_with_applicability(
 137                      expr.span,
 138                      "try using a variant of the expected type",
 139                      suggestions,
 140                      Applicability::MaybeIncorrect,
 141                 );
 142             }
 143         }
 144
 145         self.suggest_ref_or_into(&mut err, expr, expected, expr_ty);
 146
 147         (expected, Some(err))
 148     }
 149
 150     pub fn get_conversion_methods(&self, span: Span, expected: Ty<'tcx>, checked_ty: Ty<'tcx>)
 151                               -> Vec<AssociatedItem> {
 152         let mut methods = self.probe_for_return_type(span,
 153                                                      probe::Mode::MethodCall,
 154                                                      expected,
 155                                                      checked_ty,
 156                                                      ast::DUMMY_NODE_ID);
 157         methods.retain(|m| {
 158             self.has_no_input_arg(m) &&
 159                 self.tcx.get_attrs(m.def_id).iter()
 160                 // This special internal attribute is used to whitelist
 161                 // "identity-like" conversion methods to be suggested here.
 162                 //
 163                 // FIXME (#46459 and #46460): ideally
 164                 // `std::convert::Into::into` and `std::borrow:ToOwned` would
 165                 // also be `#[rustc_conversion_suggestion]`, if not for
 166                 // method-probing false-positives and -negatives (respectively).
 167                 //
 168                 // FIXME? Other potential candidate methods: `as_ref` and
 169                 // `as_mut`?
 170                 .find(|a| a.check_name("rustc_conversion_suggestion")).is_some()
 171         });
 172
 173         methods
 174     }
 175
 176     // This function checks if the method isn't static and takes other arguments than `self`.
 177     fn has_no_input_arg(&self, method: &AssociatedItem) -> bool {
 178         match method.def() {
 179             Def::Method(def_id) => {
 180                 self.tcx.fn_sig(def_id).inputs().skip_binder().len() == 1
 181             }
 182             _ => false,
 183         }
 184     }
 185
 186     /// Identify some cases where `as_ref()` would be appropriate and suggest it.
 187     ///
 188     /// Given the following code:
 189     /// ```
 190     /// struct Foo;
 191     /// fn takes_ref(_: &Foo) {}
 192     /// let ref opt = Some(Foo);
 193     ///
 194     /// opt.map(|arg| takes_ref(arg));
 195     /// ```
 196     /// Suggest using `opt.as_ref().map(|arg| takes_ref(arg));` instead.
 197     ///
 198     /// It only checks for `Option` and `Result` and won't work with
 199     /// ```
 200     /// opt.map(|arg| { takes_ref(arg) });
 201     /// ```
 202     fn can_use_as_ref(&self, expr: &hir::Expr) -> Option<(Span, &'static str, String)> {
 203         if let hir::ExprKind::Path(hir::QPath::Resolved(_, ref path)) = expr.node {
 204             if let hir::def::Def::Local(id) = path.def {
 205                 let parent = self.tcx.hir.get_parent_node(id);
 206                 if let Some(Node::Expr(hir::Expr {
 207                     id,
 208                     node: hir::ExprKind::Closure(_, decl, ..),
 209                     ..
 210                 })) = self.tcx.hir.find(parent) {
 211                     let parent = self.tcx.hir.get_parent_node(*id);
 212                     if let (Some(Node::Expr(hir::Expr {
 213                         node: hir::ExprKind::MethodCall(path, span, expr),
 214                         ..
 215                     })), 1) = (self.tcx.hir.find(parent), decl.inputs.len()) {
 216                         let self_ty = self.tables.borrow().node_id_to_type(expr[0].hir_id);
 217                         let self_ty = format!("{:?}", self_ty);
 218                         let name = path.ident.as_str();
 219                         let is_as_ref_able = (
 220                             self_ty.starts_with("&std::option::Option") ||
 221                             self_ty.starts_with("&std::result::Result") ||
 222                             self_ty.starts_with("std::option::Option") ||
 223                             self_ty.starts_with("std::result::Result")
 224                         ) && (name == "map" || name == "and_then");
 225                         if is_as_ref_able {
 226                             return Some((span.shrink_to_lo(),
 227                                          "consider using `as_ref` instead",
 228                                          "as_ref().".into()));
 229                         }
 230                     }
 231                 }
 232             }
 233         }
 234         None
 235     }
 236
 237     /// This function is used to determine potential "simple" improvements or users' errors and
 238     /// provide them useful help. For example:
 239     ///
 240     /// ```
 241     /// fn some_fn(s: &str) {}
 242     ///
 243     /// let x = "hey!".to_owned();
 244     /// some_fn(x); // error
 245     /// ```
 246     ///
 247     /// No need to find every potential function which could make a coercion to transform a
 248     /// `String` into a `&str` since a `&` would do the trick!
 249     ///
 250     /// In addition of this check, it also checks between references mutability state. If the
 251     /// expected is mutable but the provided isn't, maybe we could just say "Hey, try with
 252     /// `&mut`!".
 253     pub fn check_ref(&self,
 254                  expr: &hir::Expr,
 255                  checked_ty: Ty<'tcx>,
 256                  expected: Ty<'tcx>)
 257                  -> Option<(Span, &'static str, String)> {
 258         let cm = self.sess().source_map();
 259         // Use the callsite's span if this is a macro call. #41858
 260         let sp = cm.call_span_if_macro(expr.span);
 261         if !cm.span_to_filename(sp).is_real() {
 262             return None;
 263         }
 264
 265         match (&expected.sty, &checked_ty.sty) {
 266             (&ty::Ref(_, exp, _), &ty::Ref(_, check, _)) => match (&exp.sty, &check.sty) {
 267                 (&ty::Str, &ty::Array(arr, _)) |
 268                 (&ty::Str, &ty::Slice(arr)) if arr == self.tcx.types.u8 => {
 269                     if let hir::ExprKind::Lit(_) = expr.node {
 270                         if let Ok(src) = cm.span_to_snippet(sp) {
 271                             if src.starts_with("b\"") {
 272                                 return Some((sp,
 273                                              "consider removing the leading `b`",
 274                                              src[1..].to_string()));
 275                             }
 276                         }
 277                     }
 278                 },
 279                 (&ty::Array(arr, _), &ty::Str) |
 280                 (&ty::Slice(arr), &ty::Str) if arr == self.tcx.types.u8 => {
 281                     if let hir::ExprKind::Lit(_) = expr.node {
 282                         if let Ok(src) = cm.span_to_snippet(sp) {
 283                             if src.starts_with("\"") {
 284                                 return Some((sp,
 285                                              "consider adding a leading `b`",
 286                                              format!("b{}", src)));
 287                             }
 288                         }
 289                     }
 290                 }
 291                 _ => {}
 292             },
 293             (&ty::Ref(_, _, mutability), _) => {
 294                 // Check if it can work when put into a ref. For example:
 295                 //
 296                 // ```
 297                 // fn bar(x: &mut i32) {}
 298                 //
 299                 // let x = 0u32;
 300                 // bar(&x); // error, expected &mut
 301                 // ```
 302                 let ref_ty = match mutability {
 303                     hir::Mutability::MutMutable => self.tcx.mk_mut_ref(
 304                                                        self.tcx.mk_region(ty::ReStatic),
 305                                                        checked_ty),
 306                     hir::Mutability::MutImmutable => self.tcx.mk_imm_ref(
 307                                                        self.tcx.mk_region(ty::ReStatic),
 308                                                        checked_ty),
 309                 };
 310                 if self.can_coerce(ref_ty, expected) {
 311                     if let Ok(src) = cm.span_to_snippet(sp) {
 312                         let needs_parens = match expr.node {
 313                             // parenthesize if needed (Issue #46756)
 314                             hir::ExprKind::Cast(_, _) |
 315                             hir::ExprKind::Binary(_, _, _) => true,
 316                             // parenthesize borrows of range literals (Issue #54505)
 317                             _ if self.is_range_literal(expr) => true,
 318                             _ => false,
 319                         };
 320                         let sugg_expr = if needs_parens { format!("({})", src) } else { src };
 321
 322                         if let Some(sugg) = self.can_use_as_ref(expr) {
 323                             return Some(sugg);
 324                         }
 325                         return Some(match mutability {
 326                             hir::Mutability::MutMutable => {
 327                                 (sp, "consider mutably borrowing here", format!("&mut {}",
 328                                                                                 sugg_expr))
 329                             }
 330                             hir::Mutability::MutImmutable => {
 331                                 (sp, "consider borrowing here", format!("&{}", sugg_expr))
 332                             }
 333                         });
 334                     }
 335                 }
 336             }
 337             (_, &ty::Ref(_, checked, _)) => {
 338                 // We have `&T`, check if what was expected was `T`. If so,
 339                 // we may want to suggest adding a `*`, or removing
 340                 // a `&`.
 341                 //
 342                 // (But, also check check the `expn_info()` to see if this is
 343                 // a macro; if so, it's hard to extract the text and make a good
 344                 // suggestion, so don't bother.)
 345                 if self.infcx.can_sub(self.param_env, checked, &expected).is_ok() &&
 346                    sp.ctxt().outer().expn_info().is_none() {
 347                     match expr.node {
 348                         // Maybe remove `&`?
 349                         hir::ExprKind::AddrOf(_, ref expr) => {
 350                             if !cm.span_to_filename(expr.span).is_real() {
 351                                 return None;
 352                             }
 353                             if let Ok(code) = cm.span_to_snippet(expr.span) {
 354                                 return Some((sp, "consider removing the borrow", code));
 355                             }
 356                         }
 357
 358                         // Maybe add `*`? Only if `T: Copy`.
 359                         _ => {
 360                             if !self.infcx.type_moves_by_default(self.param_env,
 361                                                                 checked,
 362                                                                 sp) {
 363                                 // do not suggest if the span comes from a macro (#52783)
 364                                 if let (Ok(code),
 365                                         true) = (cm.span_to_snippet(sp), sp == expr.span) {
 366                                     return Some((
 367                                         sp,
 368                                         "consider dereferencing the borrow",
 369                                         format!("*{}", code),
 370                                     ));
 371                                 }
 372                             }
 373                         }
 374                     }
 375                 }
 376             }
 377             _ => {}
 378         }
 379         None
 380     }
 381
 382     // This function checks if the specified expression is a built-in range literal
 383     // (See: librustc/hir/lowering.rs::LoweringContext::lower_expr() )
 384     fn is_range_literal(&self, expr: &hir::Expr) -> bool {
 385         use hir::{Path, QPath, ExprKind, TyKind};
 386
 387         // we support `::std::ops::Range` and `::std::core::Range` prefixes
 388         // (via split on "|")
 389         let ops_path = ["{{root}}", "std|core", "ops"];
 390
 391         let is_range_path = |path: &Path| {
 392             let ident_names: Vec<_> = path.segments
 393                 .iter()
 394                 .map(|seg| seg.ident.as_str())
 395                 .collect();
 396
 397             if let Some((last, preceding)) = ident_names.split_last() {
 398                 last.starts_with("Range") &&
 399                     preceding.len() == 3 &&
 400                     preceding.iter()
 401                         .zip(ops_path.iter())
 402                         .all(|(seg, match_seg)| {
 403                             match_seg.split("|")
 404                                 .into_iter()
 405                                 .any(|ref spl_seg| seg == spl_seg)
 406                         })
 407             } else {
 408                 false
 409             }
 410         };
 411
 412         let is_range_struct_snippet = |span: &Span| {
 413             // Tell if expression span snippet looks like an explicit
 414             // Range struct or new() call.  This is to allow rejecting
 415             // Ranges constructed with non-literals.
 416             let source_map = self.tcx.sess.source_map();
 417             let end_point = source_map.end_point(*span);
 418
 419             if let Ok(end_string) = source_map.span_to_snippet(end_point) {
 420                 end_string.ends_with("}") || end_string.ends_with(")")
 421             } else {
 422                 false
 423             }
 424
 425         };
 426
 427         match expr.node {
 428             // all built-in range literals but `..=` and `..`
 429             // desugar to Structs, `..` desugars to its struct path
 430             ExprKind::Struct(QPath::Resolved(None, ref path), _, _) |
 431             ExprKind::Path(QPath::Resolved(None, ref path)) => {
 432                 return is_range_path(&path) && !is_range_struct_snippet(&expr.span);
 433             }
 434
 435             // `..=` desugars into RangeInclusive::new(...)
 436             ExprKind::Call(ref func, _) => {
 437                 if let ExprKind::Path(QPath::TypeRelative(ref ty, ref segment)) = func.node {
 438                     if let TyKind::Path(QPath::Resolved(None, ref path)) = ty.node {
 439                         let calls_new = segment.ident.as_str() == "new";
 440
 441                         return is_range_path(&path) && calls_new &&
 442                             !is_range_struct_snippet(&expr.span);
 443                     }
 444                 }
 445             }
 446
 447             _ => {}
 448         }
 449
 450         false
 451     }
 452
 453     pub fn check_for_cast(&self,
 454                       err: &mut DiagnosticBuilder<'tcx>,
 455                       expr: &hir::Expr,
 456                       checked_ty: Ty<'tcx>,
 457                       expected_ty: Ty<'tcx>)
 458                       -> bool {
 459         let parent_id = self.tcx.hir.get_parent_node(expr.id);
 460         if let Some(parent) = self.tcx.hir.find(parent_id) {
 461             // Shouldn't suggest `.into()` on `const`s.
 462             if let Node::Item(Item { node: ItemKind::Const(_, _), .. }) = parent {
 463                 // FIXME(estebank): modify once we decide to suggest `as` casts
 464                 return false;
 465             }
 466         };
 467
 468         let will_truncate = "will truncate the source value";
 469         let depending_on_isize = "will truncate or zero-extend depending on the bit width of \
 470                                   `isize`";
 471         let depending_on_usize = "will truncate or zero-extend depending on the bit width of \
 472                                   `usize`";
 473         let will_sign_extend = "will sign-extend the source value";
 474         let will_zero_extend = "will zero-extend the source value";
 475
 476         // If casting this expression to a given numeric type would be appropriate in case of a type
 477         // mismatch.
 478         //
 479         // We want to minimize the amount of casting operations that are suggested, as it can be a
 480         // lossy operation with potentially bad side effects, so we only suggest when encountering
 481         // an expression that indicates that the original type couldn't be directly changed.
 482         //
 483         // For now, don't suggest casting with `as`.
 484         let can_cast = false;
 485
 486         let needs_paren = expr.precedence().order() < (PREC_POSTFIX as i8);
 487
 488         if let Ok(src) = self.tcx.sess.source_map().span_to_snippet(expr.span) {
 489             let msg = format!("you can cast an `{}` to `{}`", checked_ty, expected_ty);
 490             let cast_suggestion = format!("{}{}{} as {}",
 491                                           if needs_paren { "(" } else { "" },
 492                                           src,
 493                                           if needs_paren { ")" } else { "" },
 494                                           expected_ty);
 495             let into_suggestion = format!(
 496                 "{}{}{}.into()",
 497                 if needs_paren { "(" } else { "" },
 498                 src,
 499                 if needs_paren { ")" } else { "" },
 500             );
 501             let literal_is_ty_suffixed = |expr: &hir::Expr| {
 502                 if let hir::ExprKind::Lit(lit) = &expr.node {
 503                     lit.node.is_suffixed()
 504                 } else {
 505                     false
 506                 }
 507             };
 508
 509             let into_sugg = into_suggestion.clone();
 510             let suggest_to_change_suffix_or_into = |err: &mut DiagnosticBuilder,
 511                                                     note: Option<&str>| {
 512                 let suggest_msg = if literal_is_ty_suffixed(expr) {
 513                     format!(
 514                         "change the type of the numeric literal from `{}` to `{}`",
 515                         checked_ty,
 516                         expected_ty,
 517                     )
 518                 } else {
 519                     match note {
 520                         Some(note) => format!("{}, which {}", msg, note),
 521                         _ => format!("{} in a lossless way", msg),
 522                     }
 523                 };
 524
 525                 let suffix_suggestion = format!(
 526                     "{}{}{}{}",
 527                     if needs_paren { "(" } else { "" },
 528                     src.trim_right_matches(&checked_ty.to_string()),
 529                     expected_ty,
 530                     if needs_paren { ")" } else { "" },
 531                 );
 532
 533                 err.span_suggestion_with_applicability(
 534                     expr.span,
 535                     &suggest_msg,
 536                     if literal_is_ty_suffixed(expr) {
 537                         suffix_suggestion
 538                     } else {
 539                         into_sugg
 540                     },
 541                     Applicability::MachineApplicable,
 542                 );
 543             };
 544
 545             match (&expected_ty.sty, &checked_ty.sty) {
 546                 (&ty::Int(ref exp), &ty::Int(ref found)) => {
 547                     match (found.bit_width(), exp.bit_width()) {
 548                         (Some(found), Some(exp)) if found > exp => {
 549                             if can_cast {
 550                                 err.span_suggestion_with_applicability(
 551                                     expr.span,
 552                                     &format!("{}, which {}", msg, will_truncate),
 553                                     cast_suggestion,
 554                                     Applicability::MaybeIncorrect // lossy conversion
 555                                 );
 556                             }
 557                         }
 558                         (None, _) | (_, None) => {
 559                             if can_cast {
 560                                 err.span_suggestion_with_applicability(
 561                                     expr.span,
 562                                     &format!("{}, which {}", msg, depending_on_isize),
 563                                     cast_suggestion,
 564                                     Applicability::MaybeIncorrect // lossy conversion
 565                                 );
 566                             }
 567                         }
 568                         _ => {
 569                             suggest_to_change_suffix_or_into(
 570                                 err,
 571                                 Some(will_sign_extend),
 572                             );
 573                         }
 574                     }
 575                     true
 576                 }
 577                 (&ty::Uint(ref exp), &ty::Uint(ref found)) => {
 578                     match (found.bit_width(), exp.bit_width()) {
 579                         (Some(found), Some(exp)) if found > exp => {
 580                             if can_cast {
 581                                 err.span_suggestion_with_applicability(
 582                                     expr.span,
 583                                     &format!("{}, which {}", msg, will_truncate),
 584                                     cast_suggestion,
 585                                     Applicability::MaybeIncorrect  // lossy conversion
 586                                 );
 587                             }
 588                         }
 589                         (None, _) | (_, None) => {
 590                             if can_cast {
 591                                 err.span_suggestion_with_applicability(
 592                                     expr.span,
 593                                     &format!("{}, which {}", msg, depending_on_usize),
 594                                     cast_suggestion,
 595                                     Applicability::MaybeIncorrect  // lossy conversion
 596                                 );
 597                             }
 598                         }
 599                         _ => {
 600                            suggest_to_change_suffix_or_into(
 601                                err,
 602                                Some(will_zero_extend),
 603                            );
 604                         }
 605                     }
 606                     true
 607                 }
 608                 (&ty::Int(ref exp), &ty::Uint(ref found)) => {
 609                     if can_cast {
 610                         match (found.bit_width(), exp.bit_width()) {
 611                             (Some(found), Some(exp)) if found > exp - 1 => {
 612                                 err.span_suggestion_with_applicability(
 613                                     expr.span,
 614                                     &format!("{}, which {}", msg, will_truncate),
 615                                     cast_suggestion,
 616                                     Applicability::MaybeIncorrect  // lossy conversion
 617                                 );
 618                             }
 619                             (None, None) => {
 620                                 err.span_suggestion_with_applicability(
 621                                     expr.span,
 622                                     &format!("{}, which {}", msg, will_truncate),
 623                                     cast_suggestion,
 624                                     Applicability::MaybeIncorrect  // lossy conversion
 625                                 );
 626                             }
 627                             (None, _) => {
 628                                 err.span_suggestion_with_applicability(
 629                                     expr.span,
 630                                     &format!("{}, which {}", msg, depending_on_isize),
 631                                     cast_suggestion,
 632                                     Applicability::MaybeIncorrect  // lossy conversion
 633                                 );
 634                             }
 635                             (_, None) => {
 636                                 err.span_suggestion_with_applicability(
 637                                     expr.span,
 638                                     &format!("{}, which {}", msg, depending_on_usize),
 639                                     cast_suggestion,
 640                                     Applicability::MaybeIncorrect  // lossy conversion
 641                                 );
 642                             }
 643                             _ => {
 644                                 err.span_suggestion_with_applicability(
 645                                     expr.span,
 646                                     &format!("{}, which {}", msg, will_zero_extend),
 647                                     cast_suggestion,
 648                                     Applicability::MachineApplicable
 649                                 );
 650                             }
 651                         }
 652                     }
 653                     true
 654                 }
 655                 (&ty::Uint(ref exp), &ty::Int(ref found)) => {
 656                     if can_cast {
 657                         match (found.bit_width(), exp.bit_width()) {
 658                             (Some(found), Some(exp)) if found - 1 > exp => {
 659                                 err.span_suggestion_with_applicability(
 660                                     expr.span,
 661                                     &format!("{}, which {}", msg, will_truncate),
 662                                     cast_suggestion,
 663                                     Applicability::MaybeIncorrect  // lossy conversion
 664                                 );
 665                             }
 666                             (None, None) => {
 667                                 err.span_suggestion_with_applicability(
 668                                     expr.span,
 669                                     &format!("{}, which {}", msg, will_sign_extend),
 670                                     cast_suggestion,
 671                                     Applicability::MachineApplicable  // lossy conversion
 672                                 );
 673                             }
 674                             (None, _) => {
 675                                 err.span_suggestion_with_applicability(
 676                                     expr.span,
 677                                     &format!("{}, which {}", msg, depending_on_usize),
 678                                     cast_suggestion,
 679                                     Applicability::MaybeIncorrect  // lossy conversion
 680                                 );
 681                             }
 682                             (_, None) => {
 683                                 err.span_suggestion_with_applicability(
 684                                     expr.span,
 685                                     &format!("{}, which {}", msg, depending_on_isize),
 686                                     cast_suggestion,
 687                                     Applicability::MaybeIncorrect  // lossy conversion
 688                                 );
 689                             }
 690                             _ => {
 691                                 err.span_suggestion_with_applicability(
 692                                     expr.span,
 693                                     &format!("{}, which {}", msg, will_sign_extend),
 694                                     cast_suggestion,
 695                                     Applicability::MachineApplicable
 696                                 );
 697                             }
 698                         }
 699                     }
 700                     true
 701                 }
 702                 (&ty::Float(ref exp), &ty::Float(ref found)) => {
 703                     if found.bit_width() < exp.bit_width() {
 704                        suggest_to_change_suffix_or_into(
 705                            err,
 706                            None,
 707                        );
 708                     } else if can_cast {
 709                         err.span_suggestion_with_applicability(
 710                             expr.span,
 711                             &format!("{}, producing the closest possible value", msg),
 712                             cast_suggestion,
 713                             Applicability::MaybeIncorrect  // lossy conversion
 714                         );
 715                     }
 716                     true
 717                 }
 718                 (&ty::Uint(_), &ty::Float(_)) | (&ty::Int(_), &ty::Float(_)) => {
 719                     if can_cast {
 720                         err.span_suggestion_with_applicability(
 721                             expr.span,
 722                             &format!("{}, rounding the float towards zero", msg),
 723                             cast_suggestion,
 724                             Applicability::MaybeIncorrect  // lossy conversion
 725                         );
 726                         err.warn("casting here will cause undefined behavior if the rounded value \
 727                                   cannot be represented by the target integer type, including \
 728                                   `Inf` and `NaN` (this is a bug and will be fixed)");
 729                     }
 730                     true
 731                 }
 732                 (&ty::Float(ref exp), &ty::Uint(ref found)) => {
 733                     // if `found` is `None` (meaning found is `usize`), don't suggest `.into()`
 734                     if exp.bit_width() > found.bit_width().unwrap_or(256) {
 735                         err.span_suggestion_with_applicability(
 736                             expr.span,
 737                             &format!("{}, producing the floating point representation of the \
 738                                       integer",
 739                                      msg),
 740                             into_suggestion,
 741                             Applicability::MachineApplicable
 742                         );
 743                     } else if can_cast {
 744                         err.span_suggestion_with_applicability(expr.span,
 745                             &format!("{}, producing the floating point representation of the \
 746                                       integer, rounded if necessary",
 747                                      msg),
 748                             cast_suggestion,
 749                             Applicability::MaybeIncorrect  // lossy conversion
 750                         );
 751                     }
 752                     true
 753                 }
 754                 (&ty::Float(ref exp), &ty::Int(ref found)) => {
 755                     // if `found` is `None` (meaning found is `isize`), don't suggest `.into()`
 756                     if exp.bit_width() > found.bit_width().unwrap_or(256) {
 757                         err.span_suggestion_with_applicability(
 758                             expr.span,
 759                             &format!("{}, producing the floating point representation of the \
 760                                       integer",
 761                                      msg),
 762                             into_suggestion,
 763                             Applicability::MachineApplicable
 764                         );
 765                     } else if can_cast {
 766                         err.span_suggestion_with_applicability(
 767                             expr.span,
 768                             &format!("{}, producing the floating point representation of the \
 769                                       integer, rounded if necessary",
 770                                      msg),
 771                             cast_suggestion,
 772                             Applicability::MaybeIncorrect  // lossy conversion
 773                         );
 774                     }
 775                     true
 776                 }
 777                 _ => false,
 778             }
 779         } else {
 780             false
 781         }
 782     }
 783 }